Mani:
Using Maven's standard structure makes sense. The reason I did not use it
in the beginning was cloud stack src code did follow the standard maven
standard directory layout. But cloud stack may have better reason than
mine. Cloud Stack probably started as an ant project. In any event, it
I had the same problem, try to create the patch by using the RBTool that
worked for me
Mani
On Fri, Sep 28, 2012 at 8:46 PM, Yichi Lu yichi...@sungard.com wrote:
Mani:
Using Maven's standard structure makes sense. The reason I did not use it
in the beginning was cloud stack src code did
Hi, Chip:
I checked out that junit-tests branch, and made modifications there.
However, when I tried to generate patch file, I got nothing. The patch has
zero byte. Did I do anything wrong? Please advise.
Yichi
On Wed, Sep 26, 2012 at 6:31 PM, Chip Childers chip.child...@sungard.comwrote:
Hey
Sorry guys. I just submitted a new review request and realized I did not
used that junit-test branch, and I did not add ASF license header either.
I'll do those next time.
Yichi
On Mon, Sep 24, 2012 at 10:22 AM, Chip Childers
chip.child...@sungard.comwrote:
Yichi,
I just committed this, but
Hey Yichi,
Can you generate new diff files and update accordingly? That way, we
commit things properly. You can just modify the current reviewboard
requests to add the new diff version, and to update the branch value for
completeness.
-chip
On Wed, Sep 26, 2012 at 5:38 PM, Yichi Lu
As per yichi's comments i see that the unit testes would be located in
unittest folder, why not keep them in the standard maven structure.
src/test/java/package structure
Mani
On Sat, Sep 22, 2012 at 1:59 AM, Chip Childers chip.child...@sungard.comwrote:
All,
I'd like to create a branch for
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7204/#review11833
---
Ship it!
Committed to the junit-tests branch. Please close this
Yichi,
I just committed this, but realized that I didn't catch the fact that we
are missing the ASF license header in
api/unittest/src/com/cloud/agent/api/AttachIsoCommandTest.java.
Can you please submit another patch to correct that?
-chip
On Mon, Sep 24, 2012 at 11:21 AM, Chip Childers
All,
I'd like to create a branch for some of the JUnit tests that Yichi is
creating. That way, we can accept the tests into the codebase (after
reviews), but not apply them to master until 4.0 is stabilized. Any
thoughts, questions or concerns?
-chip
On Thu, Sep 20, 2012 at 11:41 PM, Yichi Lu
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7204/
---
Review request for cloudstack.
Description
---
A junit test suite against
10 matches
Mail list logo
