Re: Review Request: MidoNet Networking Plugin [2/2]
On March 14, 2013, 3:59 a.m., Hiroaki Kawai wrote: server/src/com/cloud/network/NetworkManagerImpl.java, line 1773 https://reviews.apache.org/r/9898/diff/1/?file=270127#file270127line1773 NetworkElement should be always called after NetworkGuru, isn't it? Dave Cahill wrote: Looking at NetworkManagerImpl, Element does seem to be called after Guru most of the time - however in destroyNetwork(), the Elements are destroyed before the Guru. I'm happy to change the order, but since the order is not always the same in NetworkManagerImpl, do you have any document references / reasons for the suggested order? Since we have tested the current version and it works, I just want to make sure the change makes sense before implementing. I want to see a documentation, too. After reading the code again, I think NetworkElement#release should not be called in the context with NetworkGuru#deallocate . Do you really need this code block here? NetworkElement#release should be called with NetworkGuru#release, and you would be able to do something there. Network lifecycle: -- NetworkManagerImpl#implementNetwork - NetworkGuru#implement - NetworkManagerImpl#implementNetworkElementsAndResources -- NetworkElement#implement NetworkManagerImpl#restartNetwork - NetworkManagerImpl#shutdownNetworkElementsAndResources -- NetworkElement#shutdown - NetworkManagerImpl#implemetNetworkElementsAndResources -- NetworkElement#implement NetworkManagerImpl#updateGuestNetwork - NetworkManagerImpl#shutdownNetworkElementsAndResource -- NetworkElement#shutdown - NetworkManagerImpl#implemetNetworkElementsAndResources -- NetworkElement#implement NetworkManagerImpl#shutdownNetwork - NetworkManagerImpl#shutdownNetworkElementsAndResource -- NetworkElement#shutdown - NetworkGuru#shutdown Nic lifecycle: -- NetworkManagerImpl#allocate - NetworkManagerImpl#allocateNic -- NetworkGuru#allocate NetworkManager#prepareNic - NetworkGuru#reserve - NetworkManager#prepareElement -- NetworkElement#prepare NetworkManagerImpl#release - NetworkManagerImpl#releaseNic -- NetworkGuru#release -- NetworkElement#release NetworkManagerImpl#deallocate - NetworkManagerImpl#removeNic -- NetworkGuru#deallocate - Hiroaki --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9898/#review17849 --- On March 13, 2013, 9:32 a.m., Dave Cahill wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9898/ --- (Updated March 13, 2013, 9:32 a.m.) Review request for cloudstack, Hugo Trippaers and Chiradeep Vittal. Description --- Feature spec: https://cwiki.apache.org/confluence/display/CLOUDSTACK/Midokura+Networking+Plugin Jira ticket: https://issues.apache.org/jira/browse/CLOUDSTACK-996 Notes: * Moved plugin to nonoss since the MidoNet client jar is not publicly available * Documentation will follow as a separate commit * One main difference from existing networking plugins is the lack of a Resource class; we didn't feel it was necessary in this case. As mentioned in Extending CloudStack Networking [1]: Just like managers, resources are not strictly necessary. In theory a Network Element could implement a client for the API of the new controller and therefore be completely self-contained. * We allow overriding Public traffic via the MidoNetPublicNetworkGuru. We checked this approach with the list [2] and received no comments, so we're going with it for now. [1] https://cwiki.apache.org/CLOUDSTACK/extending-cloudstack-networking.html [2] http://markmail.org/message/k5qse63eyylszm3i This addresses bug CLOUDSTACK-996. Diffs - api/src/com/cloud/network/Network.java efed5cd api/src/com/cloud/network/Networks.java e3d2158 api/src/com/cloud/network/PhysicalNetwork.java 343a2b1 api/src/org/apache/cloudstack/network/ExternalNetworkDeviceManager.java bc22804 client/pom.xml cda6ab8 client/tomcatconf/nonossComponentContext.xml.in 20e0c32 deps/install-non-oss.sh 74575a8 plugins/hypervisors/kvm/pom.xml 013a58d plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtDomainXMLParser.java b622b6d plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java c93aeeb plugins/network-elements/midokura-midonet/pom.xml 7f2e2d3 plugins/network-elements/midonet/pom.xml PRE-CREATION plugins/network-elements/midonet/src/com/cloud/network/element/MidoNetElement.java 48833b3 plugins/network-elements/midonet/src/com/cloud/network/element/SimpleFirewallRule.java PRE-CREATION plugins/network-elements/midonet/src/com/cloud/network
Re: Review Request: MidoNet Networking Plugin [2/2]
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9898/#review17849 --- The patch set is so big that it is hard to review. It would be nice to separate it into management-server, plugin, agent plugin and UI. api/src/com/cloud/network/Network.java https://reviews.apache.org/r/9898/#comment37807 IMHO, plugins may not have to create a Provider instance here. Instead, it can be created at plugin's configure method or getProvider, etc. server/src/com/cloud/network/NetworkManagerImpl.java https://reviews.apache.org/r/9898/#comment37808 NetworkElement should be always called after NetworkGuru, isn't it? - Hiroaki Kawai On March 13, 2013, 9:32 a.m., Dave Cahill wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9898/ --- (Updated March 13, 2013, 9:32 a.m.) Review request for cloudstack, Hugo Trippaers and Chiradeep Vittal. Description --- Feature spec: https://cwiki.apache.org/confluence/display/CLOUDSTACK/Midokura+Networking+Plugin Jira ticket: https://issues.apache.org/jira/browse/CLOUDSTACK-996 Notes: * Moved plugin to nonoss since the MidoNet client jar is not publicly available * Documentation will follow as a separate commit * One main difference from existing networking plugins is the lack of a Resource class; we didn't feel it was necessary in this case. As mentioned in Extending CloudStack Networking [1]: Just like managers, resources are not strictly necessary. In theory a Network Element could implement a client for the API of the new controller and therefore be completely self-contained. * We allow overriding Public traffic via the MidoNetPublicNetworkGuru. We checked this approach with the list [2] and received no comments, so we're going with it for now. [1] https://cwiki.apache.org/CLOUDSTACK/extending-cloudstack-networking.html [2] http://markmail.org/message/k5qse63eyylszm3i This addresses bug CLOUDSTACK-996. Diffs - api/src/com/cloud/network/Network.java efed5cd api/src/com/cloud/network/Networks.java e3d2158 api/src/com/cloud/network/PhysicalNetwork.java 343a2b1 api/src/org/apache/cloudstack/network/ExternalNetworkDeviceManager.java bc22804 client/pom.xml cda6ab8 client/tomcatconf/nonossComponentContext.xml.in 20e0c32 deps/install-non-oss.sh 74575a8 plugins/hypervisors/kvm/pom.xml 013a58d plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtDomainXMLParser.java b622b6d plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java c93aeeb plugins/network-elements/midokura-midonet/pom.xml 7f2e2d3 plugins/network-elements/midonet/pom.xml PRE-CREATION plugins/network-elements/midonet/src/com/cloud/network/element/MidoNetElement.java 48833b3 plugins/network-elements/midonet/src/com/cloud/network/element/SimpleFirewallRule.java PRE-CREATION plugins/network-elements/midonet/src/com/cloud/network/guru/MidoNetGuestNetworkGuru.java ed0eb3c plugins/network-elements/midonet/src/com/cloud/network/guru/MidoNetPublicNetworkGuru.java PRE-CREATION plugins/network-elements/midonet/src/com/cloud/network/resource/MidoNetVifDriver.java PRE-CREATION plugins/network-elements/midonet/test/com/cloud/network/element/MidoNetElementTest.java PRE-CREATION plugins/pom.xml 88f617b server/src/com/cloud/configuration/Config.java 64465a2 server/src/com/cloud/network/NetworkManagerImpl.java 3220c91 ui/scripts/system.js 4d529ae Diff: https://reviews.apache.org/r/9898/diff/ Testing --- Built and deployed, spun up Advanced Isolated network with two VMs, verified internal and external connectivity via MidoNet. Thanks, Dave Cahill
Review Request: (CLOUDSTACK-1638) Network plugins won't be notified VM migration.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9871/ --- Review request for cloudstack. Description --- The location of the virtual machine is provided by DeployDestination, which will be passed in NetworkGuru#reserve and NetworkElement#prepare. During the virtual machine migration, it actually changes DeployDestination and it looks like that it will tell that event to network components as it has NetworkManager#prepareNicForMigration. The problem is that althogh the interface has that method, NetworkManagerImpl does not tell the DeployDestination changes to network components. So IMHO, we need to add calls of NetworkGuru#reserve and NetworkElement#prepare in NetworkManagerImpl#prepareNicForMigration . And then, we also need to add calls NetworkGuru#release and NetworkElement#release after the migration, otherwise the network resources that plugin reserved will be kept even when the vm leaves off. Created a first minimum patch to show the concept. This addresses bug CLOUDSTACK-1638. Diffs - server/src/com/cloud/network/NetworkManager.java 8b6bf9a server/src/com/cloud/network/NetworkManagerImpl.java ba5ab5d server/src/com/cloud/vm/VirtualMachineManagerImpl.java 0aeef0e Diff: https://reviews.apache.org/r/9871/diff/ Testing --- Thanks, Hiroaki Kawai
Review Request: [CLOUDSTACK-1535] kvm agent will silently ignore many exceptions
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9774/ --- Review request for cloudstack. Description --- Current kvm agent will silently ignore many exception, and there's no way to see what really happened. This patch will log in trace level log that was silently ignored. And also, it will fix huge bare Exception catch, which is very harmful because it also catches RuntimeException. This addresses bug CLOUDSTACK-1535. Diffs - core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java fc7f08f plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/KVMHABase.java af89d9b plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java 3c848de plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtXMLParser.java 3a61403 Diff: https://reviews.apache.org/r/9774/diff/ Testing --- Thanks, Hiroaki Kawai
Review Request: (CLOUDSTACK-1558) vCenter service cookie parsing is wrong
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9786/ --- Review request for cloudstack and Min Chen. Description --- I'm sorry this is a bug I put before in the patch of CLOUDSTACK-1529 ( https://reviews.apache.org/r/9768/ ) . The bug is that cookie header value assigned was a single value from cookie key value pair. Correct value is a serialized format of key value pairs which can be get by CookieSpec#formatCookies. This addresses bug CLOUDSTACK-1558. Diffs - vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareClient.java cbae5a9 Diff: https://reviews.apache.org/r/9786/diff/ Testing --- Thanks, Hiroaki Kawai
Re: Review Request: (CLOUDSTACK-1558) vCenter service cookie parsing is wrong
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9786/ --- (Updated March 6, 2013, 11:28 p.m.) Review request for cloudstack and Min Chen. Description --- I'm sorry this is a bug I put before in the patch of CLOUDSTACK-1529 ( https://reviews.apache.org/r/9768/ ) . The bug is that cookie header value assigned was a single value from cookie key value pair. Correct value is a serialized format of key value pairs which can be get by CookieSpec#formatCookies. This addresses bug CLOUDSTACK-1558. Diffs - vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareClient.java cbae5a9 Diff: https://reviews.apache.org/r/9786/diff/ Testing --- Thanks, Hiroaki Kawai
Review Request: Remove invalid use of library internal class found in vmware-base
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9768/ --- Review request for cloudstack. Description --- com.cloud.hypervisor.vmware.util.VmwareContext is imports com.sun.xml.internal.ws.transport.http.client.CookieJar, but it must not do so, because it is an library internal class. This addresses bug CLOUDSTACK-1529. Diffs - vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareClient.java 344fbdd vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareContext.java 091ce77 Diff: https://reviews.apache.org/r/9768/diff/ Testing --- Thanks, Hiroaki Kawai
Re: Review Request: Remove invalid use of library internal class found in vmware-base
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9768/ --- (Updated March 6, 2013, 5:46 a.m.) Review request for cloudstack. Description --- com.cloud.hypervisor.vmware.util.VmwareContext is imports com.sun.xml.internal.ws.transport.http.client.CookieJar, but it must not do so, because it is an library internal class. This addresses bug CLOUDSTACK-1529. Diffs - vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareClient.java 344fbdd vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareContext.java 091ce77 Diff: https://reviews.apache.org/r/9768/diff/ Testing --- Thanks, Hiroaki Kawai
Re: Review Request: Remove invalid use of library internal class found in vmware-base
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9768/ --- (Updated March 6, 2013, 6:13 a.m.) Review request for cloudstack. Changes --- For trailing whitespace, I removed. But for tab indent, what can I do? Current VmwareContext has already mixed tab/space indent. Description --- com.cloud.hypervisor.vmware.util.VmwareContext is imports com.sun.xml.internal.ws.transport.http.client.CookieJar, but it must not do so, because it is an library internal class. This addresses bug CLOUDSTACK-1529. Diffs (updated) - vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareClient.java 344fbdd vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareContext.java 091ce77 Diff: https://reviews.apache.org/r/9768/diff/ Testing --- Thanks, Hiroaki Kawai
[jira] [Updated] (CLOUDSTACK-1489) cloudstack agent plugin classpath is missing
[ https://issues.apache.org/jira/browse/CLOUDSTACK-1489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hiroaki Kawai updated CLOUDSTACK-1489: -- Component/s: KVM cloudstack agent plugin classpath is missing Key: CLOUDSTACK-1489 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-1489 Project: CloudStack Issue Type: Improvement Security Level: Public(Anyone can view this level - this is the default.) Components: KVM Affects Versions: pre-4.0.0, 4.0.0, 4.0.1, 4.0.2, 4.1.0, 4.2.0 Environment: Linux kvm Reporter: Hiroaki Kawai There is no place to put plugin jar files for cloudstack agent program now, while management server program has default @PLUGINJAVADIR@ where plugin classes will be loaded into server at startup. We will need to load a class, for example when we try to use a custom libvirt.vif.driver which can be configured at agent.properties. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (CLOUDSTACK-1489) cloudstack agent plugin classpath is missing
Hiroaki Kawai created CLOUDSTACK-1489: - Summary: cloudstack agent plugin classpath is missing Key: CLOUDSTACK-1489 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-1489 Project: CloudStack Issue Type: Improvement Security Level: Public (Anyone can view this level - this is the default.) Affects Versions: 4.0.0, pre-4.0.0, 4.0.1, 4.0.2, 4.1.0, 4.2.0 Environment: Linux kvm Reporter: Hiroaki Kawai There is no place to put plugin jar files for cloudstack agent program now, while management server program has default @PLUGINJAVADIR@ where plugin classes will be loaded into server at startup. We will need to load a class, for example when we try to use a custom libvirt.vif.driver which can be configured at agent.properties. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CLOUDSTACK-1489) cloudstack agent plugin classpath is missing
[ https://issues.apache.org/jira/browse/CLOUDSTACK-1489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hiroaki Kawai updated CLOUDSTACK-1489: -- Affects Version/s: (was: 4.2.0) (was: 4.1.0) cloudstack agent plugin classpath is missing Key: CLOUDSTACK-1489 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-1489 Project: CloudStack Issue Type: Improvement Security Level: Public(Anyone can view this level - this is the default.) Components: KVM Affects Versions: pre-4.0.0, 4.0.0, 4.0.1, 4.0.2 Environment: Linux kvm Reporter: Hiroaki Kawai There is no place to put plugin jar files for cloudstack agent program now, while management server program has default @PLUGINJAVADIR@ where plugin classes will be loaded into server at startup. We will need to load a class, for example when we try to use a custom libvirt.vif.driver which can be configured at agent.properties. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
ポロシャツ
っpqっっpqqっpっっqっっq
[jira] [Created] (CLOUDSTACK-589) Juniper SRX does not depends on f5 iControl jar
Hiroaki Kawai created CLOUDSTACK-589: Summary: Juniper SRX does not depends on f5 iControl jar Key: CLOUDSTACK-589 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-589 Project: CloudStack Issue Type: Bug Security Level: Public (Anyone can view this level - this is the default.) Components: Network Devices Affects Versions: 4.0.0, 4.0.1, 4.1.0 Reporter: Hiroaki Kawai In plugins / network-elements / juniper-srx / pom.xml, there's a dependency element which says srx requires icontrol. But the code does not use icontrol at all, and it is safe to remove this dependency from here. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CLOUDSTACK-589) Juniper SRX does not depends on f5 iControl jar
[ https://issues.apache.org/jira/browse/CLOUDSTACK-589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hiroaki Kawai updated CLOUDSTACK-589: - Attachment: srx_pom.patch Juniper SRX does not depends on f5 iControl jar --- Key: CLOUDSTACK-589 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-589 Project: CloudStack Issue Type: Bug Security Level: Public(Anyone can view this level - this is the default.) Components: Network Devices Affects Versions: 4.0.0, 4.0.1, 4.1.0 Reporter: Hiroaki Kawai Labels: maven, patch Attachments: srx_pom.patch In plugins / network-elements / juniper-srx / pom.xml, there's a dependency element which says srx requires icontrol. But the code does not use icontrol at all, and it is safe to remove this dependency from here. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
Review Request: Default admin user account will not be created in clean setup
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8293/ --- Review request for cloudstack. Description --- Current com.cloud.server.ConfigurationServerImpl#saveUser tries to insert an admin user entity into database, but the sql leaves password field unspecified. This will always fail because the database schema declares password field NOT NULL. This patch will fix database schema, and add missing logging when this sql execution failed. Diffs - server/src/com/cloud/server/ConfigurationServerImpl.java d2f0bb0 setup/db/create-schema.sql fff084e Diff: https://reviews.apache.org/r/8293/diff/ Testing --- Thanks, Hiroaki Kawai
Re: Review Request: Default admin user account will not be created in clean setup
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8293/ --- (Updated Nov. 30, 2012, 11:09 a.m.) Review request for cloudstack. Description (updated) --- Current com.cloud.server.ConfigurationServerImpl#saveUser tries to insert an admin user entity into database, but the sql leaves password field unspecified. This will always fail because the database schema declares password field NOT NULL. This patch will fix database schema, and add missing logging when this sql execution failed. This happens only on current master:HEAD. Diffs - server/src/com/cloud/server/ConfigurationServerImpl.java d2f0bb0 setup/db/create-schema.sql fff084e Diff: https://reviews.apache.org/r/8293/diff/ Testing --- Thanks, Hiroaki Kawai
Review Request: Store NetworkServiceProvider connectivity service configuration in database.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8294/
---
Review request for cloudstack.
Description
---
There are 13 services defined in com.cloud.network.Network.Service , but db
schema has 12 services with connecitivity missing in
`cloud`.`physical_network_service_providers` . This patch will fix this. In the
cloudstack api response, we'll see Connectivity service is enabled in NiciraNvp
network service provider servicelist like this:
{
listnetworkserviceprovidersresponse: {
count: 1,
networkserviceprovider: [
{
physicalnetworkid: 80bf64a1-c5ca-4eb1-810e-76917a317d59,
servicelist: [
Connectivity
],
name: NiciraNvp,
destinationphysicalnetworkid: 0,
state: Disabled,
id: efb45f75-9fd7-43aa-9937-b5c871971c00
}
]
}
}
Diffs
-
api/src/com/cloud/network/PhysicalNetworkServiceProvider.java 1b91311
packaging/centos63/package.sh 83c0e5e
server/src/com/cloud/network/dao/PhysicalNetworkServiceProviderVO.java
12b08af
server/src/com/cloud/upgrade/dao/Upgrade40to41.java 5067f39
setup/db/create-schema.sql fff084e
setup/db/db/schema-40to41.sql PRE-CREATION
Diff: https://reviews.apache.org/r/8294/diff/
Testing
---
Thanks,
Hiroaki Kawai
Re: Review Request: HttpClient needs releaseConnection method call
On Nov. 22, 2012, 9:39 a.m., Hugo Trippaers wrote: plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/NiciraNvpApi.java, line 123 https://reviews.apache.org/r/8186/diff/1/?file=222930#file222930line123 Can you release the connection here and still call the getStatusCode() below? Yes, we can release the connection and still get the status code. - Hiroaki --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8186/#review13691 --- On Nov. 22, 2012, 8:42 a.m., Hiroaki Kawai wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8186/ --- (Updated Nov. 22, 2012, 8:42 a.m.) Review request for cloudstack. Description --- Thanks to Hugo about pointing out the page http://hc.apache.org/httpclient-3.x/threading.html , I found that we MUST call releaseConnection when we're using HttpClient in conjunction with MultiThreadedHttpConnectionManager. Diffs - agent/src/com/cloud/agent/AgentShell.java 774f222 awsapi/src/com/cloud/bridge/io/S3CAStorBucketAdapter.java 2101afe plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/NiciraNvpApi.java 26e7e0d server/src/com/cloud/cluster/ClusterServiceServletImpl.java 0c3a175 server/src/com/cloud/maint/UpgradeManagerImpl.java c1ce3f0 Diff: https://reviews.apache.org/r/8186/diff/ Testing --- Thanks, Hiroaki Kawai
Re: Review Request: HttpClient needs releaseConnection method call
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8186/ --- (Updated Nov. 27, 2012, 2:03 a.m.) Review request for cloudstack. Changes --- In NiciraNvpApi.java, previous patch called releaseConnection before reading http response body. Fixed in this patch. Description --- Thanks to Hugo about pointing out the page http://hc.apache.org/httpclient-3.x/threading.html , I found that we MUST call releaseConnection when we're using HttpClient in conjunction with MultiThreadedHttpConnectionManager. Diffs (updated) - agent/src/com/cloud/agent/AgentShell.java 774f222 awsapi/src/com/cloud/bridge/io/S3CAStorBucketAdapter.java 2101afe plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/NiciraNvpApi.java 26e7e0d server/src/com/cloud/cluster/ClusterServiceServletImpl.java 0c3a175 server/src/com/cloud/maint/UpgradeManagerImpl.java c1ce3f0 Diff: https://reviews.apache.org/r/8186/diff/ Testing --- Thanks, Hiroaki Kawai
Review Request: HttpClient needs releaseConnection method call
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8186/ --- Review request for cloudstack. Description --- Thanks to Hugo about pointing out the page http://hc.apache.org/httpclient-3.x/threading.html , I found that we MUST call releaseConnection when we're using HttpClient in conjunction with MultiThreadedHttpConnectionManager. Diffs - agent/src/com/cloud/agent/AgentShell.java 774f222 awsapi/src/com/cloud/bridge/io/S3CAStorBucketAdapter.java 2101afe plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/NiciraNvpApi.java 26e7e0d server/src/com/cloud/cluster/ClusterServiceServletImpl.java 0c3a175 server/src/com/cloud/maint/UpgradeManagerImpl.java c1ce3f0 Diff: https://reviews.apache.org/r/8186/diff/ Testing --- Thanks, Hiroaki Kawai
Review Request: CentOS rpm build fix
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8166/ --- Review request for cloudstack. Description --- The jenkins build http://jenkins.cloudstack.org/job/build-master-rhel63/ stopped for long time, and I want to bring it back working. I see there are two cloud.spec files, one in packaging/centos63 is being refactoring, and the other one is at top directory which looks more maintained. In the patch, I used the top one just because it was easy. The patch also includes a tiny fix about cloud-bridge init script. Diffs - build/build-aws-api.xml 40ad22c cloud.spec 9f46dd6 packaging/centos63/package.sh 83c0e5e Diff: https://reviews.apache.org/r/8166/diff/ Testing --- bash packaging/centos63/package.sh Thanks, Hiroaki Kawai
[jira] [Updated] (CLOUDSTACK-487) HttpClient in multithreaded environment
[ https://issues.apache.org/jira/browse/CLOUDSTACK-487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hiroaki Kawai updated CLOUDSTACK-487: - Description: Running cloudstack with nicira nvp plugin, I got following error. It seems that HttpClient in servlet must use MultiThreadedHttpConnectionManager explicitly. Patch will be submitted in reviewboard. 2012-11-14 18:21:51,576 WARN [commons.httpclient.SimpleHttpConnectionManager] (DirectAgent-62:null) SimpleHttpConnectionManager being used incorrectly. Be sure that HttpMethod.releaseConnection() is always called and that only one thread and/or method is using this connection manager at a time. 2012-11-14 18:21:52,017 WARN [agent.manager.DirectAgentAttache] (DirectAgent-62:null) Seq 5-847183891: Exception Caught while executing command java.lang.IllegalStateException: Connection is not open at org.apache.commons.httpclient.HttpConnection.assertOpen(HttpConnection.java:1277) at org.apache.commons.httpclient.HttpConnection.write(HttpConnection.java:974) at org.apache.commons.httpclient.HttpConnection.write(HttpConnection.java:943) at org.apache.commons.httpclient.HttpConnection.print(HttpConnection.java:1033) at org.apache.commons.httpclient.HttpMethodBase.writeRequestHeaders(HttpMethodBase.java:2187) at org.apache.commons.httpclient.HttpMethodBase.writeRequest(HttpMethodBase.java:2060) at org.apache.commons.httpclient.HttpMethodBase.execute(HttpMethodBase.java:1096) at org.apache.commons.httpclient.HttpMethodDirector.executeWithRetry(HttpMethodDirector.java:398) at org.apache.commons.httpclient.HttpMethodDirector.executeMethod(HttpMethodDirector.java:171) at org.apache.commons.httpclient.HttpClient.executeMethod(HttpClient.java:397) at org.apache.commons.httpclient.HttpClient.executeMethod(HttpClient.java:323) at com.cloud.network.nicira.NiciraNvpApi.executeMethod(NiciraNvpApi.java:344) at com.cloud.network.nicira.NiciraNvpApi.executeDeleteObject(NiciraNvpApi.java:294) at com.cloud.network.nicira.NiciraNvpApi.deleteLogicalSwitchPort(NiciraNvpApi.java:172) at com.cloud.network.resource.NiciraNvpResource.executeRequest(NiciraNvpResource.java:286) at com.cloud.network.resource.NiciraNvpResource.executeRequest(NiciraNvpResource.java:192) at com.cloud.network.resource.NiciraNvpResource.executeRequest(NiciraNvpResource.java:172) at com.cloud.agent.manager.DirectAgentAttache$Task.run(DirectAgentAttache.java:191) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471) at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334) at java.util.concurrent.FutureTask.run(FutureTask.java:166) at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$101(ScheduledThreadPoolExecutor.java:165) at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:266) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603) at java.lang.Thread.run(Thread.java:679) was: Running cloudstack with nicira nvp plugin, I got following error. It seems that HttpClient in servlet must use MultiThreadedHttpConnectionManager explicitly. Patch will be submitted in reviewboard. https://reviews.apache.org/r/8075/ 2012-11-14 18:21:51,576 WARN [commons.httpclient.SimpleHttpConnectionManager] (DirectAgent-62:null) SimpleHttpConnectionManager being used incorrectly. Be sure that HttpMethod.releaseConnection() is always called and that only one thread and/or method is using this connection manager at a time. 2012-11-14 18:21:52,017 WARN [agent.manager.DirectAgentAttache] (DirectAgent-62:null) Seq 5-847183891: Exception Caught while executing command java.lang.IllegalStateException: Connection is not open at org.apache.commons.httpclient.HttpConnection.assertOpen(HttpConnection.java:1277) at org.apache.commons.httpclient.HttpConnection.write(HttpConnection.java:974) at org.apache.commons.httpclient.HttpConnection.write(HttpConnection.java:943) at org.apache.commons.httpclient.HttpConnection.print(HttpConnection.java:1033) at org.apache.commons.httpclient.HttpMethodBase.writeRequestHeaders(HttpMethodBase.java:2187) at org.apache.commons.httpclient.HttpMethodBase.writeRequest(HttpMethodBase.java:2060) at org.apache.commons.httpclient.HttpMethodBase.execute(HttpMethodBase.java:1096) at org.apache.commons.httpclient.HttpMethodDirector.executeWithRetry(HttpMethodDirector.java:398) at org.apache.commons.httpclient.HttpMethodDirector.executeMethod(HttpMethodDirector.java:171
Re: Review Request: CLOUDSTACK-487 HttpClient in multithreaded environment
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8075/ --- (Updated Nov. 16, 2012, 1:35 a.m.) Review request for cloudstack. Description --- Running cloudstack with nicira nvp plugin, I got following error. It seems that HttpClient in servlet must use MultiThreadedHttpConnectionManager explicitly. 2012-11-14 18:21:51,576 WARN [commons.httpclient.SimpleHttpConnectionManager] (DirectAgent-62:null) SimpleHttpConnectionManager being used incorrectly. Be sure that HttpMethod.releaseConnection() is always called and that only one thread and/or method is using this connection manager at a time. 2012-11-14 18:21:52,017 WARN [agent.manager.DirectAgentAttache] (DirectAgent-62:null) Seq 5-847183891: Exception Caught while executing command java.lang.IllegalStateException: Connection is not open at org.apache.commons.httpclient.HttpConnection.assertOpen(HttpConnection.java:1277) at org.apache.commons.httpclient.HttpConnection.write(HttpConnection.java:974) at org.apache.commons.httpclient.HttpConnection.write(HttpConnection.java:943) at org.apache.commons.httpclient.HttpConnection.print(HttpConnection.java:1033) at org.apache.commons.httpclient.HttpMethodBase.writeRequestHeaders(HttpMethodBase.java:2187) at org.apache.commons.httpclient.HttpMethodBase.writeRequest(HttpMethodBase.java:2060) at org.apache.commons.httpclient.HttpMethodBase.execute(HttpMethodBase.java:1096) at org.apache.commons.httpclient.HttpMethodDirector.executeWithRetry(HttpMethodDirector.java:398) at org.apache.commons.httpclient.HttpMethodDirector.executeMethod(HttpMethodDirector.java:171) at org.apache.commons.httpclient.HttpClient.executeMethod(HttpClient.java:397) at org.apache.commons.httpclient.HttpClient.executeMethod(HttpClient.java:323) at com.cloud.network.nicira.NiciraNvpApi.executeMethod(NiciraNvpApi.java:344) at com.cloud.network.nicira.NiciraNvpApi.executeDeleteObject(NiciraNvpApi.java:294) at com.cloud.network.nicira.NiciraNvpApi.deleteLogicalSwitchPort(NiciraNvpApi.java:172) at com.cloud.network.resource.NiciraNvpResource.executeRequest(NiciraNvpResource.java:286) at com.cloud.network.resource.NiciraNvpResource.executeRequest(NiciraNvpResource.java:192) at com.cloud.network.resource.NiciraNvpResource.executeRequest(NiciraNvpResource.java:172) at com.cloud.agent.manager.DirectAgentAttache$Task.run(DirectAgentAttache.java:191) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471) at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334) at java.util.concurrent.FutureTask.run(FutureTask.java:166) at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$101(ScheduledThreadPoolExecutor.java:165) at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:266) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603) at java.lang.Thread.run(Thread.java:679) This addresses bug CLOUDSTACK-487. Diffs (updated) - agent/src/com/cloud/agent/AgentShell.java 05caf8e awsapi/src/com/cloud/bridge/io/S3CAStorBucketAdapter.java ad6f6cd core/src/com/cloud/storage/template/HttpTemplateDownloader.java bd607b3 plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/NiciraNvpApi.java 2c002ab server/src/com/cloud/maint/UpgradeManagerImpl.java b4bc291 Diff: https://reviews.apache.org/r/8075/diff/ Testing --- Thanks, Hiroaki Kawai
[jira] [Updated] (CLOUDSTACK-487) HttpClient in multithreaded environment
[ https://issues.apache.org/jira/browse/CLOUDSTACK-487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hiroaki Kawai updated CLOUDSTACK-487: - Description: Running cloudstack with nicira nvp plugin, I got following error. It seems that HttpClient in servlet must use MultiThreadedHttpConnectionManager explicitly. Patch will be submitted in reviewboard. https://reviews.apache.org/r/8075/ 2012-11-14 18:21:51,576 WARN [commons.httpclient.SimpleHttpConnectionManager] (DirectAgent-62:null) SimpleHttpConnectionManager being used incorrectly. Be sure that HttpMethod.releaseConnection() is always called and that only one thread and/or method is using this connection manager at a time. 2012-11-14 18:21:52,017 WARN [agent.manager.DirectAgentAttache] (DirectAgent-62:null) Seq 5-847183891: Exception Caught while executing command java.lang.IllegalStateException: Connection is not open at org.apache.commons.httpclient.HttpConnection.assertOpen(HttpConnection.java:1277) at org.apache.commons.httpclient.HttpConnection.write(HttpConnection.java:974) at org.apache.commons.httpclient.HttpConnection.write(HttpConnection.java:943) at org.apache.commons.httpclient.HttpConnection.print(HttpConnection.java:1033) at org.apache.commons.httpclient.HttpMethodBase.writeRequestHeaders(HttpMethodBase.java:2187) at org.apache.commons.httpclient.HttpMethodBase.writeRequest(HttpMethodBase.java:2060) at org.apache.commons.httpclient.HttpMethodBase.execute(HttpMethodBase.java:1096) at org.apache.commons.httpclient.HttpMethodDirector.executeWithRetry(HttpMethodDirector.java:398) at org.apache.commons.httpclient.HttpMethodDirector.executeMethod(HttpMethodDirector.java:171) at org.apache.commons.httpclient.HttpClient.executeMethod(HttpClient.java:397) at org.apache.commons.httpclient.HttpClient.executeMethod(HttpClient.java:323) at com.cloud.network.nicira.NiciraNvpApi.executeMethod(NiciraNvpApi.java:344) at com.cloud.network.nicira.NiciraNvpApi.executeDeleteObject(NiciraNvpApi.java:294) at com.cloud.network.nicira.NiciraNvpApi.deleteLogicalSwitchPort(NiciraNvpApi.java:172) at com.cloud.network.resource.NiciraNvpResource.executeRequest(NiciraNvpResource.java:286) at com.cloud.network.resource.NiciraNvpResource.executeRequest(NiciraNvpResource.java:192) at com.cloud.network.resource.NiciraNvpResource.executeRequest(NiciraNvpResource.java:172) at com.cloud.agent.manager.DirectAgentAttache$Task.run(DirectAgentAttache.java:191) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471) at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334) at java.util.concurrent.FutureTask.run(FutureTask.java:166) at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$101(ScheduledThreadPoolExecutor.java:165) at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:266) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603) at java.lang.Thread.run(Thread.java:679) was: Running cloudstack with nicira nvp plugin, I got following error. It seems that HttpClient in servlet must use MultiThreadedHttpConnectionManager explicitly. Patch will be submitted in reviewboard. 2012-11-14 18:21:51,576 WARN [commons.httpclient.SimpleHttpConnectionManager] (DirectAgent-62:null) SimpleHttpConnectionManager being used incorrectly. Be sure that HttpMethod.releaseConnection() is always called and that only one thread and/or method is using this connection manager at a time. 2012-11-14 18:21:52,017 WARN [agent.manager.DirectAgentAttache] (DirectAgent-62:null) Seq 5-847183891: Exception Caught while executing command java.lang.IllegalStateException: Connection is not open at org.apache.commons.httpclient.HttpConnection.assertOpen(HttpConnection.java:1277) at org.apache.commons.httpclient.HttpConnection.write(HttpConnection.java:974) at org.apache.commons.httpclient.HttpConnection.write(HttpConnection.java:943) at org.apache.commons.httpclient.HttpConnection.print(HttpConnection.java:1033) at org.apache.commons.httpclient.HttpMethodBase.writeRequestHeaders(HttpMethodBase.java:2187) at org.apache.commons.httpclient.HttpMethodBase.writeRequest(HttpMethodBase.java:2060) at org.apache.commons.httpclient.HttpMethodBase.execute(HttpMethodBase.java:1096) at org.apache.commons.httpclient.HttpMethodDirector.executeWithRetry(HttpMethodDirector.java:398) at org.apache.commons.httpclient.HttpMethodDirector.executeMethod(HttpMethodDirector.java:171
[jira] [Created] (CLOUDSTACK-487) HttpClient in multithreaded environment
Hiroaki Kawai created CLOUDSTACK-487: Summary: HttpClient in multithreaded environment Key: CLOUDSTACK-487 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-487 Project: CloudStack Issue Type: Bug Components: Network Devices Affects Versions: 4.0.0, 4.0.1, 4.1.0 Environment: Nicira nvp plugin in use. Reporter: Hiroaki Kawai Running cloudstack with nicira nvp plugin, I got following error. It seems that HttpClient in servlet must use MultiThreadedHttpConnectionManager explicitly. Patch will be submitted in reviewboard. 2012-11-14 18:21:51,576 WARN [commons.httpclient.SimpleHttpConnectionManager] (DirectAgent-62:null) SimpleHttpConnectionManager being used incorrectly. Be sure that HttpMethod.releaseConnection() is always called and that only one thread and/or method is using this connection manager at a time. 2012-11-14 18:21:52,017 WARN [agent.manager.DirectAgentAttache] (DirectAgent-62:null) Seq 5-847183891: Exception Caught while executing command java.lang.IllegalStateException: Connection is not open at org.apache.commons.httpclient.HttpConnection.assertOpen(HttpConnection.java:1277) at org.apache.commons.httpclient.HttpConnection.write(HttpConnection.java:974) at org.apache.commons.httpclient.HttpConnection.write(HttpConnection.java:943) at org.apache.commons.httpclient.HttpConnection.print(HttpConnection.java:1033) at org.apache.commons.httpclient.HttpMethodBase.writeRequestHeaders(HttpMethodBase.java:2187) at org.apache.commons.httpclient.HttpMethodBase.writeRequest(HttpMethodBase.java:2060) at org.apache.commons.httpclient.HttpMethodBase.execute(HttpMethodBase.java:1096) at org.apache.commons.httpclient.HttpMethodDirector.executeWithRetry(HttpMethodDirector.java:398) at org.apache.commons.httpclient.HttpMethodDirector.executeMethod(HttpMethodDirector.java:171) at org.apache.commons.httpclient.HttpClient.executeMethod(HttpClient.java:397) at org.apache.commons.httpclient.HttpClient.executeMethod(HttpClient.java:323) at com.cloud.network.nicira.NiciraNvpApi.executeMethod(NiciraNvpApi.java:344) at com.cloud.network.nicira.NiciraNvpApi.executeDeleteObject(NiciraNvpApi.java:294) at com.cloud.network.nicira.NiciraNvpApi.deleteLogicalSwitchPort(NiciraNvpApi.java:172) at com.cloud.network.resource.NiciraNvpResource.executeRequest(NiciraNvpResource.java:286) at com.cloud.network.resource.NiciraNvpResource.executeRequest(NiciraNvpResource.java:192) at com.cloud.network.resource.NiciraNvpResource.executeRequest(NiciraNvpResource.java:172) at com.cloud.agent.manager.DirectAgentAttache$Task.run(DirectAgentAttache.java:191) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471) at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334) at java.util.concurrent.FutureTask.run(FutureTask.java:166) at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$101(ScheduledThreadPoolExecutor.java:165) at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:266) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603) at java.lang.Thread.run(Thread.java:679) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
Review Request: CLOUDSTACK-487 HttpClient in multithreaded environment
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8075/ --- Review request for cloudstack. Description --- Running cloudstack with nicira nvp plugin, I got following error. It seems that HttpClient in servlet must use MultiThreadedHttpConnectionManager explicitly. 2012-11-14 18:21:51,576 WARN [commons.httpclient.SimpleHttpConnectionManager] (DirectAgent-62:null) SimpleHttpConnectionManager being used incorrectly. Be sure that HttpMethod.releaseConnection() is always called and that only one thread and/or method is using this connection manager at a time. 2012-11-14 18:21:52,017 WARN [agent.manager.DirectAgentAttache] (DirectAgent-62:null) Seq 5-847183891: Exception Caught while executing command java.lang.IllegalStateException: Connection is not open at org.apache.commons.httpclient.HttpConnection.assertOpen(HttpConnection.java:1277) at org.apache.commons.httpclient.HttpConnection.write(HttpConnection.java:974) at org.apache.commons.httpclient.HttpConnection.write(HttpConnection.java:943) at org.apache.commons.httpclient.HttpConnection.print(HttpConnection.java:1033) at org.apache.commons.httpclient.HttpMethodBase.writeRequestHeaders(HttpMethodBase.java:2187) at org.apache.commons.httpclient.HttpMethodBase.writeRequest(HttpMethodBase.java:2060) at org.apache.commons.httpclient.HttpMethodBase.execute(HttpMethodBase.java:1096) at org.apache.commons.httpclient.HttpMethodDirector.executeWithRetry(HttpMethodDirector.java:398) at org.apache.commons.httpclient.HttpMethodDirector.executeMethod(HttpMethodDirector.java:171) at org.apache.commons.httpclient.HttpClient.executeMethod(HttpClient.java:397) at org.apache.commons.httpclient.HttpClient.executeMethod(HttpClient.java:323) at com.cloud.network.nicira.NiciraNvpApi.executeMethod(NiciraNvpApi.java:344) at com.cloud.network.nicira.NiciraNvpApi.executeDeleteObject(NiciraNvpApi.java:294) at com.cloud.network.nicira.NiciraNvpApi.deleteLogicalSwitchPort(NiciraNvpApi.java:172) at com.cloud.network.resource.NiciraNvpResource.executeRequest(NiciraNvpResource.java:286) at com.cloud.network.resource.NiciraNvpResource.executeRequest(NiciraNvpResource.java:192) at com.cloud.network.resource.NiciraNvpResource.executeRequest(NiciraNvpResource.java:172) at com.cloud.agent.manager.DirectAgentAttache$Task.run(DirectAgentAttache.java:191) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471) at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334) at java.util.concurrent.FutureTask.run(FutureTask.java:166) at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$101(ScheduledThreadPoolExecutor.java:165) at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:266) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603) at java.lang.Thread.run(Thread.java:679) This addresses bug CLOUDSTACK-487. Diffs - agent/src/com/cloud/agent/AgentShell.java 05caf8e awsapi/src/com/cloud/bridge/io/S3CAStorBucketAdapter.java ad6f6cd core/src/com/cloud/storage/template/HttpTemplateDownloader.java bd607b3 plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/NiciraNvpApi.java 2c002ab server/src/com/cloud/maint/UpgradeManagerImpl.java b4bc291 Diff: https://reviews.apache.org/r/8075/diff/ Testing --- Thanks, Hiroaki Kawai
[jira] [Updated] (CLOUDSTACK-487) HttpClient in multithreaded environment
[ https://issues.apache.org/jira/browse/CLOUDSTACK-487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hiroaki Kawai updated CLOUDSTACK-487: - Description: Running cloudstack with nicira nvp plugin, I got following error. It seems that HttpClient in servlet must use MultiThreadedHttpConnectionManager explicitly. Patch will be submitted in reviewboard. https://reviews.apache.org/r/8075/ 2012-11-14 18:21:51,576 WARN [commons.httpclient.SimpleHttpConnectionManager] (DirectAgent-62:null) SimpleHttpConnectionManager being used incorrectly. Be sure that HttpMethod.releaseConnection() is always called and that only one thread and/or method is using this connection manager at a time. 2012-11-14 18:21:52,017 WARN [agent.manager.DirectAgentAttache] (DirectAgent-62:null) Seq 5-847183891: Exception Caught while executing command java.lang.IllegalStateException: Connection is not open at org.apache.commons.httpclient.HttpConnection.assertOpen(HttpConnection.java:1277) at org.apache.commons.httpclient.HttpConnection.write(HttpConnection.java:974) at org.apache.commons.httpclient.HttpConnection.write(HttpConnection.java:943) at org.apache.commons.httpclient.HttpConnection.print(HttpConnection.java:1033) at org.apache.commons.httpclient.HttpMethodBase.writeRequestHeaders(HttpMethodBase.java:2187) at org.apache.commons.httpclient.HttpMethodBase.writeRequest(HttpMethodBase.java:2060) at org.apache.commons.httpclient.HttpMethodBase.execute(HttpMethodBase.java:1096) at org.apache.commons.httpclient.HttpMethodDirector.executeWithRetry(HttpMethodDirector.java:398) at org.apache.commons.httpclient.HttpMethodDirector.executeMethod(HttpMethodDirector.java:171) at org.apache.commons.httpclient.HttpClient.executeMethod(HttpClient.java:397) at org.apache.commons.httpclient.HttpClient.executeMethod(HttpClient.java:323) at com.cloud.network.nicira.NiciraNvpApi.executeMethod(NiciraNvpApi.java:344) at com.cloud.network.nicira.NiciraNvpApi.executeDeleteObject(NiciraNvpApi.java:294) at com.cloud.network.nicira.NiciraNvpApi.deleteLogicalSwitchPort(NiciraNvpApi.java:172) at com.cloud.network.resource.NiciraNvpResource.executeRequest(NiciraNvpResource.java:286) at com.cloud.network.resource.NiciraNvpResource.executeRequest(NiciraNvpResource.java:192) at com.cloud.network.resource.NiciraNvpResource.executeRequest(NiciraNvpResource.java:172) at com.cloud.agent.manager.DirectAgentAttache$Task.run(DirectAgentAttache.java:191) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471) at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334) at java.util.concurrent.FutureTask.run(FutureTask.java:166) at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$101(ScheduledThreadPoolExecutor.java:165) at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:266) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603) at java.lang.Thread.run(Thread.java:679) was: Running cloudstack with nicira nvp plugin, I got following error. It seems that HttpClient in servlet must use MultiThreadedHttpConnectionManager explicitly. Patch will be submitted in reviewboard. 2012-11-14 18:21:51,576 WARN [commons.httpclient.SimpleHttpConnectionManager] (DirectAgent-62:null) SimpleHttpConnectionManager being used incorrectly. Be sure that HttpMethod.releaseConnection() is always called and that only one thread and/or method is using this connection manager at a time. 2012-11-14 18:21:52,017 WARN [agent.manager.DirectAgentAttache] (DirectAgent-62:null) Seq 5-847183891: Exception Caught while executing command java.lang.IllegalStateException: Connection is not open at org.apache.commons.httpclient.HttpConnection.assertOpen(HttpConnection.java:1277) at org.apache.commons.httpclient.HttpConnection.write(HttpConnection.java:974) at org.apache.commons.httpclient.HttpConnection.write(HttpConnection.java:943) at org.apache.commons.httpclient.HttpConnection.print(HttpConnection.java:1033) at org.apache.commons.httpclient.HttpMethodBase.writeRequestHeaders(HttpMethodBase.java:2187) at org.apache.commons.httpclient.HttpMethodBase.writeRequest(HttpMethodBase.java:2060) at org.apache.commons.httpclient.HttpMethodBase.execute(HttpMethodBase.java:1096) at org.apache.commons.httpclient.HttpMethodDirector.executeWithRetry(HttpMethodDirector.java:398) at org.apache.commons.httpclient.HttpMethodDirector.executeMethod(HttpMethodDirector.java:171
[jira] [Updated] (CLOUDSTACK-423) During VM migration on KVM, VifDriver.unplug is not called.
[ https://issues.apache.org/jira/browse/CLOUDSTACK-423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hiroaki Kawai updated CLOUDSTACK-423: - Summary: During VM migration on KVM, VifDriver.unplug is not called. (was: During VM migration with KVM, VifDriver.unplug is not called.) During VM migration on KVM, VifDriver.unplug is not called. --- Key: CLOUDSTACK-423 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-423 Project: CloudStack Issue Type: Bug Components: KVM Affects Versions: 4.0.0, 4.1.0 Environment: Reproducable on CentOS 6.3 Reporter: Hiroaki Kawai Labels: patch VifDriver.unplug must be called in MigrateCommand which hooks VM migration in source host, because plug will be called in PrepareForMigration in destination host. But current LibvirtComputingResources lacks that operation. Patch will be submitted in reviewboard. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (CLOUDSTACK-423) During VM migration with KVM, VifDriver.unplug is not called.
Hiroaki Kawai created CLOUDSTACK-423: Summary: During VM migration with KVM, VifDriver.unplug is not called. Key: CLOUDSTACK-423 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-423 Project: CloudStack Issue Type: Bug Components: KVM Affects Versions: 4.0.0, 4.1.0 Environment: Reproducable on CentOS 6.3 Reporter: Hiroaki Kawai VifDriver.unplug must be called in MigrateCommand which hooks VM migration in source host, because plug will be called in PrepareForMigration in destination host. But current LibvirtComputingResources lacks that operation. Patch will be submitted in reviewboard. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
Review Request: CLOUDSTACK-423 : During VM migration on KVM, VifDriver.unplug is not called.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7761/ --- Review request for cloudstack. Description --- VifDriver.unplug must be called in MigrateCommand which hooks VM migration in source host, because plug will be called in PrepareForMigration in destination host. But that operation is missing in current LibvirtComputingResources. This addresses bug CLOUDSTACK-423. Diffs - plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java 1bc70fa Diff: https://reviews.apache.org/r/7761/diff/ Testing --- Thanks, Hiroaki Kawai
[jira] [Updated] (CLOUDSTACK-423) During VM migration on KVM, VifDriver.unplug is not called.
[ https://issues.apache.org/jira/browse/CLOUDSTACK-423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hiroaki Kawai updated CLOUDSTACK-423: - Description: VifDriver.unplug must be called in MigrateCommand which hooks VM migration in source host, because plug will be called in PrepareForMigration in destination host. But current LibvirtComputingResources lacks that operation. Patch will be submitted in reviewboard : https://reviews.apache.org/r/7761/ was: VifDriver.unplug must be called in MigrateCommand which hooks VM migration in source host, because plug will be called in PrepareForMigration in destination host. But current LibvirtComputingResources lacks that operation. Patch will be submitted in reviewboard. During VM migration on KVM, VifDriver.unplug is not called. --- Key: CLOUDSTACK-423 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-423 Project: CloudStack Issue Type: Bug Components: KVM Affects Versions: 4.0.0, 4.1.0 Environment: Reproducable on CentOS 6.3 Reporter: Hiroaki Kawai Labels: patch VifDriver.unplug must be called in MigrateCommand which hooks VM migration in source host, because plug will be called in PrepareForMigration in destination host. But current LibvirtComputingResources lacks that operation. Patch will be submitted in reviewboard : https://reviews.apache.org/r/7761/ -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
Review Request: kvm agent NIC unplug will always fail
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7612/ --- Review request for cloudstack. Description --- On kvm computing host, vifdriver.unplug will always fails (throws LibvirtException) and network cleanup will not be called. This was because the code first undefine the computing domain, and then tries to query the destroyed machine definition to fetch NIC information. IMHO, kvm plugin code rounds LibvirtException too much. Diffs - plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java 1bc70fa Diff: https://reviews.apache.org/r/7612/diff/ Testing --- Thanks, Hiroaki Kawai
Review Request: fix 4.0 build failure (invalid constructor argument)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7337/ --- Review request for cloudstack. Description --- This patch fixes build error displayed in http://jenkins.cloudstack.org/job/build-4.0/91/ Diffs - server/src/com/cloud/network/rules/RulesManagerImpl.java 37cae90 Diff: https://reviews.apache.org/r/7337/diff/ Testing --- Thanks, Hiroaki Kawai
Re: Review Request: STT isolation support for KVM
On Sept. 27, 2012, 12:34 a.m., edison su wrote: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java, line 132 https://reviews.apache.org/r/7165/diff/2/?file=158452#file158452line132 Sorry for the late about reviewing your code. I think here it's better to subclass BridgeVifDriver, as normal linux bridge doesn't this special handling. For example, you can put all your modification on BridgeVifDriver into a new class called ovsVifDriver, override plug and unplug, then in agent.properties file, add libvirt.vif.driver=ovsVifDriver. While playing the code, I found that current LibvirtComputingResource has tons of code that depends on linux bridge and vlan config, so I could not think about a sensible ovs libvirt.vif.driver now. I would discard this patch for now. - Hiroaki --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7165/#review11960 --- On Sept. 19, 2012, 11:30 a.m., Hiroaki Kawai wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7165/ --- (Updated Sept. 19, 2012, 11:30 a.m.) Review request for cloudstack. Description --- Adds STT support on KVM host, just like in XenServer. The host os having openvswitch and brcompat kernel module will plug the VM to openvswitch port through general brctl interface calls. Diffs - plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java cf4de09 scripts/vm/network/vnet/setupLswitch.sh PRE-CREATION server/src/com/cloud/hypervisor/HypervisorGuruBase.java 242852f Diff: https://reviews.apache.org/r/7165/diff/ Testing --- Thanks, Hiroaki Kawai
Re: Review Request: Set correct version for database version check
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7013/ --- (Updated Sept. 25, 2012, 2:27 p.m.) Review request for cloudstack. Changes --- What I really wanted to fix with this patch, is let us type just waf rpm and get a working binary. Leaving version number as 4.0 is problematic anyway. So I narrow the scope and submit a new patch. Description --- Reading com.cloud.maint.Version in server, version numbers must be x.x.x and artifacts should be appneded with -. This patch will fix startup database check errors in management server. Diffs (updated) - wscript ff38ed2 Diff: https://reviews.apache.org/r/7013/diff/ Testing --- Thanks, Hiroaki Kawai
Review Request: STT isolation support for KVM
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7165/ --- Review request for cloudstack. Description --- Adds STT support on KVM host, just like in XenServer. The host os having openvswitch and brcompat kernel module will plug the VM to openvswitch port through general brctl interface calls. Diffs - plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java cf4de09 scripts/vm/network/vnet/setupLswitch.sh PRE-CREATION server/src/com/cloud/hypervisor/HypervisorGuruBase.java 242852f Diff: https://reviews.apache.org/r/7165/diff/ Testing --- Thanks, Hiroaki Kawai
[jira] [Commented] (CLOUDSTACK-120) Failed to deploy Router with KVM hyperviosor [ Can't find the mapping of guest os: Debian GNU/Linux 5.0 (32-bit)]
[
https://issues.apache.org/jira/browse/CLOUDSTACK-120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13457707#comment-13457707
]
Hiroaki Kawai commented on CLOUDSTACK-120:
--
This is not fixed in 4.0 branch.
Failed to deploy Router with KVM hyperviosor [ Can't find the mapping of
guest os: Debian GNU/Linux 5.0 (32-bit)]
--
Key: CLOUDSTACK-120
URL: https://issues.apache.org/jira/browse/CLOUDSTACK-120
Project: CloudStack
Issue Type: Bug
Components: KVM, Management Server
Affects Versions: pre-4.0.0
Reporter: Sailaja Mada
Assignee: edison su
Priority: Blocker
Fix For: pre-4.0.0
Attachments: agent.log, api-server.log, management-server.log
Steps:
1. Setup Management server
2. Setup KVM host with Cloudstack Agent installed
3. Setup Basic Zone with SG service offering
4. After having all the system VM's running , tried to deploy the first
instance
Observation :
First Instance deployment failed as the router failed start .
MS Error log :
2012-09-17 15:10:27,255 DEBUG
[network.router.VirtualNetworkApplianceManagerImpl]
(RouterStatusMonitor-1:null) Found 0 routers.
2012-09-17 15:10:31,882 DEBUG [agent.transport.Request]
(AgentManager-Handler-14:null) Seq 3-1151271005: Processing: { Ans: ,
MgmtId: 55487956346259, via: 3, Ver: v1, Flags: 110,
[{StartAnswer:{vm:{id:4,name:r-4-VM,type:DomainRouter,cpus:1,speed:500,minRam:134217728,maxRam:134217728,arch:x86_64,os:Debian
GNU/Linux 5.0 (32-bit),bootArgs: template=domP name=r-4-VM
eth0ip=10.102.125.188 eth0mask=255.255.255.0 gateway=10.102.125.1
domain=cs1cloud.internal dhcprange=10.102.125.1 eth1ip=169.254.1.202
eth1mask=255.255.0.0 type=dhcpsrvr disable_rp_filter=true
dns1=10.103.128.15,rebootOnCrash:false,enableHA:true,limitCpuUse:false,vncPassword:fa3d755b18ba1297,params:{},uuid:6e5680fa-14b1-447d-9024-1bed9cb59268,disks:[{id:4,name:/cloudstack/sailaja/pri1/,mountPoint:0614e5e3-77ce-46da-b356-4e528752aa9d,path:0614e5e3-77ce-46da-b356-4e528752aa9d,size:725811200,type:ROOT,storagePoolType:NetworkFilesystem,storagePoolUuid:e95f2598-5038-3ceb-a326-5309b3295012,deviceId:0}],nics:[{deviceId:0,networkRateMbps:200,defaultNic:true,uuid:a6b006af-039e-4a00-bdeb-97ac623fb56e,ip:10.102.125.188,netmask:255.255.255.0,gateway:10.102.125.1,mac:06:bb:c4:00:00:09,dns1:10.103.128.15,broadcastType:Native,type:Guest,broadcastUri:vlan://untagged,isolationUri:ec2://untagged,isSecurityGroupEnabled:false},{deviceId:1,networkRateMbps:-1,defaultNic:false,uuid:e694c359-0609-42b6-872b-f2191ee20241,ip:169.254.1.202,netmask:255.255.0.0,gateway:169.254.0.1,mac:0e:00:a9:fe:01:ca,broadcastType:LinkLocal,type:Control,isSecurityGroupEnabled:false}]},result:true,wait:0}},{check.CheckSshAnswer:{result:true,wait:0}},{GetDomRVersionAnswer:{result:false,details:GetDomRVersionCmd
failed,wait:0}},{Answer:{result:false,details:Stopped by previous
failure,wait:0}}] }
2012-09-17 15:10:31,882 DEBUG [agent.transport.Request]
(Job-Executor-8:job-8) Seq 3-1151271005: Received: { Ans: , MgmtId:
55487956346259, via: 3, Ver: v1, Flags: 110, { StartAnswer, CheckSshAnswer,
GetDomRVersionAnswer, Answer } }
2012-09-17 15:10:31,884 DEBUG [agent.manager.AgentAttache]
(AgentManager-Handler-14:null) Seq 3-1151271005: No more commands found
2012-09-17 15:10:31,888 WARN
[network.router.VirtualNetworkApplianceManagerImpl] (Job-Executor-8:job-8)
Unable to get the template/scripts version of router r-4-VM due to:
GetDomRVersionCmd failed
2012-09-17 15:10:31,888 INFO [cloud.vm.VirtualMachineManagerImpl]
(Job-Executor-8:job-8) The guru did not like the answers so stopping
VM[DomainRouter|r-4-VM]
2012-09-17 15:10:31,890 DEBUG [agent.transport.Request]
(Job-Executor-8:job-8) Seq 3-1151271010: Sending { Cmd , MgmtId:
55487956346259, via: 3, Ver: v1, Flags: 100111,
[{StopCommand:{isProxy:false,vmName:r-4-VM,wait:0}}] }
Cloud Agent Error log :
2012-09-17 15:44:06,178 DEBUG [kvm.resource.KVMGuestOsMapper]
(agentRequest-Handler-5:null) Can't find the mapping of guest os: Debian
GNU/Linux 5.0 (32-bit)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
Review Request: Add proper OS name to KVMGuestOsMapper for systemvm
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7144/ --- Review request for cloudstack. Description --- The patch https://reviews.apache.org/r/7132 for https://issues.apache.org/jira/browse/CLOUDSTACK-120 is not applied in 4.0 branch. This addresses bug CLOUDSTACK-120. Diffs - plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/KVMGuestOsMapper.java 88bb0f5 Diff: https://reviews.apache.org/r/7144/diff/ Testing --- Thanks, Hiroaki Kawai
Review Request: add logging for debugging.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7153/ --- Review request for cloudstack. Description --- add logging for debugging. The default value for local.storage.path does not exists by default in CentOS 6. By default, this results in NullPointerException silently. Without this log message, administrator can't figure out the reason at all. Diffs - plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java d6236a0d6038bbf251450a424ea0089c01739e00 Diff: https://reviews.apache.org/r/7153/diff/ Testing --- Thanks, Hiroaki Kawai
[jira] [Commented] (CLOUDSTACK-78) Cloudstack Agent installation failed with jsvc package dependancy error
[ https://issues.apache.org/jira/browse/CLOUDSTACK-78?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13453847#comment-13453847 ] Hiroaki Kawai commented on CLOUDSTACK-78: - Please try typing: yum install jsvc and/or yum install jakarta-commons-daemon-jsvc Cloudstack Agent installation failed with jsvc package dependancy error Key: CLOUDSTACK-78 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-78 Project: CloudStack Issue Type: Bug Components: Install and Setup Affects Versions: pre-4.0.0 Reporter: Sailaja Mada Assignee: David Nalley Priority: Critical Fix For: pre-4.0.0 Steps: 1. Tried installing Agent with KVM host . Observation : Cloudstack Agent installation failed with jsvc package dependancy error Details : M) Install the Management Server A) Install the Agent B) Install BareMetal Agent S) Install the Usage Monitor D) Install the database server Q) Quit A Installing the Agent... Loaded plugins: product-id, security, subscription-manager Updating certificate-based repositories. cloud-temp | 2.6 kB 00:00 ... cloud-temp/primary_db | 10 kB 00:00 ... rhel | 4.0 kB 00:00 ... Setting up Install Process No package cloud-premium available. Resolving Dependencies -- Running transaction check --- Package cloud-agent.x86_64 0:4.0.59-0.59.el6.4.0 will be installed -- Processing Dependency: cloud-utils = 4.0.59 for package: cloud-agent-4.0.59-0.59.el6.4.0.x86_64 -- Processing Dependency: cloud-python = 4.0.59 for package: cloud-agent-4.0.59-0.59.el6.4.0.x86_64 -- Processing Dependency: cloud-deps = 4.0.59 for package: cloud-agent-4.0.59-0.59.el6.4.0.x86_64 -- Processing Dependency: cloud-core = 4.0.59 for package: cloud-agent-4.0.59-0.59.el6.4.0.x86_64 -- Processing Dependency: cloud-agent-scripts = 4.0.59 for package: cloud-agent-4.0.59-0.59.el6.4.0.x86_64 -- Processing Dependency: cloud-agent-libs = 4.0.59 for package: cloud-agent-4.0.59-0.59.el6.4.0.x86_64 -- Processing Dependency: jsvc for package: cloud-agent-4.0.59-0.59.el6.4.0.x86_64 -- Processing Dependency: jna for package: cloud-agent-4.0.59-0.59.el6.4.0.x86_64 -- Running transaction check --- Package cloud-agent.x86_64 0:4.0.59-0.59.el6.4.0 will be installed -- Processing Dependency: jsvc for package: cloud-agent-4.0.59-0.59.el6.4.0.x86_64 --- Package cloud-agent-libs.x86_64 0:4.0.59-0.59.el6.4.0 will be installed --- Package cloud-agent-scripts.x86_64 0:4.0.59-0.59.el6.4.0 will be installed --- Package cloud-core.x86_64 0:4.0.59-0.59.el6.4.0 will be installed --- Package cloud-deps.x86_64 0:4.0.59-0.59.el6.4.0 will be installed --- Package cloud-python.x86_64 0:4.0.59-0.59.el6.4.0 will be installed --- Package cloud-utils.x86_64 0:4.0.59-0.59.el6.4.0 will be installed --- Package jna.x86_64 0:3.2.4-2.el6 will be installed -- Finished Dependency Resolution Error: Package: cloud-agent-4.0.59-0.59.el6.4.0.x86_64 (cloud-temp) Requires: jsvc You could try using --skip-broken to work around the problem You could try running: rpm -Va --nofiles --nodigest Done Expected Results : Installation should go thru with out any issues. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
Review Request: cloud.spec centos6 Requires package name fix.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7009/ --- Review request for cloudstack. Description --- On centos 6.3, jakarta-commons-lang is the package name for apache-commons-lang which is the name on fedora. Without this patch, rpm installation will fail. Diffs - cloud.spec c31fe5b Diff: https://reviews.apache.org/r/7009/diff/ Testing --- Thanks, Hiroaki Kawai
Review Request: Set correct version for database version check
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7013/ --- Review request for cloudstack. Description --- Reading com.cloud.maint.Version in server, version numbers must be x.x.x and artifacts should be appneded with -. This patch will fix startup database check errors in management server. Diffs - wscript f1c9b62 wscript_configure dcea410 Diff: https://reviews.apache.org/r/7013/diff/ Testing --- Thanks, Hiroaki Kawai
Re: Review Request: agent rpm package requires more package on CentOS6
On Sept. 11, 2012, 12:22 p.m., Prasanna Santhanam wrote: Fixes https://issues.apache.org/jira/browse/CLOUDSTACK-78? No, I think. In my computing node od centos 6,jsvc was installed successfully. Issue 78 requires more information about the explicit distribution on which KVM is running. - Hiroaki --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7015/#review11320 --- On Sept. 11, 2012, 12:09 p.m., Hiroaki Kawai wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7015/ --- (Updated Sept. 11, 2012, 12:09 p.m.) Review request for cloudstack. Description --- On CentOS 6.3, jsvc is resolved as jakarta-commons-daemon-jsvc, but jakarta-commons-daemon was not installed with it. jakarta-commons-daemon provides /usr/share/java/commons-daemon.jar. Without this package, jsvc fails to start because of lack of necessary classes, and debugging this is quite hard that I had to pass -errfile option to jsvc. Diffs - cloud.spec c31fe5b Diff: https://reviews.apache.org/r/7015/diff/ Testing --- Thanks, Hiroaki Kawai
[jira] [Commented] (CLOUDSTACK-78) Cloudstack Agent installation failed with jsvc package dependancy error
[ https://issues.apache.org/jira/browse/CLOUDSTACK-78?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13453056#comment-13453056 ] Hiroaki Kawai commented on CLOUDSTACK-78: - What is the distribution you were using when you got this error. Red hat, fedora, centos 5 or 6, Ubuntu, or something other? Cloudstack Agent installation failed with jsvc package dependancy error Key: CLOUDSTACK-78 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-78 Project: CloudStack Issue Type: Bug Components: Install and Setup Affects Versions: pre-4.0.0 Reporter: Sailaja Mada Assignee: edison su Priority: Critical Steps: 1. Tried installing Agent with KVM host . Observation : Cloudstack Agent installation failed with jsvc package dependancy error Details : M) Install the Management Server A) Install the Agent B) Install BareMetal Agent S) Install the Usage Monitor D) Install the database server Q) Quit A Installing the Agent... Loaded plugins: product-id, security, subscription-manager Updating certificate-based repositories. cloud-temp | 2.6 kB 00:00 ... cloud-temp/primary_db | 10 kB 00:00 ... rhel | 4.0 kB 00:00 ... Setting up Install Process No package cloud-premium available. Resolving Dependencies -- Running transaction check --- Package cloud-agent.x86_64 0:4.0.59-0.59.el6.4.0 will be installed -- Processing Dependency: cloud-utils = 4.0.59 for package: cloud-agent-4.0.59-0.59.el6.4.0.x86_64 -- Processing Dependency: cloud-python = 4.0.59 for package: cloud-agent-4.0.59-0.59.el6.4.0.x86_64 -- Processing Dependency: cloud-deps = 4.0.59 for package: cloud-agent-4.0.59-0.59.el6.4.0.x86_64 -- Processing Dependency: cloud-core = 4.0.59 for package: cloud-agent-4.0.59-0.59.el6.4.0.x86_64 -- Processing Dependency: cloud-agent-scripts = 4.0.59 for package: cloud-agent-4.0.59-0.59.el6.4.0.x86_64 -- Processing Dependency: cloud-agent-libs = 4.0.59 for package: cloud-agent-4.0.59-0.59.el6.4.0.x86_64 -- Processing Dependency: jsvc for package: cloud-agent-4.0.59-0.59.el6.4.0.x86_64 -- Processing Dependency: jna for package: cloud-agent-4.0.59-0.59.el6.4.0.x86_64 -- Running transaction check --- Package cloud-agent.x86_64 0:4.0.59-0.59.el6.4.0 will be installed -- Processing Dependency: jsvc for package: cloud-agent-4.0.59-0.59.el6.4.0.x86_64 --- Package cloud-agent-libs.x86_64 0:4.0.59-0.59.el6.4.0 will be installed --- Package cloud-agent-scripts.x86_64 0:4.0.59-0.59.el6.4.0 will be installed --- Package cloud-core.x86_64 0:4.0.59-0.59.el6.4.0 will be installed --- Package cloud-deps.x86_64 0:4.0.59-0.59.el6.4.0 will be installed --- Package cloud-python.x86_64 0:4.0.59-0.59.el6.4.0 will be installed --- Package cloud-utils.x86_64 0:4.0.59-0.59.el6.4.0 will be installed --- Package jna.x86_64 0:3.2.4-2.el6 will be installed -- Finished Dependency Resolution Error: Package: cloud-agent-4.0.59-0.59.el6.4.0.x86_64 (cloud-temp) Requires: jsvc You could try using --skip-broken to work around the problem You could try running: rpm -Va --nofiles --nodigest Done Expected Results : Installation should go thru with out any issues. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: Review Request: Set correct version for database version check
On Sept. 11, 2012, 6:06 p.m., edison su wrote:
We just need to fix the parameter passed into build system. Right now, the
version number 4.0.{build number} is passed in, so each time, from mgt
server point of view, it's a different version. We can change to
4.0.0.{build number}. I'll fix it in
http://jenkins.cloudstack.org/job/build-cloudstack-master-rhel6.3/configure,
change the package-version to 4.0.0, instead of 4.0
4.0.0.{buil number} works, but I prefer 4.0.0-{build number} in the MANIFEST.MF
because com.cloud.maint.Version#trimToPatch handles -.
To clarify, I would note that in current code, which passes 4.0.{build number},
does not work because management server will raise an exception at
com.cloud.upgrade.DatabaseUpgradeChecker#upgrade with a message There is no
upgrade path from 4.0 to 4.0.{build number}. The database version would be
upgraded to 4.0.0 by com.cloud.upgrade.dao.Upgrade302to40 , and that does not
match against 4.0.{build number} written in jar manifest Implementation-Version.
- Hiroaki
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7013/#review11343
---
On Sept. 11, 2012, 10:08 a.m., Hiroaki Kawai wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7013/
---
(Updated Sept. 11, 2012, 10:08 a.m.)
Review request for cloudstack.
Description
---
Reading com.cloud.maint.Version in server, version numbers must be x.x.x and
artifacts should be appneded with -. This patch will fix startup database
check errors in management server.
Diffs
-
wscript f1c9b62
wscript_configure dcea410
Diff: https://reviews.apache.org/r/7013/diff/
Testing
---
Thanks,
Hiroaki Kawai
Review Request: typo in cloud-install-sys-tmplt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7049/ --- Review request for cloudstack. Description --- cloud-install-sys-tmplt has a typo in shell script syntax. /usr/lib64/cloud/agent/scripts/storage/secondary/cloud-install-sys-tmplt: line 141: [: missing `]' Diffs - scripts/storage/secondary/cloud-install-sys-tmplt d744b56 Diff: https://reviews.apache.org/r/7049/diff/ Testing --- Thanks, Hiroaki Kawai
Re: Review Request: typo in cloud-install-sys-tmplt
On Sept. 12, 2012, 1:46 a.m., mice xia wrote: this is CLOUDSTACK-37, already committed in master b52bd1fc5a00a3e1443e0cd30707ed961ea2a6f3 Fixd in master b3d4246a141854303ac9e72e3eb2b92ba01aca40, thanks. Then CLOUDSTACK-37 might be closed :-) - Hiroaki --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7049/#review11373 --- On Sept. 12, 2012, 12:36 a.m., Hiroaki Kawai wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7049/ --- (Updated Sept. 12, 2012, 12:36 a.m.) Review request for cloudstack. Description --- cloud-install-sys-tmplt has a typo in shell script syntax. /usr/lib64/cloud/agent/scripts/storage/secondary/cloud-install-sys-tmplt: line 141: [: missing `]' Diffs - scripts/storage/secondary/cloud-install-sys-tmplt d744b56 Diff: https://reviews.apache.org/r/7049/diff/ Testing --- Thanks, Hiroaki Kawai
Re: [ASFCS40] Release Candidate Status
On 2012/09/07, at 23:02, Rohit Yadav rohit.ya...@citrix.com wrote: On 07-Sep-2012, at 6:50 PM, Chip Childers chip.child...@sungard.com wrote: On Fri, Sep 7, 2012 at 12:33 AM, Rajesh Battala rajesh.batt...@citrix.com wrote: -Original Message- From: Chip Childers [mailto:chip.child...@sungard.com] Sent: Friday, September 07, 2012 9:41 AM To: cloudstack-dev@incubator.apache.org Subject: [ASFCS40] Release Candidate Status Hi all, Wido and Edison have been working on build issues this evening, but we haven't sorted everything yet. Currently, I'm stuck with trying to build the deb packages on a fresh Ubuntu 12.04 VM. I'm getting this error during ./waf deb: incubator-cloudstack/artifacts/debbuild/cloud-4.0/build/build-aws-api.xml:34: taskdef class org.apache.axis2.tool.ant.AntCodegenTask cannot be found [Rajesh Battala] Ant broken. Can you try building other components by commenting build-aws-api.xml in build.xml Based on the latest master, and talking with Wido, the correct build process for a deb package is now: mvn install -P deps dpkg-buildpackage WIki updated: https://cwiki.apache.org/confluence/display/CLOUDSTACK/Building+with+Maven#BuildingwithMaven-BuildingDEBpackages Temporary build process on asf master as suggested by Edison on IRC: https://cwiki.apache.org/confluence/display/CLOUDSTACK/Building+with+Maven#BuildingwithMaven-TemporaryBuildProcessonASFMaster Though I keep getting error, in compile-kvm: http://pastebin.com/Zdx1vGVw I experienced that when I have system installed libvirt-java of version 0.4.7. The cloudstack code requires 0.4.8. In maven build, this does not happen because maven builds a right class path environment from dependencies.
Review Request: Fedora 17 openjdk 1.7 support
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6941/ --- Review request for cloudstack. Description --- In fedora 17 package, openjdk 1.6 package was marked as deprecated, and only openjdk 1.7 is available for general. https://admin.fedoraproject.org/pkgdb/acls/name/java-1.6.0-openjdk Diffs - cloud.spec b22bd8c Diff: https://reviews.apache.org/r/6941/diff/ Testing --- mvn mvn test Thanks, Hiroaki Kawai
Review Request: maven without -Dnonoss build dependency fix
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6923/ --- Review request for cloudstack. Description --- I run mvn without -Dnonoss and got errors about vmware jar dependencies (with empty m2 local repository). [ERROR] Failed to execute goal on project cloud-vmware-base: Could not resolve dependencies for project org.apache.cloudstack:cloud-vmware-base:jar:4.0.0-SNAPSHOT: The following artifacts could not be resolved: com.cloud.com.vmware:vmware-vim:jar:1.0, com.cloud.com.vmware:vmware-vim25:jar:1.0, com.cloud.com.vmware:vmware-apputils:jar:1.0: Could not find artifact com.cloud.com.vmware:vmware-vim:jar:1.0 in central (http://repo.maven.apache.org/maven2) - [Help 1] Here I attach a patch to fix this. Diffs - pom.xml 99b1177 Diff: https://reviews.apache.org/r/6923/diff/ Testing --- mvn mvn test Thanks, Hiroaki Kawai
Re: Review Request: maven without -Dnonoss build dependency fix
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6923/ --- (Updated Sept. 5, 2012, 10:08 a.m.) Review request for cloudstack. Changes --- console-proxy and patches module seems just does not depend on those vmware jars, so I removed the dependencies. Description --- I run mvn without -Dnonoss and got errors about vmware jar dependencies (with empty m2 local repository). [ERROR] Failed to execute goal on project cloud-vmware-base: Could not resolve dependencies for project org.apache.cloudstack:cloud-vmware-base:jar:4.0.0-SNAPSHOT: The following artifacts could not be resolved: com.cloud.com.vmware:vmware-vim:jar:1.0, com.cloud.com.vmware:vmware-vim25:jar:1.0, com.cloud.com.vmware:vmware-apputils:jar:1.0: Could not find artifact com.cloud.com.vmware:vmware-vim:jar:1.0 in central (http://repo.maven.apache.org/maven2) - [Help 1] Here I attach a patch to fix this. Diffs (updated) - console-proxy/pom.xml 070beb8 patches/pom.xml efe61af pom.xml 99b1177 Diff: https://reviews.apache.org/r/6923/diff/ Testing --- mvn mvn test Thanks, Hiroaki Kawai
Review Request: maven kvm hypervisor plugin build without -Dnonoss
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6925/ --- Review request for cloudstack. Description --- Adding libvirt.org maven repository in pom.xml will automate the build, and we can run kvm hypervisor plugin build without -Dnonoss. I also added exec:java configuration so that we can test the hypervisor code easily. Diffs - plugins/hypervisors/kvm/pom.xml 8cdaa86 plugins/pom.xml 2a6ca31 Diff: https://reviews.apache.org/r/6925/diff/ Testing --- mvn mvn test Thanks, Hiroaki Kawai
Re: How to run kvm agent on development environment by maven
Hi,
I'd like to suggest that we run exec:java with -pl plugins/hypervisors/kvm .
# Running AgentShell will require some host setups.
On 2012/09/04, at 18:35, Wido den Hollander w...@widodh.nl wrote:
On 09/04/2012 03:38 AM, Satoshi Kobayashi wrote:
Hi Wido,
Thank you for your reply.
2012/9/3 Wido den Hollander w...@widodh.nl:
On 09/03/2012 09:37 AM, Satoshi Kobayashi wrote:
Hello,
I'm trying to run kvm agent on development environment by maven. But,
the trial has stuck. I think that there is a problem through which
dependence circulates (agent cloud-plugin-hypervisor-kvm).
The following is an outline of my trial.
1. execute maven
(mvn exec:java -pl agent
-Dexec.mainClass=com.cloud.agent.AgentShell -Dnonoss)
- an exception is raised
com.cloud.utils.exception.CloudRuntimeException: Unable to find
com.cloud.configuration.DefaultInterceptorLibrary
2. add dependency (cloud-server) to pom.xml of agent and re-execute maven
- an exception is raised
Caused by: com.cloud.utils.exception.CloudRuntimeException: Unable to
find the implementation version of this agent
at com.cloud.agent.AgentShell.init(AgentShell.java:382)
at com.cloud.agent.AgentShell.main(AgentShell.java:630)
... 6 more
Hmm, that seems something that goes wrong when the Agent is not ran by JSVC.
A couple of weeks ago the AgentShell was changed to run with JSVC:
https://git-wip-us.apache.org/repos/asf?p=incubator-cloudstack.git;a=commitdiff;h=eab3e4783e0f8aba7dab889bdfcc441a028b387a
I'll take a look at this and try to reproduce it locally.
Wido
Is using JSVC recommended even if on development environment? I would
like to know the development approach recommended for Agent.
No, it should also run without JSVC with just plain Java. I'll check this
asap.
Wido
Regards,
Satoshi
3. skip version check and re-execute maven
- permission error
Unable to start agent: Unable to create the /var/run/agent.pid. Are
you running as root?
4. run as root
- an exception is raised
ERROR [cloud.agent.AgentShell] (com.cloud.agent.AgentShell.main():)
Unable to start agent: Resource class not found:
com.cloud.hypervisor.kvm.resource.LibvirtComputingResource due to:
java.lang.ClassNotFoundException:
com.cloud.hypervisor.kvm.resource.LibvirtComputingResource
Unable to start agent: Resource class not found:
com.cloud.hypervisor.kvm.resource.LibvirtComputingResource due to:
java.lang.ClassNotFoundException:
com.cloud.hypervisor.kvm.resource.LibvirtComputingResource
5. add dependency (cloud-plugin-hypervisor-kvm) to pom.xml of agent
and re-execute maven
- maven error
[ERROR] The projects in the reactor contain a cyclic reference: Edge
between
'Vertex{label='org.apache.cloudstack:cloud-plugin-hypervisor-kvm:4.0.0-SNAPSHOT'}'
and 'Vertex{label='org.apache.cloudstack:cloud-agent:4.0.0-SNAPSHOT'}'
introduces to cycle in the graph
org.apache.cloudstack:cloud-agent:4.0.0-SNAPSHOT --
org.apache.cloudstack:cloud-plugin-hypervisor-kvm:4.0.0-SNAPSHOT --
org.apache.cloudstack:cloud-agent:4.0.0-SNAPSHOT - [Help 1]
Even if it remove dependency of agent from
cloud-plugin-hypervisor-kvm, it does not run.
It was not found although I looked for the document written about the
method of running kvm agent. Or is the method known if it is not maven
but ant?
The patch used for this trial is attached.
Thanks,
Satoshi
