Review Request: CLOUDSTACK-1511: Instance NIC details do not have network name.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10030/ --- Review request for cloudstack and Chip Childers. Description --- This patch fixes the bug https://issues.apache.org/jira/browse/CLOUDSTACK-1511, where instance NIC is missing network name information. This is fixed by fetching network_name from networks table during creating user_vm_view database view. This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-1511. Diffs - server/src/com/cloud/api/query/dao/UserVmJoinDaoImpl.java f561449 server/src/com/cloud/api/query/vo/UserVmJoinVO.java d723822 setup/db/db/schema-40to410.sql b253663 Diff: https://reviews.apache.org/r/10030/diff/ Testing --- Testing is done locally by issuing listVmCmd and check NicResponse returned in UserVmResponse. Thanks, Min Chen
Re: Review Request: CLOUDSTACK-1511: Instance NIC details do not have network name.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10030/#review18130 --- Commit 7734650bf9217424fa1bb1d3cedb18ee31437df4 in branch refs/heads/4.1 from Chip Childers chip.child...@gmail.com [ https://git-wip-us.apache.org/repos/asf?p=incubator-cloudstack.git;h=7734650 ] CLOUDSTACK-1511 and CLOUDSTACK-1446 - ASF Subversion and Git Services On March 19, 2013, 10:33 p.m., Min Chen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10030/ --- (Updated March 19, 2013, 10:33 p.m.) Review request for cloudstack and Chip Childers. Description --- This patch fixes the bug https://issues.apache.org/jira/browse/CLOUDSTACK-1511, where instance NIC is missing network name information. This is fixed by fetching network_name from networks table during creating user_vm_view database view. This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-1511. Diffs - server/src/com/cloud/api/query/dao/UserVmJoinDaoImpl.java f561449 server/src/com/cloud/api/query/vo/UserVmJoinVO.java d723822 setup/db/db/schema-40to410.sql b253663 Diff: https://reviews.apache.org/r/10030/diff/ Testing --- Testing is done locally by issuing listVmCmd and check NicResponse returned in UserVmResponse. Thanks, Min Chen
Re: Review Request: CLOUDSTACK-1511: Instance NIC details do not have network name.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10030/#review18131 --- Commit 6bc12fa66d983f295c3f3ab9d300e5e57a52cf4e in branch refs/heads/master from Chip Childers chip.child...@gmail.com [ https://git-wip-us.apache.org/repos/asf?p=incubator-cloudstack.git;h=6bc12fa ] CLOUDSTACK-1511 and CLOUDSTACK-1446 - ASF Subversion and Git Services On March 19, 2013, 10:33 p.m., Min Chen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10030/ --- (Updated March 19, 2013, 10:33 p.m.) Review request for cloudstack and Chip Childers. Description --- This patch fixes the bug https://issues.apache.org/jira/browse/CLOUDSTACK-1511, where instance NIC is missing network name information. This is fixed by fetching network_name from networks table during creating user_vm_view database view. This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-1511. Diffs - server/src/com/cloud/api/query/dao/UserVmJoinDaoImpl.java f561449 server/src/com/cloud/api/query/vo/UserVmJoinVO.java d723822 setup/db/db/schema-40to410.sql b253663 Diff: https://reviews.apache.org/r/10030/diff/ Testing --- Testing is done locally by issuing listVmCmd and check NicResponse returned in UserVmResponse. Thanks, Min Chen