[Cmake-commits] CMake branch, master, updated. v3.13.1-657-g4b513c0

t a/Source/CMakeVersion.cmake b/Source/CMakeVersion.cmake index 2a1cc73..7e2e6c5 100644 --- a/Source/CMakeVersion.cmake +++ b/Source/CMakeVersion.cmake @@ -1,5 +1,5 @@ # CMake version number components. set(CMake_VERSION_MAJOR 3) set(CMake_VERSION_MINOR 13) -set(CMake_VERSION_PATCH 20181209) +set(CMake_VER

[CMake] Correct way to specify multiple build configurations for single config generators?

I have been reading the *excellent* book "Professional CMake". The author, Craig Scott, recommends the following best practices: - check the existence of `CMAKE_CONFIGURATION_TYPES` and only adding or pruning configurations if it's preset, *AFTER* your call to `project()` - do not set

Re: [CMake] [cmake-developers] [MSVC] Setting warning level on target feels like long-time bug

Cmake is already full of do much hardcoded logic / flags and does new releases so frequently (maybe there's some correlation between these two) that adding this would hardly impact upon its quality or maintainability. So to that end, hardcoding the default per msvc version so that it's not added

Re: [cmake-developers] [CMake] [MSVC] Setting warning level on target feels like long-time bug

Cmake is already full of do much hardcoded logic / flags and does new releases so frequently (maybe there's some correlation between these two) that adding this would hardly impact upon its quality or maintainability. So to that end, hardcoding the default per msvc version so that it's not added

Re: [cmake-developers] [CMake] [MSVC] Setting warning level on target feels like long-time bug

On Sun, 9 Dec 2018 at 14:09, Marc CHEVRIER wrote: > > I think the discussion is shifting from the initial problem which was > unwanted warning « Command line warning D9025: overriding '/W3' with '/W4' ». I disagree with your opinion. Fixing just the warning would be a symptomatic treatment. >

Re: [CMake] [MSVC] Setting warning level on target feels like long-time bug

On Sun, 9 Dec 2018 at 14:09, Marc CHEVRIER wrote: > > I think the discussion is shifting from the initial problem which was > unwanted warning « Command line warning D9025: overriding '/W3' with '/W4' ». I disagree with your opinion. Fixing just the warning would be a symptomatic treatment. >

Re: [CMake] [MSVC] Setting warning level on target feels like long-time bug

I think the discussion is shifting from the initial problem which was unwanted warning « Command line warning D9025: overriding '/W3' with '/W4' ». Changing defaults is not a good idea from my point of view because relying on defaults can be problematic if Microsoft decide to change the default

Re: [cmake-developers] [CMake] [MSVC] Setting warning level on target feels like long-time bug

On Sun, 9 Dec 2018 at 12:14, Craig Scott wrote: > > From what I understand from a very limited quick search just now, > it seems that /W3 is the default warning level for Visual Studio Yes, it is the default level indeed. > but CMake explicitly adds it as a default compiler flag in >

Re: [CMake] [MSVC] Setting warning level on target feels like long-time bug

On Sun, 9 Dec 2018 at 12:14, Craig Scott wrote: > > From what I understand from a very limited quick search just now, > it seems that /W3 is the default warning level for Visual Studio Yes, it is the default level indeed. > but CMake explicitly adds it as a default compiler flag in >

Re: [cmake-developers] [CMake] dependencies of cross compiliations

On Tue, Dec 4, 2018 at 6:56 PM Torsten Robitzki wrote: > > Am 27.11.2018 um 19:55 schrieb Eric Noulard : > > > > However from my point of view and my cross-compiling experience when you > cross-compile you have: > > > > 1) the host compiler which is used to compile "host tools" > > 2) the target

Re: [CMake] dependencies of cross compiliations

On Tue, Dec 4, 2018 at 6:56 PM Torsten Robitzki wrote: > > Am 27.11.2018 um 19:55 schrieb Eric Noulard : > > > > However from my point of view and my cross-compiling experience when you > cross-compile you have: > > > > 1) the host compiler which is used to compile "host tools" > > 2) the target

Re: [CMake] [MSVC] Setting warning level on target feels like long-time bug

>From what I understand from a very limited quick search just now, it seems that /W3 is the default warning level for Visual Studio (according to the Microsoft docs ), but CMake explicitly adds it

Re: [cmake-developers] [CMake] [MSVC] Setting warning level on target feels like long-time bug

>From what I understand from a very limited quick search just now, it seems that /W3 is the default warning level for Visual Studio (according to the Microsoft docs ), but CMake explicitly adds it