Re: [cmake-developers] [PATCH] FindProtobuf: fix wrong library list for Unix

2016-02-10 Thread Antonio Pérez Barrero
El mar., 9 feb. 2016 a las 11:13, Rolf Eike Beer (<e...@sf-mail.de>) escribió: > Am 09.02.2016 11:10, schrieb Antonio Pérez Barrero: > >> > >> On 02/08/2016 04:24 PM, Antonio Pérez Barrero wrote: > >> > Yes, it is possible, but currently it's n

Re: [cmake-developers] [PATCH] FindProtobuf: check version

2016-02-09 Thread Antonio Pérez Barrero
> > > + math(EXPR Protobuf_MAJOR_VERSION "${Protobuf_VERSION} / 100") > > + math(EXPR Protobuf_MINOR_VERSION "${Protobuf_VERSION} / 1000 % 1000") > > + math(EXPR Protobuf_SUBMINOR_VERSION "${Protobuf_VERSION} % 1000") > > Would string manipulation be better here? I don't know how to make

Re: [cmake-developers] [PATCH] FindProtobuf: fix wrong library list for Unix

2016-02-09 Thread Antonio Pérez Barrero
> > On 02/08/2016 04:24 PM, Antonio Pérez Barrero wrote: > > Yes, it is possible, but currently it's not looking for the debug > > library with a different name, just in a different path that is > > unlikely to exist in a Unix system. > > The fact that a s

Re: [cmake-developers] [PATCH] FindProtobuf: check version

2016-02-08 Thread Antonio Pérez Barrero
Hi, thanks for feedback, I'll rework the patch. I was planning to actually submit three patches covering the following: * Version checking * Interface variables rename, keeping backwards compatibility. * Fix a bug when setting Protobuf_LIBRARIES on Un*x systems. So what's the best way to submit

Re: [cmake-developers] [PATCH] FindProtobuf: fix wrong library list for Unix

2016-02-08 Thread Antonio Pérez Barrero
El lun., 8 feb. 2016 a las 19:28, Brad King () escribió: > On 02/08/2016 11:47 AM, Antonio Perez Barrero wrote: > > Avoid looking for debug library unless configuring for MSVC. > [snip] > > - find_library(${name}_LIBRARY_DEBUG > > - NAMES ${filename} > > -