Re: [CMake] Canonical use of FindPackageHandleStandardArgs

2010-03-06 Thread Mateusz Loskot
Ryan Pavlik wrote: I took a quick look at your MySQL script and can offer these suggestions: Ryan, Thank you very much for your valuable comments and I'm going to improve my scripts according them. - Be sure to set the plural versions of the variables (INCLUDE_DIRS, LIBRARIES) to include

[CMake] Canonical use of FindPackageHandleStandardArgs

2010-03-03 Thread Mateusz Loskot
Hi, I'm writing some FindXXX.cmake macros [1] and I'd like to master some best practices I use and I'm having troubles with picturing what should canonical use of FindPackageHandleStandardArgs look like. I'm aware I've used it incorrectly in many places. I'm looking for confirmation if it should

Re: [CMake] Canonical use of FindPackageHandleStandardArgs

2010-03-03 Thread Ryan Pavlik
I took a quick look at your MySQL script and can offer these suggestions: - The idiom that follows is outdated and unnecessary (no if-else needed because find_whatever won't run if the variable it's given already has a valid value, and find_package_handle... takes care of the silent bit.):

Re: [CMake] Canonical use of FindPackageHandleStandardArgs

2010-03-03 Thread Ryan Pavlik
snip If you're not doing find scripts that depend on other find scripts, then look in the archives from a month or so ago: I posted some sample find scripts that are modern and clean in style. You can also take a peek at everything except FindDirectShow.cmake (I didn't write that one or