Ok, looking at other "FindXXX.cmake" modules I see that you're right, it
indeed always denotes what should be added to the "COMPILE_FLAGS" target
property, rather than "COMPILE_DEFINITIONS" property. I understand if u
don't want to rename it coz it'll break current usage, but just wanna note,
it's
Hi Yaron,
I think it should b renamed to "LIBXML2_COMPILE_FLAGS".
>
Xxx_DEFINITIONS is one of the standard variable names for a given
FindXxx.cmake find module, see
https://cmake.org/cmake/help/v3.6/manual/cmake-developer.7.html#standard-variable-names
.
> If u wish, I can submit a patch.
>
Hi,
In FindLibXml2.cmake, the name of the variable "LIBXML2_DEFINITIONS" is
confusing coz it describes actually what should be added to the
"COMPILE_FLAGS" property, not "COMPILE_DEFINITIONS". I think it should b
renamed to "LIBXML2_COMPILE_FLAGS". If u wish, I can submit a patch.
Thanx,
Yaron
