Re: [CMake] cmake-2.8.12: generator expression error when linker flags have comma

2013-10-21 Thread Stephen Kelly
Jed Brown wrote: Stephen Kelly steve...@gmail.com writes: Jed Brown wrote: I just upgraded from cmake-2.8.11.2 to 2.8.12 and now get errors when a comma ',' appears in a linker flag. Test case below. Note that this is but one of many reasons for a comma to appear in linker flags. I've

Re: [CMake] cmake-2.8.12: generator expression error when linker flags have comma

2013-10-20 Thread Rolf Eike Beer
Am Samstag, 19. Oktober 2013, 18:01:55 schrieb Jed Brown: I just upgraded from cmake-2.8.11.2 to 2.8.12 and now get errors when a comma ',' appears in a linker flag. Test case below. Note that this is but one of many reasons for a comma to appear in linker flags.

Re: [CMake] cmake-2.8.12: generator expression error when linker flags have comma

2013-10-20 Thread Nick Hutchinson
target_link_libraries() is supposed to work for linker flags as well: cmake version 2.8.12 target_link_libraries Link a target to given libraries. target_link_libraries(target [item1 [item2 [...]]] [[debug|optimized|general] item] ...)

Re: [CMake] cmake-2.8.12: generator expression error when linker flags have comma

2013-10-20 Thread Jed Brown
Nick Hutchinson nshutchin...@gmail.com writes: target_link_libraries() is supposed to work for linker flags as well: cmake version 2.8.12 target_link_libraries Link a target to given libraries. target_link_libraries(target [item1 [item2 [...]]]

Re: [CMake] cmake-2.8.12: generator expression error when linker flags have comma

2013-10-20 Thread Rolf Eike Beer
Am Sonntag, 20. Oktober 2013, 08:48:36 schrieb Jed Brown: Nick Hutchinson nshutchin...@gmail.com writes: target_link_libraries() is supposed to work for linker flags as well: This all works with earlier versions of CMake. Did 2.8.12 intentionally break compatibility and forget to document

Re: [CMake] cmake-2.8.12: generator expression error when linker flags have comma

2013-10-20 Thread Stephen Kelly
Jed Brown wrote: I just upgraded from cmake-2.8.11.2 to 2.8.12 and now get errors when a comma ',' appears in a linker flag. Test case below. Note that this is but one of many reasons for a comma to appear in linker flags. I've pushed a fix candidate:

Re: [CMake] cmake-2.8.12: generator expression error when linker flags have comma

2013-10-20 Thread David Cole
I just upgraded from cmake-2.8.11.2 to 2.8.12 and now get errors when a comma ',' appears in a linker flag. Test case below. Note that this is but one of many reasons for a comma to appear in linker flags. ... Remember that the way to avoid bugs like this in the release is to test a

Re: [CMake] cmake-2.8.12: generator expression error when linker flags have comma

2013-10-20 Thread Jed Brown
Stephen Kelly steve...@gmail.com writes: Jed Brown wrote: I just upgraded from cmake-2.8.11.2 to 2.8.12 and now get errors when a comma ',' appears in a linker flag. Test case below. Note that this is but one of many reasons for a comma to appear in linker flags. I've pushed a fix

Re: [CMake] cmake-2.8.12: generator expression error when linker flags have comma

2013-10-20 Thread Jed Brown
David, your reply failed to set In-Reply-To or References headers, and is thus not threaded with the conversation it purports to reply to, meaning that it skipped my inbox. If this was not intentional, you may want to check your mail client settings. David Cole dlrd...@aol.com writes: One

[CMake] cmake-2.8.12: generator expression error when linker flags have comma

2013-10-19 Thread Jed Brown
I just upgraded from cmake-2.8.11.2 to 2.8.12 and now get errors when a comma ',' appears in a linker flag. Test case below. Note that this is but one of many reasons for a comma to appear in linker flags. https://gist.github.com/jedbrown/7062540 $ mkdir build cd build $ cmake