Re: [cmake-developers] ncurses sub-dir and include path

Hi Brad, thanks for keeping answering my emails! >> I always end up with /usr/include/ being the CURSES_INCLUDE_PATH. > > Why is that wrong? As you said it has both `ncurses.h` and `curses.h`. > Even though they are symlinks one can still use them to compile. CMake includes form.h, not

Re: [cmake-developers] ncurses sub-dir and include path

Hi Brad, thank you for pointing out the conditions. But they cannot be used to ignore the symolic link in /usr/include/ to favor the acutal header in /usr/include/ncurses/. I always end up with /usr/include/ being the CURSES_INCLUDE_PATH. > On 7/28/19 4:21 PM, Christoph Grüninger wr

[cmake-developers] ncurses sub-dir and include path

Dear CMake developers, for several years openSuse's CMake package has a patch which adds the sub-directory ncurses to the CURSES_INCLUDE_PATH: diff --git a/Source/CursesDialog/CMakeLists.txt b/Source/CursesDialog/CMakeLists.txt index 7d4e88c..0cc5357 100644 ---

Re: [CMake] PIE-pie_off and CMP0083-cmp0083_new fail for openSuse Leap 15.0

Hi Marc, thank you for having a look. openSuse confirmed it is a bug, cf. https://bugzilla.suse.com/show_bug.cgi?id=1096008 Sorry for the noise. Good to know, that packaging CMake reveal bugs. Bye Christoph Am 20.03.19 um 12:27 schrieb Marc CHEVRIER: > clearly, from what shown on

Re: [CMake] PIE-pie_off and CMP0083-cmp0083_new fail for openSuse Leap 15.0

Hi Alan, thanks for you answer. Do you know how the open build service works? It sets up a fresh installation for each (openSuse) platform. Then CMake's sources are deflated, configure is called and the package is build, installed, tested and then packaged. So no other CMake version is involved

[CMake] PIE-pie_off and CMP0083-cmp0083_new fail for openSuse Leap 15.0

Dear CMake, while trying to update the RPMs for openSuse with the Open Build service, I stumbled upon a strange problem. Following the same spec file for all target plattforms, CMake is first built and then the tests are executed. The tests pass for different types of openSuse versions (Factory,

Re: [cmake-developers] Patch: Don't emit warning when config file not found

Hi Brad, great idea! Your suggestion will make everybody happy. I attached two patches implementing it. Bye ChristophFrom 0df376954173184ca78becf3ab1888e6f718af8f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Christoph=20Gr=C3=BCninger?= Date: Fri, 28 Apr 2017 08:19:20 +0200

Re: [cmake-developers] Patch: Don't emit warning when config file not found

Hi Brad, thanks for helping me out with the patch. Your wording of the message is better than my proposal. Please find attached an improved patch. Bye Christoph -- [..] Mathematicians are like theologians: we regard existence as the prime attribute of what we study. But unlike theologians, we

Re: [cmake-developers] Patch: Don't emit warning when config file not found

um 14:51 schrieb Brad King: > On 10/09/2016 03:24 PM, Christoph Grüninger wrote: >> * or loosing the output of tests and feature summary, as both tests are >> QUIET. >> >> I'd prefer to write the error message to the CMakeError.log and reduce >> the output to one li

Re: [CMake] Compiling CMake without libuv?

Hi Brad, thanks for the answer, I wasn't aware that I can pass CMake options to the bootstrap script. > There is also the CMAKE_USE_LIBUV option that can be set to OFF. > One can pass it to the bootstrap script via > > ../cmake/bootstrap ... -- -DCMAKE_USE_LIBUV=OFF > Works, that will ensure

[CMake] Compiling CMake without libuv?

Dear CMake folks, I am trying to package CMake for openSuse. I was a bit surprised that the new dependency libuv was nowhere mentioned. Can it be disabled by a configure switch for older systems? Currently it errors out when libuv is not found. It should be only necessary for cmake-server, right?

Re: [CMake] CMake 3.7: Test #379: RunCMake.CPack_RPM fails

Hi Domen, thanks for your answer. > > CMake 3.7 compiles so far, but test #379 (RunCMake.CPack_RPM) fails, see > > the error below from OBS. I had a brief look at our patches and I am apt > > to think they are unrelated. > > Can someone have a look and give some hint? > > > I'll test it today

[CMake] CMake 3.7: Test #379: RunCMake.CPack_RPM fails

Dear CMake folks, I am trying to package CMake for openSuse. I was a bit surprised that the new dependency libuv was nowhere mentioned. Can it be disabled by a configure switch for older systems? CMake 3.7 compiles so far, but test #379 (RunCMake.CPack_RPM) fails, see the error below from OBS. I

Re: [cmake-developers] Patch: Don't emit warning when config file not found

Hi Brad, thanks again for your answer, but the core of the problem persists. >> 1. When I use "find_package(Vc)", many users get warnings that neither >> FindVc.cmake nor VcConfig.cmake is found. > > You can use > find_package(Vc CONFIG) > to drop the FindVc part of the message. Sure, that

Re: [cmake-developers] Patch: Don't emit warning when config file not found

he feature summary. How can I achieve both without patching CMake? Bye Christoph Am 10.08.2016 um 15:17 schrieb Brad King: > On 08/09/2016 04:35 PM, Christoph Grüninger wrote: >> I am annoyed by the lengthy and disturbing warning CMake emits when a >> package is not found be

Re: [cmake-developers] Don't enclose CMake version to generated files

Hi Brad, hi Ben, > I've applied the "export" parts of the patch: > > Do not place CMake version in export files > https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=c376c5bc Hu, that was fast. Thank you. I wanted to discuss whether openSuse or CMake should change. I'll apply the patch to our

Re: [cmake-developers] Don't enclose CMake version to generated files

Hi Ben, this comes from the open build system, which is the system used by openSuse to generate the packages. If the CMake version is updated, which happens quite often, the generated files are altered and the packages are rebuild, repackaged and republished. Without the version number in the

[cmake-developers] Don't enclose CMake version to generated files

Dear CMake develoers, I just updated openSuse's CMake package. We have a patch, that removes the CMake version from generated files. This is aiming to reduce the re-publishing of generated files. Please find the current patch attached. What do you think, can we get this somehow upstreamed? Or are

[cmake-developers] [Patch] Improve documentation of FindMPI

Dear CMake developers, please find attached patch to improve the formatting of the FindMPI documentation. Bye Christoph -- My new computer came with Windows 7. Windows 7 is much more user-friendly than Windows Vista. I don't like that. [Sheldon, S03E13] >From

[cmake-developers] Use unsigned int for cmLinkInterface:: and cmGeneratorTarget::Multiplicity

Dear Brad, thanks for your advice. An accoring patch is attached. > There is no reason to have negative values for that, so please update > both cmLinkInterface::Multiplicity and cmGeneratorTarget::Multiplicity > to use `unsigned int` and follow through with any further changes > needed for that

[cmake-developers] Patch: Remove superfluous semicolon after method

Dear CMake devs, please find attached a minimal patch to fix a GCC 6 pedantic warning concerning a superfluous semicolon after a method. Additional I got the following warning: > CMake/Source/cmGeneratorTarget.cxx:4835:52: warning: format ‘%u’ expects > argument of type ‘unsigned int*’, but

[cmake-developers] Improve FindGit.cmake

Dear CMake devs, please find attached a patch to slightly improve FindGit.cmake. I did test it, but did not understand why GIT_FOUND was set in the first place. Bye Christoph >From c29c384565b7d976e36156f9351af8400cd60dc4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Christoph=20Gr=C3=BCninger?=

[cmake-developers] [PATCH] FindGLEW: Add hinting variable GLEW_ROOT

Dear CMake developers, please find attached a small patch that introduces the hinting variable GLEW_ROOT to FindGLEW.cmake. Best Christoph From c6caa68391010f9fb399d86b1e6ec154d4be3605 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Christoph=20Gr=C3=BCninger?= Date: Sun, 22 Nov

[CMake] Tests 115, 116, 117 and, 118 fail

Dear CMake, I am trying to create a CMake 3.3.0 RPM for openSuse using their Open Build Service. It compiles but the tests 115, 116, 117 and, 118 fail. The RPM build causes the error but I don't get what I should change. I attached the output. Bye Christoph -- I'm OK. The world's all wrong.

[CMake] Check whether C++ headers are self-sufficient

Dear CMakers, I want to have all my C++ headers self-sufficient (self-contained), i.e., a header can be included without additional includes. This is not only handy but also part of Google's C++ styleguide [2]. It would be great to have a make target (let's call it headercheck), that can check

Re: [cmake-developers] Fortran detection, issue 9220

Hi! I second Alan's view. The test should warn when it fails but still keep running. This includes Ninja, which would warn but still run through. I would like to get a variable language_WORKS for every enable_language(language OPTIONAL). Then I could disable features that depends on that

[cmake-developers] Fortran detection, issue 9220

Hi CMake developers, would you mind to tackle issue 9220 enable_language( OPTIONAL) signature does not work correctly? It's a shame that CMake cannot properly detect optional Fortran for more than 5 years! The workaround from Eigen works fine for me, but it's still embarrassing. BTW, is

[cmake-developers] Clarify status of link_libraries

Hi CMake developers, we wanted to use the link_libraries command and we were scared off by its deprecation. Fortunately someone found Brad's statement [1] about the deprecated. The use of deprecated is pretty bad as this usually indicates that a feature will be removed in future versions. I

[cmake-developers] FeatureSummary: Fix wrong bracket

Hi CMake developers, please find attached a small patch to change a ] to a ). Bye Christoph -- When you die, that does not mean that you lose to cancer, you beat cancer by how you live, why you live, and in the manner in which you live. -- Stuart Scott, 1965-2015 From

Re: [cmake-developers] Which binaries should be required in FindLATEX?

Hi Brad, concerning FindLATEX again: Applied: FindLATEX: Add components handling http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=07a3f9ad The link does not work and I couldn't find the commit in next. Can you double check whether you pushed it? with minor documentation tweaks and one

Re: [cmake-developers] Which binaries should be required in FindLATEX?

Hi Brad, next try and as always better than the last attempt. Bye Christoph From ba775bd58b70ad2581fc05f30d8c5e42e1c94096 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Christoph=20Gr=C3=BCninger?= gruen...@dune-project.org Date: Tue, 23 Dec 2014 11:33:32 +0100 Subject: [PATCH] FindLATEX: Add

[cmake-developers] [Patch] Get rid of C++ warnings

Dear CMake developers, find attached two small patches that get rid of C++ warnings I get from the current GCC 5 development build. One patch removes semicolons after methods, the other uses unsigned ints for version numbers to match the type of the sscanf string %u. Bye Christoph From

Re: [cmake-developers] Which binaries should be required in FindLATEX?

Hi Brad, please find attached a new patch following your latest suggestions. Once you have that explicit mapping then you can optionally use lower-case component names. I have no strong preference on that though. I'd like to have lower case components but I dislike mixed-cased variable

Re: [cmake-developers] Which binaries should be required in FindLATEX?

Hi Brad, please find attached a patch that introduces components handling for optional LaTeX executable. FPHSA's components handling feature is pretty cool. I first wrote the components handling myself, but the built-in version is more elegant. I am the first one to use this feature in an official

[CMake] CTest errors out when skipping a test

Hi CMake, I am testing the SKIP_RETURN_CODE property for tests. Unfortunately ctest error out when it found skipped tests. I expect ctest to not fail, because skipped tests should be indicated, but are to some extend expected and should still leave ctest passing. Is this a bug? Or do I

Re: [cmake-developers] [RFC] ctest: do not output failed when no tests failed

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi Brad, Maybe I'm just used to it but IMO it is more consistent to have a field for the number of failures whether it is 0 or not. I'd be interested in feedback from others on this. The change is: -100% tests passed, 0 tests failed out of

Re: [cmake-developers] Clang 3.5-svn emmits tautological-pointer-compare warning

Hi Ben, thanks for your investigations. Should I ask on the LLVM mailing list whether they can answer the open questions? Or does anyone on this mailing list have any related knowledge? Bye Christoph Hmm. I don't see anything in the docs which states that uname must always have non-NULL in

[cmake-developers] Clang 3.5-svn emmits tautological-pointer-compare warning

Hi CMake developers, I like CMake for not generating a ton of warnings. I just tried with a recent SVN version of Clang 3.5 which learned again new warnings: [ 6%] Building CXX object Source/kwsys/CMakeFiles/cmsys.dir/SystemInformation.cxx.o

Re: [CMake] Warning when find_package does not find package

Hi CMake developers, I further investigated my problem that I get a warning message from find_package which could not find the config file of an optional package, even when called with NO_MODULE. In cmFindPackageCommand.cxx, lines 811 - 822 the error messages are printed out as AUTHOR_WARNINGs

[CMake] Warning when find_package does not find package

Hi CMake fellows, I have two pieces of software. Software A is an optional dependency of B. Following the way CMake intends, A provides a a-config.cmake. B does not have a FindB.cmake because A provides the config file [1]. B has a UseB.cmake which calls find_package(A). This works well in the

[cmake-developers] Review request: FindPkgConfig stop when required package not found

Hi CMake Developers, find attached a proposal to fix #14381. It makes FindPkgConfig stop processing when a REQUIRED package is not found. Best, Christoph -- Nous vivons une époque où les pizzas arrivent plus vite que la police. [Claude Chabrol, French director] From

[cmake-developers] FindPkgConfig_Extend-PKG_CONFIG_PATH

Hi Daniele, hi Brad, thanks for you recent work on FindPkgConfig. I just wanted to investigation the feature myself and found out you already did all the work. Maybe you missed it, your patch fixes backlogged #12926. Great! I'd like to add additional paths for pkg_check_modules similar to

Re: [cmake-developers] Review request: use PKG_CONFIG

2014 um 14:35 geschrieben: On 02/24/2014 06:14 PM, Christoph Grüninger wrote: overhauled version at https://github.com/gruenich/CMake/commit/75f5f2a8df590c560455ce8310f3d9fe76af01b1 Thanks.  Can you explain the purpose of the hunk adding PKG_CONFIG_VERSION_STRING: - REQUIRED_VARS

Re: [cmake-developers] Review request: use PKG_CONFIG

Hi Brad, thanks for your patience. In the past I misused REQUIRED_VARS several times... Find my most recent attempt: https://github.com/gruenich/CMake/commit/9c0ced4b46599c08e0d3c4c5cb913e52562ea1d2 Bye Christoph -- You have to fall in love with the process of becoming great. [Blake Griffin

Re: [cmake-developers] Review request: use PKG_CONFIG

Am 24.02.2014 16:58, schrieb Brad King: On 02/23/2014 05:30 PM, Christoph Grüninger wrote: would you mind to review a patch? I try to fix issue 13175 http://public.kitware.com/Bug/view.php?id=13175 and use, if set, PKG_CONFIG as the pkg-config executable. Thanks for working on this. You

Re: [cmake-developers] Review request: use PKG_CONFIG

Hi Brat, thank you for your kind review. Considering your comments, I pushed a overhauled version at https://github.com/gruenich/CMake/commit/75f5f2a8df590c560455ce8310f3d9fe76af01b1 Best, Christoph P.S.: Sorry for my last mail, I accidentally hit enter. -- Powered by www.kitware.com Visit

[cmake-developers] Review request: use PKG_CONFIG

Dear CMake developers, would you mind to review a patch? I try to fix issue 13175 http://public.kitware.com/Bug/view.php?id=13175 and use, if set, PKG_CONFIG as the pkg-config executable. You can find my patch at GitHub: https://github.com/gruenich/CMake/compare/use-pkg_config I am not sure

[CMake] How to share CMakeCache between projects?

Hi CMake, in our code we have different related CMake projects but CMake does not really know about dependencies between the projects. It would be handy to have only one CMakeCache.txt for all projects to reduce multiple execution of the Find*.cmake tests. Is there a possibility to define the

Re: [CMake] Skip(ped) test with CTest?

Hi David, thanks for your idea with REQUIRED_FILES. I don't like the way, but we'll evaluate if it is enough for our project. Maybe a proper solution will be included in a future release of CMake. Bye Christoph There is a test property called REQUIRED_FILES, which is a list of files that

[CMake] Skip(ped) test with CTest?

Hi CMake, can I skip a test with CTest? Currently I do not add a test which is dependent on a not found feature, like: if(feature_found) add_test(..) endif(feature_found) If all tests pass, I still don't know whether everything is fine, because the not added tests are not shown. Has

Re: [CMake] Skip(ped) test with CTest?

Hi David, thanks for your answer and the bug tracker link. I don't have any new arguments besides that the arguments and use cases stated in the bug tracker apply to our use case, too. I see it like a poor man's code coverage. Once I forgot to enable MPI support in autotools and it reported