Re: [CMake] [cmake] [RFC] rewriting FindMKL

2018-01-23 Thread Sik
I made a PR based on your comment, is this what you were referring to? https://github.com/openmeeg/findmkl_cmake/pull/8 On Tue, Jan 23, 2018 at 11:25 AM Luis Caro Campos wrote: > As a comment, would it be possible to include imported targets that > encapsulate include

Re: [CMake] [cmake] [RFC] rewriting FindMKL

2018-01-23 Thread Luis Caro Campos
As a comment, would it be possible to include imported targets that encapsulate include dirs, linker arguments and compile definitions? I would say the CMake community is trying to move away from the old-style find packages that define variables instead of targets. Regards, Luis On Mon, Jan 22,

Re: [CMake] [cmake] [RFC] rewriting FindMKL

2018-01-23 Thread Kai Wolf
I've fixed some (mentioned) issues already and opened up a PR on GitHub. You might want to check that out, otherwise I'll just delete my PR. 2018-01-22 22:20 GMT+01:00 Alexander Neundorf : > On 2018 M01 22, Mon 15:16:50 CET Sik wrote: >> Hello CMake users and devs, >> >> In

Re: [CMake] [cmake] [RFC] rewriting FindMKL

2018-01-22 Thread Alexander Neundorf
On 2018 M01 22, Mon 15:16:50 CET Sik wrote: > Hello CMake users and devs, > > In openmeeg we are reviewing our MKL package finder to make it more > maintainable for ourselves and others who had adopted our solution. > Therefore I'm writing you requesting comments and feedback so that is > useful

[CMake] [cmake] [RFC] rewriting FindMKL

2018-01-22 Thread Sik
Hello CMake users and devs, In openmeeg we are reviewing our MKL package finder to make it more maintainable for ourselves and others who had adopted our solution. Therefore I'm writing you requesting comments and feedback so that is useful for everyone. Here is the project we have set up in