Re: [cmake-developers] [New Module] FindOpenCL, FindHg

2014-02-23 Thread Matthäus G. Chajdas
Hi, So, I'm very sorry to come up with those things now and not having catched them earlier. If you now do no problem, I should have also checked what I was adding with git :/ I think I fixed everything now in my latest commit. At least `git diff origin/master Modules/FindHg.cmake` looks

Re: [cmake-developers] [New Module] FindOpenCL, FindHg

2014-02-23 Thread Rolf Eike Beer
Am Sonntag, 23. Februar 2014, 09:13:18 schrieb Matthäus G. Chajdas: Hi, So, I'm very sorry to come up with those things now and not having catched them earlier. If you now do no problem, I should have also checked what I was adding with git :/ I think I fixed everything now in my

Re: [cmake-developers] [PATCH] fix version handling in find_dependency macro

2014-02-23 Thread Stephen Kelly
Alex Merry wrote: The handling of the optional version argument in the find_dependency() macro is just wrong. It is only set if ${ARGV1} (rather than ARGV1) evaluates to true, and otherwise it remains unchanged from whatever its previous value was (instead of being cleared). Either of the

Re: [cmake-developers] New EVIS parser moving forward (3.1)

2014-02-23 Thread Stephen Kelly
Brad King wrote: On 02/21/2014 02:18 PM, Jean-Christophe Fillion-Robin wrote: If possible, not having implicit expansion for quoted argument would be great at make things more intuitive and practical. This has been discussed before. It will take some refactoring of the CMake language

Re: [cmake-developers] New EVIS parser moving forward (3.1)

2014-02-23 Thread Alexander Neundorf
On Friday, February 21, 2014 14:32:18 Brad King wrote: On 02/21/2014 02:18 PM, Jean-Christophe Fillion-Robin wrote: If possible, not having implicit expansion for quoted argument would be great at make things more intuitive and practical. This has been discussed before. It will take some

[cmake-developers] Review request: use PKG_CONFIG

2014-02-23 Thread Christoph Grüninger
Dear CMake developers, would you mind to review a patch? I try to fix issue 13175 http://public.kitware.com/Bug/view.php?id=13175 and use, if set, PKG_CONFIG as the pkg-config executable. You can find my patch at GitHub: https://github.com/gruenich/CMake/compare/use-pkg_config I am not sure