[cmake-developers] Patch: Add the ability to specify SDK_REFERENCES for Visual Studio

2016-06-17 Thread Gilles Khouzam via cmake-developers
This patch is to add the ability with Visual Studio generators to add references to SDKs. This is similar to the DESKTOP, IOT and MOBILE extensions for Windows 10, but makes the process more generic, using the Property VS_SDK_REFERENCES as a semi-colon separated list. For example, adding a

[cmake-developers] Patch: Add ability to override the default Visual Studio tool

2016-06-17 Thread Gilles Khouzam via cmake-developers
This patch is to add the ability to override the default tool assigned by the Visual Studio generator based on the extension, by using a new source property VS_TOOL_OVERRIDE. This also allows for new tools to be defined without having to teach CMake how to handle them. For example, this allows

Re: [cmake-developers] daemon-mode: Infrastructure

2016-06-17 Thread Brad King
On 06/13/2016 08:00 PM, Tobias Hunger wrote: > * There will always be 1 client talking to a server. > * Client/Server communicate using JSON messages Yes. IIRC it is using stdin/stdout (I haven't checked the code), so limiting to one client is implicit. In this case, is it actually a daemon?

Re: [cmake-developers] CMake daemon-mode

2016-06-17 Thread Brad King
On 06/10/2016 12:31 PM, Tobias Hunger wrote: > I did try to do the changes you requested. The branch is here: > https://github.com/hunger/CMake/commits/compileflags Thanks. I did some refactoring to help address the path conversion problem: Refactor Makefile/Ninja tool working directory

Re: [cmake-developers] [PATCH] Allow LIB_SUFFIX be used as find path

2016-06-17 Thread Brad King
On 06/17/2016 01:33 PM, Christian Schmidbauer wrote: >> CMake sets the lib32/lib64 ones in its own >> platform modules for the relevant platforms so user code never >> needs to do it. Where in user code would it be done? > > In my setup, I would create a custom my-config.cmake file And that is

Re: [cmake-developers] [PATCH] Allow LIB_SUFFIX be used as find path

2016-06-17 Thread Christian Schmidbauer
On Fri, Jun 17, 2016 at 7:13 PM, Brad King wrote: > On 06/17/2016 12:53 PM, Christian Schmidbauer wrote: >>> Please also add the FIND_LIBRARY_USE_CUSTOM_SUFFIX item documentation, >>> or whatever it becomes after the discussion below. >>> >> Where do you want me to document

Re: [cmake-developers] FindFreetype patch for Windows debug lib naming

2016-06-17 Thread Stuart Mentzer
On 6/17/2016 1:12 PM, Brad King wrote: On 06/17/2016 01:02 PM, Stuart Mentzer wrote: Thanks but a line was lost in translation at the bottom: mark_as_advanced( *FREETYPE_LIBRARY* FREETYPE_INCLUDE_DIR_freetype2 FREETYPE_INCLUDE_DIR_ft2build ) SLC handles mark_as_advanced for the

Re: [cmake-developers] [PATCH] Allow LIB_SUFFIX be used as find path

2016-06-17 Thread Brad King
On 06/17/2016 12:53 PM, Christian Schmidbauer wrote: >> Please also add the FIND_LIBRARY_USE_CUSTOM_SUFFIX item documentation, >> or whatever it becomes after the discussion below. >> > Where do you want me to document it? In the same places that FIND_LIBRARY_USE_LIB32_PATHS documentation was

Re: [cmake-developers] FindFreetype patch for Windows debug lib naming

2016-06-17 Thread Brad King
On 06/17/2016 01:02 PM, Stuart Mentzer wrote: > Thanks but a line was lost in translation at the bottom: > > mark_as_advanced( > *FREETYPE_LIBRARY* > FREETYPE_INCLUDE_DIR_freetype2 > FREETYPE_INCLUDE_DIR_ft2build > ) > > SLC handles mark_as_advanced for the _DEBUG and _RELEASE variables >

Re: [cmake-developers] FindFreetype patch for Windows debug lib naming

2016-06-17 Thread Rolf Eike Beer
Am Freitag, 17. Juni 2016, 13:02:30 schrieb Stuart Mentzer: > On 6/17/2016 11:54 AM, Brad King wrote: > On 06/12/2016 01:52 PM, Stuart Mentzer wrote: > Looking at FindZlib.cmake I think the attached should be OK > Thanks. I've applied that as a patch here: > > FindFreetype: Find release and

Re: [cmake-developers] FindFreetype patch for Windows debug lib naming

2016-06-17 Thread Stuart Mentzer
On 6/17/2016 11:54 AM, Brad King wrote: On 06/12/2016 01:52 PM, Stuart Mentzer wrote: Looking at FindZlib.cmake I think the attached should be OK Thanks. I've applied that as a patch here: FindFreetype: Find release and debug libraries

Re: [cmake-developers] [PATCH] Allow LIB_SUFFIX be used as find path

2016-06-17 Thread Christian Schmidbauer
On Mon, Jun 13, 2016 at 5:22 PM, Brad King wrote: > Hi Christian, > > Thanks for working on this. > > On 06/12/2016 05:59 AM, Christian Schmidbauer wrote: >> A similar idea has already been suggested in #10287 > > Yes. > >> and is required for bug #15594. > > That issue

Re: [cmake-developers] FindFreetype patch for Windows debug lib naming

2016-06-17 Thread Brad King
On 06/12/2016 01:52 PM, Stuart Mentzer wrote: > Looking at FindZlib.cmake I think the attached should be OK Thanks. I've applied that as a patch here: FindFreetype: Find release and debug libraries separately https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=b213a7f6 -Brad -- Powered by

Re: [cmake-developers] codeblocks generator: Fix include directories being in unexpected order

2016-06-17 Thread Brad King
On 06/17/2016 03:31 AM, Tobias Hunger wrote: > Could this please go into 3.6? > > This is the root cause of quite a few bug reports hitting Qt Creator bug > tracker > right now, so I would love to see a fix out in the wild ASAP. Normally I don't make non-regression/doc fixes after the first RC

Re: [cmake-developers] FindPkgConfig and IMPORTED_TARGET in 3.6.0

2016-06-17 Thread Ben Boeckel
On Fri, Jun 17, 2016 at 15:40:45 +0200, Nils Gladitz wrote: > I have not been involved in that development. > From what I can tell this is Eike's work. Ack, sorry. Should have double checked. --Ben -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at:

Re: [cmake-developers] FindPkgConfig and IMPORTED_TARGET in 3.6.0

2016-06-17 Thread Brad King
On 06/17/2016 09:40 AM, Nils Gladitz wrote: > On 06/17/2016 03:36 PM, Ben Boeckel wrote: >> Nils, the IMPORTED_TARGET feature in pkg_check_modules is nice! Thanks >> for that. However, it is hidden behind the check that pkg_check_modules >> uses to see if it already ran: > > From what I can tell

Re: [cmake-developers] FindPkgConfig and IMPORTED_TARGET in 3.6.0

2016-06-17 Thread Rolf Eike Beer
Am 2016-06-17 15:36, schrieb Ben Boeckel: Hi, Nils, the IMPORTED_TARGET feature in pkg_check_modules is nice! Thanks for that. However, it is hidden behind the check that pkg_check_modules uses to see if it already ran: if (NOT DEFINED __pkg_config_checked_${_prefix} OR

Re: [cmake-developers] FindPkgConfig and IMPORTED_TARGET in 3.6.0

2016-06-17 Thread Nils Gladitz
On 06/17/2016 03:36 PM, Ben Boeckel wrote: Nils, the IMPORTED_TARGET feature in pkg_check_modules is nice! Thanks for that. However, it is hidden behind the check that pkg_check_modules uses to see if it already ran: I have not been involved in that development. From what I can tell this is

[cmake-developers] FindPkgConfig and IMPORTED_TARGET in 3.6.0

2016-06-17 Thread Ben Boeckel
Hi, Nils, the IMPORTED_TARGET feature in pkg_check_modules is nice! Thanks for that. However, it is hidden behind the check that pkg_check_modules uses to see if it already ran: if (NOT DEFINED __pkg_config_checked_${_prefix} OR __pkg_config_checked_${_prefix} LESS

Re: [cmake-developers] Toward a more deterministic ninja generator

2016-06-17 Thread Nicolas Desprès
On Thu, Jun 16, 2016 at 7:14 PM, Brad King wrote: > On 06/14/2016 11:18 AM, Nicolas Desprès wrote: > > It makes the ninja generator more deterministic by sorting the > > build edge's inputs/outputs. It does not introduce any > > regression on my macbookpro. > > > > This

Re: [cmake-developers] codeblocks generator: Fix include directories being in unexpected order

2016-06-17 Thread Tobias Hunger
On Do, 2016-06-16 at 13:14 -0400, Brad King wrote: > On 06/14/2016 11:52 AM, Tobias Hunger wrote: > > https://github.com/hunger/CMake/commit/f190b069db2e430fd94b25e6287cd7fbc2866 > > 1e3 > > > > Is the same thing updated based on suggestions from Stephen. > > Thanks, applied: > >