Please test that version because I made some minor tweaks.
I read all commits you made on the upstream and tested each of them
with attention. There's nothing you broke by what you wrote you
'rebased'. Again, thank you for your sincere review on my patches.
Cheers.
Eon Jeong
--
Eon
On 06/08/2015 11:09 PM, 정언 wrote:
New patches for FindBISON changes.
Thanks. I revised the original module's documentation formatting
and then rebased your changes on that. Applied here:
FindBISON: Improve documentation formatting
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=801b799f
On 06/03/2015 06:26 AM, 정언 wrote:
Thanks! Please re-order the patches to do the refactoring
of argument parsing first and the functional changes second.
Can you explain what you mean by 'reordering patches'? Does it mean I
should write one more patch for that, or I should merge my patches
On 05/31/2015 01:37 AM, 정언 wrote:
I made a slight change on FindBISON module, adding a new
feature DEFINES_FILE that corresponds to bison command line
option `--defines`.
Thanks! Please re-order the patches to do the refactoring
of argument parsing first and the functional changes second.
Hi,
I made a slight change on FindBISON module, adding a new feature
DEFINES_FILE that corresponds to bison command line option `--defines`. It
is added because FindBISON always internally recognizes header file name as
the one automatically generated by `-d` option, so passing `--defines`
