Re: [cmake-developers] [PATCH] FindPythonLibs patches for version searching and frameworks

On Thu, Sep 17, 2015 at 9:32 AM, Brad King wrote: > On 09/17/2015 10:43 AM, David Gobbi wrote: > > It finds the install prefix for PYTHON_EXECUTABLE > > and uses it as a hint for the library location > > Thanks. I revised the previous patch slightly to add a prefix to >

Re: [cmake-developers] [PATCH] FindPythonLibs patches for version searching and frameworks

On 09/17/2015 11:38 AM, David Gobbi wrote: > The _PREFIX temporary variable is still lying around, though. Please provide a follow-up patch I can squash in for that. Thanks, -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at:

Re: [cmake-developers] [PATCH] FindPythonLibs patches for version searching and frameworks

On Thu, Sep 17, 2015 at 9:46 AM, David Gobbi wrote: > On Thu, Sep 17, 2015 at 9:08 AM, Clinton Stimpson > wrote: > >> >> Is that related to issues you are addressing here? >> > > No, the prefix check was meant to fix things for people who use

Re: [cmake-developers] [PATCH] FindPythonLibs patches for version searching and frameworks

On Thu, Sep 17, 2015 at 9:48 AM, Brad King wrote: > > > Please provide a follow-up patch I can squash in for that. > I've renamed the variable _PREFIX -> _Python_PREFIX and now the code unsets it once it's finished with it. - David

Re: [cmake-developers] [PATCH] FindPythonLibs patches for version searching and frameworks

On 09/17/2015 12:03 PM, David Gobbi wrote: > I've renamed the variable _PREFIX -> _Python_PREFIX and now the code > unsets it once it's finished with it. Thanks: FindPythonLibs: unset temporary _PREFIX variable http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=19934b67 -Brad -- Powered by

Re: [cmake-developers] [PATCH] FindPythonLibs patches for version searching and frameworks

On 09/17/2015 10:43 AM, David Gobbi wrote: > It finds the install prefix for PYTHON_EXECUTABLE > and uses it as a hint for the library location Thanks. I revised the previous patch slightly to add a prefix to the _HINT temporary variable and unset it when finished: FindPythonLibs: Match

Re: [cmake-developers] [PATCH] FindPythonLibs patches for version searching and frameworks

On Wednesday, September 16, 2015 11:04:23 PM David Gobbi wrote: > On Wed, Sep 16, 2015 at 9:41 AM, Brad King wrote: > > On 09/16/2015 11:39 AM, Brad King wrote: > > > On 09/16/2015 10:00 AM, David Gobbi wrote: > > >> this new patch only changes the search for the include

Re: [cmake-developers] [PATCH] FindPythonLibs patches for version searching and frameworks

On Thu, Sep 17, 2015 at 9:08 AM, Clinton Stimpson wrote: > > Hi, > > I did a quick test to see if my issue has been resolved. > > I have a CMakeLists.txt file with just: > FIND_PACKAGE(PythonInterp REQUIRED) > FIND_PACKAGE(PythonLibs ${PYTHON_VERSION_STRING} REQUIRED) > > >

Re: [cmake-developers] [PATCH] FindPythonLibs patches for version searching and frameworks

On Thu, Sep 17, 2015 at 7:44 AM, Brad King wrote: > > Thanks, applied: > > FindPythonLibs: Match include dir to library version > http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=89717916 This should be the last one. It finds the install prefix for PYTHON_EXECUTABLE

Re: [cmake-developers] [PATCH] FindPythonLibs patches for version searching and frameworks

On 09/17/2015 01:04 AM, David Gobbi wrote: > I've modified my patch Thanks, applied: FindPythonLibs: Match include dir to library version http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=89717916 -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ

Re: [cmake-developers] [PATCH] FindPythonLibs patches for version searching and frameworks

On Thu, Sep 17, 2015 at 10:59 AM, Clinton Stimpson wrote: > > However, it does bother me that it found includes from the SDK and a > library > under /usr/lib. > > For example, if I use the 10.6 SDK on OS X 10.7, it appears that it would > find > /usr/lib/libpython.2.7.dylib

Re: [cmake-developers] [PATCH] FindPythonLibs patches for version searching and frameworks

On Thu, Sep 17, 2015 at 11:45 AM, David Gobbi wrote: > On Thu, Sep 17, 2015 at 11:25 AM, David Gobbi > wrote: > >> On Thu, Sep 17, 2015 at 10:59 AM, Clinton Stimpson >> wrote: >> >>> >>> However, it does bother me that it

Re: [cmake-developers] [PATCH] FindPythonLibs patches for version searching and frameworks

On 09/17/2015 12:42 PM, David Gobbi wrote: > Okay, Clinton. Now you've made me paranoid that I should be prepending > the value of CMAKE_OSX_SYSROOT before the prefix if it isn't already > part of the prefix. I don't want to ignore CMAKE_OSX_SYSROOT if it has > been set, but unfortunately I

Re: [cmake-developers] [PATCH] FindPythonLibs patches for version searching and frameworks

On Thursday, September 17, 2015 12:54:26 PM Brad King wrote: > On 09/17/2015 12:42 PM, David Gobbi wrote: > > Okay, Clinton. Now you've made me paranoid that I should be prepending > > the value of CMAKE_OSX_SYSROOT before the prefix if it isn't already > > part of the prefix. I don't want to

Re: [cmake-developers] [PATCH] FindPythonLibs patches for version searching and frameworks

On Thu, Sep 17, 2015 at 11:25 AM, David Gobbi wrote: > On Thu, Sep 17, 2015 at 10:59 AM, Clinton Stimpson > wrote: > >> >> However, it does bother me that it found includes from the SDK and a >> library >> under /usr/lib. >> >> For example, if I use

Re: [cmake-developers] [PATCH] FindPythonLibs patches for version searching and frameworks

On 09/15/2015 10:09 AM, David Gobbi wrote: > The first is trivial, it simply adds Python 3.5 and 3.6 to the search list. > > The second removes the long-deprecated PYTHON_INCLUDE_PATH as a suggestion > for PYTHON_INCLUDE_DIR. Thanks. I've applied these two: FindPython{Interp,Libs}: Add

Re: [cmake-developers] [PATCH] FindPythonLibs patches for version searching and frameworks

On Wed, Sep 16, 2015 at 7:03 AM, Brad King wrote: > On 09/15/2015 10:09 AM, David Gobbi wrote: > > The first is trivial, it simply adds Python 3.5 and 3.6 to the search > list. > > > > The second removes the long-deprecated PYTHON_INCLUDE_PATH as a > suggestion > > for

Re: [cmake-developers] [PATCH] FindPythonLibs patches for version searching and frameworks

On 09/16/2015 10:00 AM, David Gobbi wrote: > this new patch only changes the search for the include dirs. Thanks. Rather than calling find_path twice, the first call could just use HINTS instead of PATHS. HINTS are meant for this use case: searching paths detected from the system in some

Re: [cmake-developers] [PATCH] FindPythonLibs patches for version searching and frameworks

On 09/16/2015 11:39 AM, Brad King wrote: > On 09/16/2015 10:00 AM, David Gobbi wrote: >> this new patch only changes the search for the include dirs. > > Thanks. Rather than calling find_path twice, the first call could > just use HINTS instead of PATHS. HINTS are meant for this use case: >

Re: [cmake-developers] [PATCH] FindPythonLibs patches for version searching and frameworks

On Wed, Sep 16, 2015 at 9:41 AM, Brad King wrote: > On 09/16/2015 11:39 AM, Brad King wrote: > > On 09/16/2015 10:00 AM, David Gobbi wrote: > >> this new patch only changes the search for the include dirs. > > > > Thanks. Rather than calling find_path twice, the first

[cmake-developers] [PATCH] FindPythonLibs patches for version searching and frameworks

Hi All, I've attached three suggested patches for cmake. The first is trivial, it simply adds Python 3.5 and 3.6 to the search list. The second removes the long-deprecated PYTHON_INCLUDE_PATH as a suggestion for PYTHON_INCLUDE_DIR. The third does two important things: 1) it fixes bugs for