Re: [cmake-developers] [PATCH] User may now specify toolset through CMake GUI

2015-11-17 Thread Brad King
On 11/16/2015 10:52 PM, Robert Dailey wrote: > I also forgot to mention that this patch is based on the 'next' > branch. Originally it was based on 'master' but I rebased it to > 'next'. Let me know if this is correct. I'm assuming the master branch > is used for maintenance releases only and

Re: [cmake-developers] [PATCH] User may now specify toolset through CMake GUI

2015-11-16 Thread Robert Dailey
Hello everyone, I apologize for the long hiatus, but I've finally gotten back to this. I've implemented the suggestions here: * deleteCache() now clears the toolset * When the binary directory changes, the GUI now reloads the toolset (The toolset isn't used by anything except the first-time

Re: [cmake-developers] [PATCH] User may now specify toolset through CMake GUI

2015-11-16 Thread Robert Dailey
I also forgot to mention that this patch is based on the 'next' branch. Originally it was based on 'master' but I rebased it to 'next'. Let me know if this is correct. I'm assuming the master branch is used for maintenance releases only and would not be appropriate for such a change. On Mon, Nov

Re: [cmake-developers] [PATCH] User may now specify toolset through CMake GUI

2015-02-19 Thread Brad King
On 02/17/2015 01:46 PM, Brad King wrote: On 02/17/2015 01:43 PM, Robert Dailey wrote: Of course right now only Visual Studio and XCode support the toolset parameter Correct. Furthermore it is supported only for VS = 10. In response to this issue:

Re: [cmake-developers] [PATCH] User may now specify toolset through CMake GUI

2015-02-17 Thread Robert Dailey
On Tue, Feb 17, 2015 at 12:08 PM, Brad King brad.k...@kitware.com wrote: On 02/17/2015 12:21 PM, Robert Dailey wrote: What would be the best way to handle detecting which generators support toolset? The confusing piece I had to figure out last night is that there is simply no generator base

Re: [cmake-developers] [PATCH] User may now specify toolset through CMake GUI

2015-02-17 Thread Brad King
On 02/17/2015 01:43 PM, Robert Dailey wrote: Of course right now only Visual Studio and XCode support the toolset parameter Correct. Furthermore it is supported only for VS = 10. I was thinking of a case in the future where Eclipse CDT4 or Code Blocks may support toolsets. Would these be

Re: [cmake-developers] [PATCH] User may now specify toolset through CMake GUI

2015-02-17 Thread Brad King
On 02/17/2015 12:21 PM, Robert Dailey wrote: What would be the best way to handle detecting which generators support toolset? The confusing piece I had to figure out last night is that there is simply no generator base class from which everything derives, there are 2 types: extra

Re: [cmake-developers] [PATCH] User may now specify toolset through CMake GUI

2015-02-16 Thread Clinton Stimpson
On Monday, February 16, 2015 11:35:47 AM Brad King wrote: On 02/15/2015 03:27 PM, rcdailey.li...@gmail.com wrote: From: Robert Dailey rcdai...@gmail.com The -T parameter to CMake may now be specified through QtDialog (cmake-gui) via a new text field in the first-time configure wizard

Re: [cmake-developers] [PATCH] User may now specify toolset through CMake GUI

2015-02-16 Thread Brad King
On 02/15/2015 03:27 PM, rcdailey.li...@gmail.com wrote: From: Robert Dailey rcdai...@gmail.com The -T parameter to CMake may now be specified through QtDialog (cmake-gui) via a new text field in the first-time configure wizard (below the generator chooser). Thanks for working on this. I

Re: [cmake-developers] [PATCH] User may now specify toolset through CMake GUI

2015-02-16 Thread Robert Dailey
Fair points, I will make the changes. What is the recommended practice for updating patches on mailing lists? With pull requests it's easy because it picks up my changes I push to my branch automatically. I think if I push another patch to the mailing list it will start another email thread,

Re: [cmake-developers] [PATCH] User may now specify toolset through CMake GUI

2015-02-16 Thread Brad King
On 02/16/2015 11:59 AM, Robert Dailey wrote: What is the recommended practice for updating patches on mailing lists? With pull requests it's easy because it picks up my changes I push to my branch automatically. I think if I push another patch to the mailing list it will start another email

[cmake-developers] [PATCH] User may now specify toolset through CMake GUI

2015-02-15 Thread rcdailey . lists
From: Robert Dailey rcdai...@gmail.com The -T parameter to CMake may now be specified through QtDialog (cmake-gui) via a new text field in the first-time configure wizard (below the generator chooser). --- Source/QtDialog/CMakeSetupDialog.cxx | 1 + Source/QtDialog/FirstConfigure.cxx | 18