Re: [cmake-developers] FindThreads_overhaul topic

2014-10-08 Thread Brad King
On 10/07/2014 12:18 PM, Rolf Eike Beer wrote: + add_library(CMake::Threads INTERFACE IMPORTED GLOBAL) Both issues should be fixed now. Thanks. Your use of an interface target for this is a clever way of abstracting the differences between libraries and flags. Nice. I'd rather reserve the

Re: [cmake-developers] FindThreads_overhaul topic

2014-10-08 Thread Rolf Eike Beer
Am Mittwoch, 8. Oktober 2014, 10:54:12 schrieb Brad King: On 10/07/2014 12:18 PM, Rolf Eike Beer wrote: + add_library(CMake::Threads INTERFACE IMPORTED GLOBAL) Both issues should be fixed now. Thanks. Your use of an interface target for this is a clever way of abstracting the

Re: [cmake-developers] FindThreads_overhaul topic

2014-10-08 Thread Brad King
On 10/08/2014 11:37 AM, Rolf Eike Beer wrote: All credits go to Timo Rothenpieler Okay. Please add a Co-Author: or Inspired-by: footer line to give this credit. I'm not sure about Threads::Interface, it sounds so generic or abstract to me, but this target offers no abstraction of the

Re: [cmake-developers] FindThreads_overhaul topic

2014-10-08 Thread Rolf Eike Beer
Am Mittwoch, 8. Oktober 2014, 11:44:28 schrieb Brad King: On 10/08/2014 11:37 AM, Rolf Eike Beer wrote: All credits go to Timo Rothenpieler Okay. Please add a Co-Author: or Inspired-by: footer line to give this credit. He is recorded as author of that change. Only the first and last of

Re: [cmake-developers] FindThreads_overhaul topic

2014-10-08 Thread Robert Maynard
As an aside have we formally documented that we are reserving the CMake namespace on imported targets anywhere? On Wed, Oct 8, 2014 at 11:48 AM, Rolf Eike Beer e...@sf-mail.de wrote: Am Mittwoch, 8. Oktober 2014, 11:44:28 schrieb Brad King: On 10/08/2014 11:37 AM, Rolf Eike Beer wrote: All

[cmake-developers] FindThreads_overhaul topic

2014-10-07 Thread Brad King
Eike, This fails on a few dashboard machines: http://open.cdash.org/testDetails.php?test=286158250build=3519076 CMake Error at /.../Modules/FindThreads.cmake:207 (add_library): add_library cannot create imported target CMake::Threads because another target with the same name already

Re: [cmake-developers] FindThreads_overhaul topic

2014-10-07 Thread Rolf Eike Beer
Am Dienstag, 7. Oktober 2014, 10:35:24 schrieb Brad King: Eike, This fails on a few dashboard machines: http://open.cdash.org/testDetails.php?test=286158250build=3519076 CMake Error at /.../Modules/FindThreads.cmake:207 (add_library): add_library cannot create imported target