On 17 Mar 2015, at 19:39, Brad King brad.k...@kitware.com wrote:
On 03/17/2015 12:28 PM, Raffi Enficiaud wrote:
I think everything in http://www.cmake.org/Bug/view.php?id=14641 was
addressed.
What should the maintainer usually do?
I've marked your Mantis account as a developer for
Le 12/03/15 21:00, Brad King a écrit :
On 03/12/2015 12:35 PM, Raffi Enficiaud wrote:
I will squash all this together once everything is done.
For now please base further work on commit 3743aa11.
We'll see how this does on the nightly testing!
Hi,
I have a problem running the tests on win7.
On 03/17/2015 12:28 PM, Raffi Enficiaud wrote:
I think everything in http://www.cmake.org/Bug/view.php?id=14641 was
addressed.
What should the maintainer usually do?
I've marked your Mantis account as a developer for CMake and assigned
the issue to you. In this case since it's already
On 17 Mar 2015, at 16:25, Brad King brad.k...@kitware.com wrote:
Nothing right now! I've squashed this all into one commit:
FindMatlab: Rewrite module and provide a usage API
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=49c8dcf7
and merged to 'master' for inclusion in 3.3.
Le 12/03/15 21:00, Brad King a écrit :
On 03/12/2015 12:35 PM, Raffi Enficiaud wrote:
* Renamed one more MATLAB_USER_ROOT = Matlab_ROOT_DIR
* Do not call list(REMOVE_DUPLICATES/SORT/REVERSE) with no list
Thanks!
The commits are now:
FindMatlab: Rewrite module and provide a usage API
Le 11/03/15 00:12, Raffi Enficiaud a écrit :
Hi Brad,
Please find the attached patch addressing the issues. In the current
implementation, if the Matlab_ROOT_DIR is changed by the user, the
cached variables are all cleared.
Also, Matlab_ROOT_DIR is now the only variable that is seen as non
Le 26/02/15 21:32, Brad King a écrit :
On 02/26/2015 03:23 PM, Raffi Enficiaud wrote:
We never specified explicitly which name to use. I think it
should be Matlab_ROOT_DIR because that makes sense whether the
user specified it or not.
Right, so I made the changes and updated the
On 03/10/2015 09:08 AM, Raffi Enficiaud wrote:
- I change Matlab_ROOT_DIR
I am expecting all dependent variables (cached or not) be updated
The question is: should also this be implemented?
Yes. See the FindBoost module for similar behavior with respect to
the library directory.
Will
Le 10/03/15 14:34, Brad King a écrit :
On 03/10/2015 09:08 AM, Raffi Enficiaud wrote:
- I change Matlab_ROOT_DIR
I am expecting all dependent variables (cached or not) be updated
The question is: should also this be implemented?
Yes. See the FindBoost module for similar behavior with
Quick question:
Is it possible to redirect the input stream of execute_process from /dev/null
on OSX and Linux ?
Right now on these platforms, I need to reset my shell. If I run the ctest
command with /dev/null, everything is fine. So my guess is that Matlab is
manipulating the console
Hi Brad,
Please find the patch addressing the issues you raised. My local tests are
clear on the 3 platforms.
I removed the RunCMake test on Linux as now the Matlab_MAIN_PROGRAM is required
if MATLAB_USER_ROOT is not specified. In the previous implementation, I used
temporary variables to
Thanks! here is the patch then, replacing the previous one, rebased on
1416d214b3.
Best,
Raffi
0001-Simplified-workflow.patch
Description: Binary data
On 26 Feb 2015, at 18:52, Brad King brad.k...@kitware.com wrote:
On 02/26/2015 12:06 PM, Raffi Enficiaud wrote:
Is it possible to
On 02/25/2015 04:11 AM, Raffi Enficiaud wrote:
Is it ok if I rebase on 1416d21?
Yes, please.
Thanks,
-Brad
--
Powered by www.kitware.com
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Kitware offers various services to support the CMake
Hi Brad,
Thanks, I started addressing the issues, hopefully I will finish today. Is it
ok if I rebase on 1416d21?
Best,
Raffi
On 23 Feb 2015, at 18:54, Brad King brad.k...@kitware.com wrote:
Hi Raffi,
Your matlab-enabled nightly builds have been clean for a few days on all
the
On 02/19/2015 04:58 PM, Raffi Enficiaud wrote:
I just unset this variable before the call to the find_program,
and now it works good.
Yes, this is expected. If find_program sees that the variable is
already set then it assumes the value is correct. The idea is
that projects can prevent the
On 19 Feb 2015, at 18:52, Brad King brad.k...@kitware.com wrote:
On 02/19/2015 11:54 AM, Raffi Enficiaud wrote:
On the system I am working, matlab in the PATH is a symlink with
r x permissions
[snip]
Is there any internal in the find_program to check what conditions
are not met?
What
Please find attached the merge of the two previous patches, rebased on 5dae6cf.
Thanks,
Raffi Enficiaud
0001-Adding-R2014a.patch
Description: Binary data
On 19 Feb 2015, at 12:49, Raffi Enficiaud raffi.enfici...@free.fr wrote:
Dear Brad,
Apparently there are some issues when things
On 02/19/2015 08:39 AM, Raffi Enficiaud wrote:
Please find attached the merge of the two previous patches, rebased on
5dae6cf.
Applied, thanks:
FindMatlab: Further revisions
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=1416d214
Those issues are related to the space in the test
On 02/19/2015 10:20 AM, Raffi Enficiaud wrote:
If find_program doesn't find it, which won't have better luck.
I tested that yesterday on a regular LTS14.04 server. find_program
fails while which matlab does not.
Please figure out why find_program fails so we can fix it rather
than working
Ok, I thought this was for the ctest program that accepts -j flag. I will do
the change, I am running the build already with all the // flags removed.
Thanks,
Raffi
On 19 Feb 2015, at 15:17, Brad King brad.k...@kitware.com wrote:
On 02/19/2015 06:49 AM, Raffi Enficiaud wrote:
Apparently
On 19 Feb 2015, at 14:53, Brad King brad.k...@kitware.com wrote:
On 02/19/2015 08:39 AM, Raffi Enficiaud wrote:
Please find attached the merge of the two previous patches, rebased on
5dae6cf.
Applied, thanks:
FindMatlab: Further revisions
On 19 Feb 2015, at 22:24, Brad King brad.k...@kitware.com wrote:
On 02/19/2015 04:15 PM, Raffi Enficiaud wrote:
renficiaud@madeira3:~$ ls -al /is/software/matlab/linux/R2014a/bin/matlab
-r-xr-xr-x 1 stark is 55331 Dec 27 2013
/is/software/matlab/linux/R2014a/bin/matlab
r permission
On 02/19/2015 04:15 PM, Raffi Enficiaud wrote:
renficiaud@madeira3:~$ ls -al /is/software/matlab/linux/R2014a/bin/matlab
-r-xr-xr-x 1 stark is 55331 Dec 27 2013
/is/software/matlab/linux/R2014a/bin/matlab
r permission are definitively there and the user is allowed to run this
command.
On 02/19/2015 06:49 AM, Raffi Enficiaud wrote:
Apparently there are some issues when things are running with the dashboard
For the Visual Studio build on your Windows machine you have:
set(CTEST_BUILD_FLAGS -j4)
which is not a valid msbuild flag. For that you could use
On 19 Feb 2015, at 16:48, Brad King brad.k...@kitware.com wrote:
On 02/19/2015 10:20 AM, Raffi Enficiaud wrote:
If find_program doesn't find it, which won't have better luck.
I tested that yesterday on a regular LTS14.04 server. find_program
fails while which matlab does not.
Please
On 02/19/2015 11:54 AM, Raffi Enficiaud wrote:
On the system I am working, matlab in the PATH is a symlink with
r x permissions
[snip]
Is there any internal in the find_program to check what conditions
are not met?
What are the permissions of the underlying file after resolving
the link?
Dear Brad,
I just tested the patch I sent you on OSX and Win32 and all the tests are clear.
Best,
Raffi Enficiaud
On 18 Feb 2015, at 01:28, Raffi Enficiaud raffi.enfici...@free.fr wrote:
Dear Brad,
Please find attached a patch addressing the issues mentioned in your email.
The tests
Please find attached the patch addressing the issues + some others, rebased
against 5dae6cf.
I tested it on the 3 target platforms.
patch.diff
Description: Binary data
On 18 Feb 2015, at 15:13, Brad King brad.k...@kitware.com wrote:
On 02/17/2015 07:28 PM, Raffi Enficiaud wrote:
The
On 02/17/2015 07:28 PM, Raffi Enficiaud wrote:
The tests were failing because of the following modification:
- matlab_get_version_from_matlab_run(${Matlab_MAIN_PROGRAM}
matlab_list_of_all_versions)
+ matlab_get_version_from_matlab_run(${Matlab_MAIN_PROGRAM}
Dear Brad,
Please find attached a patch addressing the issues mentioned in your email.
The tests were failing because of the following modification:
- matlab_get_version_from_matlab_run(${Matlab_MAIN_PROGRAM}
matlab_list_of_all_versions)
+
On 02/13/2015 10:57 AM, Brad King wrote:
I had to add two commits to the topic to fix some continuous
testing failures:
Please rebase further work on commit 5e91eb43. I will squash
all this together later before merging to 'master'.
After a few more fixes for other nightly testing failures
Dear Brad,
Yes, thank you, you did well.
And sorry for the delay, it takes more time than expected.
Best regards,
Raffi Enficiaud
On 17 Feb 2015, at 16:16, Brad King brad.k...@kitware.com wrote:
On 02/13/2015 10:57 AM, Brad King wrote:
I had to add two commits to the topic to fix some
Hi,
3 build agents (lts14.04, osx10.9 and win7x64) are now running the nightly with
the CMake_TEST_FindMatlab set to ON.
The site name is bambooagent.raffienficiaud @
https://open.cdash.org/viewSite.php?siteid=11851project=1currenttime=1423789200
Please let me know if there is anything else I
On 13 Feb 2015, at 14:58, Brad King brad.k...@kitware.com wrote:
On 02/13/2015 05:10 AM, Raffi Enficiaud wrote:
3 build agents (lts14.04, osx10.9 and win7x64) are now running the nightly
with the CMake_TEST_FindMatlab set to ON.
The site name is bambooagent.raffienficiaud @
On 02/13/2015 05:10 AM, Raffi Enficiaud wrote:
3 build agents (lts14.04, osx10.9 and win7x64) are now running the nightly
with the CMake_TEST_FindMatlab set to ON.
The site name is bambooagent.raffienficiaud @
https://open.cdash.org/viewSite.php?siteid=11851project=1currenttime=1423789200
Hi,
My comments below:
On 13 Feb 2015, at 15:33, Brad King brad.k...@kitware.com wrote:
On 02/12/2015 11:19 AM, Raffi Enficiaud wrote:
Please find attached the reworked patch
Great, thanks. Now that we have the nightly testing worked out I've
committed this with minor tweaks as a draft
On 02/13/2015 09:43 AM, Raffi Enficiaud wrote:
* Why is Matlab_VERSION_STRING cached? Shouldn't it be computed
every time from the matlab that was found?
In case the version is not found with an obvious method
(on OSX /Applications/MATLABVersion, on Win32, the version also is
given by the
On 02/13/2015 09:33 AM, Brad King wrote:
FindMatlab: Rewrite module and provide a usage API
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=1c7710e9
I have a few more comments to be addressed before merge to 'master'.
You can base further patches on the above-linked commit.
I had to
Thanks for your feedback, I will address your comments this week-end.
Regards,
Raffi Enficiaud
On 13 Feb 2015, at 16:36, Brad King brad.k...@kitware.com wrote:
On 02/13/2015 09:43 AM, Raffi Enficiaud wrote:
* Why is Matlab_VERSION_STRING cached? Shouldn't it be computed
every time from
On 02/12/2015 11:19 AM, Raffi Enficiaud wrote:
Please find attached the reworked patch
Thanks. I'll take a look when I get a chance.
Use Windows Task Scheduler to run a .bat script that runs ctest on the
dashboard script you create.
It is really just running the commands in the page you
On 12 Feb 2015, at 19:03, Brad King brad.k...@kitware.com wrote:
The definition needs to be put in the cache of the CMake build itself,
not passed to the ctest script. To do that, add:
set(dashboard_cache
CMake_TEST_FindMatlab:BOOL=ON
)
before including the common script.
Dear Brad,
Please find attached the reworked patch + some more log in case of error of
the matlab unit tests.
I rebased the work on master rev 09cdcc5 and squashed the patch as you required.
Use Windows Task Scheduler to run a .bat script that runs ctest on the
dashboard script you create.
On 02/03/2015 06:21 PM, Raffi Enficiaud wrote:
I suppose there is some documentation on how to set up a night test server
Oops, I forgot to include the link. Here:
http://www.cmake.org/Wiki/CMake/Git/Dashboard
Use Windows Task Scheduler to run a .bat script that runs ctest on the
dashboard
On 01/28/2015 09:21 AM, Raffi Enficiaud wrote:
I am wondering why I haven't zipped the patch before.
Please find attached the patch addressing the issues you raised.
The reason it was so big is because you sent an entire patch
series containing your local development history. Instead please
Dear Brad,
Thanks for the feedback. I will implement your suggestions.
I suppose there is some documentation on how to set up a night test server, but
I could not find any. Would you please help me with this?
Regards,
Raffi Enficiaud
On 03 Feb 2015, at 20:59, Brad King
On 01/23/2015 07:52 PM, Raffi Enficiaud wrote:
This should be handled with a save/restore.
Are you referring to the CMakePushCheckState?
No, CMAKE_FIND_LIBRARY_PREFIXES should be saved/restored manually
with code in the Find module around the find_library calls. You
could also create a
Dear Brad,
I addressed your proposed solution and sent you a patch, that is pending
approval since this afternoon because of a size exceeding 300KB.
Best regards,
Raffi Enficiaud
On 26 Jan 2015, at 14:43, Brad King brad.k...@kitware.com wrote:
On 01/23/2015 07:52 PM, Raffi Enficiaud wrote:
On 01/22/2015 11:50 AM, Raffi Enficiaud wrote:
I can also do a pull request if you prefer,
As described in CONTRIBUTING.rst a patch here is preferred.
I've fetched your branch from https://github.com/raffienficiaud/CMake
Here are some comments.
Please wrap text in the documentation blocks of
Hi,
I added a section known problems in the documentation and removed the
REDUCE_VISIBILITY option. I am keeping the hidden symbols of the compiled MEX
file as it appears to be something properly supported. This behaviour is also
documented.
I moved the test for bad configuration under
Attached to this email.
I can also do a pull request if you prefer,
Best,
Raffi Enficiaud
FindMatlab.cmake
Description: Binary data
MatlabTestsRedirect.cmake
Description: Binary data
On 22 Jan 2015, at 17:48, Brad King brad.k...@kitware.com wrote:
On 01/22/2015 10:13 AM, Raffi
On 01/21/2015 12:01 PM, Raffi Enficiaud wrote:
Ok. What do you think about mimicking the mex compiler in terms
of options set to the compiler? The -Wl,--exclude-libs,ALL is in
fact set by the mex compiler for compiling the mex extensions under
Linux. Then I will just drop the REDUCE_VISIBILITY
On 10/13/2014 02:23 PM, Raffi Enficiaud wrote:
I had a hard time making some stuff compile again with Matlab under Linux.
The fact is that Matlab is shipped with its own version of libC, libhdf5,
libboost etc, and sometimes the filenames are the same (eg. hdf5, or libc)
but the subminor
Hi Brad,(Sorry for the late answer (again).)I addressed your comments in the files attached to this email (please see the remarks below). I have not yet addressed your comment about “MATLAB_ADDITIONAL_VERSIONS” but I think it is a better proposition, so I will do it next.I updated the
Hi Raffi,
Thanks for your continuing work on this module.
I've made some whitespace and quoting tweaks to the files. See attached
updated versions. I also renamed the test helper to not start in Find
since no one should call find_package(Matlab_TestsRedirect). See further
comments below.
On
Hi,
Sorry for the delayed answer.
On 11 Apr 2014, at 15:35, Brad King brad.k...@kitware.com wrote:
I avoided using the new syntax of cmake 3.x because I am still using 2.8.12
and I also would like ppl to get this new package and run it on older
versions.
If it is going to be added
On 04/09/2014 05:09 PM, Raffi Enficiaud wrote:
After Brad’s feedbacks, I did the following:
- fix + clean the documentation
- remove any unwanted message, added a variable in order to print diagnostic
- cleaned variable/function names
- changed macros to function
- added components: mex
Hi all,
After Brad’s feedbacks, I did the following:
- fix + clean the documentation
- remove any unwanted message, added a variable in order to print diagnostic
- cleaned variable/function names
- changed macros to function
- added components: mex compiler, eng/mx libraries, matlab program
-
On 03/05/2014 05:46 PM, Raffi Enficiaud wrote:
So, I began writing the doc of the module and changed the license
according to the instructions. I am attaching the module to the email.
Thanks!
The documentation so far is a good start but it looks like you're
still working on it. You can copy
Hello,
My name is Raffi Enficiaud. I am volunteering myself for maintaining the Matlab
package.
In fact, I wrote a Matlab package that I am currently using on Mac and Win in
Bamboo continuous build (and in the near future on Ubuntu).
I already gave some of the functionalities in the following
On 03/05/2014 08:49 AM, Raffi Enficiaud wrote:
I am volunteering myself for maintaining the Matlab package.
Great, thanks!
I already gave some of the functionalities in the following mantis ticket:
http://www.cmake.org/Bug/view.php?id=14641
In answer to your questions from there:
- What
Hi,
So, I began writing the doc of the module and changed the license according to
the instructions.
I am attaching the module to the email.
FindMatlab.cmake
Description: Binary data
From what I see in the instructions, there are some issues with the proposed
module:
- the error messages
61 matches
Mail list logo
