Re: [cmake-developers] Python extension to FindProtobuf

2015-09-15 Thread Andreas Bergmeier
Sorry, found a stashed change, that I missed. With that it works. -Original Message- From: Brad King [mailto:brad.k...@kitware.com] Sent: Montag, 14. September 2015 16:12 To: Andreas Bergmeier Cc: Rolf Eike Beer; cmake-developers@cmake.org Subject: Re: [cmake-developers] Python extension

Re: [cmake-developers] Python extension to FindProtobuf

2015-09-14 Thread Brad King
On 09/14/2015 03:42 AM, Andreas Bergmeier wrote: > I now added documentation, removed ARGS and GENERATED property. Thanks. Applied with minor wording tweaks: FindProtobuf: Add protobuf_generate_python function http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=143579c3 -Brad -- Powered by

Re: [cmake-developers] Python extension to FindProtobuf

2015-09-14 Thread Andreas Bergmeier
I now added documentation, removed ARGS and GENERATED property. -Original Message- From: Brad King [mailto:brad.k...@kitware.com] Sent: Freitag, 11. September 2015 20:33 To: Andreas Bergmeier Cc: Rolf Eike Beer; cmake-developers@cmake.org Subject: Re: [cmake-developers] Python extension

Re: [cmake-developers] Python extension to FindProtobuf

2015-09-11 Thread Brad King
On 09/11/2015 11:11 AM, Andreas Bergmeier wrote: > Here is the commit. Thanks. Please revise the patch to also update the documentation of the module to mention the new API. > +list(APPEND ${SRCS} "${CMAKE_CURRENT_BINARY_DIR}/${FIL_WE}.pb.py") > +add_custom_command( > + OUTPUT

[cmake-developers] Python extension to FindProtobuf

2015-09-11 Thread Andreas Bergmeier
Since beneath generating cpp and h files we often also want python bindings to be generated, I would like to have the following extension to FindProtobuf added. This adds protobuf_generate_python function. Diese E-mail enthält VERTRAULICHE UND PERSÖNLICHE

Re: [cmake-developers] Python extension to FindProtobuf

2015-09-11 Thread Rolf Eike Beer
Am Freitag, 11. September 2015, 14:44:21 schrieb Andreas Bergmeier: > Since beneath generating cpp and h files we often also want python bindings > to be generated, I would like to have the following extension to > FindProtobuf added. This adds protobuf_generate_python function. Forgot to add

Re: [cmake-developers] Python extension to FindProtobuf

2015-09-11 Thread Andreas Bergmeier
Subject: Re: [cmake-developers] Python extension to FindProtobuf Am Freitag, 11. September 2015, 14:44:21 schrieb Andreas Bergmeier: > Since beneath generating cpp and h files we often also want python > bindings to be generated, I would like to have the following extension > to FindProto