[cmake-developers] Review request: qt4-target-depends

2012-12-31 Thread Stephen Kelly
Hi there (Alex/Clinton), I've added a branch to the stage to list public link depends of Qt modules. Please review it before I merge it to next. Thanks, Steve. -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html

Re: [cmake-developers] Review request: qt4-target-depends

2012-12-31 Thread clinton
- Original Message - clin...@elemtech.com wrote: Is the list of dependencies complete? I think so. I made the lists of dependencies by using ldd and grepping for use of headers of particular modules by particular modules. For example, you list only Script, Gui, Core for

Re: [cmake-developers] Review request: qt4-target-depends

2012-12-31 Thread Stephen Kelly
clin...@elemtech.com wrote: I'm already aware of the distinction. Great. That wasn't clear from your email talking about all dependencies of QtDeclarative instead of just the public ones. Granted, UseQt4.cmake doesn't know if imported targets are being used or not, and probably cannot be

Re: [cmake-developers] Review request: qt4-target-depends

2012-12-31 Thread Clinton Stimpson
On Monday, December 31, 2012 07:09:23 PM Stephen Kelly wrote: clin...@elemtech.com wrote: I'm already aware of the distinction. Great. That wasn't clear from your email talking about all dependencies of QtDeclarative instead of just the public ones. Granted, UseQt4.cmake doesn't know