2011/10/24 Brad King brad.k...@kitware.com:
On 10/24/2011 4:53 AM, Nicolas Desprès wrote:
Ok. Here the real change applied on this file (except the remove of
the trailing white-space). It fixes some doxygen warnings:
diff --git a/Source/kwsys/SystemTools.hxx.in
2011/10/17 Brad King brad.k...@kitware.com:
On 10/16/2011 12:56 PM, Nicolas Desprès wrote:
I pushed the new version.
That looks good. There is one more detail though. The KWSys source
tree is read-only in our Git repository. A robot replays changes
out of a separate CVS repository for
On 10/24/2011 4:53 AM, Nicolas Desprès wrote:
Ok. Here the real change applied on this file (except the remove of
the trailing white-space). It fixes some doxygen warnings:
diff --git a/Source/kwsys/SystemTools.hxx.in b/Source/kwsys/SystemTools.hxx.in
I committed this separately, thanks.
On 10/16/2011 12:56 PM, Nicolas Desprès wrote:
I pushed the new version.
That looks good. There is one more detail though. The KWSys source
tree is read-only in our Git repository. A robot replays changes
out of a separate CVS repository for that project. Please rewrite
the branch to leave
Brad King wrote:
- Some of the patches remove trailing whitespace from lines unrelated to
the real change. Please identify the set of files from which you've
blanket-removed whitespace, create a commit that does just that, and
then rebase the rest of the patches on it. That will
On Thu, Oct 13, 2011 at 8:30 AM, Rolf Eike Beer e...@sf-mail.de wrote:
Brad King wrote:
- Some of the patches remove trailing whitespace from lines unrelated to
the real change. Please identify the set of files from which you've
blanket-removed whitespace, create a commit that does
2011/10/13 Brad King brad.k...@kitware.com:
On 10/12/2011 11:10 AM, Nicolas Desprès wrote:
I have extracted some documentation patches I have made while I was
working on the ninja-generator and some enhancement for ccmake. I
would like to submit them now. They are addressing:
- usage
2011/10/13 Nicolas Desprès nicolas.desp...@gmail.com:
2011/10/13 Brad King brad.k...@kitware.com:
On 10/12/2011 11:10 AM, Nicolas Desprès wrote:
I have extracted some documentation patches I have made while I was
working on the ninja-generator and some enhancement for ccmake. I
would like
On 10/13/2011 2:14 PM, Nicolas Desprès wrote:
2011/10/13 Nicolas Desprèsnicolas.desp...@gmail.com:
Thanks for the review. I have fix all the remarks.
Pushed on my github:
https://github.com/polrop/CMake/commits/some-documentation-fixes
Thanks. I will fetch it from there when I get a chance
On 10/13/2011 2:14 PM, Nicolas Desprès wrote:
2011/10/13 Nicolas Desprèsnicolas.desp...@gmail.com:
Thanks for the review. I have fix all the remarks.
Pushed on my github:
https://github.com/polrop/CMake/commits/some-documentation-fixes
That looks pretty good. I have two more comments:
-
On 10/12/2011 11:10 AM, Nicolas Desprès wrote:
I have extracted some documentation patches I have made while I was
working on the ninja-generator and some enhancement for ccmake. I
would like to submit them now. They are addressing:
- usage messages
- doxygen documentation
- online help in
11 matches
Mail list logo
