On 09/24/2015 11:08 AM, Kislinskiy, Stefan wrote:
> Regarding the nice bracket tweak: Maybe the minimum required
> version in Tests/GeneratorExpression/CMakeLists.txt should be
> updated to 3.0.0 then?
The test also covers policy CMP0044 behavior and so cannot require
a version new enough to set
On 09/24/2015 11:08 AM, Kislinskiy, Stefan wrote:
> Regarding the ExternalProjectShellPathGenex test
[snip]
> there is a standard Windows command out there that cannot
> handle slashed even if they are quoted (any idea?)
Rather than trying to find a command for this you could just have
the test
ailto:brad.k...@kitware.com]
> Sent: Mittwoch, 23. September 2015 16:57
> To: Kislinskiy, Stefan
> Cc: cmake-developers@cmake.org
> Subject: Re: [cmake-developers] generator expression for path slash conversion
>
> On 09/23/2015 10:45 AM, Kislinskiy, Stefan wrote:
>> I see
To: Kislinskiy, Stefan
Cc: cmake-developers@cmake.org
Subject: Re: [cmake-developers] generator expression for path slash conversion
On 09/23/2015 10:45 AM, Kislinskiy, Stefan wrote:
> I see. I would suggest that I add another output flag to
> cmOutputConverter like SHELL_NO_ESCAPE then. If thi
efan
Cc: cmake-developers@cmake.org
Subject: Re: [cmake-developers] generator expression for path slash conversion
On 09/24/2015 09:05 AM, Kislinskiy, Stefan wrote:
> I factored out the code from
> cmOutputConverter::ConvertToOutputFormat()
> into another helper
On 09/24/2015 09:05 AM, Kislinskiy, Stefan wrote:
> I factored out the code from cmOutputConverter::ConvertToOutputFormat()
> into another helper method called ConvertDirectorySeparatorsForShell(),
> changed the SHELL_PATH genex to accept only absolute paths, and changed
> its documentation
> -Original Message-
> From: cmake-developers [mailto:cmake-developers-boun...@cmake.org]
> On Behalf Of Kislinskiy, Stefan
> Sent: Thursday, September 24, 2015 15:09
> To: Brad King
> Cc: cmake-developers@cmake.org
> Subject: Re: [cmake-developers] generator expr
-
From: Brad King [mailto:brad.k...@kitware.com]
Sent: Donnerstag, 17. September 2015 15:56
To: Kislinskiy, Stefan
Cc: CHEVRIER, Marc; cmake-developers@cmake.org; James Johnston
Subject: Re: [cmake-developers] generator expression for path slash conversion
On 09/17/2015 09:51 AM, Kislinskiy, Stefan
On 09/23/2015 08:40 AM, Kislinskiy, Stefan wrote:
> I wrote the documentation, added a genex test that checks it the
> given path is converted as expected on different platforms, and
> added another ExternalProject test for Windows that invokes
> pushd, which is is command sensitive to the path
Johnston
Subject: Re: [cmake-developers] generator expression for path slash conversion
On 09/21/2015 10:05 AM, Kislinskiy, Stefan wrote:
> if(MSYS)
> check(test_shell_path "/c/shell/path")
> elseif(WIN32)
> check(test_shell_path "c:shellpath")
> elseif
is
working... which also fails. The configuring/generating itself is working.. Any
ideas?
Stefan
-Original Message-
From: Brad King [mailto:brad.k...@kitware.com]
Sent: Donnerstag, 17. September 2015 15:56
To: Kislinskiy, Stefan
Cc: CHEVRIER, Marc; cmake-developers@cmake.org; James J
On 09/21/2015 10:05 AM, Kislinskiy, Stefan wrote:
> if(MSYS)
> check(test_shell_path "/c/shell/path")
> elseif(WIN32)
> check(test_shell_path "c:shellpath")
> elseif(UNIX)
> check(test_shell_path "c:/shell/path")
> endif()
>
> No matter what I'm doing, it always ends up in the WIN32
On 09/17/2015 09:51 AM, Kislinskiy, Stefan wrote:
> I wrote a SHELL_PATH genex which uses
> cmOutputConverter->ConvertToOutputFormat(..., SHELL) for the conversion.
> I decided to name the genex SHELL_PATH instead of TO_SHELL_PATH for the
> sake of consistency to other genexes like LOWER_CASE.
Re: [cmake-developers] generator expression for path slash conversion
(was: ExternalProject: Use native paths as substitute for directory tokens)
On 08/31/2015 09:35 AM, Kislinskiy, Stefan wrote:
> As there is already a patch for such a genex in bug 15509 and the
> discussion in 5939 (both lin
On 08/31/2015 09:35 AM, Kislinskiy, Stefan wrote:
> As there is already a patch for such a genex in bug 15509 and the
> discussion in 5939 (both linked below in Brad's reply) started 7
> years ago... It would be a great pity to let this issue seep away
> again. What can I do to help fixing this
On 08/28/2015 04:06 AM, CHEVRIER, Marc wrote:
Offering generator-expressions is a very good idea because it offers
a global solution to this problem.
Now regarding the name of the generator, may be TO_NATIVE_PATH is
not judicious, (even if problems explained in
Sorry for the false assertion.
I assumed, wrongly, that add_custom_command had same behaviour as
execute_process for which the doc clearly explains that System API are used (no
shell used).
So, adding some precisions on how add_custom_command (and add_custom_target I
presume) launch specified
17 matches
Mail list logo
