Re: [cmake-developers] [CMake] Setup/tear down steps for CTest

2016-09-08 Thread Daniel Pfeifer
On Thu, Sep 8, 2016 at 5:52 PM, Brad King wrote: > On 09/08/2016 10:15 AM, Craig Scott wrote: >> the current behaviour of DEPENDS. At the moment, if test B depends >> on test A, test B still executes if test A fails. >> It is unexpected because I'd initially have thought of

[cmake-developers] [patch] FreeBSD build fix

2016-09-08 Thread Roger Leigh
With FreeBSD 11, I was getting a link failure due to missing kvm symbols in Utilities/cmlibuv. The fix is a trivial addition. It's added unconditionally; I checked for its presence in FreeBSD 11, 10 and 9. Branch: freebsd-kvm-link Merged into stage for testing. Regards, Roger -- Powered

[cmake-developers] [patch] BZip2 imported targets

2016-09-08 Thread Roger Leigh
Adds BZip2::BZip2 imported target and documentation, along with unit test which may be enabled with the CMake_TEST_FindBZip2 option. Derived from the existing code in FindZLib. Branch: bzip2-imported-targets Merged into stage for testing. Regards, Roger -- Powered by www.kitware.com

Re: [cmake-developers] CMake version to build CMake

2016-09-08 Thread Brad King
On 09/08/2016 02:17 PM, Stephen Kelly wrote: > Are there dashboard machines which need to be updated first? Oops, right. I see a bunch that are still on 2.8.12. There are only a few older than that (2.8.7, 2.8.9, 2.8.11). I'll try to get those updated soon and report back. Then we can move to

Re: [cmake-developers] CMake version to build CMake

2016-09-08 Thread Stephen Kelly
Brad King wrote: > On 09/07/2016 06:44 PM, Stephen Kelly wrote: >> ALIAS targets were introduced in CMake 2.8.12 (released August 2013). >> >> What do you think of updating the requirement to that or higher? > > Fine with me. It really only matters on platforms where one cannot use > the

Re: [cmake-developers] [CMake] Setup/tear down steps for CTest

2016-09-08 Thread Brad King
On 09/08/2016 10:15 AM, Craig Scott wrote: > the current behaviour of DEPENDS. At the moment, if test B depends > on test A, test B still executes if test A fails. > It is unexpected because I'd initially have thought of DEPENDS as > meaning I can't run test B if test A fails, after all, B depends

Re: [cmake-developers] [CMake] Setup/tear down steps for CTest

2016-09-08 Thread Craig Scott
I should also point out that another reason for not implementing the "skipping tests if the setup fails logic" relates to the current behaviour of DEPENDS. At the moment, if test B depends on test A, test B still executes if test A fails. This is both useful and unexpected at the same time. It is

Re: [cmake-developers] CMake version to build CMake

2016-09-08 Thread Brad King
On 09/07/2016 06:44 PM, Stephen Kelly wrote: > ALIAS targets were introduced in CMake 2.8.12 (released August 2013). > > What do you think of updating the requirement to that or higher? Fine with me. It really only matters on platforms where one cannot use the bootstrap script. Let's go to 3.0

Re: [cmake-developers] [CMake] Setup/tear down steps for CTest

2016-09-08 Thread Craig Scott
Merge request implementing this feature is now up for review here: https://gitlab.kitware.com/cmake/cmake/merge_requests/88 I ended up going with FIXTURE_... test property names rather than GROUP_... since it seemed more specific. I have not implemented the logic for skipping regular tests if

Re: [cmake-developers] [Patch 5/5] Improved WIX support

2016-09-08 Thread Nils Gladitz
On 09/06/2016 01:26 PM, Stuermer, Michael SP/HZA-ZSEP wrote: Yes I tried, didn't work somehow. Never mind, the current approach works. It should have worked. I've added a new working test case to my suite: https://github.com/ngladitz/cmake-wix-testsuite/tree/master/feature_ref_in_product