Re: [cmake-developers] How to handle dependencies of protobuf files ?

2018-05-30 Thread Brad King
On 05/30/2018 09:54 AM, Eric Noulard wrote: > protoc can already do something like that but it spits out a makefile > includable file. > > see --dependency_out=FILE option. That may work well for the Ninja generator at least. See the add_custom_command `DEPFILE` option. One day it would be

Re: [cmake-developers] How to handle dependencies of protobuf files ?

2018-05-30 Thread Eric Noulard
Le mer. 30 mai 2018 à 15:12, Brad King a écrit : > On 05/29/2018 04:00 PM, Alexander Neundorf wrote: > >> In order to handle implicit dependencies like that implied by > >> > >> import "MyBase.proto"; > >> > >> then they would somehow need to be extracted from source content. > > > > Would

Re: [cmake-developers] How to handle dependencies of protobuf files ?

2018-05-30 Thread Brad King
On 05/29/2018 04:00 PM, Alexander Neundorf wrote: >> In order to handle implicit dependencies like that implied by >> >> import "MyBase.proto"; >> >> then they would somehow need to be extracted from source content. > > Would that have to be implemented similar to the C dependency scanning ?

Re: [cmake-developers] How to handle dependencies of protobuf files ?

2018-05-29 Thread Alexander Neundorf
Hi, On 2018 M05 29, Tue 09:52:16 CEST Brad King wrote: > On 05/15/2018 03:45 PM, Alexander Neundorf wrote: > > I think to do it properly, there would have to be a dependency scanning > > for > > proto files like there is for C/C++ headers. > > In order to handle implicit dependencies like that

Re: [cmake-developers] How to handle dependencies of protobuf files ?

2018-05-29 Thread Brad King
On 05/15/2018 03:45 PM, Alexander Neundorf wrote: > I think to do it properly, there would have to be a dependency scanning for > proto files like there is for C/C++ headers. In order to handle implicit dependencies like that implied by import "MyBase.proto"; then they would somehow need

Re: [cmake-developers] How to handle dependencies of protobuf files ?

2018-05-25 Thread Alexander Neundorf
Any comments ? Alex On 2018 M05 15, Tue 21:45:06 CEST Alexander Neundorf wrote: > Hi, > > I stumbled upon a problem with protobuf files, I attached a testcase. > There is a MyBase.proto, which is "imported" by Complex.proto. > If MyBase.proto is modified, protoc is run again in MyBase.proto,

[cmake-developers] How to handle dependencies of protobuf files ?

2018-05-15 Thread Alexander Neundorf
Hi, I stumbled upon a problem with protobuf files, I attached a testcase. There is a MyBase.proto, which is "imported" by Complex.proto. If MyBase.proto is modified, protoc is run again in MyBase.proto, but not on Complex.proto, although it should. You can have a look at the attached example.