Re: [cmake-developers] Listing all targets

2016-03-13 Thread Stephen Kelly
Clifford Yapp wrote: > On Mon, Sep 14, 2015 at 1:47 PM, Stephen Kelly > wrote: >> Making the target names available through properties via cmState is also >> trivial after targets become first-class parts of cmState >> (cmState::Target like cmState::Directory). >> >> That can

Re: [cmake-developers] Listing all targets

2016-03-11 Thread Clifford Yapp
On Mon, Sep 14, 2015 at 1:47 PM, Stephen Kelly wrote: > Brad King wrote: > >> On 09/14/2015 11:46 AM, David Cole wrote: >>> (1) I see how I can easily move "COMPONENTS" from >>> cmGetCMakePropertyCommand::InitialPass to cmState::GetGlobalProperty >>> because I can access the

Re: [cmake-developers] Listing all targets

2015-09-14 Thread David Cole via cmake-developers
Finally getting back to this, hopefully can push to next this week, and have this completed in time for the upcoming 3.4 release. I have three questions before attempting my first merge-to-next for testing: (1) I see how I can easily move "COMPONENTS" from cmGetCMakePropertyCommand::InitialPass

Re: [cmake-developers] Listing all targets

2015-09-14 Thread Brad King
On 09/14/2015 11:46 AM, David Cole wrote: > (1) I see how I can easily move "COMPONENTS" from > cmGetCMakePropertyCommand::InitialPass to cmState::GetGlobalProperty > because I can access the global generator from cmState as well... Yes. > move "VARIABLES" and "MACROS," though, I need access to

Re: [cmake-developers] Listing all targets

2015-09-14 Thread Stephen Kelly
Brad King wrote: > On 09/14/2015 11:46 AM, David Cole wrote: >> (1) I see how I can easily move "COMPONENTS" from >> cmGetCMakePropertyCommand::InitialPass to cmState::GetGlobalProperty >> because I can access the global generator from cmState as well... > > Yes. I assume you're thinking of

Re: [cmake-developers] Listing all targets

2015-07-20 Thread David Cole via cmake-developers
Thanks for the comments. I'll incorporate these into my next iteration... On Mon, Jul 20, 2015 at 9:30 AM, Brad King brad.k...@kitware.com wrote: On 07/17/2015 06:05 PM, David Cole via cmake-developers wrote: Attached is a patch file of my first attempt. I can iterate some more on this (better

Re: [cmake-developers] Listing all targets (was: Wrapping functions in CMake)

2015-07-18 Thread David Cole via cmake-developers
You're welcome. The key to using it effectively, of course, is using it at the very bottom of the top level CMakeLists.txt file. It can only report on the targets defined so far, so if you put it in the middle somewhere, targets may be defined after you use it, and you'll miss them... D On

Re: [cmake-developers] Listing all targets (was: Wrapping functions in CMake)

2015-07-17 Thread Ben Boeckel
On Thu, Jul 16, 2015 at 13:27:12 -0400, David Cole via cmake-developers wrote: This would best be added as a TARGETS variant of the existing http://www.cmake.org/cmake/help/v3.3/command/get_cmake_property.html command. (In my opinion...) The get_property command would also need to handle

Re: [cmake-developers] Listing all targets (was: Wrapping functions in CMake)

2015-07-17 Thread David Cole via cmake-developers
Are you saying there should be a named GLOBAL property with this information in it...? It seems like more of a fit to get_cmake_property. On Fri, Jul 17, 2015 at 10:14 AM, Ben Boeckel ben.boec...@kitware.com wrote: On Thu, Jul 16, 2015 at 13:27:12 -0400, David Cole via cmake-developers wrote:

Re: [cmake-developers] Listing all targets (was: Wrapping functions in CMake)

2015-07-17 Thread Ben Boeckel
On Fri, Jul 17, 2015 at 14:16:34 -0400, David Cole wrote: get_cmake_property is more like strictly well-pre-defined, read only (ish), built-into CMake properties. Note there is no set_cmake_property... What docs are you looking at that you think have a bug...? Help/command/get_cmake_property:

Re: [cmake-developers] Listing all targets (was: Wrapping functions in CMake)

2015-07-17 Thread David Cole via cmake-developers
I think the see also is relevant because it points to another way to get to a whole different set of properties. Perhaps what they're looking for when they stumble upon get_cmake_property is actually target properties, which are only accessible via get_property. While it's relevant, and I think

Re: [cmake-developers] Listing all targets (was: Wrapping functions in CMake)

2015-07-17 Thread David Cole via cmake-developers
get_cmake_property is more like strictly well-pre-defined, read only (ish), built-into CMake properties. Note there is no set_cmake_property... What docs are you looking at that you think have a bug...? To implement TARGETS for get_cmake_property, I would look to see what logic is used by

Re: [cmake-developers] Listing all targets (was: Wrapping functions in CMake)

2015-07-17 Thread Ben Boeckel
On Fri, Jul 17, 2015 at 12:18:18 -0400, David Cole wrote: Are you saying there should be a named GLOBAL property with this information in it...? It seems like more of a fit to get_cmake_property. Indeed. It seems there is no overlap between `get_property` and `get_cmake_property`. Which

Re: [cmake-developers] Listing all targets (was: Wrapping functions in CMake)

2015-07-17 Thread Clifford Yapp
On Fri, Jul 17, 2015 at 6:05 PM, David Cole dlrd...@aol.com wrote: Attached is a patch file of my first attempt. I can iterate some more on this (better testing, add docs, clarify existing docs, address anybody's comments, submit to stage) next week. Attached now in case anybody wants to try

Re: [cmake-developers] Listing all targets (was: Wrapping functions in CMake)

2015-07-17 Thread David Cole via cmake-developers
Attached is a patch file of my first attempt. I can iterate some more on this (better testing, add docs, clarify existing docs, address anybody's comments, submit to stage) next week. Attached now in case anybody wants to try it out over the weekend. Cheers, David C. On Fri, Jul 17, 2015 at

Re: [cmake-developers] Listing all targets (was: Wrapping functions in CMake)

2015-07-16 Thread David Cole via cmake-developers
This would best be added as a TARGETS variant of the existing http://www.cmake.org/cmake/help/v3.3/command/get_cmake_property.html command. (In my opinion...) David C. On Thu, Jul 16, 2015 at 11:42 AM, Clifford Yapp cliffy...@gmail.com wrote: On Wed, Jul 15, 2015 at 9:10 AM, Brad King

Re: [cmake-developers] Listing all targets (was: Wrapping functions in CMake)

2015-07-16 Thread Clifford Yapp
On Wed, Jul 15, 2015 at 9:10 AM, Brad King brad.k...@kitware.com wrote: On 07/10/2015 03:42 PM, Clifford Yapp wrote: On Thu, Jul 9, 2015 at 1:35 PM, Clifford Yapp cliffy...@gmail.com wrote: 2. Provide similar lists of all defined targets for the various types (e.g. CMAKE_EXECUTABLE_TARGETS,

Re: [cmake-developers] Listing all targets (was: Wrapping functions in CMake)

2015-07-15 Thread Brad King
On 07/10/2015 03:42 PM, Clifford Yapp wrote: On Thu, Jul 9, 2015 at 1:35 PM, Clifford Yapp cliffy...@gmail.com wrote: 2. Provide similar lists of all defined targets for the various types (e.g. CMAKE_EXECUTABLE_TARGETS, CMAKE_LIBRARY_TARGETS, CMAKE_CUSTOM_TARGETS). Looking into the CMake