Re: [cmake-developers] add_custom_command differences in tests

2014-02-11 Thread Steve Wilson
Thank you, that fixed the problem I was seeing. SteveW On Feb 10, 2014, at 8:28 AM, Brad King brad.k...@kitware.com wrote: On 02/07/2014 05:19 PM, Steve Wilson wrote: On Feb 7, 2014, at 3:01 PM, Brad King wrote: -DCMAKE_BUILD_TYPE=\${CTEST_CONFIGURATION_TYPE} I have tried adding that to

Re: [cmake-developers] add_custom_command differences in tests

2014-02-10 Thread Brad King
On 02/07/2014 05:19 PM, Steve Wilson wrote: On Feb 7, 2014, at 3:01 PM, Brad King wrote: -DCMAKE_BUILD_TYPE=\${CTEST_CONFIGURATION_TYPE} I have tried adding that to my test call (--build-options) but it doesn't seem to make any difference. Oops, I picked the wrong line for an example. We

Re: [cmake-developers] add_custom_command differences in tests

2014-02-07 Thread Steve Wilson
On Feb 7, 2014, at 10:14 AM, Steve Wilson ste...@wolfram.com wrote: On Feb 6, 2014, at 10:12 PM, Ben Boeckel ben.boec...@kitware.com wrote: On Thu, Feb 06, 2014 at 17:30:11 -0700, Steve Wilson wrote: I have my topic branch with the add_custom_command changes to include the CONFIG keyword

Re: [cmake-developers] add_custom_command differences in tests

2014-02-07 Thread Jean-Christophe Fillion-Robin
Agreed. Is there an issue in the tracker to document that problem ? On Fri, Feb 7, 2014 at 3:05 PM, Steve Wilson ste...@wolfram.com wrote: On Feb 7, 2014, at 10:14 AM, Steve Wilson ste...@wolfram.com wrote: On Feb 6, 2014, at 10:12 PM, Ben Boeckel ben.boec...@kitware.com wrote: On Thu,

Re: [cmake-developers] add_custom_command differences in tests

2014-02-07 Thread Brad King
On 02/07/2014 04:46 PM, Jean-Christophe Fillion-Robin wrote: I have been able to determine that the code isn’t working because it seems that when running from ctest, cmake seems to be running in a configuration-less mode. Ie CMAKE_BUILD_TYPE/CMAKE_CONFIGURATION_TYPE are not set

Re: [cmake-developers] add_custom_command differences in tests

2014-02-07 Thread Steve Wilson
On Feb 7, 2014, at 3:01 PM, Brad King brad.k...@kitware.com wrote: On 02/07/2014 04:46 PM, Jean-Christophe Fillion-Robin wrote: I have been able to determine that the code isn’t working because it seems that when running from ctest, cmake seems to be running in a configuration-less

[cmake-developers] add_custom_command differences in tests

2014-02-06 Thread Steve Wilson
I have my topic branch with the add_custom_command changes to include the CONFIG keyword working.The CMake binary produced from the build will correctly generated build systems that have custom commands with the CONFIG keyword. I’m having trouble writing tests for the changes though.

Re: [cmake-developers] add_custom_command differences in tests

2014-02-06 Thread Ben Boeckel
On Thu, Feb 06, 2014 at 17:30:11 -0700, Steve Wilson wrote: I have my topic branch with the add_custom_command changes to include the CONFIG keyword working.The CMake binary produced from the build will correctly generated build systems that have custom commands with the CONFIG keyword.