Re: [collectd] java plugin class files

2010-02-10 Thread Florian Forster
Hi Amit, On Thu, Jan 28, 2010 at 02:03:53PM +0530, Amit Gupta wrote: Today, I downloaded collectd-4.9.0 source code. However, I couldn't see the jar patch applied as yet. Here is the updated patch with respect to 4.9.0 source code. sorry, I lost track :/ In general your patch looks fine,

Re: [collectd] java plugin class files

2010-02-10 Thread Amit Gupta
On Wed, Feb 10, 2010 at 6:46 PM, Florian Forster o...@verplant.org wrote: Hi Amit, On Thu, Jan 28, 2010 at 02:03:53PM +0530, Amit Gupta wrote: Today, I downloaded collectd-4.9.0 source code. However, I couldn't see the jar patch applied as yet. Here is the updated patch with respect to

Re: [collectd] java plugin class files

2010-02-10 Thread Florian Forster
Hi Amit, On Wed, Feb 10, 2010 at 07:00:30PM +0530, Amit Gupta wrote: I am okay with these names as well. Do you want me to submit a updated patch? no, don't worry about that. It's easier to fix while applying the patch ;) Regards, —octo -- Florian octo Forster Hacker in training GnuPG:

Re: [collectd] java plugin class files

2010-02-10 Thread Florian Forster
Hi Amit, On Wed, Feb 10, 2010 at 02:35:44PM +0100, Florian Forster wrote: no, don't worry about that. It's easier to fix while applying the patch ;) I've applied your patch to the collectd-4.8 branch. I moved the creation of the .jar files to the build phase (instead of the install phase). You

Re: [collectd] java plugin class files

2010-01-28 Thread Amit Gupta
Today, I downloaded collectd-4.9.0 source code. However, I couldn't see the jar patch applied as yet. Here is the updated patch with respect to 4.9.0 source code. Let me know if there are any issues with the patch. Regards Amit On Mon, Sep 14, 2009 at 7:53 PM, Amit Gupta