[
https://issues.apache.org/jira/browse/CASSANDRA-10726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17049772#comment-17049772
]
Nihar Dudam commented on CASSANDRA-10726:
-
Thanks Jeff and Jeremiah. Seems like we are
[
https://issues.apache.org/jira/browse/CASSANDRA-10726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17049757#comment-17049757
]
Jeremiah Jordan commented on CASSANDRA-10726:
-
Not saying this patch isn’t helpful. It
[
https://issues.apache.org/jira/browse/CASSANDRA-10726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17049745#comment-17049745
]
Jeff Jirsa commented on CASSANDRA-10726:
[~jjordan]:
bq. In 3.11 you should set both
[
https://issues.apache.org/jira/browse/CASSANDRA-10726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17049591#comment-17049591
]
Nihar Dudam commented on CASSANDRA-10726:
-
@Jeremiah Thanks for the input.
Replicas are
[
https://issues.apache.org/jira/browse/CASSANDRA-10726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17049553#comment-17049553
]
Jeremiah Jordan commented on CASSANDRA-10726:
-
In 3.11 you should set both
[
https://issues.apache.org/jira/browse/CASSANDRA-10726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17049547#comment-17049547
]
Nihar Dudam commented on CASSANDRA-10726:
-
We are also very much interested in 3.11
[
https://issues.apache.org/jira/browse/CASSANDRA-10726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17044701#comment-17044701
]
Jerome BAROTIN commented on CASSANDRA-10726:
[~isaacreath] Nice work ! We are indeed
[
https://issues.apache.org/jira/browse/CASSANDRA-10726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16974101#comment-16974101
]
Sanjit Mohanty commented on CASSANDRA-10726:
[~isaacreath]: We are using C* version
[
https://issues.apache.org/jira/browse/CASSANDRA-10726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16966946#comment-16966946
]
Federico commented on CASSANDRA-10726:
--
[~isaacreath] would you? I've encountered this problem
[
https://issues.apache.org/jira/browse/CASSANDRA-10726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16824557#comment-16824557
]
Isaac Reath commented on CASSANDRA-10726:
-
I've had an issue pop up a couple of times where
[
https://issues.apache.org/jira/browse/CASSANDRA-10726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16804130#comment-16804130
]
Blake Eggleston commented on CASSANDRA-10726:
-
4.0 only I'm afraid. It's built on a
[
https://issues.apache.org/jira/browse/CASSANDRA-10726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16803747#comment-16803747
]
Mikael Svensson commented on CASSANDRA-10726:
-
Will this be backported to 3.11? I run in
[
https://issues.apache.org/jira/browse/CASSANDRA-10726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16589495#comment-16589495
]
Kurt Greaves commented on CASSANDRA-10726:
--
Great, thanks Blake. I just needed a quick fix
[
https://issues.apache.org/jira/browse/CASSANDRA-10726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16589010#comment-16589010
]
Blake Eggleston commented on CASSANDRA-10726:
-
Thanks Kurt. Opening the response in a
[
https://issues.apache.org/jira/browse/CASSANDRA-10726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16588731#comment-16588731
]
Kurt Greaves commented on CASSANDRA-10726:
--
[~bdeggleston], looks like this [broke
[
https://issues.apache.org/jira/browse/CASSANDRA-10726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16587730#comment-16587730
]
Marcus Eriksson commented on CASSANDRA-10726:
-
this lgtm, +1
> Read repair inserts
[
https://issues.apache.org/jira/browse/CASSANDRA-10726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16585612#comment-16585612
]
Alex Petrov commented on CASSANDRA-10726:
-
Thank you!
A couple more nits:
*
[
https://issues.apache.org/jira/browse/CASSANDRA-10726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16581234#comment-16581234
]
Blake Eggleston commented on CASSANDRA-10726:
-
Review changes pushed to branch with a
[
https://issues.apache.org/jira/browse/CASSANDRA-10726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16574643#comment-16574643
]
Alex Petrov commented on CASSANDRA-10726:
-
It seems that there still might be a problem with
[
https://issues.apache.org/jira/browse/CASSANDRA-10726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16531020#comment-16531020
]
Marcus Eriksson commented on CASSANDRA-10726:
-
this looks good to me in general, a few
[
https://issues.apache.org/jira/browse/CASSANDRA-10726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16525356#comment-16525356
]
ASF GitHub Bot commented on CASSANDRA-10726:
Github user bdeggleston commented on the
[
https://issues.apache.org/jira/browse/CASSANDRA-10726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16525324#comment-16525324
]
ASF GitHub Bot commented on CASSANDRA-10726:
Github user tedcarroll commented on a diff
[
https://issues.apache.org/jira/browse/CASSANDRA-10726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16525311#comment-16525311
]
ASF GitHub Bot commented on CASSANDRA-10726:
Github user tedcarroll commented on the
[
https://issues.apache.org/jira/browse/CASSANDRA-10726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476556#comment-16476556
]
Blake Eggleston commented on CASSANDRA-10726:
-
I reworked the patch after the recent read
[
https://issues.apache.org/jira/browse/CASSANDRA-10726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16257697#comment-16257697
]
Blake Eggleston commented on CASSANDRA-10726:
-
I opened CASSANDRA-14058 for the refactor
[
https://issues.apache.org/jira/browse/CASSANDRA-10726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16234071#comment-16234071
]
Jeff Jirsa commented on CASSANDRA-10726:
Agree as well - keep the default as-is, but I like
[
https://issues.apache.org/jira/browse/CASSANDRA-10726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16234058#comment-16234058
]
Jeremiah Jordan commented on CASSANDRA-10726:
-
{quote}And I'm leaning towards these three
[
https://issues.apache.org/jira/browse/CASSANDRA-10726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16220351#comment-16220351
]
Aleksey Yeschenko commented on CASSANDRA-10726:
---
I don't agree that it's *required*,
[
https://issues.apache.org/jira/browse/CASSANDRA-10726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219759#comment-16219759
]
Richard Low commented on CASSANDRA-10726:
-
Background read repair is quite different. This
[
https://issues.apache.org/jira/browse/CASSANDRA-10726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219254#comment-16219254
]
Aleksey Yeschenko commented on CASSANDRA-10726:
---
I've been thinking more about this, in
[
https://issues.apache.org/jira/browse/CASSANDRA-10726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16130504#comment-16130504
]
Xiaolong Jiang commented on CASSANDRA-10726:
[~iamaleksey] Because I don't know how to do
[
https://issues.apache.org/jira/browse/CASSANDRA-10726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16130320#comment-16130320
]
Aleksey Yeschenko commented on CASSANDRA-10726:
---
bq. I wound not refactor the whole
[
https://issues.apache.org/jira/browse/CASSANDRA-10726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16129843#comment-16129843
]
Xiaolong Jiang commented on CASSANDRA-10726:
[~krummas] we don't want to share results.
[
https://issues.apache.org/jira/browse/CASSANDRA-10726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16128848#comment-16128848
]
Aleksey Yeschenko commented on CASSANDRA-10726:
---
Not a fan of what the patch does to
[
https://issues.apache.org/jira/browse/CASSANDRA-10726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16128832#comment-16128832
]
Marcus Eriksson commented on CASSANDRA-10726:
-
Your patch fixes the issue, but don't we
[
https://issues.apache.org/jira/browse/CASSANDRA-10726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16126694#comment-16126694
]
Xiaolong Jiang commented on CASSANDRA-10726:
[~krummas] this is the patch to fix CME
[
https://issues.apache.org/jira/browse/CASSANDRA-10726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16126376#comment-16126376
]
Xiaolong Jiang commented on CASSANDRA-10726:
[~krummas] After digging into this, I think
[
https://issues.apache.org/jira/browse/CASSANDRA-10726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16125586#comment-16125586
]
Marcus Eriksson commented on CASSANDRA-10726:
-
[~xiaolong...@gmail.com] seems we are
[
https://issues.apache.org/jira/browse/CASSANDRA-10726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123604#comment-16123604
]
Xiaolong Jiang commented on CASSANDRA-10726:
[~krummas] Thanks for the review. Yes, your
[
https://issues.apache.org/jira/browse/CASSANDRA-10726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123171#comment-16123171
]
Marcus Eriksson commented on CASSANDRA-10726:
-
btw, I think this should go to 4.0 only,
[
https://issues.apache.org/jira/browse/CASSANDRA-10726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123166#comment-16123166
]
Marcus Eriksson commented on CASSANDRA-10726:
-
This LGTM, pushed a branch with some small
[
https://issues.apache.org/jira/browse/CASSANDRA-10726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16078474#comment-16078474
]
Xiaolong Jiang commented on CASSANDRA-10726:
[~bdeggleston]I made a few changes based on
[
https://issues.apache.org/jira/browse/CASSANDRA-10726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16077257#comment-16077257
]
Xiaolong Jiang commented on CASSANDRA-10726:
1. I will change isQuorum to
[
https://issues.apache.org/jira/browse/CASSANDRA-10726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16077236#comment-16077236
]
Xiaolong Jiang commented on CASSANDRA-10726:
[~bdeggleston]Thanks for taking the time to
[
https://issues.apache.org/jira/browse/CASSANDRA-10726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16068995#comment-16068995
]
Blake Eggleston commented on CASSANDRA-10726:
-
Sorry for the delay getting to this. I
[
https://issues.apache.org/jira/browse/CASSANDRA-10726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16006704#comment-16006704
]
Xiaolong Jiang commented on CASSANDRA-10726:
regarding distinctHostNum:
/**
*
[
https://issues.apache.org/jira/browse/CASSANDRA-10726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16006701#comment-16006701
]
Xiaolong Jiang commented on CASSANDRA-10726:
regarding the response snapshot count:
[
https://issues.apache.org/jira/browse/CASSANDRA-10726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15925260#comment-15925260
]
Jason Brown commented on CASSANDRA-10726:
-
[~xiaolong...@gmail.com] Thanks for the comments
[
https://issues.apache.org/jira/browse/CASSANDRA-10726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15923200#comment-15923200
]
Xiaolong Jiang commented on CASSANDRA-10726:
The patch is trying to do 2 things:
1.
[
https://issues.apache.org/jira/browse/CASSANDRA-10726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15872885#comment-15872885
]
Xiaolong Jiang commented on CASSANDRA-10726:
[~jasobrown] Patch is ready
[
https://issues.apache.org/jira/browse/CASSANDRA-10726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15872879#comment-15872879
]
ASF GitHub Bot commented on CASSANDRA-10726:
GitHub user xiaolong302 opened a pull
[
https://issues.apache.org/jira/browse/CASSANDRA-10726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15658728#comment-15658728
]
Xiaolong Jiang commented on CASSANDRA-10726:
[~kohlisankalp]Can you assign to me? [~rlow]
[
https://issues.apache.org/jira/browse/CASSANDRA-10726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15394236#comment-15394236
]
sankalp kohli commented on CASSANDRA-10726:
---
Assigned to [~nachiket_patil]
> Read repair
[
https://issues.apache.org/jira/browse/CASSANDRA-10726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15181364#comment-15181364
]
Jonathan Ellis commented on CASSANDRA-10726:
Yes. And if two of the nodes agree on the
[
https://issues.apache.org/jira/browse/CASSANDRA-10726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15181335#comment-15181335
]
Richard Low commented on CASSANDRA-10726:
-
What do you think [~jbellis] [~slebresne]?
> Read
[
https://issues.apache.org/jira/browse/CASSANDRA-10726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15122431#comment-15122431
]
Richard Low commented on CASSANDRA-10726:
-
Actually, isn't the real problem here that
[
https://issues.apache.org/jira/browse/CASSANDRA-10726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15093872#comment-15093872
]
Sylvain Lebresne commented on CASSANDRA-10726:
--
bq. Would a reasonable half way house be
[
https://issues.apache.org/jira/browse/CASSANDRA-10726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15093975#comment-15093975
]
Jonathan Ellis commented on CASSANDRA-10726:
I can live with the -D approach.
> Read
[
https://issues.apache.org/jira/browse/CASSANDRA-10726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15092081#comment-15092081
]
Brandon Williams commented on CASSANDRA-10726:
--
I understand your sentiment, but maybe a
[
https://issues.apache.org/jira/browse/CASSANDRA-10726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15092135#comment-15092135
]
Aleksey Yeschenko commented on CASSANDRA-10726:
---
bq. I understand your sentiment, but
[
https://issues.apache.org/jira/browse/CASSANDRA-10726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15092150#comment-15092150
]
Richard Low commented on CASSANDRA-10726:
-
It would lose a guarantee (which admittedly I
[
https://issues.apache.org/jira/browse/CASSANDRA-10726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15092013#comment-15092013
]
Jonathan Ellis commented on CASSANDRA-10726:
For the last, we already have options for
[
https://issues.apache.org/jira/browse/CASSANDRA-10726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15081936#comment-15081936
]
Brandon Williams commented on CASSANDRA-10726:
--
Let's make it configurable for a)
[
https://issues.apache.org/jira/browse/CASSANDRA-10726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15081929#comment-15081929
]
Richard Low commented on CASSANDRA-10726:
-
+1 on the option to disable.
> Read repair
[
https://issues.apache.org/jira/browse/CASSANDRA-10726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15068248#comment-15068248
]
Jonathan Ellis commented on CASSANDRA-10726:
Seeing reads "go backwards in time" is one
[
https://issues.apache.org/jira/browse/CASSANDRA-10726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15062414#comment-15062414
]
Aleksey Yeschenko commented on CASSANDRA-10726:
---
Need to think about it more, but I
[
https://issues.apache.org/jira/browse/CASSANDRA-10726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15059773#comment-15059773
]
Sylvain Lebresne commented on CASSANDRA-10726:
--
The comment in the code is not terribly
[
https://issues.apache.org/jira/browse/CASSANDRA-10726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15058496#comment-15058496
]
sankalp kohli commented on CASSANDRA-10726:
---
cc [~brandon.williams] [~slebresne]
What do
[
https://issues.apache.org/jira/browse/CASSANDRA-10726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15058502#comment-15058502
]
Brandon Williams commented on CASSANDRA-10726:
--
Blocking foreground repair basically
[
https://issues.apache.org/jira/browse/CASSANDRA-10726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15058576#comment-15058576
]
Richard Low commented on CASSANDRA-10726:
-
How does it violate consistency? The replica was
70 matches
Mail list logo