[
https://issues.apache.org/jira/browse/CASSANDRA-13265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16197193#comment-16197193
]
ASF GitHub Bot commented on CASSANDRA-13265:
Github user christian-esken commented on the
[
https://issues.apache.org/jira/browse/CASSANDRA-13265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16197194#comment-16197194
]
ASF GitHub Bot commented on CASSANDRA-13265:
Github user christian-esken closed the pull
[
https://issues.apache.org/jira/browse/CASSANDRA-13265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16197195#comment-16197195
]
Christian Esken commented on CASSANDRA-13265:
-
PR closed:
[
https://issues.apache.org/jira/browse/CASSANDRA-13265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195765#comment-16195765
]
ASF GitHub Bot commented on CASSANDRA-13265:
Github user jeffjirsa commented on the
[
https://issues.apache.org/jira/browse/CASSANDRA-13265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15998310#comment-15998310
]
Ariel Weisberg commented on CASSANDRA-13265:
I'm sorry :-( I'll try to get a more
[
https://issues.apache.org/jira/browse/CASSANDRA-13265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15998277#comment-15998277
]
Christian Esken commented on CASSANDRA-13265:
-
It is fine, I do not use 2.2. I was just
[
https://issues.apache.org/jira/browse/CASSANDRA-13265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15996951#comment-15996951
]
Ariel Weisberg commented on CASSANDRA-13265:
I decided to start from 3.0 because 2.2 is
[
https://issues.apache.org/jira/browse/CASSANDRA-13265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15996322#comment-15996322
]
Christian Esken commented on CASSANDRA-13265:
-
Thanks. I have seen your commit in three
[
https://issues.apache.org/jira/browse/CASSANDRA-13265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15994820#comment-15994820
]
Christian Esken commented on CASSANDRA-13265:
-
Done. Squashed and pushed.
I also
[
https://issues.apache.org/jira/browse/CASSANDRA-13265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15991146#comment-15991146
]
Ariel Weisberg commented on CASSANDRA-13265:
So the dtests failing on the branch don't
[
https://issues.apache.org/jira/browse/CASSANDRA-13265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15986786#comment-15986786
]
Ariel Weisberg commented on CASSANDRA-13265:
You don't need to get all the tests passing.
[
https://issues.apache.org/jira/browse/CASSANDRA-13265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15986426#comment-15986426
]
Christian Esken commented on CASSANDRA-13265:
-
I am fixing the branches, while you work
[
https://issues.apache.org/jira/browse/CASSANDRA-13265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985008#comment-15985008
]
Ariel Weisberg commented on CASSANDRA-13265:
I think the stress-test target just doesn't
[
https://issues.apache.org/jira/browse/CASSANDRA-13265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15981236#comment-15981236
]
Christian Esken commented on CASSANDRA-13265:
-
First here is the summary: The tests work
[
https://issues.apache.org/jira/browse/CASSANDRA-13265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978748#comment-15978748
]
Christian Esken commented on CASSANDRA-13265:
-
I pulled the changes, fixed the
[
https://issues.apache.org/jira/browse/CASSANDRA-13265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978730#comment-15978730
]
Christian Esken commented on CASSANDRA-13265:
-
Hmm, I rebased on 2.2 and trunk. I am
[
https://issues.apache.org/jira/browse/CASSANDRA-13265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15977067#comment-15977067
]
Ariel Weisberg commented on CASSANDRA-13265:
The branches are out of date. 3.11 ones
[
https://issues.apache.org/jira/browse/CASSANDRA-13265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15976867#comment-15976867
]
Ariel Weisberg commented on CASSANDRA-13265:
That circle.yml is broken. For instance
[
https://issues.apache.org/jira/browse/CASSANDRA-13265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15976279#comment-15976279
]
Christian Esken commented on CASSANDRA-13265:
-
Unfortunately some test failed, not
[
https://issues.apache.org/jira/browse/CASSANDRA-13265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15974885#comment-15974885
]
Christian Esken commented on CASSANDRA-13265:
-
No problem. I was away for Easter, so I
[
https://issues.apache.org/jira/browse/CASSANDRA-13265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15974671#comment-15974671
]
Ariel Weisberg commented on CASSANDRA-13265:
Sorry I just had a really busy week last
[
https://issues.apache.org/jira/browse/CASSANDRA-13265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15974590#comment-15974590
]
Christian Esken commented on CASSANDRA-13265:
-
bq. For CHANGES.TXT the entry should go at
[
https://issues.apache.org/jira/browse/CASSANDRA-13265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15967870#comment-15967870
]
Ariel Weisberg commented on CASSANDRA-13265:
Nevermind I'll run them. I have to anyways
[
https://issues.apache.org/jira/browse/CASSANDRA-13265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15967857#comment-15967857
]
Ariel Weisberg commented on CASSANDRA-13265:
OK, don't forget to get set up with CircleCI
[
https://issues.apache.org/jira/browse/CASSANDRA-13265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15967484#comment-15967484
]
Christian Esken commented on CASSANDRA-13265:
-
There were different reasons why the build
[
https://issues.apache.org/jira/browse/CASSANDRA-13265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15964943#comment-15964943
]
Ariel Weisberg commented on CASSANDRA-13265:
There seem to be some build issues in
[
https://issues.apache.org/jira/browse/CASSANDRA-13265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15964613#comment-15964613
]
Ariel Weisberg commented on CASSANDRA-13265:
Squashing is preferred, but I like to keep
[
https://issues.apache.org/jira/browse/CASSANDRA-13265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15964522#comment-15964522
]
Christian Esken commented on CASSANDRA-13265:
-
Done. 2 organizational topics left:
I
[
https://issues.apache.org/jira/browse/CASSANDRA-13265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15963230#comment-15963230
]
Ariel Weisberg commented on CASSANDRA-13265:
Great! Most regular contributors are linking
[
https://issues.apache.org/jira/browse/CASSANDRA-13265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15963095#comment-15963095
]
Christian Esken commented on CASSANDRA-13265:
-
Done. My highest priority is the 3.0
[
https://issues.apache.org/jira/browse/CASSANDRA-13265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15928300#comment-15928300
]
Ariel Weisberg commented on CASSANDRA-13265:
Great! Almost there.
* [Use
[
https://issues.apache.org/jira/browse/CASSANDRA-13265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15926348#comment-15926348
]
Christian Esken commented on CASSANDRA-13265:
-
bq. I still think it's a good idea to
[
https://issues.apache.org/jira/browse/CASSANDRA-13265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15926015#comment-15926015
]
Ariel Weisberg commented on CASSANDRA-13265:
bq. I see. I thought it would just clutter
[
https://issues.apache.org/jira/browse/CASSANDRA-13265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15925815#comment-15925815
]
Christian Esken commented on CASSANDRA-13265:
-
bq. it's very low effort to add a property
[
https://issues.apache.org/jira/browse/CASSANDRA-13265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15924658#comment-15924658
]
Ariel Weisberg commented on CASSANDRA-13265:
bq. I still think it's a good idea to avoid
[
https://issues.apache.org/jira/browse/CASSANDRA-13265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15924135#comment-15924135
]
Christian Esken commented on CASSANDRA-13265:
-
Marking off feedback:
- (/) A smaller
[
https://issues.apache.org/jira/browse/CASSANDRA-13265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15923915#comment-15923915
]
Christian Esken commented on CASSANDRA-13265:
-
bq. This is not quite correct you can't
[
https://issues.apache.org/jira/browse/CASSANDRA-13265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15908545#comment-15908545
]
Ariel Weisberg commented on CASSANDRA-13265:
The right way to do it is create a branch
[
https://issues.apache.org/jira/browse/CASSANDRA-13265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15907493#comment-15907493
]
Christian Esken commented on CASSANDRA-13265:
-
The change is now finished, including
[
https://issues.apache.org/jira/browse/CASSANDRA-13265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15905409#comment-15905409
]
Christian Esken commented on CASSANDRA-13265:
-
I committed the change containing the
[
https://issues.apache.org/jira/browse/CASSANDRA-13265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15904949#comment-15904949
]
Christian Esken commented on CASSANDRA-13265:
-
I am nearly done with the configuration,
[
https://issues.apache.org/jira/browse/CASSANDRA-13265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15901495#comment-15901495
]
Christian Esken commented on CASSANDRA-13265:
-
I pushed the changes noted in the former
[
https://issues.apache.org/jira/browse/CASSANDRA-13265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15901414#comment-15901414
]
Christian Esken commented on CASSANDRA-13265:
-
I will update the status while working on
[
https://issues.apache.org/jira/browse/CASSANDRA-13265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15901047#comment-15901047
]
Christian Esken commented on CASSANDRA-13265:
-
bq. It should include drained messages as
[
https://issues.apache.org/jira/browse/CASSANDRA-13265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1595#comment-1595
]
Ariel Weisberg commented on CASSANDRA-13265:
Awesome.
* [This needs to be configurable
[
https://issues.apache.org/jira/browse/CASSANDRA-13265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15899773#comment-15899773
]
Christian Esken commented on CASSANDRA-13265:
-
I added three changes:
- Implemented unit
[
https://issues.apache.org/jira/browse/CASSANDRA-13265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15898266#comment-15898266
]
Jason Brown commented on CASSANDRA-13265:
-
bq. we were supposed to mark those as dropped
We
[
https://issues.apache.org/jira/browse/CASSANDRA-13265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15898249#comment-15898249
]
Ariel Weisberg commented on CASSANDRA-13265:
I think you are correct that we were
[
https://issues.apache.org/jira/browse/CASSANDRA-13265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15897641#comment-15897641
]
Christian Esken commented on CASSANDRA-13265:
-
I have one question about a code fragment.
[
https://issues.apache.org/jira/browse/CASSANDRA-13265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15897121#comment-15897121
]
Christian Esken commented on CASSANDRA-13265:
-
I was already looking into doing a unit
[
https://issues.apache.org/jira/browse/CASSANDRA-13265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15894783#comment-15894783
]
Jason Brown commented on CASSANDRA-13265:
-
I'm +1 on the ticket, but [~aweisberg] should also
51 matches
Mail list logo