[
https://issues.apache.org/jira/browse/CASSANDRA-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16154249#comment-16154249
]
Mick Semb Wever commented on CASSANDRA-13418:
-
thanks for the patch. is going to make a
[
https://issues.apache.org/jira/browse/CASSANDRA-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16153498#comment-16153498
]
Romain GERARD commented on CASSANDRA-13418:
---
Champagne !
Thanks for the commitment :)
>
[
https://issues.apache.org/jira/browse/CASSANDRA-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16151196#comment-16151196
]
mck commented on CASSANDRA-13418:
-
{quote}P.s:
[
https://issues.apache.org/jira/browse/CASSANDRA-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16150559#comment-16150559
]
Romain GERARD commented on CASSANDRA-13418:
---
Don't worry [~mck], I am currently working
[
https://issues.apache.org/jira/browse/CASSANDRA-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16150446#comment-16150446
]
mck commented on CASSANDRA-13418:
-
Updated:
|| branch || testall || dtest ||
|
[
https://issues.apache.org/jira/browse/CASSANDRA-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16150409#comment-16150409
]
mck commented on CASSANDRA-13418:
-
[~rgerard], i failed to see your last comment til now.
I've
[
https://issues.apache.org/jira/browse/CASSANDRA-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16150175#comment-16150175
]
Marcus Eriksson commented on CASSANDRA-13418:
-
A dtest that makes sure that we drop
[
https://issues.apache.org/jira/browse/CASSANDRA-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16150173#comment-16150173
]
Romain GERARD commented on CASSANDRA-13418:
---
Will change code style and the protected to
[
https://issues.apache.org/jira/browse/CASSANDRA-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16148879#comment-16148879
]
Marcus Eriksson commented on CASSANDRA-13418:
-
I had a quick read through and I have a
[
https://issues.apache.org/jira/browse/CASSANDRA-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16148862#comment-16148862
]
Romain GERARD commented on CASSANDRA-13418:
---
+1
> Allow TWCS to ignore overlaps when
[
https://issues.apache.org/jira/browse/CASSANDRA-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16148739#comment-16148739
]
mck commented on CASSANDRA-13418:
-
Both patches are updated, with the warning log removed. The links
[
https://issues.apache.org/jira/browse/CASSANDRA-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16148606#comment-16148606
]
Romain GERARD commented on CASSANDRA-13418:
---
{quote}Shall I just remove the log warning
[
https://issues.apache.org/jira/browse/CASSANDRA-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16147112#comment-16147112
]
mck commented on CASSANDRA-13418:
-
[~KurtG], thanks for the two use cases write up. at least it's
[
https://issues.apache.org/jira/browse/CASSANDRA-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16146693#comment-16146693
]
mck commented on CASSANDRA-13418:
-
Am working on docs… (i think i will intentionally only add doc
[
https://issues.apache.org/jira/browse/CASSANDRA-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16146634#comment-16146634
]
Kurt Greaves commented on CASSANDRA-13418:
--
Yeah more want to document the implications for
[
https://issues.apache.org/jira/browse/CASSANDRA-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144901#comment-16144901
]
Romain GERARD commented on CASSANDRA-13418:
---
2. only enabling
[
https://issues.apache.org/jira/browse/CASSANDRA-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144660#comment-16144660
]
Kurt Greaves commented on CASSANDRA-13418:
--
>Watchers, feel free to jump on the question
May
[
https://issues.apache.org/jira/browse/CASSANDRA-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16143749#comment-16143749
]
Marcus Eriksson commented on CASSANDRA-13418:
-
bq. N.B: I tried to apply the syle guide
[
https://issues.apache.org/jira/browse/CASSANDRA-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16143548#comment-16143548
]
Romain GERARD commented on CASSANDRA-13418:
---
Point noted.
My only issue with putting a log
[
https://issues.apache.org/jira/browse/CASSANDRA-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16142240#comment-16142240
]
mck commented on CASSANDRA-13418:
-
{quote}N.B: I tried to apply the syle guide found in
[
https://issues.apache.org/jira/browse/CASSANDRA-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16141425#comment-16141425
]
Romain GERARD commented on CASSANDRA-13418:
---
I am at peace with that :)
> Allow TWCS to
[
https://issues.apache.org/jira/browse/CASSANDRA-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16141130#comment-16141130
]
mck commented on CASSANDRA-13418:
-
{quote}is this bad new ?
[
https://issues.apache.org/jira/browse/CASSANDRA-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16140505#comment-16140505
]
Romain GERARD commented on CASSANDRA-13418:
---
is this bad new ?
[
https://issues.apache.org/jira/browse/CASSANDRA-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16139378#comment-16139378
]
mck commented on CASSANDRA-13418:
-
[~rgerard]'s patch, again (a35b9e8):
|| branch || testall ||
[
https://issues.apache.org/jira/browse/CASSANDRA-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138221#comment-16138221
]
Romain GERARD commented on CASSANDRA-13418:
---
{quote}I think so yes. Not because it's my
[
https://issues.apache.org/jira/browse/CASSANDRA-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137722#comment-16137722
]
mck commented on CASSANDRA-13418:
-
{quote}I can remove
[
https://issues.apache.org/jira/browse/CASSANDRA-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16136964#comment-16136964
]
Romain GERARD commented on CASSANDRA-13418:
---
Do you have in mind any test that should be
[
https://issues.apache.org/jira/browse/CASSANDRA-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16136652#comment-16136652
]
Romain GERARD commented on CASSANDRA-13418:
---
New version here
[
https://issues.apache.org/jira/browse/CASSANDRA-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16136544#comment-16136544
]
Marcus Eriksson commented on CASSANDRA-13418:
-
bq. I enable uncheckedTombstoneCompaction
[
https://issues.apache.org/jira/browse/CASSANDRA-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16135748#comment-16135748
]
mck commented on CASSANDRA-13418:
-
{quote}And also as the parent function already use a mutable
[
https://issues.apache.org/jira/browse/CASSANDRA-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16135283#comment-16135283
]
Romain GERARD commented on CASSANDRA-13418:
---
Initial review comments:
* CHANGES.txt needs
[
https://issues.apache.org/jira/browse/CASSANDRA-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16135028#comment-16135028
]
mck commented on CASSANDRA-13418:
-
[~rgerard],
Initial review comments:
- {{CHANGES.txt}} needs a
[
https://issues.apache.org/jira/browse/CASSANDRA-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16134638#comment-16134638
]
mck commented on CASSANDRA-13418:
-
[~rgerard]'s patch:
|| branch || testall || dtest ||
|
[
https://issues.apache.org/jira/browse/CASSANDRA-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16130152#comment-16130152
]
Romain GERARD commented on CASSANDRA-13418:
---
Hi,
I am back with a new proposition
[
https://issues.apache.org/jira/browse/CASSANDRA-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16091218#comment-16091218
]
Romain GERARD commented on CASSANDRA-13418:
---
Yes I am still looking forward to test the
[
https://issues.apache.org/jira/browse/CASSANDRA-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16091082#comment-16091082
]
mck commented on CASSANDRA-13418:
-
[~rgerard], are you looking to add any unit tests to [~krummas]'s
[
https://issues.apache.org/jira/browse/CASSANDRA-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16074910#comment-16074910
]
Romain GERARD commented on CASSANDRA-13418:
---
Agreed for the unit tests
> Allow TWCS to
[
https://issues.apache.org/jira/browse/CASSANDRA-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16074593#comment-16074593
]
Marcus Eriksson commented on CASSANDRA-13418:
-
this needs unit tests before getting
[
https://issues.apache.org/jira/browse/CASSANDRA-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16074581#comment-16074581
]
Romain GERARD commented on CASSANDRA-13418:
---
Seems better and will try it out.
I will keep
[
https://issues.apache.org/jira/browse/CASSANDRA-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16074565#comment-16074565
]
Marcus Eriksson commented on CASSANDRA-13418:
-
how about something like this?
[
https://issues.apache.org/jira/browse/CASSANDRA-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16074408#comment-16074408
]
Romain GERARD commented on CASSANDRA-13418:
---
Sorry about the bad name :(
So here is the
[
https://issues.apache.org/jira/browse/CASSANDRA-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16074381#comment-16074381
]
Marcus Eriksson commented on CASSANDRA-13418:
-
[~rgerard] you seem to be mentioning the
[
https://issues.apache.org/jira/browse/CASSANDRA-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16074357#comment-16074357
]
Romain GERARD commented on CASSANDRA-13418:
---
Gentle bump, [~markerickson-wk]
> Allow TWCS
[
https://issues.apache.org/jira/browse/CASSANDRA-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16066894#comment-16066894
]
Romain GERARD commented on CASSANDRA-13418:
---
Hi back Marcus,
So I took into account your
[
https://issues.apache.org/jira/browse/CASSANDRA-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16062629#comment-16062629
]
Romain GERARD commented on CASSANDRA-13418:
---
Will have a look at it this week
[
https://issues.apache.org/jira/browse/CASSANDRA-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057490#comment-16057490
]
Marcus Eriksson commented on CASSANDRA-13418:
-
Had a (too?) quick read-through
Would it
[
https://issues.apache.org/jira/browse/CASSANDRA-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057392#comment-16057392
]
Corentin Chary commented on CASSANDRA-13418:
Latest version of the patch works as it
[
https://issues.apache.org/jira/browse/CASSANDRA-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16055289#comment-16055289
]
Romain GERARD commented on CASSANDRA-13418:
---
Hello Jonathan, thanks to keep us up to date
[
https://issues.apache.org/jira/browse/CASSANDRA-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16041465#comment-16041465
]
Jonathan Owens commented on CASSANDRA-13418:
I also should mention that our TWCS
[
https://issues.apache.org/jira/browse/CASSANDRA-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16037380#comment-16037380
]
Jonathan Owens commented on CASSANDRA-13418:
We're chasing what may be a gotcha in our
[
https://issues.apache.org/jira/browse/CASSANDRA-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16011913#comment-16011913
]
Romain GERARD commented on CASSANDRA-13418:
---
Any advices to take a next step forward ?
>
[
https://issues.apache.org/jira/browse/CASSANDRA-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16000735#comment-16000735
]
Romain GERARD commented on CASSANDRA-13418:
---
I am trying things out by merging your ideas
[
https://issues.apache.org/jira/browse/CASSANDRA-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15988846#comment-15988846
]
Jeff Jirsa commented on CASSANDRA-13418:
I think the path forward is this:
Let's create a
[
https://issues.apache.org/jira/browse/CASSANDRA-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15988836#comment-15988836
]
Nate McCall commented on CASSANDRA-13418:
-
I would like to see an append-only optimization as
[
https://issues.apache.org/jira/browse/CASSANDRA-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15988490#comment-15988490
]
Corentin Chary commented on CASSANDRA-13418:
I agree that fixing CASSANDRA-13418 would be
[
https://issues.apache.org/jira/browse/CASSANDRA-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15987304#comment-15987304
]
Jonathan Owens commented on CASSANDRA-13418:
We did exactly this about a year ago for our
[
https://issues.apache.org/jira/browse/CASSANDRA-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15987267#comment-15987267
]
Jeff Jirsa commented on CASSANDRA-13418:
I think Marcus' concern is valid, but having run
[
https://issues.apache.org/jira/browse/CASSANDRA-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15986853#comment-15986853
]
Jon Haddad commented on CASSANDRA-13418:
I get the desire to guard users to not shoot
[
https://issues.apache.org/jira/browse/CASSANDRA-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15984600#comment-15984600
]
Corentin Chary commented on CASSANDRA-13418:
[~krummas]: good point, CASSANDRA-10496
[
https://issues.apache.org/jira/browse/CASSANDRA-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15984564#comment-15984564
]
Marcus Eriksson commented on CASSANDRA-13418:
-
I think we should instead fix the actual
[
https://issues.apache.org/jira/browse/CASSANDRA-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15984514#comment-15984514
]
Alexander Dejanovski commented on CASSANDRA-13418:
--
[~iksaif], I have a similar
[
https://issues.apache.org/jira/browse/CASSANDRA-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15984354#comment-15984354
]
Corentin Chary commented on CASSANDRA-13418:
Trying to go forward, [~jjirsa],
[
https://issues.apache.org/jira/browse/CASSANDRA-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15974996#comment-15974996
]
Jeff Jirsa commented on CASSANDRA-13418:
[~iksaif] - this isn't a review, but at first glance
[
https://issues.apache.org/jira/browse/CASSANDRA-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15974024#comment-15974024
]
Corentin Chary commented on CASSANDRA-13418:
[~rgerard]: No it should certainly not be
[
https://issues.apache.org/jira/browse/CASSANDRA-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15973651#comment-15973651
]
Romain GERARD commented on CASSANDRA-13418:
---
I haven't had time to check my own questions
[
https://issues.apache.org/jira/browse/CASSANDRA-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15972898#comment-15972898
]
Corentin Chary commented on CASSANDRA-13418:
Here is an attempt at a patch:
[
https://issues.apache.org/jira/browse/CASSANDRA-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15962212#comment-15962212
]
Corentin Chary commented on CASSANDRA-13418:
If I understand things correctly here, the
[
https://issues.apache.org/jira/browse/CASSANDRA-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15962188#comment-15962188
]
Marcus Eriksson commented on CASSANDRA-13418:
-
I'll think more about this, but generally
[
https://issues.apache.org/jira/browse/CASSANDRA-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15962183#comment-15962183
]
Corentin Chary commented on CASSANDRA-13418:
AFAIK provide_overlapping_tombstones is a
[
https://issues.apache.org/jira/browse/CASSANDRA-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15961710#comment-15961710
]
Jeff Jirsa commented on CASSANDRA-13418:
{quote}
What do you think about
[
https://issues.apache.org/jira/browse/CASSANDRA-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15961662#comment-15961662
]
Jeff Jirsa commented on CASSANDRA-13418:
unchecked_tombstone_compaction and
71 matches
Mail list logo
