[
https://issues.apache.org/jira/browse/CASSANDRA-6809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14556583#comment-14556583
]
Alan Boudreault commented on CASSANDRA-6809:
I did multiple tests locally
[
https://issues.apache.org/jira/browse/CASSANDRA-6809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14379649#comment-14379649
]
Branimir Lambov commented on CASSANDRA-6809:
Fix-up and rename
[
https://issues.apache.org/jira/browse/CASSANDRA-6809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14378865#comment-14378865
]
Ariel Weisberg commented on CASSANDRA-6809:
---
I did +1 the final set of
[
https://issues.apache.org/jira/browse/CASSANDRA-6809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14378857#comment-14378857
]
Benedict commented on CASSANDRA-6809:
-
Could I just confirm that [~aweisberg] has
[
https://issues.apache.org/jira/browse/CASSANDRA-6809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14378875#comment-14378875
]
Benedict commented on CASSANDRA-6809:
-
bq. I _would still_ be +1
is too
[
https://issues.apache.org/jira/browse/CASSANDRA-6809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14375856#comment-14375856
]
Aleksey Yeschenko commented on CASSANDRA-6809:
--
+1 to committing as is.
[
https://issues.apache.org/jira/browse/CASSANDRA-6809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14375918#comment-14375918
]
Alan Boudreault commented on CASSANDRA-6809:
[~benedict] Adding a note to
[
https://issues.apache.org/jira/browse/CASSANDRA-6809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14366930#comment-14366930
]
Benedict commented on CASSANDRA-6809:
-
I wouldn't hold up commit over that, no.
[
https://issues.apache.org/jira/browse/CASSANDRA-6809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14365867#comment-14365867
]
Ariel Weisberg commented on CASSANDRA-6809:
---
I think what Benedict is
[
https://issues.apache.org/jira/browse/CASSANDRA-6809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14360969#comment-14360969
]
Ariel Weisberg commented on CASSANDRA-6809:
---
I don't think it works as a
[
https://issues.apache.org/jira/browse/CASSANDRA-6809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14360980#comment-14360980
]
Benedict commented on CASSANDRA-6809:
-
The idea of making it a hard limit instead
[
https://issues.apache.org/jira/browse/CASSANDRA-6809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14360367#comment-14360367
]
Benedict commented on CASSANDRA-6809:
-
bq. Good catch, the number of segments
[
https://issues.apache.org/jira/browse/CASSANDRA-6809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14360347#comment-14360347
]
Branimir Lambov commented on CASSANDRA-6809:
Rebased and updated
[
https://issues.apache.org/jira/browse/CASSANDRA-6809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14355743#comment-14355743
]
Ariel Weisberg commented on CASSANDRA-6809:
---
I really like what you did with
[
https://issues.apache.org/jira/browse/CASSANDRA-6809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14340607#comment-14340607
]
Branimir Lambov commented on CASSANDRA-6809:
New version uploaded to [the
[
https://issues.apache.org/jira/browse/CASSANDRA-6809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14313299#comment-14313299
]
Ariel Weisberg commented on CASSANDRA-6809:
---
* In cassandra.yaml, for
[
https://issues.apache.org/jira/browse/CASSANDRA-6809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14303666#comment-14303666
]
Alan Boudreault commented on CASSANDRA-6809:
Great. Thanks.
Compressed
[
https://issues.apache.org/jira/browse/CASSANDRA-6809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14303660#comment-14303660
]
Branimir Lambov commented on CASSANDRA-6809:
Yes, this is the expected
[
https://issues.apache.org/jira/browse/CASSANDRA-6809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14303633#comment-14303633
]
Alan Boudreault commented on CASSANDRA-6809:
[~barnie] Can you confirm if
[
https://issues.apache.org/jira/browse/CASSANDRA-6809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14298891#comment-14298891
]
Branimir Lambov commented on CASSANDRA-6809:
Added a stress test
[
https://issues.apache.org/jira/browse/CASSANDRA-6809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14293420#comment-14293420
]
Branimir Lambov commented on CASSANDRA-6809:
Rebased and applied review
[
https://issues.apache.org/jira/browse/CASSANDRA-6809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14289213#comment-14289213
]
Branimir Lambov commented on CASSANDRA-6809:
Thank you, I did not realise
[
https://issues.apache.org/jira/browse/CASSANDRA-6809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14289242#comment-14289242
]
Benedict commented on CASSANDRA-6809:
-
bq. Thank you, I did not realise you are
[
https://issues.apache.org/jira/browse/CASSANDRA-6809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14288522#comment-14288522
]
Benedict commented on CASSANDRA-6809:
-
It's a bit late at night to throw this
[
https://issues.apache.org/jira/browse/CASSANDRA-6809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14287853#comment-14287853
]
Branimir Lambov commented on CASSANDRA-6809:
{quote}
* single sync thread
[
https://issues.apache.org/jira/browse/CASSANDRA-6809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14285476#comment-14285476
]
Benedict commented on CASSANDRA-6809:
-
bq. assuming that the sync period is sane
[
https://issues.apache.org/jira/browse/CASSANDRA-6809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14285436#comment-14285436
]
Branimir Lambov commented on CASSANDRA-6809:
The current approach boils
[
https://issues.apache.org/jira/browse/CASSANDRA-6809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14284213#comment-14284213
]
Benedict commented on CASSANDRA-6809:
-
I haven't looked _closely_ at the patch,
[
https://issues.apache.org/jira/browse/CASSANDRA-6809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14284186#comment-14284186
]
Branimir Lambov commented on CASSANDRA-6809:
Multiple sync threads weren't
[
https://issues.apache.org/jira/browse/CASSANDRA-6809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14277638#comment-14277638
]
Branimir Lambov commented on CASSANDRA-6809:
Thanks for the review, Ariel.
[
https://issues.apache.org/jira/browse/CASSANDRA-6809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14275726#comment-14275726
]
Ariel Weisberg commented on CASSANDRA-6809:
---
I finished my review. Comments
[
https://issues.apache.org/jira/browse/CASSANDRA-6809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14275865#comment-14275865
]
Ariel Weisberg commented on CASSANDRA-6809:
---
Moving conversation to JIRA
[
https://issues.apache.org/jira/browse/CASSANDRA-6809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14270142#comment-14270142
]
Jason Brown commented on CASSANDRA-6809:
Please reassign as I'm not going to
[
https://issues.apache.org/jira/browse/CASSANDRA-6809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14269301#comment-14269301
]
Aleksey Yeschenko commented on CASSANDRA-6809:
--
[~jasobrown] Are you
[
https://issues.apache.org/jira/browse/CASSANDRA-6809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14140658#comment-14140658
]
Branimir Lambov commented on CASSANDRA-6809:
Patch is available for review
[
https://issues.apache.org/jira/browse/CASSANDRA-6809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14140668#comment-14140668
]
Benedict commented on CASSANDRA-6809:
-
Thanks, I'll get to review this soon. As
[
https://issues.apache.org/jira/browse/CASSANDRA-6809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14141286#comment-14141286
]
Jason Brown commented on CASSANDRA-6809:
I'd also like to have a chance to
[
https://issues.apache.org/jira/browse/CASSANDRA-6809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14141292#comment-14141292
]
Jason Brown commented on CASSANDRA-6809:
[~blambov] The github link you add
[
https://issues.apache.org/jira/browse/CASSANDRA-6809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14141293#comment-14141293
]
Benedict commented on CASSANDRA-6809:
-
[
https://issues.apache.org/jira/browse/CASSANDRA-6809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14141321#comment-14141321
]
Jason Brown commented on CASSANDRA-6809:
I think I read compressed-ci as
[
https://issues.apache.org/jira/browse/CASSANDRA-6809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14122738#comment-14122738
]
Branimir Lambov commented on CASSANDRA-6809:
I'm doing some testing before
[
https://issues.apache.org/jira/browse/CASSANDRA-6809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14122754#comment-14122754
]
Benedict commented on CASSANDRA-6809:
-
I'm +1 on your over all intended approach,
[
https://issues.apache.org/jira/browse/CASSANDRA-6809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14123492#comment-14123492
]
Jason Brown commented on CASSANDRA-6809:
[~barnie] Your proposal is very
[
https://issues.apache.org/jira/browse/CASSANDRA-6809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14103569#comment-14103569
]
Jason Brown commented on CASSANDRA-6809:
bq. we may as well allocate on the
[
https://issues.apache.org/jira/browse/CASSANDRA-6809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14103580#comment-14103580
]
Benedict commented on CASSANDRA-6809:
-
Per-disk sync threads...
Compressed
[
https://issues.apache.org/jira/browse/CASSANDRA-6809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14103622#comment-14103622
]
Jason Brown commented on CASSANDRA-6809:
bq. If we're dropping recycling, ...
[
https://issues.apache.org/jira/browse/CASSANDRA-6809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14103626#comment-14103626
]
Jason Brown commented on CASSANDRA-6809:
If we did try an async flush of the
[
https://issues.apache.org/jira/browse/CASSANDRA-6809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14103661#comment-14103661
]
Benedict commented on CASSANDRA-6809:
-
bq. Thus, the main CL thread(s) can
[
https://issues.apache.org/jira/browse/CASSANDRA-6809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14103680#comment-14103680
]
Jason Brown commented on CASSANDRA-6809:
bq. I think you're still thinking in
[
https://issues.apache.org/jira/browse/CASSANDRA-6809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14103687#comment-14103687
]
Benedict commented on CASSANDRA-6809:
-
Sounds like we're approximately in
[
https://issues.apache.org/jira/browse/CASSANDRA-6809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14102212#comment-14102212
]
Jason Brown commented on CASSANDRA-6809:
So, I'll be honest, I'm not sure why
[
https://issues.apache.org/jira/browse/CASSANDRA-6809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14102247#comment-14102247
]
Benedict commented on CASSANDRA-6809:
-
bq. is better than using a simple
[
https://issues.apache.org/jira/browse/CASSANDRA-6809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14102901#comment-14102901
]
Jonathan Ellis commented on CASSANDRA-6809:
---
bq. Don't want to bound by a
[
https://issues.apache.org/jira/browse/CASSANDRA-6809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14103210#comment-14103210
]
Benedict commented on CASSANDRA-6809:
-
It's also potentially less capable of
[
https://issues.apache.org/jira/browse/CASSANDRA-6809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14103211#comment-14103211
]
Jonathan Ellis commented on CASSANDRA-6809:
---
Sounds reasonable.
Compressed
[
https://issues.apache.org/jira/browse/CASSANDRA-6809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14103387#comment-14103387
]
Jason Brown commented on CASSANDRA-6809:
bq. It's also potentially less
[
https://issues.apache.org/jira/browse/CASSANDRA-6809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14103412#comment-14103412
]
Benedict commented on CASSANDRA-6809:
-
bq. Does this statement apply to this
[
https://issues.apache.org/jira/browse/CASSANDRA-6809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14103417#comment-14103417
]
Benedict commented on CASSANDRA-6809:
-
That said, if we have a separate thread per
[
https://issues.apache.org/jira/browse/CASSANDRA-6809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13978921#comment-13978921
]
Benedict commented on CASSANDRA-6809:
-
I would probably go one step further still:
[
https://issues.apache.org/jira/browse/CASSANDRA-6809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13978939#comment-13978939
]
T Jake Luciani commented on CASSANDRA-6809:
---
bq. All in all it's not a
60 matches
Mail list logo
