Re: [PR] CASSANDRA-19513: Refactor Cassandra bridge [cassandra-analytics]

2024-04-02 Thread via GitHub
frankgh merged PR #48: URL: https://github.com/apache/cassandra-analytics/pull/48 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] CASSANDRA-19513: Refactor Cassandra bridge [cassandra-analytics]

2024-04-02 Thread via GitHub
frankgh commented on code in PR #48: URL: https://github.com/apache/cassandra-analytics/pull/48#discussion_r1548723495 ## cassandra-four-zero-bridge/src/main/java/org/apache/cassandra/bridge/CassandraBridgeImplementation.java: ## @@ -244,7 +244,7 @@ public static List>

Re: [PR] CASSANDRA-19513: Refactor Cassandra bridge [cassandra-analytics]

2024-04-02 Thread via GitHub
yifan-c commented on code in PR #48: URL: https://github.com/apache/cassandra-analytics/pull/48#discussion_r1548719722 ## cassandra-four-zero-bridge/src/main/java/org/apache/cassandra/bridge/CassandraBridgeImplementation.java: ## @@ -244,7 +244,7 @@ public static List>

Re: [PR] CASSANDRA-19513: Refactor Cassandra bridge [cassandra-analytics]

2024-04-02 Thread via GitHub
frankgh commented on code in PR #48: URL: https://github.com/apache/cassandra-analytics/pull/48#discussion_r1548710244 ## scripts/relocate-dtest-dependencies.pom: ## @@ -114,12 +114,12 @@

Re: [PR] CASSANDRA-19513: Refactor Cassandra bridge [cassandra-analytics]

2024-04-02 Thread via GitHub
frankgh commented on code in PR #48: URL: https://github.com/apache/cassandra-analytics/pull/48#discussion_r1548644061 ## cassandra-analytics-core/src/test/java/org/apache/cassandra/spark/SSTableReaderTests.java: ## @@ -0,0 +1,147 @@ +/* + * Licensed to the Apache Software

Re: [PR] CASSANDRA-19513: Refactor Cassandra bridge [cassandra-analytics]

2024-04-02 Thread via GitHub
frankgh commented on code in PR #48: URL: https://github.com/apache/cassandra-analytics/pull/48#discussion_r1548642277 ## cassandra-analytics-core/build.gradle: ## @@ -19,171 +19,152 @@ import java.nio.file.Paths * under the License. */

Re: [PR] CASSANDRA-19513: Refactor Cassandra bridge [cassandra-analytics]

2024-04-02 Thread via GitHub
frankgh commented on code in PR #48: URL: https://github.com/apache/cassandra-analytics/pull/48#discussion_r1548642100 ## cassandra-analytics-core/build.gradle: ## @@ -19,171 +19,152 @@ import java.nio.file.Paths * under the License. */

Re: [PR] CASSANDRA-19513: Refactor Cassandra bridge [cassandra-analytics]

2024-04-02 Thread via GitHub
frankgh commented on code in PR #48: URL: https://github.com/apache/cassandra-analytics/pull/48#discussion_r1548620059 ## scripts/relocate-dtest-dependencies.pom: ## @@ -114,12 +114,12 @@