svn commit: r1746225 - /commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/memoryleaktests/MemoryLeakTestCase.java

[ggregory]

Author: ggregory
Date: Tue May 31 05:14:47 2016
New Revision: 1746225

URL: http://svn.apache.org/viewvc?rev=1746225=rev
Log:
Javadoc: Use the active voice.

Modified:

commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/memoryleaktests/MemoryLeakTestCase.java

Modified: 
commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/memoryleaktests/MemoryLeakTestCase.java
URL: 
http://svn.apache.org/viewvc/commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/memoryleaktests/MemoryLeakTestCase.java?rev=1746225=1746224=1746225=diff
==
--- 
commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/memoryleaktests/MemoryLeakTestCase.java
 (original)
+++ 
commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/memoryleaktests/MemoryLeakTestCase.java
 Tue May 31 05:14:47 2016
@@ -38,7 +38,7 @@ import org.apache.commons.beanutils.loca
 import junit.framework.TestCase;
 
 /**
- * Test BeanUtils memory leaks.
+ * Tests BeanUtils memory leaks.
  *
  * See https://issues.apache.org/jira/browse/BEANUTILS-291
  *
@@ -432,7 +432,7 @@ public class MemoryLeakTestCase extends
 }
 
 /**
- * Clear all the BeanUtils Caches manually.
+ * Clears all the BeanUtils Caches manually.
  *
  * This is probably overkill, but since we're dealing with static caches
  * it seems sensible to ensure that all test cases start with a clean 
sheet.
@@ -459,7 +459,7 @@ public class MemoryLeakTestCase extends
 }
 
 /**
- * Try to force the garbage collector to run by filling up memory and 
calling System.gc().
+ * Tries to force the garbage collector to run by filling up memory and 
calling System.gc().
  */
 private void forceGarbageCollection() throws Exception {
 // Fill up memory
@@ -493,7 +493,7 @@ public class MemoryLeakTestCase extends
 }
 
 /**
- * Create a new class loader instance.
+ * Creates a new class loader instance.
  */
 private static URLClassLoader newClassLoader() throws 
MalformedURLException {
 
@@ -518,7 +518,7 @@ public class MemoryLeakTestCase extends
 }
 
 /**
- * Produce a profiler report about where the leaks are.
+ * Produces a profiler report about where the leaks are.
  *
  * This requires JBoss's profiler be installed, see:
  * http://labs.jboss.com/jbossprofiler/
@@ -538,7 +538,7 @@ public class MemoryLeakTestCase extends
 }
 
 /**
- * Get the total, free, used memory stats.
+ * Gets the total, free, used memory stats.
  * @return the total, free, used memory stats
  */
 private String getMemoryStats() {

svn commit: r1746224 - /commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/memoryleaktests/MemoryLeakTestCase.java

[ggregory]

Author: ggregory
Date: Tue May 31 05:13:07 2016
New Revision: 1746224

URL: http://svn.apache.org/viewvc?rev=1746224=rev
Log:
Fix what must have been a typo!

Modified:

commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/memoryleaktests/MemoryLeakTestCase.java

Modified: 
commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/memoryleaktests/MemoryLeakTestCase.java
URL: 
http://svn.apache.org/viewvc/commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/memoryleaktests/MemoryLeakTestCase.java?rev=1746224=1746223=1746224=diff
==
--- 
commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/memoryleaktests/MemoryLeakTestCase.java
 (original)
+++ 
commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/memoryleaktests/MemoryLeakTestCase.java
 Tue May 31 05:13:07 2016
@@ -443,7 +443,7 @@ public class MemoryLeakTestCase extends
 BeanUtilsBean.getInstance().getPropertyUtils().clearDescriptors();
 
 // Clear LocaleBeanUtilsBean's PropertyUtilsBean descriptor caches
-BeanUtilsBean.getInstance().getPropertyUtils().clearDescriptors();
+
LocaleBeanUtilsBean.getLocaleBeanUtilsInstance().getPropertyUtils().clearDescriptors();
 
 // Clear MethodUtils's method cache
 MethodUtils.clearCache();

svn commit: r1746223 - /commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/memoryleaktests/MemoryLeakTestCase.java

[ggregory]

Author: ggregory
Date: Tue May 31 05:12:10 2016
New Revision: 1746223

URL: http://svn.apache.org/viewvc?rev=1746223=rev
Log:
Access static method directly.

Modified:

commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/memoryleaktests/MemoryLeakTestCase.java

Modified: 
commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/memoryleaktests/MemoryLeakTestCase.java
URL: 
http://svn.apache.org/viewvc/commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/memoryleaktests/MemoryLeakTestCase.java?rev=1746223=1746222=1746223=diff
==
--- 
commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/memoryleaktests/MemoryLeakTestCase.java
 (original)
+++ 
commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/memoryleaktests/MemoryLeakTestCase.java
 Tue May 31 05:12:10 2016
@@ -443,7 +443,7 @@ public class MemoryLeakTestCase extends
 BeanUtilsBean.getInstance().getPropertyUtils().clearDescriptors();
 
 // Clear LocaleBeanUtilsBean's PropertyUtilsBean descriptor caches
-
LocaleBeanUtilsBean.getInstance().getPropertyUtils().clearDescriptors();
+BeanUtilsBean.getInstance().getPropertyUtils().clearDescriptors();
 
 // Clear MethodUtils's method cache
 MethodUtils.clearCache();

svn commit: r1746222 - /commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/memoryleaktests/MemoryLeakTestCase.java

[ggregory]

Author: ggregory
Date: Tue May 31 05:11:40 2016
New Revision: 1746222

URL: http://svn.apache.org/viewvc?rev=1746222=rev
Log:
Remove unused import.

Modified:

commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/memoryleaktests/MemoryLeakTestCase.java

Modified: 
commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/memoryleaktests/MemoryLeakTestCase.java
URL: 
http://svn.apache.org/viewvc/commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/memoryleaktests/MemoryLeakTestCase.java?rev=1746222=1746221=1746222=diff
==
--- 
commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/memoryleaktests/MemoryLeakTestCase.java
 (original)
+++ 
commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/memoryleaktests/MemoryLeakTestCase.java
 Tue May 31 05:11:40 2016
@@ -22,9 +22,6 @@ import java.net.MalformedURLException;
 import java.net.URL;
 import java.net.URLClassLoader;
 import java.util.Locale;
-import java.util.StringTokenizer;
-
-import junit.framework.TestCase;
 
 import org.apache.commons.beanutils.BeanUtilsBean;
 import org.apache.commons.beanutils.ConvertUtils;
@@ -38,6 +35,8 @@ import org.apache.commons.beanutils.loca
 import org.apache.commons.beanutils.locale.LocaleConvertUtils;
 import org.apache.commons.beanutils.locale.converters.IntegerLocaleConverter;
 
+import junit.framework.TestCase;
+
 /**
  * Test BeanUtils memory leaks.
  *

svn commit: r1746221 - /commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/memoryleaktests/MemoryLeakTestCase.java

[ggregory]

Author: ggregory
Date: Tue May 31 05:11:06 2016
New Revision: 1746221

URL: http://svn.apache.org/viewvc?rev=1746221=rev
Log:
No need to avoid running tests on JVMs older than 1.5 since we require 1.5.

Modified:

commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/memoryleaktests/MemoryLeakTestCase.java

Modified: 
commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/memoryleaktests/MemoryLeakTestCase.java
URL: 
http://svn.apache.org/viewvc/commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/memoryleaktests/MemoryLeakTestCase.java?rev=1746221=1746220=1746221=diff
==
--- 
commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/memoryleaktests/MemoryLeakTestCase.java
 (original)
+++ 
commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/memoryleaktests/MemoryLeakTestCase.java
 Tue May 31 05:11:06 2016
@@ -51,9 +51,6 @@ public class MemoryLeakTestCase extends
  * Tests that PropertyUtilsBean's descriptorsCache doesn't cause a memory 
leak.
  */
 public void testPropertyUtilsBean_descriptorsCache_memoryLeak() throws 
Exception {
-if (isPre15JVM()) {
-return;
-}
 
 // Clear All BeanUtils caches before the test
 clearAllBeanUtilsCaches();
@@ -100,9 +97,6 @@ public class MemoryLeakTestCase extends
  * Tests that PropertyUtilsBean's mappedDescriptorsCache doesn't cause a 
memory leak.
  */
 public void testPropertyUtilsBean_mappedDescriptorsCache_memoryLeak() 
throws Exception {
-if (isPre15JVM()) {
-return;
-}
 
 // Clear All BeanUtils caches before the test
 clearAllBeanUtilsCaches();
@@ -296,9 +290,6 @@ public class MemoryLeakTestCase extends
  * Tests that WrapDynaClass's dynaClasses doesn't cause a memory leak.
  */
 public void testWrapDynaClass_dynaClasses_memoryLeak() throws Exception {
-if (isPre15JVM()) {
-return;
-}
 
 // Clear All BeanUtils caches before the test
 clearAllBeanUtilsCaches();
@@ -548,33 +539,6 @@ public class MemoryLeakTestCase extends
 }
 
 /**
- * Test for JDK 1.5
- */
-private boolean isPre15JVM() {
-final String version = 
System.getProperty("java.specification.version");
-final StringTokenizer tokenizer = new StringTokenizer(version,".");
-if (tokenizer.nextToken().equals("1")) {
-final String minorVersion = tokenizer.nextToken();
-if (minorVersion.equals("0")) {
-return true;
-}
-if (minorVersion.equals("1")) {
-return true;
-}
-if (minorVersion.equals("2")) {
-return true;
-}
-if (minorVersion.equals("3")) {
-return true;
-}
-if (minorVersion.equals("4")) {
-return true;
-}
-}
-return false;
-}
-
-/**
  * Get the total, free, used memory stats.
  * @return the total, free, used memory stats
  */

svn commit: r1746220 - in /commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils: DynaResultSetTestCase.java LazyDynaListTestCase.java

[ggregory]

Author: ggregory
Date: Tue May 31 05:09:11 2016
New Revision: 1746220

URL: http://svn.apache.org/viewvc?rev=1746220=rev
Log:
Remove unnecessary casts.

Modified:

commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/DynaResultSetTestCase.java

commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/LazyDynaListTestCase.java

Modified: 
commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/DynaResultSetTestCase.java
URL: 
http://svn.apache.org/viewvc/commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/DynaResultSetTestCase.java?rev=1746220=1746219=1746220=diff
==
--- 
commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/DynaResultSetTestCase.java
 (original)
+++ 
commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/DynaResultSetTestCase.java
 Tue May 31 05:09:11 2016
@@ -199,7 +199,7 @@ public class DynaResultSetTestCase exten
 final Iterator rows = dynaClass.iterator();
 rows.next();
 rows.next();
-final DynaBean row = (DynaBean) rows.next();
+final DynaBean row = rows.next();
 
 // Invalid argument test
 try {
@@ -258,7 +258,7 @@ public class DynaResultSetTestCase exten
 final Iterator rows = dynaClass.iterator();
 rows.next();
 rows.next();
-final DynaBean row = (DynaBean) rows.next();
+final DynaBean row = rows.next();
 
 // Invalid argument test
 try {

Modified: 
commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/LazyDynaListTestCase.java
URL: 
http://svn.apache.org/viewvc/commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/LazyDynaListTestCase.java?rev=1746220=1746219=1746220=diff
==
--- 
commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/LazyDynaListTestCase.java
 (original)
+++ 
commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/LazyDynaListTestCase.java
 Tue May 31 05:09:11 2016
@@ -613,7 +613,7 @@ public class LazyDynaListTestCase extend
 final LazyDynaList list = new LazyDynaList(LazyDynaBean.class);
 final LazyDynaBean elem = new LazyDynaBean();
 list.add(elem);
-final LazyDynaBean[] array = (LazyDynaBean[]) list.toArray(new 
LazyDynaBean[0]);
+final LazyDynaBean[] array = list.toArray(new LazyDynaBean[0]);
 assertEquals("Wrong array size", 1, array.length);
 assertEquals("Wrong element", elem, array[0]);
 }

svn commit: r1746219 - in /commons/proper/beanutils/trunk/src: main/java/org/apache/commons/beanutils/ main/java/org/apache/commons/beanutils/converters/ test/java/org/apache/commons/beanutils/ test/j

[ggregory]

Author: ggregory
Date: Tue May 31 05:05:09 2016
New Revision: 1746219

URL: http://svn.apache.org/viewvc?rev=1746219=rev
Log:
Convert for loops to enhanced for loops.

Modified:

commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/BaseDynaBeanMapDecorator.java

commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/BasicDynaClass.java

commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/BeanMap.java

commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/BeanUtilsBean.java

commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/ConstructorUtils.java

commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/DefaultIntrospectionContext.java

commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/JDBCDynaClass.java

commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/LazyDynaList.java

commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/LazyDynaMap.java

commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/MappedPropertyDescriptor.java

commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/MethodUtils.java

commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/PropertyUtilsBean.java

commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/RowSetDynaClass.java

commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/converters/ArrayConverter.java

commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/converters/BooleanConverter.java

commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/converters/DateTimeConverter.java

commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/BasicDynaBeanTestCase.java

commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/BeanMapTestCase.java

commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/BeanUtilsTestCase.java

commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/DynaBeanUtilsTestCase.java

commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/DynaPropertyUtilsTestCase.java

commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/LazyDynaListTestCase.java

commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/PropertyUtilsTestCase.java

commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/bugs/Jira357TestCase.java

commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/converters/ArrayConverterTestCase.java

commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/converters/BooleanConverterTestCase.java

Modified: 
commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/BaseDynaBeanMapDecorator.java
URL: 
http://svn.apache.org/viewvc/commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/BaseDynaBeanMapDecorator.java?rev=1746219=1746218=1746219=diff
==
--- 
commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/BaseDynaBeanMapDecorator.java
 (original)
+++ 
commons/proper/beanutils/trunk/src/main/java/org/apache/commons/beanutils/BaseDynaBeanMapDecorator.java
 Tue May 31 05:05:09 2016
@@ -134,8 +134,8 @@ public abstract class BaseDynaBeanMapDec
  */
 public boolean containsValue(final Object value) {
 final DynaProperty[] properties = getDynaProperties();
-for (int i = 0; i < properties.length; i++) {
-final String key = properties[i].getName();
+for (DynaProperty propertie : properties) {
+final String key = propertie.getName();
 final Object prop = getDynaBean().get(key);
 if (value == null) {
 if (prop == null) {
@@ -163,9 +163,9 @@ public abstract class BaseDynaBeanMapDec
 public Set> entrySet() {
 final DynaProperty[] properties = getDynaProperties();
 final Set> set = new HashSet>(properties.length);
-for (int i = 0; i < properties.length; i++) {
-final K key = convertKey(properties[i].getName());
-final Object value = getDynaBean().get(properties[i].getName());
+for (DynaProperty propertie : properties) {
+final K key = convertKey(propertie.getName());
+final Object value = getDynaBean().get(propertie.getName());
 set.add(new MapEntry(key, value));
 }
 return Collections.unmodifiableSet(set);
@@ -212,8 +212,8 @@ public abstract class BaseDynaBeanMapDec
 // Create a Set of the keys
 final DynaProperty[] properties = getDynaProperties();
   

svn commit: r1746218 - in /commons/proper/beanutils/trunk: license-header.txt pom.xml src/main/assembly/src.xml

[ggregory]

Author: ggregory
Date: Tue May 31 04:57:10 2016
New Revision: 1746218

URL: http://svn.apache.org/viewvc?rev=1746218=rev
Log:
Rely on RAT for license checking, not Checkstyle; commons-parent 34 -> 40.

Removed:
commons/proper/beanutils/trunk/license-header.txt
Modified:
commons/proper/beanutils/trunk/pom.xml
commons/proper/beanutils/trunk/src/main/assembly/src.xml

Modified: commons/proper/beanutils/trunk/pom.xml
URL: 
http://svn.apache.org/viewvc/commons/proper/beanutils/trunk/pom.xml?rev=1746218=1746217=1746218=diff
==
--- commons/proper/beanutils/trunk/pom.xml (original)
+++ commons/proper/beanutils/trunk/pom.xml Tue May 31 04:57:10 2016
@@ -22,7 +22,7 @@
   
 org.apache.commons
 commons-parent
-34
+40
   
   4.0.0
   commons-beanutils
@@ -374,7 +374,6 @@
 
 ${basedir}/checkstyle.xml
 false
-
${basedir}/license-header.txt
 
 
 

Modified: commons/proper/beanutils/trunk/src/main/assembly/src.xml
URL: 
http://svn.apache.org/viewvc/commons/proper/beanutils/trunk/src/main/assembly/src.xml?rev=1746218=1746217=1746218=diff
==
--- commons/proper/beanutils/trunk/src/main/assembly/src.xml (original)
+++ commons/proper/beanutils/trunk/src/main/assembly/src.xml Tue May 31 
04:57:10 2016
@@ -28,7 +28,6 @@
 build.xml
 checkstyle.xml
 LICENSE.txt
-license-header.txt
 NOTICE.txt
 pom.xml
 README.txt

svn commit: r1746217 - /commons/proper/commons-parent/trunk/pom.xml

[ggregory]

Author: ggregory
Date: Tue May 31 04:54:11 2016
New Revision: 1746217

URL: http://svn.apache.org/viewvc?rev=1746217=rev
Log:
RAT: Exclude Eclipse local files and folders.

Modified:
commons/proper/commons-parent/trunk/pom.xml

Modified: commons/proper/commons-parent/trunk/pom.xml
URL: 
http://svn.apache.org/viewvc/commons/proper/commons-parent/trunk/pom.xml?rev=1746217=1746216=1746217=diff
==
--- commons/proper/commons-parent/trunk/pom.xml (original)
+++ commons/proper/commons-parent/trunk/pom.xml Tue May 31 04:54:11 2016
@@ -732,6 +732,9 @@ Version 39:
 .pmd
 src/site/resources/download_*.cgi
 src/site/resources/profile.*
+
+maven-eclipse.xml
+.externalToolBuilders/**
   
 
   

svn commit: r1746216 - /commons/proper/commons-parent/trunk/pom.xml

[ggregory]

Author: ggregory
Date: Tue May 31 04:51:29 2016
New Revision: 1746216

URL: http://svn.apache.org/viewvc?rev=1746216=rev
Log:
Capitalize.

Modified:
commons/proper/commons-parent/trunk/pom.xml

Modified: commons/proper/commons-parent/trunk/pom.xml
URL: 
http://svn.apache.org/viewvc/commons/proper/commons-parent/trunk/pom.xml?rev=1746216=1746215=1746216=diff
==
--- commons/proper/commons-parent/trunk/pom.xml (original)
+++ commons/proper/commons-parent/trunk/pom.xml Tue May 31 04:51:29 2016
@@ -40,7 +40,7 @@
 Version 41:
 
 - Update Apache parent: 17 -> 18
-- changed ciManagement to Jenkins builds.apache.org
+- Changed ciManagement to Jenkins builds.apache.org
 - RAT: Exclude Eclipse local files and folders
 
 Version 40:

svn commit: r1746215 - /commons/proper/commons-parent/trunk/pom.xml

[ggregory]

Author: ggregory
Date: Tue May 31 04:51:15 2016
New Revision: 1746215

URL: http://svn.apache.org/viewvc?rev=1746215=rev
Log:
RAT: Exclude Eclipse local files and folders.

Modified:
commons/proper/commons-parent/trunk/pom.xml

Modified: commons/proper/commons-parent/trunk/pom.xml
URL: 
http://svn.apache.org/viewvc/commons/proper/commons-parent/trunk/pom.xml?rev=1746215=1746214=1746215=diff
==
--- commons/proper/commons-parent/trunk/pom.xml (original)
+++ commons/proper/commons-parent/trunk/pom.xml Tue May 31 04:51:15 2016
@@ -41,6 +41,7 @@ Version 41:
 
 - Update Apache parent: 17 -> 18
 - changed ciManagement to Jenkins builds.apache.org
+- RAT: Exclude Eclipse local files and folders
 
 Version 40:
 
@@ -556,6 +557,9 @@ Version 39:
 .pmd
 src/site/resources/download_*.cgi
 src/site/resources/profile.*
+
+maven-eclipse.xml
+.externalToolBuilders/**
   
 
   

[Math] Change on branch "master": Commons Math MasterBranch - Build # 9 - Successful

[Apache Jenkins Server]

The Apache Jenkins build system has built Commons Math MasterBranch (build #9)

Status: Successful

Check console output at 
https://builds.apache.org/job/Commons%20Math%20MasterBranch/9/ to view the 
results.

[math] Reverting changes on "master" as per Commons Math policy.

[erans]

Repository: commons-math
Updated Branches:
  refs/heads/master ffc1caada -> 598edc127


Reverting changes on "master" as per Commons Math policy.

The corresponding changes have been ported into branch "develop".


Project: http://git-wip-us.apache.org/repos/asf/commons-math/repo
Commit: http://git-wip-us.apache.org/repos/asf/commons-math/commit/598edc12
Tree: http://git-wip-us.apache.org/repos/asf/commons-math/tree/598edc12
Diff: http://git-wip-us.apache.org/repos/asf/commons-math/diff/598edc12

Branch: refs/heads/master
Commit: 598edc12736945d27fb7dbd77cb81ac8e51f491a
Parents: ffc1caa
Author: Gilles 
Authored: Tue May 31 03:20:13 2016 +0200
Committer: Gilles 
Committed: Tue May 31 03:20:13 2016 +0200

--
 .../distribution/AbstractIntegerDistribution.java   |  3 ++-
 .../descriptive/MultivariateSummaryStatistics.java  |  6 +++---
 .../math4/stat/interval/ClopperPearsonInterval.java | 16 
 3 files changed, 13 insertions(+), 12 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/commons-math/blob/598edc12/src/main/java/org/apache/commons/math4/distribution/AbstractIntegerDistribution.java
--
diff --git 
a/src/main/java/org/apache/commons/math4/distribution/AbstractIntegerDistribution.java
 
b/src/main/java/org/apache/commons/math4/distribution/AbstractIntegerDistribution.java
index 4c42c01..95d6f07 100644
--- 
a/src/main/java/org/apache/commons/math4/distribution/AbstractIntegerDistribution.java
+++ 
b/src/main/java/org/apache/commons/math4/distribution/AbstractIntegerDistribution.java
@@ -209,7 +209,8 @@ public abstract class AbstractIntegerDistribution 
implements IntegerDistribution
  */
 private double checkedCumulativeProbability(int argument)
 throws MathInternalError {
-double result = cumulativeProbability(argument);
+double result = Double.NaN;
+result = cumulativeProbability(argument);
 if (Double.isNaN(result)) {
 throw new MathInternalError(LocalizedFormats
 .DISCRETE_CUMULATIVE_PROBABILITY_RETURNED_NAN, argument);

http://git-wip-us.apache.org/repos/asf/commons-math/blob/598edc12/src/main/java/org/apache/commons/math4/stat/descriptive/MultivariateSummaryStatistics.java
--
diff --git 
a/src/main/java/org/apache/commons/math4/stat/descriptive/MultivariateSummaryStatistics.java
 
b/src/main/java/org/apache/commons/math4/stat/descriptive/MultivariateSummaryStatistics.java
index 39083d0..eb1642c 100644
--- 
a/src/main/java/org/apache/commons/math4/stat/descriptive/MultivariateSummaryStatistics.java
+++ 
b/src/main/java/org/apache/commons/math4/stat/descriptive/MultivariateSummaryStatistics.java
@@ -319,8 +319,8 @@ public class MultivariateSummaryStatistics
 final String separator = ", ";
 final String suffix = System.getProperty("line.separator");
 StringBuilder outBuffer = new StringBuilder();
-outBuffer.append("MultivariateSummaryStatistics:").append(suffix);
-outBuffer.append("n: ").append(getN()).append(suffix);
+outBuffer.append("MultivariateSummaryStatistics:" + suffix);
+outBuffer.append("n: " + getN() + suffix);
 append(outBuffer, getMin(), "min: ", separator, suffix);
 append(outBuffer, getMax(), "max: ", separator, suffix);
 append(outBuffer, getMean(), "mean: ", separator, suffix);
@@ -328,7 +328,7 @@ public class MultivariateSummaryStatistics
 append(outBuffer, getSumSq(), "sum of squares: ", separator, suffix);
 append(outBuffer, getSumLog(), "sum of logarithms: ", separator, 
suffix);
 append(outBuffer, getStandardDeviation(), "standard deviation: ", 
separator, suffix);
-outBuffer.append("covariance: 
").append(getCovariance()).append(suffix);
+outBuffer.append("covariance: " + getCovariance().toString() + suffix);
 return outBuffer.toString();
 }
 

http://git-wip-us.apache.org/repos/asf/commons-math/blob/598edc12/src/main/java/org/apache/commons/math4/stat/interval/ClopperPearsonInterval.java
--
diff --git 
a/src/main/java/org/apache/commons/math4/stat/interval/ClopperPearsonInterval.java
 
b/src/main/java/org/apache/commons/math4/stat/interval/ClopperPearsonInterval.java
index ed0904c..bf5d6ad 100644
--- 
a/src/main/java/org/apache/commons/math4/stat/interval/ClopperPearsonInterval.java
+++ 
b/src/main/java/org/apache/commons/math4/stat/interval/ClopperPearsonInterval.java
@@ -35,19 +35,19 @@ public class ClopperPearsonInterval implements 
BinomialConfidenceInterval {
 IntervalUtils.checkParameters(numberOfTrials, numberOfSuccesses, 
confidenceLevel);
 

[Math] Change on branch "develop": Commons Math DeveloperBranch - Build # 23 - Fixed

[Apache Jenkins Server]

The Apache Jenkins build system has built Commons Math DeveloperBranch (build 
#23)

Status: Fixed

Check console output at 
https://builds.apache.org/job/Commons%20Math%20DeveloperBranch/23/ to view the 
results.

[3/3] [math] Perform computation/allocation only if needed.

[erans]

Perform computation/allocation only if needed.

Thanks to Dave Brosius.


Project: http://git-wip-us.apache.org/repos/asf/commons-math/repo
Commit: http://git-wip-us.apache.org/repos/asf/commons-math/commit/fc9d93db
Tree: http://git-wip-us.apache.org/repos/asf/commons-math/tree/fc9d93db
Diff: http://git-wip-us.apache.org/repos/asf/commons-math/diff/fc9d93db

Branch: refs/heads/develop
Commit: fc9d93db68a3c33e5ead8c7ecb187fdf0f06cc4f
Parents: 362ab2b
Author: Gilles 
Authored: Tue May 31 02:38:16 2016 +0200
Committer: Gilles 
Committed: Tue May 31 02:38:16 2016 +0200

--
 .../math4/stat/interval/ClopperPearsonInterval.java| 13 ++---
 1 file changed, 6 insertions(+), 7 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/commons-math/blob/fc9d93db/src/main/java/org/apache/commons/math4/stat/interval/ClopperPearsonInterval.java
--
diff --git 
a/src/main/java/org/apache/commons/math4/stat/interval/ClopperPearsonInterval.java
 
b/src/main/java/org/apache/commons/math4/stat/interval/ClopperPearsonInterval.java
index bf5d6ad..6f257e7 100644
--- 
a/src/main/java/org/apache/commons/math4/stat/interval/ClopperPearsonInterval.java
+++ 
b/src/main/java/org/apache/commons/math4/stat/interval/ClopperPearsonInterval.java
@@ -35,19 +35,18 @@ public class ClopperPearsonInterval implements 
BinomialConfidenceInterval {
 IntervalUtils.checkParameters(numberOfTrials, numberOfSuccesses, 
confidenceLevel);
 double lowerBound = 0;
 double upperBound = 0;
-final double alpha = (1.0 - confidenceLevel) / 2.0;
 
-final FDistribution distributionLowerBound = new FDistribution(2 * 
(numberOfTrials - numberOfSuccesses + 1),
-   2 * 
numberOfSuccesses);
 if (numberOfSuccesses > 0) {
+   final double alpha = 0.5 * (1 - confidenceLevel);
+
+   final FDistribution distributionLowerBound = new FDistribution(2 * 
(numberOfTrials - numberOfSuccesses + 1),
+  2 * 
numberOfSuccesses);
 final double fValueLowerBound = 
distributionLowerBound.inverseCumulativeProbability(1 - alpha);
 lowerBound = numberOfSuccesses /
  (numberOfSuccesses + (numberOfTrials - 
numberOfSuccesses + 1) * fValueLowerBound);
-}
 
-final FDistribution distributionUpperBound = new FDistribution(2 * 
(numberOfSuccesses + 1),
-   2 * 
(numberOfTrials - numberOfSuccesses));
-if (numberOfSuccesses > 0) {
+   final FDistribution distributionUpperBound = new FDistribution(2 * 
(numberOfSuccesses + 1),
+  2 * 
(numberOfTrials - numberOfSuccesses));
 final double fValueUpperBound = 
distributionUpperBound.inverseCumulativeProbability(1 - alpha);
 upperBound = (numberOfSuccesses + 1) * fValueUpperBound /
  (numberOfTrials - numberOfSuccesses + 
(numberOfSuccesses + 1) * fValueUpperBound);

[1/3] [math] Initialize at declaration.

[erans]

Repository: commons-math
Updated Branches:
  refs/heads/develop e7c42ed0f -> fc9d93db6


Initialize at declaration.

Thanks to Dave Brosius.


Project: http://git-wip-us.apache.org/repos/asf/commons-math/repo
Commit: http://git-wip-us.apache.org/repos/asf/commons-math/commit/633de29f
Tree: http://git-wip-us.apache.org/repos/asf/commons-math/tree/633de29f
Diff: http://git-wip-us.apache.org/repos/asf/commons-math/diff/633de29f

Branch: refs/heads/develop
Commit: 633de29fedf11544f2c3d5052890cb014e612bd5
Parents: e7c42ed
Author: Gilles 
Authored: Tue May 31 02:28:14 2016 +0200
Committer: Gilles 
Committed: Tue May 31 02:28:14 2016 +0200

--
 .../commons/math4/distribution/AbstractIntegerDistribution.java   | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/commons-math/blob/633de29f/src/main/java/org/apache/commons/math4/distribution/AbstractIntegerDistribution.java
--
diff --git 
a/src/main/java/org/apache/commons/math4/distribution/AbstractIntegerDistribution.java
 
b/src/main/java/org/apache/commons/math4/distribution/AbstractIntegerDistribution.java
index 4612b58..0bc377d 100644
--- 
a/src/main/java/org/apache/commons/math4/distribution/AbstractIntegerDistribution.java
+++ 
b/src/main/java/org/apache/commons/math4/distribution/AbstractIntegerDistribution.java
@@ -156,8 +156,7 @@ public abstract class AbstractIntegerDistribution 
implements IntegerDistribution
  */
 private double checkedCumulativeProbability(int argument)
 throws MathInternalError {
-double result = Double.NaN;
-result = cumulativeProbability(argument);
+final double result = cumulativeProbability(argument);
 if (Double.isNaN(result)) {
 throw new MathInternalError(LocalizedFormats
 .DISCRETE_CUMULATIVE_PROBABILITY_RETURNED_NAN, argument);

[2/3] [math] Unnecessary String creation.

[erans]

Unnecessary String creation.

Thanks to Dave Brosius.


Project: http://git-wip-us.apache.org/repos/asf/commons-math/repo
Commit: http://git-wip-us.apache.org/repos/asf/commons-math/commit/362ab2bc
Tree: http://git-wip-us.apache.org/repos/asf/commons-math/tree/362ab2bc
Diff: http://git-wip-us.apache.org/repos/asf/commons-math/diff/362ab2bc

Branch: refs/heads/develop
Commit: 362ab2bc41697980391c4a61c23cb3ef6bce740c
Parents: 633de29
Author: Gilles 
Authored: Tue May 31 02:30:47 2016 +0200
Committer: Gilles 
Committed: Tue May 31 02:30:47 2016 +0200

--
 .../math4/stat/descriptive/MultivariateSummaryStatistics.java  | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/commons-math/blob/362ab2bc/src/main/java/org/apache/commons/math4/stat/descriptive/MultivariateSummaryStatistics.java
--
diff --git 
a/src/main/java/org/apache/commons/math4/stat/descriptive/MultivariateSummaryStatistics.java
 
b/src/main/java/org/apache/commons/math4/stat/descriptive/MultivariateSummaryStatistics.java
index eb1642c..39083d0 100644
--- 
a/src/main/java/org/apache/commons/math4/stat/descriptive/MultivariateSummaryStatistics.java
+++ 
b/src/main/java/org/apache/commons/math4/stat/descriptive/MultivariateSummaryStatistics.java
@@ -319,8 +319,8 @@ public class MultivariateSummaryStatistics
 final String separator = ", ";
 final String suffix = System.getProperty("line.separator");
 StringBuilder outBuffer = new StringBuilder();
-outBuffer.append("MultivariateSummaryStatistics:" + suffix);
-outBuffer.append("n: " + getN() + suffix);
+outBuffer.append("MultivariateSummaryStatistics:").append(suffix);
+outBuffer.append("n: ").append(getN()).append(suffix);
 append(outBuffer, getMin(), "min: ", separator, suffix);
 append(outBuffer, getMax(), "max: ", separator, suffix);
 append(outBuffer, getMean(), "mean: ", separator, suffix);
@@ -328,7 +328,7 @@ public class MultivariateSummaryStatistics
 append(outBuffer, getSumSq(), "sum of squares: ", separator, suffix);
 append(outBuffer, getSumLog(), "sum of logarithms: ", separator, 
suffix);
 append(outBuffer, getStandardDeviation(), "standard deviation: ", 
separator, suffix);
-outBuffer.append("covariance: " + getCovariance().toString() + suffix);
+outBuffer.append("covariance: 
").append(getCovariance()).append(suffix);
 return outBuffer.toString();
 }
 

[2/2] [lang] LANG-1240: add changes.xml entry

[pascalschumacher]

LANG-1240: add changes.xml entry


Project: http://git-wip-us.apache.org/repos/asf/commons-lang/repo
Commit: http://git-wip-us.apache.org/repos/asf/commons-lang/commit/17d6f216
Tree: http://git-wip-us.apache.org/repos/asf/commons-lang/tree/17d6f216
Diff: http://git-wip-us.apache.org/repos/asf/commons-lang/diff/17d6f216

Branch: refs/heads/master
Commit: 17d6f2163db436518f953166c1e9d495232f90b6
Parents: 84d5291
Author: pascalschumacher 
Authored: Mon May 30 22:21:56 2016 +0200
Committer: pascalschumacher 
Committed: Mon May 30 22:23:33 2016 +0200

--
 src/changes/changes.xml | 1 +
 1 file changed, 1 insertion(+)
--


http://git-wip-us.apache.org/repos/asf/commons-lang/blob/17d6f216/src/changes/changes.xml
--
diff --git a/src/changes/changes.xml b/src/changes/changes.xml
index a03b992..d1785b7 100644
--- a/src/changes/changes.xml
+++ b/src/changes/changes.xml
@@ -22,6 +22,7 @@
   
 
   
+Optimize BitField constructor implementation
 Improve CharSetUtils.squeeze() performance
 Add RandomStringUtils#randomGraph and #randomPrint which match 
corresponding regular expression class
 StringUtils#startsWithAny/endsWithAny is case sensitive - 
documented as case insensitive

[1/2] [lang] LANG-1240: Optimize BitField constructor implementation (closes #119)

[pascalschumacher]

Repository: commons-lang
Updated Branches:
  refs/heads/master afedbae8a -> 17d6f2163


LANG-1240: Optimize BitField constructor implementation (closes #119)


Project: http://git-wip-us.apache.org/repos/asf/commons-lang/repo
Commit: http://git-wip-us.apache.org/repos/asf/commons-lang/commit/84d52919
Tree: http://git-wip-us.apache.org/repos/asf/commons-lang/tree/84d52919
Diff: http://git-wip-us.apache.org/repos/asf/commons-lang/diff/84d52919

Branch: refs/heads/master
Commit: 84d52919ec3b3c75f28a185ad7cd87603c3cc4cf
Parents: afedbae
Author: zhanhb 
Authored: Mon Dec 14 15:29:26 2015 +0800
Committer: pascalschumacher 
Committed: Mon May 30 22:23:14 2016 +0200

--
 src/main/java/org/apache/commons/lang3/BitField.java | 11 +--
 1 file changed, 1 insertion(+), 10 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/commons-lang/blob/84d52919/src/main/java/org/apache/commons/lang3/BitField.java
--
diff --git a/src/main/java/org/apache/commons/lang3/BitField.java 
b/src/main/java/org/apache/commons/lang3/BitField.java
index 824d242..65b465e 100644
--- a/src/main/java/org/apache/commons/lang3/BitField.java
+++ b/src/main/java/org/apache/commons/lang3/BitField.java
@@ -84,16 +84,7 @@ public class BitField {
  */
 public BitField(final int mask) {
 _mask = mask;
-int count = 0;
-int bit_pattern = mask;
-
-if (bit_pattern != 0) {
-while ((bit_pattern & 1) == 0) {
-count++;
-bit_pattern >>= 1;
-}
-}
-_shift_count = count;
+_shift_count = mask != 0 ? Integer.numberOfTrailingZeros(mask) : 0;
 }
 
 /**

[Math] Change on branch "master": Commons Math MasterBranch - Build # 8 - Fixed

[Apache Jenkins Server]

The Apache Jenkins build system has built Commons Math MasterBranch (build #8)

Status: Fixed

Check console output at 
https://builds.apache.org/job/Commons%20Math%20MasterBranch/8/ to view the 
results.

[math] Revert "no need for Double allocation just to get hashCode"

[dbrosius]

Repository: commons-math
Updated Branches:
  refs/heads/master 803e1a6f4 -> ffc1caada


Revert "no need for Double allocation just to get hashCode"

a java 8 method

This reverts commit 803e1a6f4bfcc0ce77cd9b63cf70d264aa8a90ad.


Project: http://git-wip-us.apache.org/repos/asf/commons-math/repo
Commit: http://git-wip-us.apache.org/repos/asf/commons-math/commit/ffc1caad
Tree: http://git-wip-us.apache.org/repos/asf/commons-math/tree/ffc1caad
Diff: http://git-wip-us.apache.org/repos/asf/commons-math/diff/ffc1caad

Branch: refs/heads/master
Commit: ffc1caada54272e273ca26c17e54f2f91245884f
Parents: 803e1a6
Author: Dave Brosius 
Authored: Mon May 30 13:25:18 2016 -0400
Committer: Dave Brosius 
Committed: Mon May 30 13:25:18 2016 -0400

--
 src/main/java/org/apache/commons/math4/util/MathUtils.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
--


http://git-wip-us.apache.org/repos/asf/commons-math/blob/ffc1caad/src/main/java/org/apache/commons/math4/util/MathUtils.java
--
diff --git a/src/main/java/org/apache/commons/math4/util/MathUtils.java 
b/src/main/java/org/apache/commons/math4/util/MathUtils.java
index fc3e3fe..7f10455 100644
--- a/src/main/java/org/apache/commons/math4/util/MathUtils.java
+++ b/src/main/java/org/apache/commons/math4/util/MathUtils.java
@@ -61,7 +61,7 @@ public final class MathUtils {
  * @return the hash code
  */
 public static int hash(double value) {
-return Double.hashCode(value);
+return new Double(value).hashCode();
 }
 
 /**