Testing POOL-324 org.apache.commons.pool2.impl.GenericObjectPool.getFactoryType() throws java.lang.ClassCastException
Project: http://git-wip-us.apache.org/repos/asf/commons-pool/repo Commit: http://git-wip-us.apache.org/repos/asf/commons-pool/commit/4e57e776 Tree: http://git-wip-us.apache.org/repos/asf/commons-pool/tree/4e57e776 Diff: http://git-wip-us.apache.org/repos/asf/commons-pool/diff/4e57e776 Branch: refs/heads/master Commit: 4e57e776793f89e45d0cb3051a7617f565e3fdc3 Parents: 68b86c2 Author: Gary Gregory <ggreg...@apache.org> Authored: Mon Mar 27 09:35:29 2017 -0700 Committer: Gary Gregory <ggreg...@apache.org> Committed: Mon Mar 27 09:35:29 2017 -0700 ---------------------------------------------------------------------- .../pool2/impl/TestGenericObjectPool.java | 59 +++++++------------- 1 file changed, 19 insertions(+), 40 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/commons-pool/blob/4e57e776/src/test/java/org/apache/commons/pool2/impl/TestGenericObjectPool.java ---------------------------------------------------------------------- diff --git a/src/test/java/org/apache/commons/pool2/impl/TestGenericObjectPool.java b/src/test/java/org/apache/commons/pool2/impl/TestGenericObjectPool.java index f88b421..9bb48cb 100644 --- a/src/test/java/org/apache/commons/pool2/impl/TestGenericObjectPool.java +++ b/src/test/java/org/apache/commons/pool2/impl/TestGenericObjectPool.java @@ -2645,22 +2645,25 @@ public class TestGenericObjectPool extends TestBaseObjectPool { } } + private BasePooledObjectFactory<String> createBasePooledObjectfactory() { + return new BasePooledObjectFactory<String>() { + @Override + public String create() { + // fake + return null; + } + + @Override + public PooledObject<String> wrap(String obj) { + // fake + return null; + } + }; + } + @Test public void testGetFactoryType() { - GenericObjectPool<String> pool = new GenericObjectPool<String>( - new BasePooledObjectFactory<String>() { - @Override - public String create() { - // fake - return null; - } - - @Override - public PooledObject<String> wrap(String obj) { - // fake - return null; - } - }); + GenericObjectPool<String> pool = new GenericObjectPool<String>(createBasePooledObjectfactory()); Assert.assertNotNull((pool.getFactoryType())); } @@ -2668,19 +2671,7 @@ public class TestGenericObjectPool extends TestBaseObjectPool { @Ignore public void testGetFactoryType_PoolUtilssynchronizedPooledFactory() { GenericObjectPool<String> pool = new GenericObjectPool<String>( - PoolUtils.synchronizedPooledFactory(new BasePooledObjectFactory<String>() { - @Override - public String create() { - // fake - return null; - } - - @Override - public PooledObject<String> wrap(String obj) { - // fake - return null; - } - })); + PoolUtils.synchronizedPooledFactory(createBasePooledObjectfactory())); Assert.assertNotNull((pool.getFactoryType())); } @@ -2688,19 +2679,7 @@ public class TestGenericObjectPool extends TestBaseObjectPool { @Ignore public void testGetFactoryType_SynchronizedPooledObjectFactory() { GenericObjectPool<String> pool = new GenericObjectPool<String>( - new TestSynchronizedPooledObjectFactory<String>(new BasePooledObjectFactory<String>() { - @Override - public String create() { - // fake - return null; - } - - @Override - public PooledObject<String> wrap(String obj) { - // fake - return null; - } - })); + new TestSynchronizedPooledObjectFactory<String>(createBasePooledObjectfactory())); Assert.assertNotNull((pool.getFactoryType())); }
