Re: [PR] 4th (and final) cut of New Layer API & Improved Implementation [daffodil]

2024-03-16 Thread via GitHub
mbeckerle commented on code in PR #1187: URL: https://github.com/apache/daffodil/pull/1187#discussion_r1527357442 ## daffodil-runtime1-unparser/src/main/scala/org/apache/daffodil/unparsers/runtime1/PackedBinaryUnparserTraits.scala: ## @@ -94,9 +94,9 @@ abstract class

[jira] [Commented] (DAFFODIL-2845) Layer improvements

2024-03-16 Thread Mike Beckerle (Jira)
[ https://issues.apache.org/jira/browse/DAFFODIL-2845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17827747#comment-17827747 ] Mike Beckerle commented on DAFFODIL-2845: - See PR:

[jira] [Commented] (DAFFODIL-2844) LayerNotEnoughDataException doesn't propagate Throwable Error

2024-03-16 Thread Mike Beckerle (Jira)
[ https://issues.apache.org/jira/browse/DAFFODIL-2844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17827749#comment-17827749 ] Mike Beckerle commented on DAFFODIL-2844: - See PR https://github.com/apache/daffodil/pull/1187

[jira] [Commented] (DAFFODIL-2841) Layers do not support (or poorly documented) creating SDE or Parse/UnparseErrors

2024-03-16 Thread Mike Beckerle (Jira)
[ https://issues.apache.org/jira/browse/DAFFODIL-2841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17827746#comment-17827746 ] Mike Beckerle commented on DAFFODIL-2841: - See PR https://github.com/apache/daffodil/pull/1187

[jira] [Commented] (DAFFODIL-2843) Unclear how to create Parse/UnparseError from ParseOrUnparseState

2024-03-16 Thread Mike Beckerle (Jira)
[ https://issues.apache.org/jira/browse/DAFFODIL-2843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17827745#comment-17827745 ] Mike Beckerle commented on DAFFODIL-2843: - PR https://github.com/apache/daffodil/pull/1187 >

[jira] [Commented] (DAFFODIL-2671) support minInclusive maxInclusive on date/time/dateTime

2024-03-16 Thread Mike Beckerle (Jira)
[ https://issues.apache.org/jira/browse/DAFFODIL-2671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17827741#comment-17827741 ] Mike Beckerle commented on DAFFODIL-2671: - [~slawrence] This ticket seems apropos of a recent

[PR] Update scallop to 5.1.0 [daffodil]

2024-03-16 Thread via GitHub
scala-steward opened a new pull request, #1186: URL: https://github.com/apache/daffodil/pull/1186 ## About this PR  Updates [org.rogach:scallop](https://github.com/scallop/scallop) from `5.0.1` to `5.1.0`  [GitHub Release