Author: bimargulies Date: Mon Aug 29 23:50:32 2011 New Revision: 1163055 URL: http://svn.apache.org/viewvc?rev=1163055&view=rev Log: Add comments.
Modified: maven/sandbox/branches/doxia-ide-eclipse-with-tycho/eclipse-plugins/plugins/org.apache.maven.doxia.ide.eclipse.common.ui/pom.xml maven/sandbox/branches/doxia-ide-eclipse-with-tycho/eclipse-plugins/plugins/org.apache.maven.doxia.ide.eclipse.common.ui/src/main/java/org/apache/maven/doxia/ide/eclipse/common/ui/AbstractDoxiaPlugin.java Modified: maven/sandbox/branches/doxia-ide-eclipse-with-tycho/eclipse-plugins/plugins/org.apache.maven.doxia.ide.eclipse.common.ui/pom.xml URL: http://svn.apache.org/viewvc/maven/sandbox/branches/doxia-ide-eclipse-with-tycho/eclipse-plugins/plugins/org.apache.maven.doxia.ide.eclipse.common.ui/pom.xml?rev=1163055&r1=1163054&r2=1163055&view=diff ============================================================================== --- maven/sandbox/branches/doxia-ide-eclipse-with-tycho/eclipse-plugins/plugins/org.apache.maven.doxia.ide.eclipse.common.ui/pom.xml (original) +++ maven/sandbox/branches/doxia-ide-eclipse-with-tycho/eclipse-plugins/plugins/org.apache.maven.doxia.ide.eclipse.common.ui/pom.xml Mon Aug 29 23:50:32 2011 @@ -31,6 +31,13 @@ under the License. <name>Doxia Tools :: Eclipse IDE - Common UI Plugin</name> <description>Eclipse IDE - Common UI Plugin</description> <build> + <!-- + Sadly, the PDE does not understand copying from someplace like + src/main/resources to the root of the output. So, for the icons + to work from PDE debugging, they have to really be at the top of the + project, and thus this exercise to get them into the output jar + with Maven. + --> <resources> <resource> <targetPath>/</targetPath> Modified: maven/sandbox/branches/doxia-ide-eclipse-with-tycho/eclipse-plugins/plugins/org.apache.maven.doxia.ide.eclipse.common.ui/src/main/java/org/apache/maven/doxia/ide/eclipse/common/ui/AbstractDoxiaPlugin.java URL: http://svn.apache.org/viewvc/maven/sandbox/branches/doxia-ide-eclipse-with-tycho/eclipse-plugins/plugins/org.apache.maven.doxia.ide.eclipse.common.ui/src/main/java/org/apache/maven/doxia/ide/eclipse/common/ui/AbstractDoxiaPlugin.java?rev=1163055&r1=1163054&r2=1163055&view=diff ============================================================================== --- maven/sandbox/branches/doxia-ide-eclipse-with-tycho/eclipse-plugins/plugins/org.apache.maven.doxia.ide.eclipse.common.ui/src/main/java/org/apache/maven/doxia/ide/eclipse/common/ui/AbstractDoxiaPlugin.java (original) +++ maven/sandbox/branches/doxia-ide-eclipse-with-tycho/eclipse-plugins/plugins/org.apache.maven.doxia.ide.eclipse.common.ui/src/main/java/org/apache/maven/doxia/ide/eclipse/common/ui/AbstractDoxiaPlugin.java Mon Aug 29 23:50:32 2011 @@ -132,6 +132,15 @@ public abstract class AbstractDoxiaPlugi // Private methods // ---------------------------------------------------------------------- + /* + * TODO: + * This function gets the icons from a bundle path, not the classpath. + * This in turn requires them to be in the root of the source of the project + * to make the PDE work. It would be better, I think, to put them + * on classpath if Eclipse will let us. + */ + + private ImageDescriptor registerImage( String path ) { Assert.isNotNull( path, "path is not initialized." );