Author: cbrisson Date: Sun Mar 10 12:19:04 2019 New Revision: 1855146 URL: http://svn.apache.org/viewvc?rev=1855146&view=rev Log: [engine][VELOCITY-909] Deprecate directive.include.output_error_start and directive.include.output_error_end (if/how errors are displayed is not the concern of the engine, which should throw in all cases)
Modified: velocity/engine/branches/VELOCITY-909/velocity-engine-core/src/main/java/org/apache/velocity/runtime/RuntimeConstants.java velocity/engine/branches/VELOCITY-909/velocity-engine-core/src/main/java/org/apache/velocity/runtime/directive/Include.java Modified: velocity/engine/branches/VELOCITY-909/velocity-engine-core/src/main/java/org/apache/velocity/runtime/RuntimeConstants.java URL: http://svn.apache.org/viewvc/velocity/engine/branches/VELOCITY-909/velocity-engine-core/src/main/java/org/apache/velocity/runtime/RuntimeConstants.java?rev=1855146&r1=1855145&r2=1855146&view=diff ============================================================================== --- velocity/engine/branches/VELOCITY-909/velocity-engine-core/src/main/java/org/apache/velocity/runtime/RuntimeConstants.java (original) +++ velocity/engine/branches/VELOCITY-909/velocity-engine-core/src/main/java/org/apache/velocity/runtime/RuntimeConstants.java Sun Mar 10 12:19:04 2019 @@ -88,12 +88,14 @@ public interface RuntimeConstants extend /** * Starting tag for error messages triggered by passing a parameter not allowed in the #include directive. Only string literals, * and references are allowed. + * @deprecated if/how errors are displayed is not the concern of the engine, which should throw in all cases */ String ERRORMSG_START = "directive.include.output_error_start"; /** * Ending tag for error messages triggered by passing a parameter not allowed in the #include directive. Only string literals, * and references are allowed. + * @deprecated if/how errors are displayed is not the concern of the engine, which should throw in all cases */ String ERRORMSG_END = "directive.include.output_error_end"; Modified: velocity/engine/branches/VELOCITY-909/velocity-engine-core/src/main/java/org/apache/velocity/runtime/directive/Include.java URL: http://svn.apache.org/viewvc/velocity/engine/branches/VELOCITY-909/velocity-engine-core/src/main/java/org/apache/velocity/runtime/directive/Include.java?rev=1855146&r1=1855145&r2=1855146&view=diff ============================================================================== --- velocity/engine/branches/VELOCITY-909/velocity-engine-core/src/main/java/org/apache/velocity/runtime/directive/Include.java (original) +++ velocity/engine/branches/VELOCITY-909/velocity-engine-core/src/main/java/org/apache/velocity/runtime/directive/Include.java Sun Mar 10 12:19:04 2019 @@ -287,6 +287,7 @@ public class Include extends InputBase * @param writer * @param msg * @throws IOException + * @deprecated if/how errors are displayed is not the concern of the engine, which should throw in all cases */ private void outputErrorToStream( Writer writer, String msg ) throws IOException