Author: cbrisson Date: Fri Jun 29 07:09:19 2007 New Revision: 551904 URL: http://svn.apache.org/viewvc?view=rev&rev=551904 Log: protect BrowserTool from requests without user agent
Modified: velocity/tools/branches/2.x/src/main/java/org/apache/velocity/tools/view/BrowserTool.java Modified: velocity/tools/branches/2.x/src/main/java/org/apache/velocity/tools/view/BrowserTool.java URL: http://svn.apache.org/viewvc/velocity/tools/branches/2.x/src/main/java/org/apache/velocity/tools/view/BrowserTool.java?view=diff&rev=551904&r1=551903&r2=551904 ============================================================================== --- velocity/tools/branches/2.x/src/main/java/org/apache/velocity/tools/view/BrowserTool.java (original) +++ velocity/tools/branches/2.x/src/main/java/org/apache/velocity/tools/view/BrowserTool.java Fri Jun 29 07:09:19 2007 @@ -84,7 +84,12 @@ { throw new NullPointerException("request should not be null"); } - userAgent = request.getHeader("User-Agent").toLowerCase(); + userAgent = request.getHeader("User-Agent"); + if(userAgent == null) { + userAgent = ""; + } else { + userAgent = userAgent.toLowerCase(); + } } /* Generic getter for unknown tests