Re: [PR] HADOOP-19156. ZooKeeper based state stores use different ZK address c… [hadoop]

Hexiaoqiao commented on PR #6767: URL: https://github.com/apache/hadoop/pull/6767#issuecomment-2106914489 cc @slfan1989 @ayushtkn would you mind to give another reviews? Thanks. BTW, `mvnsite` seems not related with this changes. Will follow up at ML for a while. -- This is an

Re: [PR] HADOOP-19156. ZooKeeper based state stores use different ZK address c… [hadoop]

hadoop-yetus commented on PR #6767: URL: https://github.com/apache/hadoop/pull/6767#issuecomment-2105500387 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

Re: [PR] HADOOP-19156. ZooKeeper based state stores use different ZK address c… [hadoop]

hadoop-yetus commented on PR #6767: URL: https://github.com/apache/hadoop/pull/6767#issuecomment-2105055678 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HADOOP-19156. ZooKeeper based state stores use different ZK address c… [hadoop]

hadoop-yetus commented on PR #6767: URL: https://github.com/apache/hadoop/pull/6767#issuecomment-2104169307 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

Re: [PR] HADOOP-19156. ZooKeeper based state stores use different ZK address c… [hadoop]

hadoop-yetus commented on PR #6767: URL: https://github.com/apache/hadoop/pull/6767#issuecomment-2101905008 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

Re: [PR] HADOOP-19156. ZooKeeper based state stores use different ZK address c… [hadoop]

Hexiaoqiao commented on PR #6767: URL: https://github.com/apache/hadoop/pull/6767#issuecomment-2100603374 @liubin101 Almost look good to me. Also need to update ResourceManagerHA.md / Federation.md / ResourceManagerRestart.md about zk config guide. Thanks. -- This is an automated message

Re: [PR] HADOOP-19156. ZooKeeper based state stores use different ZK address c… [hadoop]

hadoop-yetus commented on PR #6767: URL: https://github.com/apache/hadoop/pull/6767#issuecomment-2099680632 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HADOOP-19156. ZooKeeper based state stores use different ZK address c… [hadoop]

liubin101 commented on code in PR #6767: URL: https://github.com/apache/hadoop/pull/6767#discussion_r1593306172 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/curator/ZKCuratorManager.java: ## @@ -135,29 +135,51 @@ public void start() throws

Re: [PR] HADOOP-19156. ZooKeeper based state stores use different ZK address c… [hadoop]

slfan1989 commented on code in PR #6767: URL: https://github.com/apache/hadoop/pull/6767#discussion_r1586919556 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/curator/ZKCuratorManager.java: ## @@ -135,29 +135,51 @@ public void start() throws

Re: [PR] HADOOP-19156. ZooKeeper based state stores use different ZK address c… [hadoop]

hadoop-yetus commented on PR #6767: URL: https://github.com/apache/hadoop/pull/6767#issuecomment-2086063685 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HADOOP-19156. ZooKeeper based state stores use different ZK address c… [hadoop]

liubin101 commented on PR #6767: URL: https://github.com/apache/hadoop/pull/6767#issuecomment-2081785275 > @liubin101 Thanks for your works. Strong +1 from my side. Just one concerns, we should consider to be compatible with the old configuration keys. Thanks.

Re: [PR] HADOOP-19156. ZooKeeper based state stores use different ZK address c… [hadoop]

hadoop-yetus commented on PR #6767: URL: https://github.com/apache/hadoop/pull/6767#issuecomment-2081593653 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

Re: [PR] HADOOP-19156. ZooKeeper based state stores use different ZK address c… [hadoop]

Hexiaoqiao commented on PR #6767: URL: https://github.com/apache/hadoop/pull/6767#issuecomment-2081488645 @liubin101 Thanks for your works. Strong +1 from my side. Just one concerns, we should consider to be compatible with the old configuration keys. Thanks. -- This is an automated

Re: [PR] HADOOP-19156. ZooKeeper based state stores use different ZK address c… [hadoop]

hadoop-yetus commented on PR #6767: URL: https://github.com/apache/hadoop/pull/6767#issuecomment-2081478842 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

Re: [PR] HADOOP-19156. ZooKeeper based state stores use different ZK address c… [hadoop]

hadoop-yetus commented on PR #6767: URL: https://github.com/apache/hadoop/pull/6767#issuecomment-2081429516 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HADOOP-19156. ZooKeeper based state stores use different ZK address c… [hadoop]

hadoop-yetus commented on PR #6767: URL: https://github.com/apache/hadoop/pull/6767#issuecomment-2079146708 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HADOOP-19156. ZooKeeper based state stores use different ZK address c… [hadoop]

hadoop-yetus commented on PR #6767: URL: https://github.com/apache/hadoop/pull/6767#issuecomment-2075430805 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[PR] HADOOP-19156. ZooKeeper based state stores use different ZK address c… [hadoop]

liubin101 opened a new pull request, #6767: URL: https://github.com/apache/hadoop/pull/6767 ### Description of PR Currently, the Zookeeper-based state stores of RM, YARN Federation, and HDFS Federation use the same ZK address config `hadoop.zk.address`. But in our production