Re: [PR] HDFS-17401. EC: Excess internal block may not be able to be deleted correctly when it's stored in fallback storage [hadoop]

hadoop-yetus commented on PR #6597: URL: https://github.com/apache/hadoop/pull/6597#issuecomment-2076378724 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

Re: [PR] HDFS-17401. EC: Excess internal block may not be able to be deleted correctly when it's stored in fallback storage [hadoop]

haiyang1987 commented on code in PR #6597: URL: https://github.com/apache/hadoop/pull/6597#discussion_r1522764907 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestReconstructStripedBlocks.java: ## @@ -575,5 +576,80 @@ public void

Re: [PR] HDFS-17401. EC: Excess internal block may not be able to be deleted correctly when it's stored in fallback storage [hadoop]

hadoop-yetus commented on PR #6597: URL: https://github.com/apache/hadoop/pull/6597#issuecomment-1996015292 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17401. EC: Excess internal block may not be able to be deleted correctly when it's stored in fallback storage [hadoop]

haiyang1987 commented on PR #6597: URL: https://github.com/apache/hadoop/pull/6597#issuecomment-1993832664 From my side seems well, except for some small issues in test UT. please @zhangshuyan0 help review it again, thanks~ -- This is an automated message from the Apache Git

Re: [PR] HDFS-17401. EC: Excess internal block may not be able to be deleted correctly when it's stored in fallback storage [hadoop]

haiyang1987 commented on code in PR #6597: URL: https://github.com/apache/hadoop/pull/6597#discussion_r1522666775 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestReconstructStripedBlocks.java: ## @@ -575,5 +576,80 @@ public void

Re: [PR] HDFS-17401. EC: Excess internal block may not be able to be deleted correctly when it's stored in fallback storage [hadoop]

hadoop-yetus commented on PR #6597: URL: https://github.com/apache/hadoop/pull/6597#issuecomment-1989664239 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17401. EC: Excess internal block may not be able to be deleted correctly when it's stored in fallback storage [hadoop]

hadoop-yetus commented on PR #6597: URL: https://github.com/apache/hadoop/pull/6597#issuecomment-1989493142 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17401. EC: Excess internal block may not be able to be deleted correctly when it's stored in fallback storage [hadoop]

hadoop-yetus commented on PR #6597: URL: https://github.com/apache/hadoop/pull/6597#issuecomment-1989203593 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17401. EC: Excess internal block may not be able to be deleted correctly when it's stored in fallback storage [hadoop]

RuinanGu commented on PR #6597: URL: https://github.com/apache/hadoop/pull/6597#issuecomment-1988972943 > In` BlockManager.java`the variable `logEmptyExcessType` seems unused can remove? This parameter is added in [https://github.com/apache/hadoop/pull/5474](url) (Also a patch I

Re: [PR] HDFS-17401. EC: Excess internal block may not be able to be deleted correctly when it's stored in fallback storage [hadoop]

haiyang1987 commented on code in PR #6597: URL: https://github.com/apache/hadoop/pull/6597#discussion_r1519564314 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestReconstructStripedBlocks.java: ## @@ -575,5 +576,78 @@ public void

Re: [PR] HDFS-17401. EC: Excess internal block may not be able to be deleted correctly when it's stored in fallback storage [hadoop]

haiyang1987 commented on code in PR #6597: URL: https://github.com/apache/hadoop/pull/6597#discussion_r1519563597 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java: ## @@ -4359,9 +4348,15 @@ private void

Re: [PR] HDFS-17401. EC: Excess internal block may not be able to be deleted correctly when it's stored in fallback storage [hadoop]

haiyang1987 commented on PR #6597: URL: https://github.com/apache/hadoop/pull/6597#issuecomment-1988219761 In` BlockManager.java`the variable `logEmptyExcessType` seems unused can remove? -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] HDFS-17401. EC: Excess internal block may not be able to be deleted correctly when it's stored in fallback storage [hadoop]

hadoop-yetus commented on PR #6597: URL: https://github.com/apache/hadoop/pull/6597#issuecomment-1987280103 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17401. EC: Excess internal block may not be able to be deleted correctly when it's stored in fallback storage [hadoop]

haiyang1987 commented on PR #6597: URL: https://github.com/apache/hadoop/pull/6597#issuecomment-1987086735 please fix checkstytle, thanks~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] HDFS-17401. EC: Excess internal block may not be able to be deleted correctly when it's stored in fallback storage [hadoop]

hadoop-yetus commented on PR #6597: URL: https://github.com/apache/hadoop/pull/6597#issuecomment-1986986934 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17401. EC: Excess internal block may not be able to be deleted correctly when it's stored in fallback storage [hadoop]

haiyang1987 commented on code in PR #6597: URL: https://github.com/apache/hadoop/pull/6597#discussion_r1516059534 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestReconstructStripedBlocks.java: ## @@ -575,5 +576,82 @@ public void

Re: [PR] HDFS-17401. EC: Excess internal block may not be able to be deleted correctly when it's stored in fallback storage [hadoop]

haiyang1987 commented on code in PR #6597: URL: https://github.com/apache/hadoop/pull/6597#discussion_r1515435820 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestReconstructStripedBlocks.java: ## @@ -575,5 +576,82 @@ public void

Re: [PR] HDFS-17401. EC: Excess internal block may not be able to be deleted correctly when it's stored in fallback storage [hadoop]

hadoop-yetus commented on PR #6597: URL: https://github.com/apache/hadoop/pull/6597#issuecomment-1981846301 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17401. EC: Excess internal block may not be able to be deleted correctly when it's stored in fallback storage [hadoop]

zhangshuyan0 commented on code in PR #6597: URL: https://github.com/apache/hadoop/pull/6597#discussion_r1514212224 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestReconstructStripedBlocks.java: ## @@ -27,13 +27,7 @@ import