Re: [PR] HDFS-17463. Support the switch StringTable Split ID feature [hadoop]

2024-05-13 Thread via GitHub
hiwangzhihui commented on PR #6736: URL: https://github.com/apache/hadoop/pull/6736#issuecomment-2106760458 @Hexiaoqiao I agree with your propose , We will proceed with work for it. Thank you for your guide. -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] HDFS-17463. Support the switch StringTable Split ID feature [hadoop]

2024-04-29 Thread via GitHub
Hexiaoqiao commented on PR #6736: URL: https://github.com/apache/hadoop/pull/6736#issuecomment-2082660933 @XbaoWu @hiwangzhihui Thanks for your works. I prefer to push this feature into tool module. a. I totally agree that fsimage is not compatible with all versions (include some

Re: [PR] HDFS-17463. Support the switch StringTable Split ID feature [hadoop]

2024-04-29 Thread via GitHub
hadoop-yetus commented on PR #6736: URL: https://github.com/apache/hadoop/pull/6736#issuecomment-2082632595 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

Re: [PR] HDFS-17463. Support the switch StringTable Split ID feature [hadoop]

2024-04-25 Thread via GitHub
hadoop-yetus commented on PR #6736: URL: https://github.com/apache/hadoop/pull/6736#issuecomment-2076952024 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17463. Support the switch StringTable Split ID feature [hadoop]

2024-04-23 Thread via GitHub
hadoop-yetus commented on PR #6736: URL: https://github.com/apache/hadoop/pull/6736#issuecomment-2073100512 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17463. Support the switch StringTable Split ID feature [hadoop]

2024-04-23 Thread via GitHub
hadoop-yetus commented on PR #6736: URL: https://github.com/apache/hadoop/pull/6736#issuecomment-2072822967 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

Re: [PR] HDFS-17463. Support the switch StringTable Split ID feature [hadoop]

2024-04-19 Thread via GitHub
hadoop-yetus commented on PR #6736: URL: https://github.com/apache/hadoop/pull/6736#issuecomment-2066734147 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17463. Support the switch StringTable Split ID feature [hadoop]

2024-04-16 Thread via GitHub
hadoop-yetus commented on PR #6736: URL: https://github.com/apache/hadoop/pull/6736#issuecomment-2058962419 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17463. Support the switch StringTable Split ID feature [hadoop]

2024-04-16 Thread via GitHub
XbaoWu commented on code in PR #6736: URL: https://github.com/apache/hadoop/pull/6736#discussion_r1567230524 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/SerialNumberManager.java: ## @@ -115,6 +119,36 @@ public static StringTable

Re: [PR] HDFS-17463. Support the switch StringTable Split ID feature [hadoop]

2024-04-16 Thread via GitHub
XbaoWu commented on code in PR #6736: URL: https://github.com/apache/hadoop/pull/6736#discussion_r1567205509 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/SerialNumberManager.java: ## @@ -115,6 +119,36 @@ public static StringTable

Re: [PR] HDFS-17463. Support the switch StringTable Split ID feature [hadoop]

2024-04-16 Thread via GitHub
XbaoWu commented on code in PR #6736: URL: https://github.com/apache/hadoop/pull/6736#discussion_r1567203473 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImageFormatPBINode.java: ## @@ -628,25 +638,59 @@ private void

Re: [PR] HDFS-17463. Support the switch StringTable Split ID feature [hadoop]

2024-04-16 Thread via GitHub
XbaoWu commented on code in PR #6736: URL: https://github.com/apache/hadoop/pull/6736#discussion_r1567198629 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/AclEntryStatusFormat.java: ## @@ -47,7 +47,7 @@ public enum AclEntryStatusFormat

Re: [PR] HDFS-17463. Support the switch StringTable Split ID feature [hadoop]

2024-04-16 Thread via GitHub
hiwangzhihui commented on code in PR #6736: URL: https://github.com/apache/hadoop/pull/6736#discussion_r1566889645 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/SerialNumberManager.java: ## @@ -115,6 +119,36 @@ public static StringTable

[PR] HDFS-17463. Support the switch StringTable Split ID feature [hadoop]

2024-04-16 Thread via GitHub
XbaoWu opened a new pull request, #6736: URL: https://github.com/apache/hadoop/pull/6736 ### Description of PR Hadoop 3.2 introduced optimization features for HDFS StringTable (b60ca37914b22550e3630fa02742d40697decb3), It resulted in lower versions of Hadoop upgraded to 3.2 and