Re: [PR] YARN-11684. Fix general contract violation in PriorityQueueComparator… [hadoop]

2024-04-25 Thread via GitHub
slfan1989 commented on PR #6753: URL: https://github.com/apache/hadoop/pull/6753#issuecomment-2077624938 @tomicooler Thanks for the contribution! Merged into branch-3.4. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] YARN-11684. Fix general contract violation in PriorityQueueComparator… [hadoop]

2024-04-25 Thread via GitHub
slfan1989 merged PR #6753: URL: https://github.com/apache/hadoop/pull/6753 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] YARN-11684. Fix general contract violation in PriorityQueueComparator… [hadoop]

2024-04-23 Thread via GitHub
hadoop-yetus commented on PR #6753: URL: https://github.com/apache/hadoop/pull/6753#issuecomment-2072124888 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] YARN-11684. Fix general contract violation in PriorityQueueComparator… [hadoop]

2024-04-23 Thread via GitHub
hadoop-yetus commented on PR #6753: URL: https://github.com/apache/hadoop/pull/6753#issuecomment-2071566319 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

Re: [PR] YARN-11684. Fix general contract violation in PriorityQueueComparator… [hadoop]

2024-04-22 Thread via GitHub
slfan1989 commented on PR #6754: URL: https://github.com/apache/hadoop/pull/6754#issuecomment-2071158121 @tomicooler Thanks for the contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] YARN-11684. Fix general contract violation in PriorityQueueComparator… [hadoop]

2024-04-22 Thread via GitHub
slfan1989 merged PR #6754: URL: https://github.com/apache/hadoop/pull/6754 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] YARN-11684. Fix general contract violation in PriorityQueueComparator… [hadoop]

2024-04-19 Thread via GitHub
hadoop-yetus commented on PR #6753: URL: https://github.com/apache/hadoop/pull/6753#issuecomment-2066990100 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] YARN-11684. Fix general contract violation in PriorityQueueComparator… [hadoop]

2024-04-19 Thread via GitHub
hadoop-yetus commented on PR #6754: URL: https://github.com/apache/hadoop/pull/6754#issuecomment-2066856438 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[PR] YARN-11684. Fix general contract violation in PriorityQueueComparator… [hadoop]

2024-04-19 Thread via GitHub
tomicooler opened a new pull request, #6754: URL: https://github.com/apache/hadoop/pull/6754 …. (#6725) Contributed by Tamas Domok. Signed-off-by: Shilun Fan (cherry picked from commit a386ac1f5632949bc49a9d09195073ba5f980b5c) ### Description of PR Backport.

[PR] YARN-11684. Fix general contract violation in PriorityQueueComparator… [hadoop]

2024-04-19 Thread via GitHub
tomicooler opened a new pull request, #6753: URL: https://github.com/apache/hadoop/pull/6753 …. (#6725) Contributed by Tamas Domok. Signed-off-by: Shilun Fan (cherry picked from commit a386ac1f5632949bc49a9d09195073ba5f980b5c) ### Description of PR Backport.

Re: [PR] YARN-11684. Fix general contract violation in PriorityQueueComparator. [hadoop]

2024-04-18 Thread via GitHub
slfan1989 commented on PR #6725: URL: https://github.com/apache/hadoop/pull/6725#issuecomment-2065544174 @tomicooler Thanks for the contribution! Merged into trunk. @p-szucs Thanks for the review! -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] YARN-11684. Fix general contract violation in PriorityQueueComparator. [hadoop]

2024-04-18 Thread via GitHub
slfan1989 merged PR #6725: URL: https://github.com/apache/hadoop/pull/6725 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] YARN-11684. Fix general contract violation in PriorityQueueComparator. [hadoop]

2024-04-15 Thread via GitHub
p-szucs commented on PR #6725: URL: https://github.com/apache/hadoop/pull/6725#issuecomment-2057244899 Thanks @tomicooler for the patch, LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] YARN-11684. Fix general contract violation in PriorityQueueComparator. [hadoop]

2024-04-15 Thread via GitHub
hadoop-yetus commented on PR #6725: URL: https://github.com/apache/hadoop/pull/6725#issuecomment-2056538051 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] YARN-11684. Fix general contract violation in PriorityQueueComparator. [hadoop]

2024-04-14 Thread via GitHub
tomicooler commented on PR #6725: URL: https://github.com/apache/hadoop/pull/6725#issuecomment-2054110615 @slfan1989 thanks for the review, I'll fix those tomorrow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] YARN-11684. Fix general contract violation in PriorityQueueComparator. [hadoop]

2024-04-14 Thread via GitHub
slfan1989 commented on PR #6725: URL: https://github.com/apache/hadoop/pull/6725#issuecomment-2054067082 @tomicooler We need to fix the checkstyle issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] YARN-11684. Fix general contract violation in PriorityQueueComparator. [hadoop]

2024-04-12 Thread via GitHub
hadoop-yetus commented on PR #6725: URL: https://github.com/apache/hadoop/pull/6725#issuecomment-2051972158 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[PR] YARN-11684. Fix general contract violation in PriorityQueueComparator. [hadoop]

2024-04-12 Thread via GitHub
tomicooler opened a new pull request, #6725: URL: https://github.com/apache/hadoop/pull/6725 Change-Id: I0ca72134b3328a250445ad41525d76d6cbd50a98 ### Description of PR Jira: [YARN-11684](https://issues.apache.org/jira/browse/YARN-11684) Previous attempt for the fix: