Re: [PR] HADOOP-19073 WASB: Fix connection leak in FolderRenamePending [hadoop]

2024-05-15 Thread via GitHub
steveloughran commented on PR #6534: URL: https://github.com/apache/hadoop/pull/6534#issuecomment-2112568052 thanks, merged to trunk and updated the JIRA. If you do a cherrypick of this commit and submit as a PR against branch-3.4 I'll merge it there too, once yetus is happy --

Re: [PR] HADOOP-19073 WASB: Fix connection leak in FolderRenamePending [hadoop]

2024-05-15 Thread via GitHub
steveloughran merged PR #6534: URL: https://github.com/apache/hadoop/pull/6534 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HADOOP-19073 WASB: Fix connection leak in FolderRenamePending [hadoop]

2024-05-13 Thread via GitHub
xuzifu666 commented on PR #6534: URL: https://github.com/apache/hadoop/pull/6534#issuecomment-2109009003 > @xuzifu666 before I merge, what name do you want to be credited with in the patch...your github account doesn't have one. Thanks for your review, do you mean my real name? My

Re: [PR] HADOOP-19073 WASB: Fix connection leak in FolderRenamePending [hadoop]

2024-05-13 Thread via GitHub
steveloughran commented on PR #6534: URL: https://github.com/apache/hadoop/pull/6534#issuecomment-2108366767 @xuzifu666 before I merge, what name do you want to be credited with in the patch...your github account doesn't have one. -- This is an automated message from the Apache Git

Re: [PR] HADOOP-19073 WASB: Fix connection leak in FolderRenamePending [hadoop]

2024-05-13 Thread via GitHub
steveloughran commented on PR #6534: URL: https://github.com/apache/hadoop/pull/6534#issuecomment-2108355675 I've been away for a week and am catching up, so not tested yet, sorry... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] HADOOP-19073 WASB: Fix connection leak in FolderRenamePending [hadoop]

2024-05-05 Thread via GitHub
xuzifu666 commented on PR #6534: URL: https://github.com/apache/hadoop/pull/6534#issuecomment-2095114022 > let me try and test this myself. OK,Thanks,currently it can be work now? @steveloughran -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] HADOOP-19073 WASB: Fix connection leak in FolderRenamePending [hadoop]

2024-05-02 Thread via GitHub
steveloughran commented on PR #6534: URL: https://github.com/apache/hadoop/pull/6534#issuecomment-2091420304 (which I can't do today as both my hadoop source trees are testing my "support parallel tests against the same s3 bucket" right now... -- This is an automated message from the

Re: [PR] HADOOP-19073 WASB: Fix connection leak in FolderRenamePending [hadoop]

2024-05-02 Thread via GitHub
steveloughran commented on PR #6534: URL: https://github.com/apache/hadoop/pull/6534#issuecomment-2091418801 let me try and test this myself. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] HADOOP-19073 WASB: Fix connection leak in FolderRenamePending [hadoop]

2024-04-26 Thread via GitHub
xuzifu666 commented on PR #6534: URL: https://github.com/apache/hadoop/pull/6534#issuecomment-2078699796 @steveloughran could you give the final review or close the pr? Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] HADOOP-19073 WASB: Fix connection leak in FolderRenamePending [hadoop]

2024-04-25 Thread via GitHub
xuzifu666 commented on PR #6534: URL: https://github.com/apache/hadoop/pull/6534#issuecomment-2078294578 > > @xuzifu666 yes. > > > > 1. Which azure region did you run all the wasb tests against > > 2. and what were your maven command line arguments used? > > 3. did any tests

Re: [PR] HADOOP-19073 WASB: Fix connection leak in FolderRenamePending [hadoop]

2024-04-25 Thread via GitHub
hadoop-yetus commented on PR #6534: URL: https://github.com/apache/hadoop/pull/6534#issuecomment-2077324557 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

Re: [PR] HADOOP-19073 WASB: Fix connection leak in FolderRenamePending [hadoop]

2024-02-18 Thread via GitHub
xuzifu666 commented on PR #6534: URL: https://github.com/apache/hadoop/pull/6534#issuecomment-1951137482 > @xuzifu666 yes. > > 1. Which azure region did you run all the wasb tests against > 2. and what were your maven command line arguments used? > 3. did any tests fail?

Re: [PR] HADOOP-19073 WASB: Fix connection leak in FolderRenamePending [hadoop]

2024-02-09 Thread via GitHub
steveloughran commented on PR #6534: URL: https://github.com/apache/hadoop/pull/6534#issuecomment-1936498628 @xuzifu666 yes. 1. Which azure region did you run all the wasb tests against 2. and what were your maven command line arguments used? 3. did any tests fail? -- This is an

Re: [PR] HADOOP-19073 WASB: Fix connection leak in FolderRenamePending [hadoop]

2024-02-09 Thread via GitHub
xuzifu666 commented on PR #6534: URL: https://github.com/apache/hadoop/pull/6534#issuecomment-1936056092 > moved to hadoop; azure component. > > now, the bad news: as it goes near a cloud store, you *have* to run the entire hadoop-azure tests for the wasb component, and tell us

Re: [PR] HADOOP-19073 WASB: Fix connection leak in FolderRenamePending [hadoop]

2024-02-09 Thread via GitHub
steveloughran commented on PR #6534: URL: https://github.com/apache/hadoop/pull/6534#issuecomment-1936045642 moved to hadoop; azure component. now, the bad news: as it goes near a cloud store, you *have* to run the entire hadoop-azure tests for the wasb component, and tell us which