Re: [PR] HADOOP-18679. Add API for bulk/paged object deletion [hadoop]

2024-04-25 Thread via GitHub
mukund-thakur commented on code in PR #6726: URL: https://github.com/apache/hadoop/pull/6726#discussion_r1580173720 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/DefalutBulkDeleteSource.java: ## @@ -0,0 +1,38 @@ +/** + * Licensed to the Apache

Re: [PR] HADOOP-19139.No GetPathStatus for opening AbfsInputStream [hadoop]

2024-04-25 Thread via GitHub
saxenapranav commented on PR #6699: URL: https://github.com/apache/hadoop/pull/6699#issuecomment-2078578293 @steveloughran , @mukund-thakur , @mehakmeet , requesting your kind review please. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] HADOOP-18682. Move hadoop docker scripts under the main source code [hadoop]

2024-04-25 Thread via GitHub
hadoop-yetus commented on PR #6483: URL: https://github.com/apache/hadoop/pull/6483#issuecomment-2078631754 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

[jira] [Commented] (HADOOP-18682) Move hadoop docker scripts under the main source code

2024-04-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17841050#comment-17841050 ] ASF GitHub Bot commented on HADOOP-18682: - hadoop-yetus commented on PR #6483: URL:

Re: [PR] HDFS-17438. RBF: The newest STANDBY and UNAVAILABLE nn should be the lowest priority. [hadoop]

2024-04-25 Thread via GitHub
hadoop-yetus commented on PR #6655: URL: https://github.com/apache/hadoop/pull/6655#issuecomment-2078682775 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18679) Add API for bulk/paged object deletion

2024-04-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840989#comment-17840989 ] ASF GitHub Bot commented on HADOOP-18679: - mukund-thakur commented on code in PR #6726: URL:

Re: [PR] HDFS-17344. Last packet will be splited into two parts when write block. [hadoop]

2024-04-25 Thread via GitHub
hadoop-yetus commented on PR #6478: URL: https://github.com/apache/hadoop/pull/6478#issuecomment-2078402028 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

Re: [PR] YARN-11644. LogAggregationService can't upload log in time when application finished [hadoop]

2024-04-25 Thread via GitHub
hadoop-yetus commented on PR #6452: URL: https://github.com/apache/hadoop/pull/6452#issuecomment-2078653415 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

Re: [PR] HDFS-17341: Support dedicated user queues in Namenode FairCallQueue [hadoop]

2024-04-25 Thread via GitHub
hadoop-yetus commented on PR #6461: URL: https://github.com/apache/hadoop/pull/6461#issuecomment-2078623638 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

[jira] [Commented] (HADOOP-18938) S3A region logic to handle vpce and non standard endpoints

2024-04-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17841054#comment-17841054 ] ASF GitHub Bot commented on HADOOP-18938: - hadoop-yetus commented on PR #6466: URL:

Re: [PR] YARN-11649. [Federation] Create Override for Maximum Resource Capability in getNewApplication [hadoop]

2024-04-25 Thread via GitHub
hadoop-yetus commented on PR #6481: URL: https://github.com/apache/hadoop/pull/6481#issuecomment-2078481513 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

[jira] [Commented] (HADOOP-19158) S3A: Support ByteBufferPositionedReadable through vector IO

2024-04-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840990#comment-17840990 ] ASF GitHub Bot commented on HADOOP-19158: - hadoop-yetus commented on PR #6773: URL:

Re: [PR] HADOOP-19158. S3A: Support ByteBufferPositionedReadable through vector IO [hadoop]

2024-04-25 Thread via GitHub
hadoop-yetus commented on PR #6773: URL: https://github.com/apache/hadoop/pull/6773#issuecomment-2078254536 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17365. EC: Add extra redunency configuration in checkStreamerFailures to prevent data loss. [hadoop]

2024-04-25 Thread via GitHub
hadoop-yetus commented on PR #6517: URL: https://github.com/apache/hadoop/pull/6517#issuecomment-2078301297 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

Re: [PR] MAPREDUCE-7470: multi-thread mapreduce committer [hadoop]

2024-04-25 Thread via GitHub
hadoop-yetus commented on PR #6469: URL: https://github.com/apache/hadoop/pull/6469#issuecomment-2078561571 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

Re: [PR] HADOOP-19134. Use StringBuilder instead of StringBuffer. [hadoop]

2024-04-25 Thread via GitHub
hadoop-yetus commented on PR #6692: URL: https://github.com/apache/hadoop/pull/6692#issuecomment-2078615455 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-19134) use StringBuilder instead of StringBuffer

2024-04-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17841045#comment-17841045 ] ASF GitHub Bot commented on HADOOP-19134: - hadoop-yetus commented on PR #6692: URL:

Re: [PR] HADOOP-18938. AWS SDK v2: Fix endpoint region parsing for vpc endpoints. [hadoop]

2024-04-25 Thread via GitHub
hadoop-yetus commented on PR #6466: URL: https://github.com/apache/hadoop/pull/6466#issuecomment-2078647702 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

[jira] [Commented] (HADOOP-19131) Assist reflection IO with WrappedOperations class

2024-04-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840993#comment-17840993 ] ASF GitHub Bot commented on HADOOP-19131: - hadoop-yetus commented on PR #6686: URL:

[jira] [Commented] (HADOOP-19036) Standardize Maven Initialization Across Operating Systems

2024-04-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17841013#comment-17841013 ] ASF GitHub Bot commented on HADOOP-19036: - hadoop-yetus commented on PR #6444: URL:

Re: [PR] HADOOP-19036. Standardize Maven Initialization Across Operating Systems. [hadoop]

2024-04-25 Thread via GitHub
hadoop-yetus commented on PR #6444: URL: https://github.com/apache/hadoop/pull/6444#issuecomment-2078467162 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | -1 :x: | patch

[jira] [Commented] (HADOOP-19037) S3A: S3A: ITestS3AConfiguration failing with region problems

2024-04-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840991#comment-17840991 ] ASF GitHub Bot commented on HADOOP-19037: - hadoop-yetus commented on PR #6486: URL:

Re: [PR] HADOOP-19037. AWS SDK v2: ITestS3AConfiguration failing with region problems [hadoop]

2024-04-25 Thread via GitHub
hadoop-yetus commented on PR #6486: URL: https://github.com/apache/hadoop/pull/6486#issuecomment-2078256387 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

Re: [PR] HADOOP-19073 WASB: Fix connection leak in FolderRenamePending [hadoop]

2024-04-25 Thread via GitHub
xuzifu666 commented on PR #6534: URL: https://github.com/apache/hadoop/pull/6534#issuecomment-2078294578 > > @xuzifu666 yes. > > > > 1. Which azure region did you run all the wasb tests against > > 2. and what were your maven command line arguments used? > > 3. did any tests

[jira] [Commented] (HADOOP-19073) WASB: Fix connection leak in FolderRenamePending

2024-04-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17841002#comment-17841002 ] ASF GitHub Bot commented on HADOOP-19073: - xuzifu666 commented on PR #6534: URL:

Re: [PR] YARN-11690. Update container executor to use CGROUP2_SUPER_MAGIC in cgroup 2 scenarios [hadoop]

2024-04-25 Thread via GitHub
tomicooler commented on code in PR #6771: URL: https://github.com/apache/hadoop/pull/6771#discussion_r1580335818 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/container-executor.h: ## @@ -80,6 +80,11

[jira] [Commented] (HADOOP-19131) Assist reflection IO with WrappedOperations class

2024-04-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840994#comment-17840994 ] ASF GitHub Bot commented on HADOOP-19131: - hadoop-yetus commented on PR #6686: URL:

Re: [PR] HADOOP-19131. Assist reflection IO with WrappedOperations class [hadoop]

2024-04-25 Thread via GitHub
hadoop-yetus commented on PR #6686: URL: https://github.com/apache/hadoop/pull/6686#issuecomment-2078260263 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HADOOP-19131. Assist reflection IO with WrappedOperations class [hadoop]

2024-04-25 Thread via GitHub
hadoop-yetus commented on PR #6686: URL: https://github.com/apache/hadoop/pull/6686#issuecomment-2078260697 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] TEST [hadoop]

2024-04-25 Thread via GitHub
hadoop-yetus commented on PR #6477: URL: https://github.com/apache/hadoop/pull/6477#issuecomment-2078435553 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

[jira] [Commented] (HADOOP-19139) [ABFS]: No GetPathStatus call for opening AbfsInputStream

2024-04-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17841037#comment-17841037 ] ASF GitHub Bot commented on HADOOP-19139: - saxenapranav commented on PR #6699: URL:

[jira] [Commented] (HADOOP-19137) [ABFS]:Extra getAcl call while calling the very first API of FileSystem

2024-04-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840674#comment-17840674 ] ASF GitHub Bot commented on HADOOP-19137: - saxenapranav commented on code in PR #6752: URL:

[jira] [Commented] (HADOOP-19137) [ABFS]:Extra getAcl call while calling the very first API of FileSystem

2024-04-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840673#comment-17840673 ] ASF GitHub Bot commented on HADOOP-19137: - saxenapranav commented on code in PR #6752: URL:

Re: [PR] HADOOP-19137. [ABFS]Fail fs init if cpk config is given on non-hns account [hadoop]

2024-04-25 Thread via GitHub
saxenapranav commented on code in PR #6752: URL: https://github.com/apache/hadoop/pull/6752#discussion_r1578968010 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystemStore.java: ## @@ -373,7 +372,21 @@ public boolean

Re: [PR] HADOOP-19139.No GetPathStatus for opening AbfsInputStream [hadoop]

2024-04-25 Thread via GitHub
anmolanmol1234 commented on code in PR #6699: URL: https://github.com/apache/hadoop/pull/6699#discussion_r1578933240 ## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAbfsNetworkStatistics.java: ## @@ -231,7 +237,17 @@ public void

[jira] [Commented] (HADOOP-19139) [ABFS]: No GetPathStatus call for opening AbfsInputStream

2024-04-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840665#comment-17840665 ] ASF GitHub Bot commented on HADOOP-19139: - anmolanmol1234 commented on code in PR #6699: URL:

Re: [PR] HDFS-17352. Add configuration to control whether DN delete this replica from disk when client requests a missing block [hadoop]

2024-04-25 Thread via GitHub
hadoop-yetus commented on PR #6559: URL: https://github.com/apache/hadoop/pull/6559#issuecomment-2076543325 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

Re: [PR] HDFS-17378. Add missing operationType for some operations in authorizer [hadoop]

2024-04-25 Thread via GitHub
hadoop-yetus commented on PR #6553: URL: https://github.com/apache/hadoop/pull/6553#issuecomment-2076556974 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

[jira] [Commented] (HADOOP-19139) [ABFS]: No GetPathStatus call for opening AbfsInputStream

2024-04-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840669#comment-17840669 ] ASF GitHub Bot commented on HADOOP-19139: - saxenapranav commented on code in PR #6699: URL:

Re: [PR] HADOOP-19139.No GetPathStatus for opening AbfsInputStream [hadoop]

2024-04-25 Thread via GitHub
saxenapranav commented on code in PR #6699: URL: https://github.com/apache/hadoop/pull/6699#discussion_r1578942351 ## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFileSystemAuthorization.java: ## @@ -328,13 +328,13 @@ private void

Re: [PR] HADOOP-19137. [ABFS]Fail fs init if cpk config is given on non-hns account [hadoop]

2024-04-25 Thread via GitHub
saxenapranav commented on code in PR #6752: URL: https://github.com/apache/hadoop/pull/6752#discussion_r1578968010 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystemStore.java: ## @@ -373,7 +372,21 @@ public boolean

[jira] [Commented] (HADOOP-19137) [ABFS]:Extra getAcl call while calling the very first API of FileSystem

2024-04-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840671#comment-17840671 ] ASF GitHub Bot commented on HADOOP-19137: - anmolanmol1234 commented on code in PR #6752: URL:

Re: [PR] HADOOP-19137. [ABFS]Fail fs init if cpk config is given on non-hns account [hadoop]

2024-04-25 Thread via GitHub
anmolanmol1234 commented on code in PR #6752: URL: https://github.com/apache/hadoop/pull/6752#discussion_r1578943627 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystemStore.java: ## @@ -373,7 +372,21 @@ public boolean

[jira] [Updated] (HADOOP-19137) [ABFS]:Extra getAcl call while calling the very first API of FileSystem

2024-04-25 Thread Pranav Saxena (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pranav Saxena updated HADOOP-19137: --- Description: Store doesn't flow in the namespace information to the client. In

Re: [PR] YARN-11690. Update container executor to use CGROUP2_SUPER_MAGIC in cgroup 2 scenarios [hadoop]

2024-04-25 Thread via GitHub
tomicooler commented on code in PR #6771: URL: https://github.com/apache/hadoop/pull/6771#discussion_r1579096249 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/container-executor.c: ## @@ -242,8

[jira] [Commented] (HADOOP-19139) [ABFS]: No GetPathStatus call for opening AbfsInputStream

2024-04-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840733#comment-17840733 ] ASF GitHub Bot commented on HADOOP-19139: - saxenapranav commented on code in PR #6699: URL:

Re: [PR] HADOOP-19139.No GetPathStatus for opening AbfsInputStream [hadoop]

2024-04-25 Thread via GitHub
anmolanmol1234 commented on code in PR #6699: URL: https://github.com/apache/hadoop/pull/6699#discussion_r1579209761 ## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFileSystemAuthorization.java: ## @@ -328,13 +328,13 @@ private void

Re: [PR] YARN-11191. Fix potentional deadlock in GlobalScheduler refreshQueues… [hadoop]

2024-04-25 Thread via GitHub
hadoop-yetus commented on PR #6768: URL: https://github.com/apache/hadoop/pull/6768#issuecomment-2076847309 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] YARN-11675. Update MemoryResourceHandler implementation for cgroup v2 support [hadoop]

2024-04-25 Thread via GitHub
hadoop-yetus commented on PR #6760: URL: https://github.com/apache/hadoop/pull/6760#issuecomment-2076880252 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-19134) use StringBuilder instead of StringBuffer

2024-04-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840774#comment-17840774 ] ASF GitHub Bot commented on HADOOP-19134: - hadoop-yetus commented on PR #6692: URL:

[jira] [Commented] (HADOOP-19139) [ABFS]: No GetPathStatus call for opening AbfsInputStream

2024-04-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840724#comment-17840724 ] ASF GitHub Bot commented on HADOOP-19139: - saxenapranav commented on code in PR #6699: URL:

Re: [PR] HADOOP-19139.No GetPathStatus for opening AbfsInputStream [hadoop]

2024-04-25 Thread via GitHub
saxenapranav commented on code in PR #6699: URL: https://github.com/apache/hadoop/pull/6699#discussion_r1579170762 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsInputStream.java: ## @@ -376,32 +439,48 @@ private int readLastBlock(final

Re: [PR] [SPARK-38958]: Override S3 Client in Spark Write/Read calls [hadoop]

2024-04-25 Thread via GitHub
hadoop-yetus commented on PR #6550: URL: https://github.com/apache/hadoop/pull/6550#issuecomment-2076861454 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

Re: [PR] HDFS-17382. Add Apache Log4j Extras Library to Hadoop 3.4 for Enhance… [hadoop]

2024-04-25 Thread via GitHub
hadoop-yetus commented on PR #6584: URL: https://github.com/apache/hadoop/pull/6584#issuecomment-2076934071 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

Re: [PR] YARN-11685. Create a config to enable/disable cgroup v2 functionality [hadoop]

2024-04-25 Thread via GitHub
hadoop-yetus commented on PR #6770: URL: https://github.com/apache/hadoop/pull/6770#issuecomment-2076967275 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] YARN-11690. Update container executor to use CGROUP2_SUPER_MAGIC in cgroup 2 scenarios [hadoop]

2024-04-25 Thread via GitHub
brumi1024 commented on code in PR #6771: URL: https://github.com/apache/hadoop/pull/6771#discussion_r1579314396 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/container-executor.c: ## @@ -242,8 +242,8

Re: [PR] HADOOP-19139.No GetPathStatus for opening AbfsInputStream [hadoop]

2024-04-25 Thread via GitHub
saxenapranav commented on code in PR #6699: URL: https://github.com/apache/hadoop/pull/6699#discussion_r1579186349 ## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAbfsNetworkStatistics.java: ## @@ -231,7 +237,17 @@ public void

[jira] [Commented] (HADOOP-19139) [ABFS]: No GetPathStatus call for opening AbfsInputStream

2024-04-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840732#comment-17840732 ] ASF GitHub Bot commented on HADOOP-19139: - saxenapranav commented on code in PR #6699: URL:

Re: [PR] YARN-11675. Update MemoryResourceHandler implementation for cgroup v2 support [hadoop]

2024-04-25 Thread via GitHub
hadoop-yetus commented on PR #6760: URL: https://github.com/apache/hadoop/pull/6760#issuecomment-2076877632 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HADOOP-19071. Update maven-surefire-plugin from 3.0.0 to 3.2.5. [hadoop]

2024-04-25 Thread via GitHub
hadoop-yetus commented on PR #6545: URL: https://github.com/apache/hadoop/pull/6545#issuecomment-2076895892 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-19071) Update maven-surefire-plugin from 3.0.0 to 3.2.5

2024-04-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840753#comment-17840753 ] ASF GitHub Bot commented on HADOOP-19071: - hadoop-yetus commented on PR #6545: URL:

Re: [PR] HDFS-17372. CommandProcessingThread#queue should use LinkedBlockingDeque to prevent high priority command blocked by low priority command [hadoop]

2024-04-25 Thread via GitHub
hadoop-yetus commented on PR #6530: URL: https://github.com/apache/hadoop/pull/6530#issuecomment-2076916456 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | -1 :x: | patch

Re: [PR] HDFS-17463. Support the switch StringTable Split ID feature [hadoop]

2024-04-25 Thread via GitHub
hadoop-yetus commented on PR #6736: URL: https://github.com/apache/hadoop/pull/6736#issuecomment-2076952024 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HADOOP-19139.No GetPathStatus for opening AbfsInputStream [hadoop]

2024-04-25 Thread via GitHub
saxenapranav commented on code in PR #6699: URL: https://github.com/apache/hadoop/pull/6699#discussion_r1579180763 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsInputStream.java: ## @@ -376,32 +439,48 @@ private int readLastBlock(final

[jira] [Commented] (HADOOP-19139) [ABFS]: No GetPathStatus call for opening AbfsInputStream

2024-04-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840736#comment-17840736 ] ASF GitHub Bot commented on HADOOP-19139: - anmolanmol1234 commented on code in PR #6699: URL:

Re: [PR] HADOOP-18516: [ABFS][Authentication] Support Fixed SAS Token for ABFS Authentication [hadoop]

2024-04-25 Thread via GitHub
hadoop-yetus commented on PR #6552: URL: https://github.com/apache/hadoop/pull/6552#issuecomment-2076944140 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

[jira] [Commented] (HADOOP-18516) [ABFS]: Support fixed SAS token config in addition to Custom SASTokenProvider Implementation

2024-04-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840759#comment-17840759 ] ASF GitHub Bot commented on HADOOP-18516: - hadoop-yetus commented on PR #6552: URL:

[jira] [Commented] (HADOOP-19134) use StringBuilder instead of StringBuffer

2024-04-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840771#comment-17840771 ] ASF GitHub Bot commented on HADOOP-19134: - hadoop-yetus commented on PR #6692: URL:

Re: [PR] HADOOP-19134. Use StringBuilder instead of StringBuffer. [hadoop]

2024-04-25 Thread via GitHub
hadoop-yetus commented on PR #6692: URL: https://github.com/apache/hadoop/pull/6692#issuecomment-2077013292 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] YARN-11675. Update MemoryResourceHandler implementation for cgroup v2 support [hadoop]

2024-04-25 Thread via GitHub
hadoop-yetus commented on PR #6760: URL: https://github.com/apache/hadoop/pull/6760#issuecomment-2076761316 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-19139) [ABFS]: No GetPathStatus call for opening AbfsInputStream

2024-04-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840729#comment-17840729 ] ASF GitHub Bot commented on HADOOP-19139: - saxenapranav commented on code in PR #6699: URL:

Re: [PR] HADOOP-19139.No GetPathStatus for opening AbfsInputStream [hadoop]

2024-04-25 Thread via GitHub
saxenapranav commented on code in PR #6699: URL: https://github.com/apache/hadoop/pull/6699#discussion_r1579189592 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsInputStream.java: ## @@ -376,32 +439,48 @@ private int readLastBlock(final

Re: [PR] HDFS-17446. The DataNode adds a log to report its progress during addToReplicasMap execution. [hadoop]

2024-04-25 Thread via GitHub
hadoop-yetus commented on PR #6685: URL: https://github.com/apache/hadoop/pull/6685#issuecomment-2076830219 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HADOOP-19134. Use StringBuilder instead of StringBuffer. [hadoop]

2024-04-25 Thread via GitHub
hadoop-yetus commented on PR #6692: URL: https://github.com/apache/hadoop/pull/6692#issuecomment-2077039728 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17381. Distcp of EC files should not be limited to DFS. [hadoop]

2024-04-25 Thread via GitHub
hadoop-yetus commented on PR #6551: URL: https://github.com/apache/hadoop/pull/6551#issuecomment-2077058346 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

Re: [PR] YARN-11674. Add CPUResourceHandler for cgroup v2. [hadoop]

2024-04-25 Thread via GitHub
tomicooler commented on code in PR #6751: URL: https://github.com/apache/hadoop/pull/6751#discussion_r1579625169 ##

Re: [PR] HADOOP-19072. S3A: expand optimisations on stores with "fs.s3a.create.performance" [hadoop]

2024-04-25 Thread via GitHub
hadoop-yetus commented on PR #6543: URL: https://github.com/apache/hadoop/pull/6543#issuecomment-2077150464 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

Re: [PR] HDFS-17374. EC: StripedBlockReader#newConnectedPeer should set SO_TIMEOUT and SO_KEEPALIVE [hadoop]

2024-04-25 Thread via GitHub
hadoop-yetus commented on PR #6536: URL: https://github.com/apache/hadoop/pull/6536#issuecomment-2077450806 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

Re: [PR] HDFS-17372. CommandProcessingThread#queue should use LinkedBlockingDeque to prevent high priority command blocked by low priority command [hadoop]

2024-04-25 Thread via GitHub
hfutatzhanghb commented on PR #6530: URL: https://github.com/apache/hadoop/pull/6530#issuecomment-2077114489 @Hexiaoqiao @zhangshuyan0 @ZanderXu Sir, this PR has run rightly for about two months. Could you please help me push this PR forward ? thanks a lot. -- This is an automated

[jira] [Commented] (HADOOP-19072) S3A: expand optimisations on stores with "fs.s3a.create.performance"

2024-04-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840791#comment-17840791 ] ASF GitHub Bot commented on HADOOP-19072: - hadoop-yetus commented on PR #6543: URL:

[jira] [Commented] (HADOOP-19139) [ABFS]: No GetPathStatus call for opening AbfsInputStream

2024-04-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840818#comment-17840818 ] ASF GitHub Bot commented on HADOOP-19139: - hadoop-yetus commented on PR #6699: URL:

Re: [PR] HADOOP-19139.No GetPathStatus for opening AbfsInputStream [hadoop]

2024-04-25 Thread via GitHub
hadoop-yetus commented on PR #6699: URL: https://github.com/apache/hadoop/pull/6699#issuecomment-2077298894 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] YARN-11690. Update container executor to use CGROUP2_SUPER_MAGIC in cgroup 2 scenarios [hadoop]

2024-04-25 Thread via GitHub
hadoop-yetus commented on PR #6771: URL: https://github.com/apache/hadoop/pull/6771#issuecomment-2077302452 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HADOOP-19073 WASB: Fix connection leak in FolderRenamePending [hadoop]

2024-04-25 Thread via GitHub
hadoop-yetus commented on PR #6534: URL: https://github.com/apache/hadoop/pull/6534#issuecomment-2077324557 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

[jira] [Commented] (HADOOP-19073) WASB: Fix connection leak in FolderRenamePending

2024-04-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840825#comment-17840825 ] ASF GitHub Bot commented on HADOOP-19073: - hadoop-yetus commented on PR #6534: URL:

Re: [PR] HADOOP-19152. Do not hard code security providers. [hadoop]

2024-04-25 Thread via GitHub
szetszwo commented on PR #6739: URL: https://github.com/apache/hadoop/pull/6739#issuecomment-2077652244 Oops, just found that I accidentally changed the whitespaces in `TestCryptoCodec`. Let me revert them. -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Commented] (HADOOP-19012) Use CRC tables to speed up galoisFieldMultiply in CrcUtil

2024-04-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840848#comment-17840848 ] ASF GitHub Bot commented on HADOOP-19012: - hadoop-yetus commented on PR #6542: URL:

Re: [PR] YARN-11684. Fix general contract violation in PriorityQueueComparator… [hadoop]

2024-04-25 Thread via GitHub
slfan1989 merged PR #6753: URL: https://github.com/apache/hadoop/pull/6753 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HADOOP-19012. Use CRC tables to speed up galoisFieldMultiply in CrcUtil. [hadoop]

2024-04-25 Thread via GitHub
hadoop-yetus commented on PR #6542: URL: https://github.com/apache/hadoop/pull/6542#issuecomment-2077552234 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

Re: [PR] YARN-11684. Fix general contract violation in PriorityQueueComparator… [hadoop]

2024-04-25 Thread via GitHub
slfan1989 commented on PR #6753: URL: https://github.com/apache/hadoop/pull/6753#issuecomment-2077624938 @tomicooler Thanks for the contribution! Merged into branch-3.4. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] YARN-11690. Update container executor to use CGROUP2_SUPER_MAGIC in cgroup 2 scenarios [hadoop]

2024-04-25 Thread via GitHub
hadoop-yetus commented on PR #6771: URL: https://github.com/apache/hadoop/pull/6771#issuecomment-2077695501 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17367. Add PercentUsed for Different StorageTypes in JMX [hadoop]

2024-04-25 Thread via GitHub
hadoop-yetus commented on PR #6735: URL: https://github.com/apache/hadoop/pull/6735#issuecomment-2078012457 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HADOOP-19152. Do not hard code security providers. [hadoop]

2024-04-25 Thread via GitHub
hadoop-yetus commented on PR #6739: URL: https://github.com/apache/hadoop/pull/6739#issuecomment-2078071797 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-19152) Do not hard code security providers.

2024-04-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840946#comment-17840946 ] ASF GitHub Bot commented on HADOOP-19152: - hadoop-yetus commented on PR #6739: URL:

Re: [PR] YARN-11674. Add CPUResourceHandler for cgroup v2. [hadoop]

2024-04-25 Thread via GitHub
hadoop-yetus commented on PR #6751: URL: https://github.com/apache/hadoop/pull/6751#issuecomment-2077839495 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17372. CommandProcessingThread#queue should use LinkedBlockingDeque to prevent high priority command blocked by low priority command [hadoop]

2024-04-25 Thread via GitHub
hadoop-yetus commented on PR #6530: URL: https://github.com/apache/hadoop/pull/6530#issuecomment-2077843466 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] MAPREDUCE-7472. Decode value of hive.query.string for the job Confguration which was encoded by hive [hadoop]

2024-04-25 Thread via GitHub
hadoop-yetus commented on PR #6520: URL: https://github.com/apache/hadoop/pull/6520#issuecomment-2077848831 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

[jira] [Updated] (HADOOP-19158) S3A: Support ByteBufferPositionedReadable through vector IO

2024-04-25 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-19158: Summary: S3A: Support ByteBufferPositionedReadable through vector IO (was: S3A: Support

Re: [PR] HADOOP-19013. Adding x-amz-server-side-encryption-aws-kms-key-id in the get file attributes for S3A. [hadoop]

2024-04-25 Thread via GitHub
steveloughran commented on code in PR #6646: URL: https://github.com/apache/hadoop/pull/6646#discussion_r1534430622 ## hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/EncryptionTestUtils.java: ## @@ -111,4 +119,27 @@ public static void

[jira] [Commented] (HADOOP-19013) fs.getXattrs(path) for S3FS doesn't have x-amz-server-side-encryption-aws-kms-key-id header.

2024-04-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840901#comment-17840901 ] ASF GitHub Bot commented on HADOOP-19013: - steveloughran commented on code in PR #6646: URL:

  1   2   >