if (.zip.equals(extension)) - ArchiveType.ZIP.newInstance();
if (.rar.equals(extension)) - ArchiveType.RAR.newInstance();
...
in you code - which is cumbersome IMO.
In that situation you'd use: ArchiveType.valueOf(extension).newInstance()
...so what's the benefit over the usual factory +
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
will pugh wrote:
Yeah. I agree valueOf would work just fine, but unless I'm missing
something, the current implementation doesn't have this. The purpose of
my comments was to say that I thought it should have something along
those lines.
The
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
...so what's the benefit over the usual factory + constructor
instantiation then?
Archive arch = new TarArchive(new File(my.tar));
Archive arch = ArchiveFactory.newInstance(new File(my.tar);
Archive arch = ArchiveFactory.newInstance(tar);
i
i have read your suggestion but i was not sure why i should accept
strings for choosing an archive.
This can also be convenient if the method comes from a configuration.
Common practise for factories.
I like the idea ArchiveFactory
identifys archives by it's header. So, thanks for making this
On Sat, 2006-05-13 at 00:15 +0100, Stephen Colebourne wrote:
Stephen Colebourne wrote:
This is a vote for the release of [collections] v3.2
RC1 is here:
http://people.apache.org/~scolebourne/commons-collections/
Site here:
Author: scolebourne
Date: Sat May 13 03:44:37 2006
New Revision: 406071
URL: http://svn.apache.org/viewcvs?rev=406071view=rev
Log:
Javadoc changes for v3.2
Modified:
jakarta/commons/proper/collections/trunk/src/java/org/apache/commons/collections/functors/AllPredicate.java
On Thu, 2006-04-06 at 08:51 +0200, Nicolas De Loof wrote:
I agree about NOT making non-final jars available on ibiblio (httpclient
beeing an exception)
So could the next RC be uploaded to
http://cvs.apache.org/maven-snapshot-repository/ ?
Please also consider using the new groupId
Author: scolebourne
Date: Sat May 13 04:36:15 2006
New Revision: 406078
URL: http://svn.apache.org/viewcvs?rev=406078view=rev
Log:
Javadoc improvement
Modified:
jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/text/StrTokenizer.java
Modified:
Author: rdonkin
Date: Sat May 13 04:37:02 2006
New Revision: 406079
URL: http://svn.apache.org/viewcvs?rev=406079view=rev
Log:
Updated to next SNAPSHOT
Modified:
jakarta/commons/proper/logging/trunk/build.xml
jakarta/commons/proper/logging/trunk/project.xml
Author: scolebourne
Date: Sat May 13 04:37:28 2006
New Revision: 406080
URL: http://svn.apache.org/viewcvs?rev=406080view=rev
Log:
Javadoc improvement
Modified:
jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/text/StrBuilder.java
Modified:
To whom it may engage...
This is an automated request, but not an unsolicited one. For
more information please visit http://gump.apache.org/nagged.html,
and/or contact the folk at [EMAIL PROTECTED]
Project commons-jelly-tags-jsl-test has an issue affecting its community
integration.
To whom it may engage...
This is an automated request, but not an unsolicited one. For
more information please visit http://gump.apache.org/nagged.html,
and/or contact the folk at [EMAIL PROTECTED]
Project commons-jelly-tags-jsl-test has an issue affecting its community
integration.
Author: scolebourne
Date: Sat May 13 05:10:37 2006
New Revision: 406081
URL: http://svn.apache.org/viewcvs?rev=406081view=rev
Log:
Style changes to match rest of class
Modified:
jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/ClassUtils.java
Modified:
Author: scolebourne
Date: Sat May 13 05:11:13 2006
New Revision: 406082
URL: http://svn.apache.org/viewcvs?rev=406082view=rev
Log:
Javadoc for not escaping apos
Modified:
jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/StringEscapeUtils.java
Modified:
Author: polx
Date: Sat May 13 05:19:38 2006
New Revision: 406083
URL: http://svn.apache.org/viewcvs?rev=406083view=rev
Log:
Fixed the evil error which had nothing to do with jaxen
but with jexl... the i variable was an integer which
jaxen cannot compare to an attribute value... fixed
by using i =
Author: polx
Date: Sat May 13 05:20:33 2006
New Revision: 406084
URL: http://svn.apache.org/viewcvs?rev=406084view=rev
Log:
Removing odd assert-test... this makes it all run with dom4j 1.6.1
by me.
paul
Modified:
This is a new addition in this release.
Should we be creating a MethodUtils instead?
Stephen
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
To whom it may engage...
This is an automated request, but not an unsolicited one. For
more information please visit http://gump.apache.org/nagged.html,
and/or contact the folk at [EMAIL PROTECTED]
Project commons-jelly-tags-define-test has an issue affecting its community
To whom it may engage...
This is an automated request, but not an unsolicited one. For
more information please visit http://gump.apache.org/nagged.html,
and/or contact the folk at [EMAIL PROTECTED]
Project commons-jelly-tags-define-test has an issue affecting its community
To whom it may engage...
This is an automated request, but not an unsolicited one. For
more information please visit http://gump.apache.org/nagged.html,
and/or contact the folk at [EMAIL PROTECTED]
Project commons-jelly-tags-html has an issue affecting its community
integration.
This
To whom it may engage...
This is an automated request, but not an unsolicited one. For
more information please visit http://gump.apache.org/nagged.html,
and/or contact the folk at [EMAIL PROTECTED]
Project commons-jelly-tags-html has an issue affecting its community
integration.
This
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=39548.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.
robert burrell donkin wrote:
On Thu, 2006-04-06 at 08:51 +0200, Nicolas De Loof wrote:
I agree about NOT making non-final jars available on ibiblio (httpclient
beeing an exception)
So could the next RC be uploaded to
http://cvs.apache.org/maven-snapshot-repository/ ?
Please also consider
robert burrell donkin wrote:
i've uploaded JCL1.1FC to
http://people.apache.org/~rdonkin/commons-logging/. it's not yet
available through the distributions and it will be a day or two before
the mirrors sync and i issue the official announcement.
Robert, I have been unable to do a download
On 5/13/06, robert burrell donkin [EMAIL PROTECTED]
wrote:
On Thu, 2006-04-06 at 08:51 +0200, Nicolas De Loof wrote:
I agree about NOT making non-final jars available on ibiblio (httpclient
beeing an exception)
So could the next RC be uploaded to
On 5/8/06, Stephen Colebourne [EMAIL PROTECTED] wrote:
This is a vote for the release of [collections] v3.2
RC1 is here:
http://people.apache.org/~scolebourne/commons-collections/
Site here:
http://people.apache.org/~scolebourne/commons-collections/site/
Release notes here:
Author: polx
Date: Sat May 13 14:02:26 2006
New Revision: 406151
URL: http://svn.apache.org/viewcvs?rev=406151view=rev
Log:
Spurious debug test-output left here, sorry.
paul
Modified:
jakarta/commons/proper/jelly/trunk/jelly-tags/jsl/src/test/org/apache/commons/jelly/jsl/TestJSL.java
Hello Jellyers,
After my two test fixes, which had almost nothing to do with dom4j...
I seem to be happily running everything with dom4j 1.6.1.
Can anyone confirm me this ? It's quite radical but it'd help in many
other places.
paul
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=39575.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=39575.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.
Author: polx
Date: Sat May 13 14:35:11 2006
New Revision: 406152
URL: http://svn.apache.org/viewcvs?rev=406152view=rev
Log:
Added a test for $${xx} to be output as ${x}.
This is used by some but was not tested.
This is important for JELLY-187.
paul
Modified:
[
http://issues.apache.org/jira/browse/JELLY-187?page=comments#action_12383406 ]
Paul Libbrecht commented on JELLY-187:
--
I have an issue with this patch... Namely the undocumented following usage:
$${a.b.c} does output ${a.b.c}
at least I use this
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=39575.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.
Author: polx
Date: Sat May 13 14:46:04 2006
New Revision: 406153
URL: http://svn.apache.org/viewcvs?rev=406153view=rev
Log:
Fix for JELLY-218. I wish we had a unit test to verify this...
paul
Modified:
[ http://issues.apache.org/jira/browse/JELLY-218?page=all ]
Paul Libbrecht resolved JELLY-218:
--
Fix Version: 1.1
Resolution: Fixed
Assign To: Paul Libbrecht
Fixed in subversion, please test.
If you have some time for a contribution,
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=39576.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.
On 5/13/06, Dennis Lundberg [EMAIL PROTECTED] wrote:
robert burrell donkin wrote:
On Thu, 2006-04-06 at 08:51 +0200, Nicolas De Loof wrote:
I agree about NOT making non-final jars available on ibiblio (httpclient
beeing an exception)
So could the next RC be uploaded to
Dear Wiki user,
You have subscribed to a wiki page or wiki category on Jakarta-commons Wiki
for change notification.
The following page has been changed by DennisLundberg:
http://wiki.apache.org/jakarta-commons/MavenPlugins
The comment on the change is:
Updated versions
Here is my +1, although I wasn't able to give it a try (but I trust
your judgement :-)
On 5/9/06, Paul Libbrecht [EMAIL PROTECTED] wrote:
Thanks to give it a try* and provide a vote.
[X ] +1 yes let's release it
-
To
Attempting to do this now. Will take a good few hours I suspect.
We'll figure out any issues that pop up in Bugzilla in the meantime
after the fact.
Hen
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands,
On Sat, 2006-05-13 at 11:30 -0700, Martin Cooper wrote:
On 5/13/06, robert burrell donkin [EMAIL PROTECTED]
wrote:
On Thu, 2006-04-06 at 08:51 +0200, Nicolas De Loof wrote:
I agree about NOT making non-final jars available on ibiblio (httpclient
beeing an exception)
So could the
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=39576.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=39460.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.
Author: sandymac
Date: Sat May 13 17:54:00 2006
New Revision: 406176
URL: http://svn.apache.org/viewcvs?rev=406176view=rev
Log:
Fully minimized synchronization but this leaves a race condition for pools
with a max active limit. Created a unit test to verify this race condition.
Small Javadoc
Issues are loaded into Jira. Bugzilla is 'closed' - which I think
means that people can still work on the issues there but can't add new
ones. Apparantly you can't get any more read-only than that.
Currently I'm slowly moving the components from the imported Commons
project into the newly
In Maven 2.1, it will be able to correlate between the two, but
currently they'll end up in there twice.
I'd suggest when a release first does this, it's going to need to move
all the old versions to the new group ID, and add a relocation for the
original group IDs to get it to work, as
There are now two projects in Jira, Jelly and Commons JellyImported.
If someone has a moment, it'd be a real help if they could take a look
at the two of these and let me know if JellyImported can be deleted or
if it should have its issues moved into Jelly.
I'll be renaming Jelly to Commons
Ack. I screwed up in my understanding of how the version-fixing script
works. Should have taken a copy of Jira 3 hours ago.
Starting again *wince*.
Hen
On 5/13/06, Henri Yandell [EMAIL PROTECTED] wrote:
Issues are loaded into Jira. Bugzilla is 'closed' - which I think
means that people can
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=39477.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.
49 matches
Mail list logo
