RE: [jelly] Upgrade to dom4j 1.6.1 ?

2006-06-04 Thread Hans Gilde
Ok unit tests I have work, so I'm also +1. -Original Message- From: Paul Libbrecht [mailto:[EMAIL PROTECTED] Sent: Friday, June 02, 2006 4:50 PM To: Hans Gilde Cc: 'Jakarta Commons Developers List' Subject: Re: [jelly] Upgrade to dom4j 1.6.1 ? I please beg another round of review

RE: [jelly] taglibs lead distribution ?

2006-05-16 Thread Hans Gilde
it, or whether it should be delegated. paul Hans Gilde wrote: I can do bug fixes and such and I'm definitely in favor of cleaning up the Jira assignments. If you'd like to assign me some stuff, I'll fix it. But I'm not in a position to really lead anything at the moment. -Original Message

RE: [jelly] Upgrade to dom4j 1.6.1 ?

2006-05-16 Thread Hans Gilde
+0 If the unit tests pass, I'm inclined to say that the latest version should be used. But I have not tried it. -Original Message- From: Paul Libbrecht [mailto:[EMAIL PROTECTED] Sent: Saturday, May 13, 2006 5:06 PM To: Jakarta Commons Developers List Subject: [jelly] Upgrade to dom4j

RE: [jelly] [vote] Release commons-jelly-tags-interaction 1.1

2006-05-16 Thread Hans Gilde
+1 due to current community use -Original Message- From: Paul Libbrecht [mailto:[EMAIL PROTECTED] Sent: Tuesday, May 09, 2006 5:08 PM To: Jakarta Commons Developers List Subject: [jelly] [vote] Release commons-jelly-tags-interaction 1.1 The story seems quite simple so I thought I'd just

RE: [jelly] taglibs lead distribution ?

2006-05-10 Thread Hans Gilde
I can do bug fixes and such and I'm definitely in favor of cleaning up the Jira assignments. If you'd like to assign me some stuff, I'll fix it. But I'm not in a position to really lead anything at the moment. -Original Message- From: Paul Libbrecht [mailto:[EMAIL PROTECTED] Sent:

RE: [jelly][vote] APT tag library

2006-01-26 Thread Hans Gilde
have recorded three people voting positive for both proposals: Dion Gillard Hans Gilde Paul Libbrecht hi ryan (sorry to have to start being a little legalistic...) i know that this can be a little

RE: [jelly] apt tag library

2005-11-29 Thread Hans Gilde
I haven't had a chance to look at it, but I'm +1 based on the amount of work Ryan's done on his end. That's +1 to accept the code and +1 for committer access for Ryan. -Original Message- From: Dion Gillard [mailto:[EMAIL PROTECTED] Sent: Monday, November 28, 2005 2:50 PM To: Jakarta

[jelly] testing the tags

2005-11-13 Thread Hans Gilde
I'm running tags:do with goal=test:test against my particular Jelly build, but the reactor fails with Attempting to download activation-1.0.2.jar. WARNING: Failed to download activation-1.0.2.jar. Attempting to download mail-1.2.jar. WARNING: Failed to download mail-1.2.jar. Is this

[jira] Created: (JELLY-223) Swing tags should clear their component to avoid holding extra memory

2005-11-06 Thread Hans Gilde (JIRA)
Versions: 1.0 Reporter: Hans Gilde Priority: Minor It seems that JELLY-122 has been undone and now, Swing component tags keep a reference to their component after running. This reference is *useless* because the tags will always create a new component when they run a second time

[jelly] paul, your changes to ComponentTag

2005-11-06 Thread Hans Gilde
Paul, I see you made some changes to the Swing ComponentTag in January. Is this a line of development that you're still following? If not, I'd like to take some of your changes out, because they cause the tag to keep a reference to its components when it doesn't need one. Hans

[jelly] attempting big speed improvement

2005-11-06 Thread Hans Gilde
A while ago, I noticed a potential for a huge speed improvement with Jelly. Basically, it uses this DynaBean stuff which sounds good, but was never taken anywhere within Jelly. Because of this, every tag goes through 3 stages of having its attributes set from XML and I plan to knock that down to

RE: svn commit: r331137 - /jakarta/commons/proper/jelly/branches/hans-speed-improvement/

2005-11-06 Thread Hans Gilde
No, sorry, I've not committed into the new branch. I will commit directly to it and you can test from there but I'm ironing out some stuff first. It could take me a few days. -Original Message- From: Dion Gillard [mailto:[EMAIL PROTECTED] Sent: Sunday, November 06, 2005 3:00 PM To:

RE: svn commit: r331137 - /jakarta/commons/proper/jelly/branches/hans-speed-improvement/

2005-11-06 Thread Hans Gilde
Also, I'm not 100% sure that it will work properly, hence the branch. My email was to let you know why I created the branch. -Original Message- From: Dion Gillard [mailto:[EMAIL PROTECTED] Sent: Sunday, November 06, 2005 3:00 PM To: Jakarta Commons Developers List Subject: Re: svn

[jira] Commented: (JELLY-222) Add CardLayout

2005-11-06 Thread Hans Gilde (JIRA)
[ http://issues.apache.org/jira/browse/JELLY-222?page=comments#action_12356911 ] Hans Gilde commented on JELLY-222: -- solved per Subversion commit Add CardLayout -- Key: JELLY-222 URL: http://issues.apache.org/jira/browse

[jira] Commented: (JELLY-223) Swing tags should clear their component to avoid holding extra memory

2005-11-06 Thread Hans Gilde (JIRA)
[ http://issues.apache.org/jira/browse/JELLY-223?page=comments#action_12356912 ] Hans Gilde commented on JELLY-223: -- re-fixed per SVN commit Swing tags should clear their component to avoid holding extra memory

[jelly] double checking my logic

2005-11-06 Thread Hans Gilde
Just to be sure I'm not missing something. the following if condition couldn't possible execute: if (type != null type.isAssignableFrom(Expression.class) !type.isAssignableFrom(Object.class)) The reason being that anything that isAssignableFrom(Expression.class) also

[jelly] JIRA

2005-11-05 Thread Hans Gilde
It looks like Jelly JIRA is a little out of date. What's needed to bring it up to date in terms of the fact that 1.0 is out and 1.1 or 1.0.1 is next? Hans

[jira] Created: (JELLY-222) Add CardLayout

2005-11-05 Thread Hans Gilde (JIRA)
Add CardLayout -- Key: JELLY-222 URL: http://issues.apache.org/jira/browse/JELLY-222 Project: jelly Type: New Feature Components: taglib.swing Versions: 1.0 Reporter: Hans Gilde Priority: Minor Add layout tag for CardLayout

RE: [jelly] JIRA

2005-11-05 Thread Hans Gilde
list?? On 11/6/05, Hans Gilde [EMAIL PROTECTED] wrote: It looks like Jelly JIRA is a little out of date. What's needed to bring it up to date in terms of the fact that 1.0 is out and 1.1 or 1.0.1 is next? Hans -- http://www.multitask.com.au/people/dion/ You are going to let the fear

RE: [jelly] 1.0-final problem wrt tag caching

2005-08-16 Thread Hans Gilde
No, this is how it's always worked. It has to work this way in order to support some of the more esoteric features of Jelly. I also tried to change this when fixing the memory leak. As you discovered, it's currently stuck this way. Wit can be fixed but, as I recall, it would mean changing the

RE: [jelly] 1.0-final problem wrt tag caching

2005-08-14 Thread Hans Gilde
Yes, you're running into a fundamental problem: there's no difference between the cache and the mechanism that tags use to look up their parents. The interface solution will be a partial fix, because tags that are never looked up by their children, never need caching. -Original Message-

RE: [jelly] 1.0-final problem wrt tag caching

2005-07-26 Thread Hans Gilde
. 05, à 23:33, Hans Gilde a écrit : Got it, thanks. I was the one who accidentally removed isCacheTags(), sorry. By no means, I was the one and that is not so accidental. (I remember somewhat warning about it) Allow me to comment on the following, I think there's a deep issue here! Previous

RE: [jelly] 1.0-final problem wrt tag caching

2005-07-24 Thread Hans Gilde
, at 5:02 AM, Hans Gilde wrote: So I'm looking at your test, and it looks like one should expect this behavior (the test should always fail). Have you tried this test on a pre-leak-fix version of Jelly? I'm going to do so tomorrow. Yes. This test mimics a regression from an earlier RC that I ran

RE: [jelly] 1.0-final problem wrt tag caching

2005-07-23 Thread Hans Gilde
Hiya, just getting to read this. To shed a little extra light here: You aren't quite correct, caching tags is actually always the default. It's needed for several tag libraries to work. Now, the caching is supposed to be per-thread. Tags are cached in the TagScript that instantiates the Tag

RE: [jelly] 1.0-final problem wrt tag caching

2005-07-23 Thread Hans Gilde
So I'm looking at your test, and it looks like one should expect this behavior (the test should always fail). Have you tried this test on a pre-leak-fix version of Jelly? I'm going to do so tomorrow. This isn't the same caching problem reported by other users. That problem is caused not by

RE: [jelly] SOLVED: Maven issue with Hans memory leak patch

2005-06-27 Thread Hans Gilde
Kristofer, could you send some XML as an example? Paul, I believe that you are correct, which is why I'm worried. I went through various scenarios with the caching patch and thought that there would be absolutely no change whatsoever to the functionality. This is why I was a little freaked out

RE: [jelly] SOLVED: Maven issue with Hans memory leak patch

2005-06-26 Thread Hans Gilde
Hmm, I'm having a hard time replicating this. Could you send some examples? Basically, if the tag has two attributes on the first run, how would it have one attribute on the second run? -Original Message- From: Kristofer Eriksson [mailto:[EMAIL PROTECTED] Sent: Friday, June 24, 2005

RE: [jelly] SOLVED: Maven issue with Hans memory leak patch

2005-06-24 Thread Hans Gilde
This isn't supposed to work this way, I'm looking into it. -Original Message- From: Kristofer Eriksson [mailto:[EMAIL PROTECTED] Sent: Friday, June 24, 2005 9:34 AM To: Jakarta Commons Developers List Subject: RE: [jelly] SOLVED: Maven issue with Hans memory leak patch Hi Paul, many

RE: [result] Release Commons Jelly 1.0 based on RC4

2005-06-19 Thread Hans Gilde
Not that it matters but I am, in fact, a committer. -Original Message- From: Brett Porter [mailto:[EMAIL PROTECTED] Sent: Thursday, June 16, 2005 12:07 AM To: Jakarta Commons Developers List Cc: [EMAIL PROTECTED] Subject: [result] Release Commons Jelly 1.0 based on RC4 -BEGIN PGP

RE: [jelly] distribution format

2005-06-13 Thread Hans Gilde
We have all agreed that some of the Jelly API needs to change. The thinking is along your line: it's been so long, we need the momentum on 1.0. Also, even API changes might not change the Tag API (or might leave room for backward compatibility), which is what allot of Jelly infrastructure is

RE: maven.compile.source was: [vote] Release Commons Jelly 1.0 based on RC3

2005-06-12 Thread Hans Gilde
Well, targeting the 1.3 class file definition won't prevent it from using the rt.jar in your 1.5 JDK... thus possible compiling against an API that is in 1.3. In fact, this is not the case and I tried it... but just pointing it out. -Original Message- From: Brett Porter [mailto:[EMAIL

RE: [vote] Release Commons Jelly 1.0 based on RC4

2005-06-12 Thread Hans Gilde
+1 No leak, tests good with my stuff. -Original Message- From: Brett Porter [mailto:[EMAIL PROTECTED] Sent: Saturday, June 11, 2005 11:27 PM To: Jakarta Commons Developers List Subject: [vote] Release Commons Jelly 1.0 based on RC4 Hi, There are release candidates here:

RE: [jelly] distribution format

2005-06-09 Thread Hans Gilde
I would agree except that I'm having a hard time figuring out how a new user would figure out which libraries to use. The exception will be ClassnotFound nested within some JellyExceptions, so it might not be so obvious. -Original Message- From: Dion Gillard [mailto:[EMAIL PROTECTED]

RE: [jelly] proposal: taglib/core releases

2005-06-05 Thread Hans Gilde
+1, +1 -Original Message- From: Brett Porter [mailto:[EMAIL PROTECTED] Sent: Thursday, June 02, 2005 4:11 AM To: Jakarta Commons Developers List Subject: [jelly] proposal: taglib/core releases -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, Is any inclined to do, or failing that

RE: [jelly] SOLVED: Maven issue with Hans memory leak patch

2005-05-22 Thread Hans Gilde
with Hans memory leak patch -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hans Gilde wrote: Wait... strike this new patch. My old one should be fine. Now I'm jumping to conclusions because I haven't looked at it for so long. Brett, what's being reused where it wasn't before? I would not expect

RE: [jelly] SOLVED: Maven issue with Hans memory leak patch

2005-05-21 Thread Hans Gilde
Wait... strike this new patch. My old one should be fine. Now I'm jumping to conclusions because I haven't looked at it for so long. Brett, what's being reused where it wasn't before? I would not expect this behavior. -Original Message- From: Hans Gilde [mailto:[EMAIL PROTECTED] Sent

RE: [jelly] SOLVED: Maven issue with Hans memory leak patch

2005-05-20 Thread Hans Gilde
Sorry not to be around so much any more. I got laid off and had to find a new job. I'm so sorry to say that my memory leak patch has a big flaw in it. It should not have caused the tag to be improperly reused. I'm happy to say that I have a fix (replacement), which is attached. This patch should

RE: [jelly] SOLVED: Maven issue with Hans memory leak patch

2005-05-20 Thread Hans Gilde
Ok, things have moved on somewhat from when I did my patch from CSV, and my SVN stuff isn't working right. So, that last parch was from the really old CVS. -Original Message- From: Hans Gilde [mailto:[EMAIL PROTECTED] Sent: Saturday, May 21, 2005 1:48 AM To: 'Jakarta Commons Developers

RE: SVN From Eclipse is too slow

2005-04-22 Thread Hans Gilde
The Eclipse SVN plugin is an abomination and should be wiped from the face of the earth before it causes any more suffering. -Original Message- From: Dion Gillard [mailto:[EMAIL PROTECTED] Sent: Friday, April 22, 2005 12:09 AM To: Jakarta Commons Developers List Subject: SVN From Eclipse

[jelly] RE: Memory leak patch

2005-03-26 Thread Hans Gilde
mail. Thanks, Brett Hans Gilde wrote: Apparently I did something dumb. The fix that I'm really confident about isn't in either CVS or SVN and also isn't in the last patch I sent out. But does it even exist, or did I dream the whole thing? It does exist! I'm attaching 3 patches that should apply

Memory leak patch

2005-03-25 Thread Hans Gilde
Apparently I did something dumb. The fix that I'm really confident about isn't in either CVS or SVN and also isn't in the last patch I sent out. But does it even exist, or did I dream the whole thing? It does exist! I'm attaching 3 patches that should apply to the latest CSV and should also fix

RE: [Jelly] Memory leak revealed

2005-03-22 Thread Hans Gilde
This is one of the bugs that's been fixed by the last memory patch. -Original Message- From: Agustin Ramos [mailto:[EMAIL PROTECTED] Sent: Friday, March 18, 2005 10:54 PM To: Jakarta Commons Developers List Subject: [Jelly] Memory leak revealed I've been struggling to find a memory leak

RE: [Jelly] Memory leak revealed

2005-03-22 Thread Hans Gilde
Paul, this looks just like the leak that's been fixed. It's all the stuff getting stuck in the ThreadLocal. Augustin, have you tried this with the latest build of Jelly? Hans -Original Message- From: Paul Libbrecht [mailto:[EMAIL PROTECTED] Sent: Saturday, March 19, 2005 5:38 PM To:

RE: [Jexl BeanUtils] Why not extend Jexl or beanutils to match same map syntax ?

2005-01-31 Thread Hans Gilde
Although... it would be fairly easy to adapt a new scripting language into Jelly. The fairly-simple task of implementing a pluggable language interface has been on the table for a while. I think that Morph would be an interesting candidate for a second language. -Original Message- From:

RE: [jelly] Maven JSL memory leak and Jelly

2005-01-27 Thread Hans Gilde
I've got dom4j/jaxen working on Maven's trunk again. I'd say this is good enough for RC2, as it has at least halved the consumption of building a site. Nice work! - Brett Hans Gilde wrote: It was just a little issue, it should be fixed now. -Original Message- From: Brett

Re: [jelly] Maven JSL memory leak and Jelly

2005-01-27 Thread Hans Gilde
I need to commit this to SVN, don't I? On Thu, 27 Jan 2005 21:13:03 -0500, Hans Gilde [EMAIL PROTECTED] wrote: Great. Sorry about that patch thing... I generated it with Eclipse, then edited it by hand and screwed it up. I'm going to commit the changes with come added comments

RE: [jelly] Maven JSL memory leak and Jelly

2005-01-27 Thread Hans Gilde
know if it makes any difference, and possibly do some more investigations later after I've got dom4j/jaxen working on Maven's trunk again. I'd say this is good enough for RC2, as it has at least halved the consumption of building a site. Nice work! - Brett Hans Gilde wrote: It was just a little

RE: [all][VOTE][Results] commons svn migration

2005-01-26 Thread Hans Gilde
I say that if it's to die, let's not have it sitting around rotting. Who wants CVS is it's not up to date? Hans -Original Message- From: Henri Yandell [mailto:[EMAIL PROTECTED] Sent: Wednesday, January 26, 2005 8:41 PM To: Jakarta Commons Developers List Subject: Re:

RE: [jelly] Maven JSL memory leak and Jelly

2005-01-26 Thread Hans Gilde
that's all I had time for this morning before work. Good luck... Cheers, Brett Quoting Hans Gilde [EMAIL PROTECTED]: I just added a super-simple test case for the include tag to the core test suite. Include is a special kind of tag, so hopefully it's the only one leaking. Once we fix

[jira] Commented: (JELLY-199) Leak in IncludeTag or JellyContext.runScript

2005-01-26 Thread Hans Gilde (JIRA)
[ http://issues.apache.org/jira/browse/JELLY-199?page=comments#action_58142 ] Hans Gilde commented on JELLY-199: -- Fixed! Leak in IncludeTag or JellyContext.runScript Key: JELLY-199

[jelly] a memory leak fix without a tag cache

2005-01-26 Thread Hans Gilde
Heres a patch for HEAD with a thread-safe cache thats got no JellyContext tag cache, no memory leak and no dumb WeakReferences. And it even passes the unit tests. Its so simple that it was invisible; its less than 10 lines of change from the pre-RC1 TagScript. Sigh. Anyway, I didnt

RE: [jelly] Maven JSL memory leak and Jelly

2005-01-24 Thread Hans Gilde
Why won't RC2 work with maven 1.0.x? -Original Message- From: Brett Porter [mailto:[EMAIL PROTECTED] Sent: Monday, January 24, 2005 7:30 AM To: Jakarta Commons Developers List Subject: Re: [jelly] Maven JSL memory leak and Jelly Paul Libbrecht wrote: Ideally, a test-case would be

RE: [jelly] Maven JSL memory leak and Jelly

2005-01-24 Thread Hans Gilde
There's definitely a leak in the include tag. Brett, I'm guessing that this leak also exists pre-RC2, right? -Original Message- From: Brett Porter [mailto:[EMAIL PROTECTED] Sent: Monday, January 24, 2005 7:30 AM To: Jakarta Commons Developers List Subject: Re: [jelly] Maven JSL memory

RE: [jelly] Maven JSL memory leak and Jelly

2005-01-24 Thread Hans Gilde
if required. - Brett Quoting Hans Gilde [EMAIL PROTECTED]: There's definitely a leak in the include tag. Brett, I'm guessing that this leak also exists pre-RC2, right? -Original Message- From: Brett Porter [mailto:[EMAIL PROTECTED] Sent: Monday, January 24, 2005 7:30 AM To: Jakarta

[jira] Created: (JELLY-199) Leak in IncludeTag or JellyContext.runScript

2005-01-24 Thread Hans Gilde (JIRA)
Leak in IncludeTag or JellyContext.runScript Key: JELLY-199 URL: http://issues.apache.org/jira/browse/JELLY-199 Project: jelly Type: Bug Components: core / taglib.core Versions: 1.0-RC1 Reporter: Hans

[jira] Commented: (JELLY-199) Leak in IncludeTag or JellyContext.runScript

2005-01-24 Thread Hans Gilde (JIRA)
[ http://issues.apache.org/jira/browse/JELLY-199?page=comments#action_58027 ] Hans Gilde commented on JELLY-199: -- It's definitely something to do with JellyContext.runScript Leak in IncludeTag or JellyContext.runScript

[jira] Commented: (JELLY-167) add 'public JellyContext newEmptyJellyContext()' to JellyContext

2005-01-23 Thread Hans Gilde (JIRA)
[ http://issues.apache.org/jira/browse/JELLY-167?page=comments#action_57960 ] Hans Gilde commented on JELLY-167: -- Could you give an example of an existing piece of code that would be improved? Are you suggesting getting rid of inherit and export

[jira] Commented: (JELLY-167) add 'public JellyContext newEmptyJellyContext()' to JellyContext

2005-01-23 Thread Hans Gilde (JIRA)
[ http://issues.apache.org/jira/browse/JELLY-167?page=comments#action_57976 ] Hans Gilde commented on JELLY-167: -- I haven't read over your function tag patch yet, maybe that'll help me understand. From your unit test, it seems like you want

[jira] Commented: (JELLY-177) In JellyServlet, the procedure used to determine the script's location is too simplistic

2005-01-23 Thread Hans Gilde (JIRA)
[ http://issues.apache.org/jira/browse/JELLY-177?page=comments#action_57977 ] Hans Gilde commented on JELLY-177: -- Marc, could you give me an example of someting that works after this change but not before? In JellyServlet, the procedure used

[jira] Commented: (JELLY-167) add 'public JellyContext newEmptyJellyContext()' to JellyContext

2005-01-23 Thread Hans Gilde (JIRA)
[ http://issues.apache.org/jira/browse/JELLY-167?page=comments#action_57978 ] Hans Gilde commented on JELLY-167: -- And, when would one use newEmptyJellyContext() as opposed to newJellyContext()? add 'public JellyContext newEmptyJellyContext

[jira] Commented: (JELLY-167) add 'public JellyContext newEmptyJellyContext()' to JellyContext

2005-01-23 Thread Hans Gilde (JIRA)
[ http://issues.apache.org/jira/browse/JELLY-167?page=comments#action_57980 ] Hans Gilde commented on JELLY-167: -- I completely agree that we should pass down the ClassLoader, but I think that this should be added to the constructor JellyContext

RE: [all][VOTE] svn migration

2005-01-23 Thread Hans Gilde
-0 Because subversion support is rather shy of Eclipse's built in CVS. But if it's got to happen soon, it's better to start before the deadline is looming. Hans -Original Message- From: Tim O'Brien [mailto:[EMAIL PROTECTED] Sent: Saturday, January 22, 2005 1:31 PM To: Jakarta Commons

RE: [jelly] RC2?

2005-01-21 Thread Hans Gilde
Although, if JellyContext goes out of scope it should have the same effect. -Original Message- From: Paul Libbrecht [mailto:[EMAIL PROTECTED] Sent: Friday, January 21, 2005 3:50 AM To: Jakarta Commons Developers List Subject: Re: [jelly] RC2? As simple as that:

[jira] Commented: (JELLY-85) TagScript doesn't clear its cached tags after run()

2005-01-21 Thread Hans Gilde (JIRA)
[ http://issues.apache.org/jira/browse/JELLY-85?page=comments#action_57890 ] Hans Gilde commented on JELLY-85: - Well... It's not how Jelly works now, so I'll have to think about it. I'm really in favor of this: splitting off the different bits

RE: [jelly] RC2?

2005-01-20 Thread Hans Gilde
. - Brett Dion Gillard wrote: Yep, I'm up for RC2 after some testing and then assuming no showstoppers, a 1.0 straight after. On Thu, 20 Jan 2005 00:32:32 -0500, Hans Gilde [EMAIL PROTECTED] wrote: I couldn't fix the problems with my weak ref implementation, so I tweaked Paul's fix a little

RE: [jelly] RC2?

2005-01-20 Thread Hans Gilde
. On Thu, 20 Jan 2005 00:32:32 -0500, Hans Gilde [EMAIL PROTECTED] wrote: I couldn't fix the problems with my weak ref implementation, so I tweaked Paul's fix a little to make it thread safe and better for inheritance. Anyway, the memory leak is gone and all unit tests pass after many

[jira] Commented: (JELLY-85) TagScript doesn't clear its cached tags after run()

2005-01-20 Thread Hans Gilde (JIRA)
[ http://issues.apache.org/jira/browse/JELLY-85?page=comments#action_57868 ] Hans Gilde commented on JELLY-85: - Absolutely, this would be much easier. But it gets complicated when you look at what creating a new context means. Like, contexts search up

[jira] Commented: (JELLY-85) TagScript doesn't clear its cached tags after run()

2005-01-19 Thread Hans Gilde (JIRA)
[ http://issues.apache.org/jira/browse/JELLY-85?page=comments#action_57802 ] Hans Gilde commented on JELLY-85: - Paul, I made some changes to your code based on my experience using Jelly. And I fixed the part about thread guarantees for Tag instances

[jelly] RC2?

2005-01-19 Thread Hans Gilde
I couldn't fix the problems with my weak ref implementation, so I tweaked Paul's fix a little to make it thread safe and better for inheritance. Anyway, the memory leak is gone and all unit tests pass after many iterations. Are we ready for an RC2 and, hopefully, a quick release of version

[jira] Commented: (JELLY-177) In JellyServlet, the procedure used to determine the script's location is too simplistic

2005-01-19 Thread Hans Gilde (JIRA)
[ http://issues.apache.org/jira/browse/JELLY-177?page=comments#action_57806 ] Hans Gilde commented on JELLY-177: -- +1 Dion, if you don't object, I'm going to put this in now for RC2. In JellyServlet, the procedure used to determine the script's

[jira] Commented: (JELLY-166) Intermittent error with weak reference wrapper

2005-01-19 Thread Hans Gilde (JIRA)
[ http://issues.apache.org/jira/browse/JELLY-166?page=comments#action_57803 ] Hans Gilde commented on JELLY-166: -- I believe that this is fixed in HEAD. Intermittent error with weak reference wrapper

[jira] Commented: (JELLY-188) tag library xml does not correctly parse body

2005-01-19 Thread Hans Gilde (JIRA)
[ http://issues.apache.org/jira/browse/JELLY-188?page=comments#action_57807 ] Hans Gilde commented on JELLY-188: -- I'm not clear on why the code that's there wouldn't work. I'd say that the current solution is much faster because the SAX events

[jira] Commented: (JELLY-188) tag library xml does not correctly parse body

2005-01-19 Thread Hans Gilde (JIRA)
[ http://issues.apache.org/jira/browse/JELLY-188?page=comments#action_57808 ] Hans Gilde commented on JELLY-188: -- Wait, are you saying that the parse tag doesn't work when applied to the body? tag library xml does not correctly parse body

[jelly] the .project and .classpath files

2005-01-18 Thread Hans Gilde
Hey, does anyone use the .project or .classpath files in the Jelly directory? How do you substitute the MAVEN_REPO variable in the paths? Hans

RE: [Email] To release or not to release

2005-01-17 Thread Hans Gilde
I'm actually +1 *only* if we make the minor API changes that I suggested last week. These changes are to the new caching API: * Change setTagForScript in JellyContext to setScriptData. This method should take a key of type Script, not TagScript. * Also in JellyContext, change the name of

[jelly] WeakReference stuff in CVS?

2005-01-09 Thread Hans Gilde
Hey all, I've been out of the loop for a couple of weeks, sorry. I'm back and I'm going to look at the problem with the WeakReference stuff. It looks like HEAD on cvs.apache.org isn't using the WeakReference code. Has it not been applied to CVS or does this have something to do with the switch

RE: [jelly] WeakReference stuff in CVS?

2005-01-09 Thread Hans Gilde
- From: Paul Libbrecht [mailto:[EMAIL PROTECTED] Sent: Sunday, January 09, 2005 5:27 PM To: Jakarta Commons Developers List Subject: Re: [jelly] WeakReference stuff in CVS? Le 9 janv. 05, à 23:12, Hans Gilde a écrit : Hey all, I've been out of the loop for a couple of weeks, sorry. I'm

RE: [jelly] WeakReference stuff in CVS?

2005-01-09 Thread Hans Gilde
think that it's not prudent to add more stuff now. I think that the idea behind the caching in JellyContext is the right way to go in the long run but I'm not sure that JellyContext is actually the right place to put it. Any opinions? Hans -Original Message- From: Hans Gilde [mailto

RE: Memory-leak test seems to go through

2004-12-19 Thread Hans Gilde
, 2004 4:11 PM To: Hans Gilde Subject: Memory-leak test seems to go through Hey Hans, This mail will arrive probably too late as I am offline now but... anyways... just to let you know that my TagHolderMap thread-local seems to succeed with the memory-leak test that you have proposed. I'd like

RE: [jelly] Trying to understand ThreadLocal story

2004-12-16 Thread Hans Gilde
I agree that it's cleaner but here's why I didn't do it: It's important for the cache to exist because some tags need it just to run. So, I didn't want to keep the cache in with the context variables because that data is vulnerable to inherit/export setting on the context. If the cache is broken

RE: [jelly] Trying to understand ThreadLocal story

2004-12-16 Thread Hans Gilde
Or maybe as a stack, passed down from invocation to invocation. Since we're trying to separate stuff from the context as much as possible. But this would be a big API change. -Original Message- From: peter royal [mailto:[EMAIL PROTECTED] Sent: Thursday, December 16, 2004 6:37 PM To:

[jira] Commented: (JELLY-148) Huge memory leak resulting from the use of ThreadLocal

2004-12-15 Thread Hans Gilde (JIRA)
[ http://nagoya.apache.org/jira/browse/JELLY-148?page=comments#action_56749 ] Hans Gilde commented on JELLY-148: -- There's some problem with the patch for this issue, see JELLY-85 I'm looking into it. Huge memory leak resulting from the use

[jira] Commented: (JELLY-85) TagScript doesn't clear its cached tags after run()

2004-12-15 Thread Hans Gilde (JIRA)
[ http://nagoya.apache.org/jira/browse/JELLY-85?page=comments#action_56751 ] Hans Gilde commented on JELLY-85: - this is a problem with code introduced in the patch for JELLY-148 TagScript doesn't clear its cached tags after run

RE: patch for jelly-tags-interaction

2004-12-08 Thread Hans Gilde
Could you file this as an improvement: http://nagoya.apache.org/jira/browse/JELLY -Original Message- From: Ryan Christianson [mailto:[EMAIL PROTECTED] Sent: Wednesday, December 08, 2004 5:12 PM To: [EMAIL PROTECTED] Subject: patch for jelly-tags-interaction Apologies i sent this to the

RE: patch for jelly-tags-interaction

2004-12-08 Thread Hans Gilde
allows me to pick myFaces as the name of the project. is that correct? On Wed, 08 Dec 2004 18:11:35 -0500, Hans Gilde [EMAIL PROTECTED] wrote: Could you file this as an improvement: http://nagoya.apache.org/jira/browse/JELLY -Original Message- From: Ryan Christianson [mailto

[jira] Commented: (JELLY-173) Support for XML Schema

2004-12-08 Thread Hans Gilde (JIRA)
[ http://nagoya.apache.org/jira/browse/JELLY-173?page=comments#action_56414 ] Hans Gilde commented on JELLY-173: -- sorry, what output are you expecting from this? Support for XML Schema -- Key: JELLY-173 URL

RE: [jelly] comment - memory leak from using ThreadLocal

2004-12-07 Thread Hans Gilde
TagScript sets the body Script into the Tag just before the Tag is executed. This is after setTag has been called, and it's the only time that a Tag is access to its body Script. So, as far as I can tell, a Tag is never given access to its body Script directly. The leak was caused by a circular

RE: [jira] Commented: (JELLY-169) Testing fails in JDK 1.5

2004-12-05 Thread Hans Gilde
Paul, you're still getting Attempt to use a script that has been garbage collected. with JDK 1.5? I added this message when I fixed the big memory leak. I'll take a look. -Original Message- From: Paul Libbrecht (JIRA) [mailto:[EMAIL PROTECTED] Sent: Monday, November 29, 2004 4:40 AM

RE: [jelly] documentation on all tags

2004-11-29 Thread Hans Gilde
I like it. Could the list of tags also appear on the overview page? -Original Message- From: Dion Gillard [mailto:[EMAIL PROTECTED] Sent: Monday, November 29, 2004 6:54 PM To: dan tran; Jakarta Commons Developers List Subject: [jelly] documentation on all tags Ok, the plan is to add a

[jira] Commented: (JELLY-167) add 'public JellyContext newEmptyJellyContext()' to JellyContext

2004-11-27 Thread Hans Gilde (JIRA)
[ http://nagoya.apache.org/jira/browse/JELLY-167?page=comments#action_55940 ] Hans Gilde commented on JELLY-167: -- newJellyContext exists so that you can override it. The idea is that a subclass Of JellyContext might want to implement certain behavior

RE: [jira] Created: (JELLY-163) Allow Expressions to throw exceptions

2004-11-22 Thread Hans Gilde
? thanks paul Le 15 nov. 04, à 02:32, Hans Gilde (JIRA) a écrit : Expressions are evaluated before the tag is run, so it normally wouldn't know anything about them. - To unsubscribe, e-mail: [EMAIL PROTECTED

[jira] Created: (JELLY-163) Allow Expressions to throw exceptions

2004-11-14 Thread Hans Gilde (JIRA)
Allow Expressions to throw exceptions - Key: JELLY-163 URL: http://nagoya.apache.org/jira/browse/JELLY-163 Project: jelly Type: Improvement Components: core / taglib.core Versions: 1.1-beta-1 Reporter: Hans Gilde

RE: [jelly] interim release for testing memory use?

2004-10-27 Thread Hans Gilde
and the XMLOutput flush patch, we make it a release candidate for 1.0? On Tue, 26 Oct 2004 23:49:22 -0400, Hans Gilde [EMAIL PROTECTED] wrote: We're not entirely sure if the big memory leak is gone, how about an interim release for Servlet users to test? Hans -- http

[jelly] LoopTagStatus

2004-10-27 Thread Hans Gilde
I have to say that I'm not so thrilled with LoopTagStatus in the head version of ForEachTag. I know that it's the standard but it adds yet another library as a dependency, which is pretty annoying for embedded jelly. I forget, why not use a clone with identical methods? Hans

[jelly] interim release for testing memory use?

2004-10-26 Thread Hans Gilde
We're not entirely sure if the big memory leak is gone, how about an interim release for Servlet users to test? Hans

[jira] Commented: (JELLY-159) share base test classes with tag lib test builds

2004-10-25 Thread Hans Gilde (JIRA)
[ http://issues.apache.org/jira/browse/JELLY-159?page=comments#action_54635 ] Hans Gilde commented on JELLY-159: -- I agree share base test classes with tag lib test builds Key: JELLY-159

[jira] Commented: (JELLY-107) util:properties doesn't evaluate expressions

2004-10-25 Thread Hans Gilde (JIRA)
[ http://issues.apache.org/jira/browse/JELLY-107?page=comments#action_54636 ] Hans Gilde commented on JELLY-107: -- If we're going to allow for plugin expression evaluators in the future, how would that fit into a situation like this? Maybe that's just

RE: About Jira

2004-10-17 Thread Hans Gilde
http://nagoya.apache.org/jira/secure/BrowseProject.jspa?id=10012 Click Create new issue in project jelly -Original Message- From: A Leg [mailto:[EMAIL PROTECTED] Sent: Sunday, October 17, 2004 4:34 PM To: [EMAIL PROTECTED] Subject: About Jira Hi I want submit a jelly bug in JIRA. But

RE: (JELLY-150) j:forEach tag not properly using varStatus attribute

2004-10-04 Thread Hans Gilde
to do it, I'll do it when I get home tonight (I can't access Jira here at work) Thanks, Ben Quoting [EMAIL PROTECTED]: The following comment has been added to this issue: Author: Hans Gilde Created: Sat, 2 Oct 2004 9:30 PM Body: This patch adds a class in the package

[jelly] running tests with using own Jelly build

2004-10-03 Thread Hans Gilde
How do I run the tests for components in jelly-tags and force Maven to use my build of Jelly, not the downloaded snapshot? thx, Hans

  1   2   >