Mike Bowler wrote:
I've added a second patch to the bug which fixes more checkstyle
warnings. I'm still not sure why the patches were being discarded from
my emails this morning so I'm just playing it safe and putting them in
bugzilla.
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16429
Ok, I thought we might wait on style related patches untill we finalize
some guidelines, but you have focused on issues not is dispute so thats
good. I do prefer patches to bugzilla, less traffic generated by email
(someone has to be paying for the apache bandwitdh).
Mike Bowler wrote:
I've
Hey Mike,
A couple issues with the patch. The tests failed due to a change to the
parameters member in HeaderElement. A protected member was made to be
private and given an accessor. I think that this is a good change, but
patches should pass the tests before they are posted. The tests were
Here is the first step towards fixing the checkstyle warnings. I've
cleaned up warnings in quite a few files but lots still to go.
--
Mike Bowler
Principal, Gargoyle Software Inc.
Voice: (416) 822-0973 | Email : [EMAIL PROTECTED]
Fax : (416) 822-0975 | Website: http://www.GargoyleSoftware.com
