Re: [concordance-devel] Congruity Port to New API

2013-01-06 Thread Phil Dibowitz
On 01/03/2013 07:59 PM, Scott Talbert wrote: On Wed, 2 Jan 2013, Phil Dibowitz wrote: Unfortunately, no it cannot. It needs to be able to store/act on that information, and it can't do that without its pointer. Did you have any further thoughts on this? I suppose we could just add

Re: [concordance-devel] Congruity Port to New API

2013-01-06 Thread Scott Talbert
On Sun, 6 Jan 2013, Phil Dibowitz wrote: - cb(LC_CB_STAGE_RESET, 0, 0, 2, LC_CB_COUNTER_TYPE_STEPS, cb_arg); + cb(LC_CB_STAGE_RESET, 0, 0, 2, LC_CB_COUNTER_TYPE_STEPS, + cb_arg, NULL); Why the line-wrap here? cb_arg fits in under 80 chars. And

Re: [concordance-devel] Congruity Port to New API

2013-01-06 Thread Scott Talbert
On Sun, 6 Jan 2013, Phil Dibowitz wrote: Other than that, I think this looks great. I'd like to take one more look at it when it's not super late but I think other than the two minor things above we're good to go. Different thought. Congruity and libconcord currently differ a bit in how