Re: [concordance-devel] [PATCH] Allow for separate IR learning implementation for ZWave (HID and USBNET).

2013-07-30 Thread Phil Dibowitz
On 07/28/2013 07:32 PM, Scott Talbert wrote: In preparation for supporting IR learning for ZWave, change the IRLearn() function to be a subclass function for each so that IR learning can be implemented and easily merged for each type separately. I'm totally fine with this. Out of curiosity

[concordance-devel] Some SF cleanup

2013-07-30 Thread Phil Dibowitz
I removed the old CVS repo. I then renamed the git module from src to Code, so git now falls into where CVS used to fall in the GUI, and matches a project that was setup with git from the beginning. -- Phil Dibowitz p...@ipom.com Open Source software and tech docs

Re: [concordance-devel] [PATCH] Allow for separate IR learning implementation for ZWave (HID and USBNET).

2013-07-30 Thread Scott Talbert
On Mon, 29 Jul 2013, Phil Dibowitz wrote: In preparation for supporting IR learning for ZWave, change the IRLearn() function to be a subclass function for each so that IR learning can be implemented and easily merged for each type separately. I'm totally fine with this. Out of curiosity

Re: [concordance-devel] [PATCH] Fix serial number handling for ZWave-HID remotes.

2013-07-30 Thread Stephen Warren
On 07/30/2013 12:25 AM, Phil Dibowitz wrote: On 07/23/2013 08:15 PM, Scott Talbert wrote: Use the normal byte ordering for them. Additionally, we were off by one byte when copying the the serial number data in UDP_Read(). Applied. Thanks, this format works great. I like this workflow

Re: [concordance-devel] [PATCH] Fix serial number handling for ZWave-HID remotes.

2013-07-30 Thread Phil Dibowitz
On 07/30/2013 08:09 AM, Stephen Warren wrote: On 07/30/2013 12:25 AM, Phil Dibowitz wrote: On 07/23/2013 08:15 PM, Scott Talbert wrote: Use the normal byte ordering for them. Additionally, we were off by one byte when copying the the serial number data in UDP_Read(). Applied. Thanks,

Re: [concordance-devel] [PATCH] Fix serial number handling for ZWave-HID remotes.

2013-07-30 Thread Phil Dibowitz
On 07/30/2013 09:16 AM, Phil Dibowitz wrote: You can edit the saved email, or simply run git commit --amend after it's been applied. If you apply a bunch of patches in a batch, you can use git rebase -i to edit commit messages further back. You likely want to do all that before you push

Re: [concordance-devel] [PATCH] Fix serial number handling for ZWave-HID remotes.

2013-07-30 Thread Stephen Warren
On 07/30/2013 10:16 AM, Phil Dibowitz wrote: On 07/30/2013 08:09 AM, Stephen Warren wrote: On 07/30/2013 12:25 AM, Phil Dibowitz wrote: On 07/23/2013 08:15 PM, Scott Talbert wrote: Use the normal byte ordering for them. Additionally, we were off by one byte when copying the the serial number

Re: [concordance-devel] [PATCH] Add support for Harmony Link.

2013-07-30 Thread Scott Talbert
On Mon, 29 Jul 2013, Phil Dibowitz wrote: as well as account configuration (email, etc). The Link does not receive its configuration via USB like other remotes - it receives it via WiFi. So, we don't send it a configuration at all, we just tell it how to get on the network and how to log