One of the things I want to cleanup before we get 0.20 out the door is libconcord/concordance.h. There's not much left in this file, but it makes no sense for anything called 'concordance' to be in libconcord/
There are only a few things in this file: * An include of windows.h for WIN32 hosts. * A #define of LIBUSB for non-WIN32 systems. * An typedef of stricmp and strnicmp to strcasecmp and strncasecmp respectively, on non-win32 hosts. * An include of <string> for all platforms and 'using namespace std;' * A prototype for report_net_error() an internal function to libconcord that many areas may need to call (it's in libconcord.cpp) I'm not entirely sure all this is even necessary, but at the very least, we probably need a header file for internal stuff we want to include from throughout libconcord but that we don't want in the external libconcord.h. Thus I suggest we rename this file (I'll just delete it and re-add it, there's nothing that useful in here that we need to track the CVS changes to it) to something else. I don't really know what to call it.. maybe libconcord_internal.h ? Suggestions welcome. Now, a few comments on the contents of this file.... First, I'm surprised the string include works given that new gcc supposedly doesn't "follow" includes this way, but if you remove it, you'll find, in fact, it's quite necessary, there are plenty of places that use <string> that rely on their concordance.h include to provide it. Either way if we're going to keep this, the string include should probably be removed from win/winhid.cpp since that includes concordance.h already. I of course, can't test that. By thee same token, I'm surprised the windows.h include works, though I don't mind any #ifdef'd #includes being sucked off to one place. We should move the define of debug() to this new internal header. The #pragma to disable warnings for Windows code should probably be moved either to the windows files themselves, or at the very least, this new internal header. Thoughts, comments, complaints, suggestions? -- Phil Dibowitz [EMAIL PROTECTED] Open Source software and tech docs Insanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ "Never write it in C if you can do it in 'awk'; Never do it in 'awk' if 'sed' can handle it; Never use 'sed' when 'tr' can do the job; Never invoke 'tr' when 'cat' is sufficient; Avoid using 'cat' whenever possible" -- Taylor's Laws of Programming
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------- This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code J8TL2D2. http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
_______________________________________________ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
