Apologize for the multiple copies, Thunderbird had issue with network,
and resulting several copies sent.
Sorry for the incident.
Cheers,
Henry
On 10/15/2013 10:53 PM, Henry Jen wrote:
On 10/15/2013 04:05 PM, Mike Duigou wrote:
Where is the null handling for methods like
Changeset: a70aab9b373e
Author:weijun
Date: 2013-10-16 14:39 +0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a70aab9b373e
8025124: InitialToken.useNullKey incorrectly applies NULL_KEY in some cases
Reviewed-by: xuelei
!
Changeset: 6cb4f20d971f
Author:jlaskey
Date: 2013-10-11 14:54 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/6cb4f20d971f
8026309: latest runsunspider.js tests contains several bugs
Reviewed-by: sundar, lagergren
Contributed-by: james.las...@oracle.com
!
On 15 October 2013 20:35, Xueming Shen xueming.s...@oracle.com wrote:
Please help codereview the changes for
8025971: Remove Time-Zone IDs HST/EST/MST
The method ZoneId.systemDefault() now does not match its specification:
/**
* Gets the system default time-zone.
* p
* This queries {@link
Looks good with Henry's correction (that i missed the first time around!).
Paul.
On Oct 15, 2013, at 10:18 PM, Mike Duigou mike.dui...@oracle.com wrote:
Hello all;
As promised on the lambda-libs-spec-experts mailing list I have prepared a
changeset which renames the single arg substream()
Hi Mandy,
On 10/16/13 12:58 AM, Mandy Chung wrote:
On 10/15/2013 9:48 AM, Daniel Fuchs wrote:
Hi,
Please find below a fix for:
8026499: Root Logger level can be reset unexpectedly
https://bugs.openjdk.java.net/browse/JDK-8026499
On Oct 16, 2013, at 6:41 AM, David Holmes david.hol...@oracle.com wrote:
Okay you have incited me to throw in my 2c :) I think the CME issue has been
raised a number of times in the past (and if the below doesn't agree with
what I've said in the past Hey! It's a brand new day! ;-) )
But
New webrev: http://cr.openjdk.java.net/~erikj/6604021/webrev.02/
* Changed Node.java as David suggested.
* Added comment suggested by Martin to Setup.gmk, where the compiler
setup is done. Couldn't think of a better place.
* Changed comment in JavaCompilation.
A note on Corba. While the corba
On 2013-10-15 17:29, Volker Simonis wrote:
Hi Erik, Alan,
first of all I think this is a good change because it helps porters to
build a complete JDK even if the newly build rmic wouldn't run.
On the other hand I'm a little bit concerned if this change still
allows it to bootstrap with a
On 16/10/2013 8:03 PM, Paul Sandoz wrote:
On Oct 16, 2013, at 6:41 AM, David Holmes david.hol...@oracle.com wrote:
Okay you have incited me to throw in my 2c :) I think the CME issue has been
raised a number of times in the past (and if the below doesn't agree with what
I've said in the
Ship it! Quickly! :)
Thanks,
David
On 16/10/2013 8:19 PM, Erik Joelsson wrote:
New webrev: http://cr.openjdk.java.net/~erikj/6604021/webrev.02/
* Changed Node.java as David suggested.
* Added comment suggested by Martin to Setup.gmk, where the compiler
setup is done. Couldn't think of a
On 16/10/2013 11:35, David Holmes wrote:
Ship it! Quickly! :)
+1 looks good to me.
Thanks Erik,
-Chris.
Thanks,
David
On 16/10/2013 8:19 PM, Erik Joelsson wrote:
New webrev: http://cr.openjdk.java.net/~erikj/6604021/webrev.02/
* Changed Node.java as David suggested.
* Added comment
Changeset: 9ea6a464c147
Author:igerasim
Date: 2013-10-15 21:15 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9ea6a464c147
8023431: Test java/util/zip/GZIP/GZIPInZip.java failed
Summary: Properly close PipedStreams. Additional testing for malformed input
Reviewed-by: darcy,
On Oct 16, 2013, at 12:28 PM, David Holmes david.hol...@oracle.com wrote:
On 16/10/2013 8:03 PM, Paul Sandoz wrote:
On Oct 16, 2013, at 6:41 AM, David Holmes david.hol...@oracle.com wrote:
Okay you have incited me to throw in my 2c :) I think the CME issue has
been raised a number of
On 16/10/2013 01:04, David Holmes wrote:
I think API restrictions already apply to the sun.tools packages - and
both language and API restrictions apply to other build tools that are
compiled using the boot JDK.
Yes for build tools but not sun.tools.** in general (the change to
On 15/10/2013 21:58, Brian Burkhalter wrote:
Pursuant to comments on the submitted CCC request, the patch previously
approved for this issue has been revised:
http://cr.openjdk.java.net/~bpb/7179567/webrev.6/
The difference is that the URLClassLoader constructors and newInstance()
methods no
On 16/10/2013 9:26 PM, Paul Sandoz wrote:
On Oct 16, 2013, at 12:28 PM, David Holmes david.hol...@oracle.com wrote:
On 16/10/2013 8:03 PM, Paul Sandoz wrote:
On Oct 16, 2013, at 6:41 AM, David Holmes david.hol...@oracle.com wrote:
Okay you have incited me to throw in my 2c :) I think the
On 10/16/2013 07:26 AM, Paul Sandoz wrote:
On Oct 16, 2013, at 12:28 PM, David Holmes david.hol...@oracle.com wrote:
On 16/10/2013 8:03 PM, Paul Sandoz wrote:
HashMap.compute*/merge methods do not throw CME either. I suppose those
methods could and do so beyond that of only the entry under
This bug got a bit lost from my radar after vacation, but I've picked it
again now. I've moved Arrays.asList() as suggested. In further testing
of the fix though, I found that the include list is not enough, as one
of the expected method exit events is from String.intern(), which might
also be
Changeset: af81988013b5
Author:erikj
Date: 2013-10-16 13:50 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/rev/af81988013b5
6604021: RMIC is defaulting to BOOT jdk version, needs to be rmic.jar
Reviewed-by: dholmes, chegar
! common/makefiles/JavaCompilation.gmk
!
Hi,
Please find below the new revision:
http://cr.openjdk.java.net/~dfuchs/webrev_8026499/webrev.01/
- added comment in LogManager
- renamed hasLocalLevel() into isLevelInitialized()
- fixed the test, including Logger.global, with and
without SecurityManager
-- daniel
On 10/16/13 11:47
On Oct 16, 2013, at 1:52 PM, David Holmes david.hol...@oracle.com wrote:
Perhaps HashMap's implementations should throw CME?
Perhaps, seems to be going beyond the call of duty. My inclination is not to
bother. It becomes most relevant with forEach since the consumer will have
Changeset: 438c54c148a6
Author:erikj
Date: 2013-10-16 13:49 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/438c54c148a6
6604021: RMIC is defaulting to BOOT jdk version, needs to be rmic.jar
Reviewed-by: dholmes, chegar
! makefiles/BuildCorba.gmk
On Wed, Oct 16, 2013 at 12:22 PM, Erik Joelsson
erik.joels...@oracle.com wrote:
On 2013-10-15 17:29, Volker Simonis wrote:
Hi Erik, Alan,
first of all I think this is a good change because it helps porters to
build a complete JDK even if the newly build rmic wouldn't run.
On the other
Changeset: 76a7c0bc74fd
Author:erikj
Date: 2013-10-16 13:50 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/76a7c0bc74fd
6604021: RMIC is defaulting to BOOT jdk version, needs to be rmic.jar
Reviewed-by: dholmes, chegar
! makefiles/GendataBreakIterator.gmk
!
Hi,
Please review the fix for JDK-8004912 and JDK-8019420 below.
Description:
The behavior of Class.get[Declared]AnnotationsByType was wrong. These methods
delegate to sun.reflect.annotation.AnnotationSupport which has been rewritten.
NonInheritableContainee.java is added and contains the
Changeset: d8eec0e3a023
Author:robm
Date: 2013-10-16 15:06 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d8eec0e3a023
8026245: InetAddress.getLocalHost crash if IPv6 disabled (macosx)
Reviewed-by: chegar, alanb
! src/solaris/native/java/net/Inet4AddressImpl.c
!
Hi Aleksej and Masayoshi,
The translation of the timezone names are correct according to the
translators. So, the files in your webrev look fine to me.
thanks,
-michael
On 13年10月14日 10:19 下午, Michael Fang wrote:
Hi Masayoshi,
I am not sure if the changes are correct. I need to check with
If you look at the current classes (b111) that have documented annotations,
the first annotation is correctly left-aligned but all others are indented
by one space. If this is already reported, my apologies; if not, please
confirm.
Example:
Changeset: 445667b19e32
Author:dfuchs
Date: 2013-10-16 17:19 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/445667b19e32
8011638: Remove deprecated methods in sun.util.logging.PlatformLogger
Reviewed-by: psandoz, mchung, alanb, chegar
!
Alan,
I've updated the fix. New changes are:
1. Make processB fail if interrupted,
2. Replace Error throwing by RuntimeException.
Here is a link to webrev:
http://cr.openjdk.java.net/~robm/8024660/webrev.02/[1]
On Tue, 15 of Oct 2013 20:44:42 Alan Bateman wrote:
On 15/10/2013 16:46, Pavel
Hello,
As per Nashorn teams request, I have also run the octane test, and it
passes.
I need reviewers from Lambda, Nashorn and ASM projects to approve this.
Thanks
Kumar
Hello,
Please review refreshing the internal ASM sources to ASM_5_0_BETA,
I have run all the lambda test-ng tests using
On 16/10/2013 17:31, Pavel Punegov wrote:
Alan,
I've updated the fix. New changes are:
1. Make processB fail if interrupted,
2. Replace Error throwing by RuntimeException.
Here is a link to webrev:
http://cr.openjdk.java.net/~robm/8024660/webrev.02/
On Oct 16, 2013, at 4:46 AM, Alan Bateman wrote:
This version looks okay too. For JDK-8026517 then you could add a note to say
that the tests for it are in the NullURLTest.java test case, alternatively
remove the commented-out tests and leave it to when JDK-8026517 is
re-examined.
I'll
Yup.
-Rob
On 16/10/13 17:50, Alan Bateman wrote:
On 16/10/2013 17:31, Pavel Punegov wrote:
Alan,
I've updated the fix. New changes are:
1. Make processB fail if interrupted,
2. Replace Error throwing by RuntimeException.
Here is a link to webrev:
Thank you, Paul.
I tried to combine your and Joe's suggestions in the updated WebRev:
http://cr.openjdk.java.net/~bpb/6910473/webrev.2/
-Dima
On Tue, Oct 15, 2013 at 12:20 PM, Paul Sandoz paul.san...@oracle.comwrote:
Hi,
I took a look at the patch, but i am not an expert in this area.
Changeset: d7e155f874a7
Author:jjg
Date: 2013-10-16 10:47 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d7e155f874a7
8026704: Build failure with --enable-debug
Reviewed-by: ksrini
! src/share/classes/com/sun/tools/javac/code/Flags.java
!
Changeset: 2ef43f3a901c
Author:dfuchs
Date: 2013-10-16 20:47 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2ef43f3a901c
8013839: Enhance Logger API for handling of resource bundles
4814565: (rb) add method to get basename from a ResourceBundle
Summary: adds
Changeset: cf9cb3d241a3
Author:mduigou
Date: 2013-10-16 13:03 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cf9cb3d241a3
8025910: rename substream(long) - skip and remove substream(long,long)
Reviewed-by: psandoz, henryjen
!
Hi,
Javadoc cleanup to satisfy javadoc -Xlint.
Webrev:
http://cr.openjdk.java.net/~rriggs/webrev-javadoc-8026516/
Thanks, Roger
Hello all;
With the imminent promotion of JTReg 4.1b07 it's possible to finally consider
completing this changeset!
http://cr.openjdk.java.net/~mduigou/JDK-8015068/2/webrev/
This updated webrev includes handling of the shared library permissions.
Thanks,
Mike
On Aug 28 2013, at 04:11 , Alan
Looks fine. To make things easier I reviewed the patch rather than the
individual file diffs.
Mike
On Oct 16 2013, at 13:15 , roger riggs roger.ri...@oracle.com wrote:
Hi,
Javadoc cleanup to satisfy javadoc -Xlint.
Webrev:
http://cr.openjdk.java.net/~rriggs/webrev-javadoc-8026516/
Changeset: 7f6481e5fe3a
Author:emc
Date: 2013-10-16 16:33 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7f6481e5fe3a
8026286: Improper locking of annotation queues causes assertion failures.
8026063: Calls to annotate.flush() cause incorrect type annotations to be
Hi Roger,
Looks good; approved to go back.
Thanks,
-Joe
On 10/16/2013 1:15 PM, roger riggs wrote:
Hi,
Javadoc cleanup to satisfy javadoc -Xlint.
Webrev:
http://cr.openjdk.java.net/~rriggs/webrev-javadoc-8026516/
Thanks, Roger
Hi Roger,
I think what you have done is OK.
I do have questions on should more be done in general so that we use P /P
(as I thought that was no required vs just a solo P?). As I started to look
through some of the JDBC warnings, I saw more tags that I thought should have
been reported by
Changeset: 60e3cdbe8cdf
Author:aefimov
Date: 2013-10-13 14:19 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/60e3cdbe8cdf
8025255: (tz) Support tzdata2013g
Reviewed-by: okutsu, mfang
! make/sun/javazic/tzdata/VERSION
! make/sun/javazic/tzdata/africa
!
Hi Lance,
The empty p tag is because in most cases it precedes a ul or a
header hx .
So there is no content in the paragraph.
In the past using an empty p tag created some empty vertical space;
but i understand that's a misuse of p.
I didn't try to compensate for that in my updates but it
Hi Roger
On Oct 16, 2013, at 4:50 PM, roger riggs wrote:
Hi Lance,
The empty p tag is because in most cases it precedes a ul or a header
hx .
So there is no content in the paragraph.
I was referring more to an example such as this in Instant.java
* h3Time-scale/h3
* p
* The length of
Hi Lance,
The immediate issue was to get javadoc -Xlint clean again.
AFAIK that is what has been requested.
Roger
On 10/16/2013 4:56 PM, Lance Andersen - Oracle wrote:
Hi Roger
On Oct 16, 2013, at 4:50 PM, roger riggs wrote:
Hi Lance,
The empty p tag is because in most cases it precedes a
Dmitry,
I think you are correct: that slipped by both me and the reviewers. I have
reopened the issue and posted an amendment to the original webrev here:
http://cr.openjdk.java.net/~bpb/8010371/webrev.4-amendment/
Thanks for catching this.
Brian
On Oct 16, 2013, at 3:06 PM, Dmitry Samersoff
On Oct 16 2013, at 05:34 , Paul Sandoz paul.san...@oracle.com wrote:
On Oct 16, 2013, at 1:52 PM, David Holmes david.hol...@oracle.com wrote:
Perhaps HashMap's implementations should throw CME?
Perhaps, seems to be going beyond the call of duty. My inclination is not
to bother. It
Brian,
On 17/10/2013 9:21 AM, Brian Burkhalter wrote:
Dmitry,
I think you are correct: that slipped by both me and the reviewers. I have
reopened the issue and posted an amendment to the original webrev here:
You can not reopen a bug once it has been fixed! You need to create a
new bug for
Hi,
A simple webrev to add missing @since 1.8 tag.
Cheers,
Henry
On 10/16/2013 08:18 PM, Henry Jen wrote:
Hi,
A simple webrev to add missing @since 1.8 tag.
Sigh,
http://cr.openjdk.java.net/~henryjen/tl/8026768/0/webrev/
Cheers,
Henry
Hello everybody!
When I proposed a fix for 8023431 I messed up with verifying the fix
somehow, and the test started to fail right after pushing the fix.
I'm sorry about that.
The reason of the failure is that when GZIPStream is closed, it also
closes the underlying stream.
In this fix I
Reviewed!
Thanks,
David
On 17/10/2013 1:27 PM, Henry Jen wrote:
On 10/16/2013 08:18 PM, Henry Jen wrote:
Hi,
A simple webrev to add missing @since 1.8 tag.
Sigh,
http://cr.openjdk.java.net/~henryjen/tl/8026768/0/webrev/
Cheers,
Henry
Hi Mike,
Looking mainly at the docs not the operational semantics of null
handling ...
On 17/10/2013 9:52 AM, Mike Duigou wrote:
On Oct 16 2013, at 05:34 , Paul Sandoz paul.san...@oracle.com wrote:
On Oct 16, 2013, at 1:52 PM, David Holmes david.hol...@oracle.com wrote:
Perhaps HashMap's
Changeset: e2e3c2c249e2
Author:henryjen
Date: 2013-10-16 21:34 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e2e3c2c249e2
8026768: java.util.Map.Entry comparingBy methods missing @since 1.8
Reviewed-by: dholmes
! src/share/classes/java/util/Map.java
Changeset: ce266885222d
Author:peytoia
Date: 2013-10-17 13:57 +0900
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ce266885222d
8025703: Update LSR datafile for BCP 47
Reviewed-by: okutsu
! src/share/classes/sun/util/locale/LocaleEquivalentMaps.java
+
59 matches
Mail list logo
